From 54884a442665feebd7056d98726aac20fd54c19c Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Date: Tue, 18 Mar 2025 16:16:33 +0100 Subject: [PATCH] swscale/tests/swscale: Fix potential buffer overflow The field width in a %s directive gives the amount of characters to read from the input and not the size of the receiving buffer; the latter must be of course also have space for the trailing \0 which has been forgotten here. The commit adds it (and fixes a -Wfortify-source warning from Clang). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libswscale/tests/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c index 2e83197694..096573f8c3 100644 --- a/libswscale/tests/swscale.c +++ b/libswscale/tests/swscale.c @@ -297,7 +297,7 @@ static int run_file_tests(const AVFrame *ref, FILE *fp, struct options opts) int ret; while (fgets(buf, sizeof(buf), fp)) { - char src_fmt_str[20], dst_fmt_str[20]; + char src_fmt_str[21], dst_fmt_str[21]; enum AVPixelFormat src_fmt; enum AVPixelFormat dst_fmt; int sw, sh, dw, dh, mse[4]; -- 2.45.2