From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 65A2E4CA0D for ; Mon, 10 Feb 2025 16:05:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1526C68BDA9; Mon, 10 Feb 2025 18:05:08 +0200 (EET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2093.outbound.protection.outlook.com [40.92.49.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DD5268BA61 for ; Mon, 10 Feb 2025 18:05:02 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OHhvRZJ7Fy/lzZTYQoXDv0fzKEUexgMCr+zsfuMUGythF+mTRGh7EYBrGj3dEF5G6adIjUH7EqNauqG5wzacAVIGWh0Agg50znrxS7vFP6cWksyMTPFsC+AwtbHSjlVJAJBwMPsb6tvxCfQCRdaGXzBQbnbBP1K5g9eUsz5RiK9SCb1h+Q4Pc5PRSgIKoUFUQ9ulsGiu0GoqBbDd9q8/aAWLRpw9+4ldUqgLEqUIcFcdxaMQm3BPq8Ji8q6pugl/U75Cm/rbqWNXREWCW6kYWx/hoC2VcQl0Y57WfpE3TA/pM7oE0FPzrEVKkt+SECbX5JpXbQ4N7UKTwnMY9ULtsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YJehc8vlIlGuyMYOset4vFLQAszS6jr3T+VrED4nUqQ=; b=DiCML1YmzWKmUSpQ/BkdBtG4gaehegQjY4gQcclMUVQtWs797tPk6kAsNhDF8EacGw5PrFFV6CiJr8MI6nw+wbISXeqhcycolyfAqTimnqmqnjelKx8gw51Vm5X9yTi0uaF3GeLUH44tDKYpRfeGMIv+05iaB0HSw6ckR6YWLgYfYLtKggXObm8p2PFeLQbf0f25F1Mp/0L7vgJW2znyFbAEYp5t3E07oZvpvX3JaVCLgGNmearSRJw1YYUweNPuT4oXXwLVEJstemiKkV8AYKJ5s9csYD6yo+IADO6YllWkdJSAQr1yqN5BkNfO8CouNaxmltkfaO+Y5fwaveEI/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJehc8vlIlGuyMYOset4vFLQAszS6jr3T+VrED4nUqQ=; b=owXCAgqIYR/XzfjckPQV/OhGKN+KuG1GJf9eypaoHA7zLici/KQcBjZUcYXfYcik4yiQDRjhZKpXIkzlrhkZPxyFrv66q5IFUcHWjyQYmAwTlr2swl9RFORqZtR6Hsfbghxf7zV/HAQP1esZdj8xCIaAeFe7wcKs886fn5JhnloEguGiLpo7QeKL8uS73I2Qlwc8dcYTyOZlKueIwJtnkD6WejDE9FNHRA1/OeksEZPJvesWfvcZIkiX5/SpG45+BiYpwC1Q+buBabfQalAnmKZUfoqEPiUvkauTBP845Rib2bkj59us8l7grNIyRjX+sfUTTsO88RGgMbCwbD1hBA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAVP250MB0980.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:303::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.14; Mon, 10 Feb 2025 16:05:00 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.8422.012; Mon, 10 Feb 2025 16:05:00 +0000 Message-ID: Date: Mon, 10 Feb 2025 17:04:58 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: ZR2P278CA0085.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:65::7) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAVP250MB0980:EE_ X-MS-Office365-Filtering-Correlation-Id: bf7ab336-dc3a-4c18-cdaf-08dd49ecabd5 X-MS-Exchange-SLBlob-MailProps: 9IecXKUgicA7+VuJlYgio7csxP7RAb93pnuQ6y06yjy3eI8E20FtYskNRSVAewXTPxN1sIezZ5SiGj3GuyTuZOiq5nfRd/AazNsf0fgmzdZGr41hDzE7LN+9reKzVzTAMMQ3nklXlhfJiUxJOYlgHW4SWtYjsNQSuNAN/KDZYZsxalAAOXcUQGy+QPLUc9Y6wsVSeJtN6FAA23rb1Q/1YcaRAIrCJvNOfTXFcrXYrRAkMyk+eW5agrRL5ZSP+Qd2KJmid94z9eyx8c3/7CXy04lCXKC1Cfdw4AQFEPyUVcg3ec08PRmfquhPj1+jtNzg8YC/3Q4esP8Wf1vxP01R7N8zDLnsabcGwj7rHa1zaIMB574aK8gUVI5XSDLm3TxvZYp1kgphNVy0xjpMaNQBMDbt7F4pM1qhQKMW475n9wV2ngLTof9Tjt0zR3SecU1eJwgqZ8PhOLMz2DVll4o7BVi0bFy82ETGQFu/b0r4KpgHc8OzicDwZ5zZgxRkwTTFTh36NXah681XrATB6f9D9Elw4pGhQfA2q4IY6VpHfzdFZ013NcY1HyyRNpcyxwVQ3wR3Hw2a+X0qGOFqqCGwN2RSFO7nB0pejufVRdfya05QPiz4FFaymhw0m/L+SmyupqW44LN3cM+VGPzpa52yDBZ6aQL/g81CVt4bYmbZeDxni90AGn4CVdvGpBMlibvjHU/BFJgEMnJV3BQhijLeInNPBN5ACrKe+PlxuUqB2loHtwnsZCM+tQ== X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|15080799006|19110799003|461199028|7092599003|6090799003|8060799006|3412199025|440099028|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NERVa3pRMU1KU2R1SU1tajhnUGwvbEo1YkxyTmFBeVlzcmZsdnUyV0JGSWp3?= =?utf-8?B?ZHVjTDFlVnU1c0tOSzZaOVlxUXdMbnpTRTRMR0RGbmU5bForbG1ia1R1bmQ2?= =?utf-8?B?THpIZzVPQWhvNURnSTF4RklWR3ltNGpYazJRNU4yOW5UMXRGUElUdndja1dX?= =?utf-8?B?dmdhN2RDNUhLbWZXdEQ2S1g5TFdnck4wbWw3R2F3b3pKMTY5ZktOMGZWMmU3?= =?utf-8?B?MnJYcHpiejdld3ZIaEx5WHI2Qi9UKzl6Qlg1RVBYWWRZTGo2MVUyODVTZENF?= =?utf-8?B?YmhxNE40VnQraDZpTUdNYTJKSDBkaVBHcms5U2pHNGtsVlpoRkxOTnVEYmRX?= =?utf-8?B?OElQMy9oS1dpdDhlZTE1UE1VV0xNTkgyTWUvQ2JheThnbGZPd1JJamRxREhI?= =?utf-8?B?WGdLVjdNYTU5WjBTNlpkZXFFL0ZKR2NSb3M5Wk1KeDFEcEF0anhVOE4ybXB3?= =?utf-8?B?UjFuS2VROVoxbHJhTkt5SkRFMjg4VG1kU0RZVzVUU2NWUU53ejJZL1hqQ0pM?= =?utf-8?B?Z1V0bGpBeHNhd21aRXlEUXFiRzcrRmNBeVlVMU80RW1RTUJjdW1OWWRVdklt?= =?utf-8?B?MmNPdTgxSDRXR3MxYm01TnJTeHhlVnZ1bDZnODY4Y3d4U0JZS0FpOXhyb09y?= =?utf-8?B?bzhwY2UzdnV2eCtaZmo2V3lMNDRQT2Q5WWNmL1NsQUNIT1BWWWRYZy9Rck16?= =?utf-8?B?NENiWk04eWtic1ZwQ0wzblhyOUVlU2QvTE41OTFNRHBtS3d1NW92cHR0Vmpn?= =?utf-8?B?VTRmVGRiK1dSRlNMeHM2UTg1RGs3S2xLdjYwMUZhNngyakpvVExPWDNaUjF6?= =?utf-8?B?ZFJoaDJYcFZ3R0Q5OHgvbjl5ejYvL2VXdEcrSW5pZzkrWVRKeVN5OVRSb3J3?= =?utf-8?B?alBhMURpeGswVVZ2MlRaUXl2RUJUQVlaeWpUbFhvV3pRTnBFYkZEWVVQRlJH?= =?utf-8?B?bnFCajJTNGIvNVlycCsva1lDbmJPOU83bnJtOUhVT0pkMG4ya2dTeGpXdm1j?= =?utf-8?B?RGY0Wmc5MkRld3lWYndlNEZEQnR5UG5wdWI3WnJsajJoZGRMYUQxUksrS09B?= =?utf-8?B?dHI0aithTjhXcSs4MGNDL2Rod1NmdkFIcXJ4eURKN1QwY2FnN2JEYVhOaEd3?= =?utf-8?B?UFNTOHg0K3BjeW4xWDAwaEVqcEJzS1VUaG1sUVp6ajhQTEQwWEVQV1JWUWhS?= =?utf-8?B?bXNtWWkzUExsSHQ0eGZOVDJPcTdTTEJIMHZpTnFlMUIzSkFEWUdzcExVc1c4?= =?utf-8?B?MWxJZWVLQTZXRnZiZVpPVnc3MzRmZE1FS2tQcHFLN3l1VGI1Ulc3MDY2RFo0?= =?utf-8?B?em5rbEYrUlJpcDY0Nm05Z1JFU0Q0cnlLamtZTjNQQXVqSnlDemR3SWdITFVn?= =?utf-8?B?UFYxQnFaS2Jvb2hhZ2pKcENZSGVQU3lTUXpyNFJhdHIzbUxGNlNYN09ZSEUv?= =?utf-8?B?SnJTbW1iU0NKWW5EMVh2ZnYzcFNpbDRwMms2bWNyNThvaGNsSVgvRWhKenZ5?= =?utf-8?Q?wa5taieMwU/s0qUiAR62cGOveVY?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUsybTNXS3FEYlhrbWtlK1Q3d0dsT0JRVkJEMnNpS2UvSHkvYlI0NWRTL0dG?= =?utf-8?B?L29EbkUvd3ZZZjFadU9meWt1R1NjYXZod1c1ZmZmNFQ3a3p2bTVtTXBONXUx?= =?utf-8?B?c3pJS2Y0SUl2aXRXenIwQ1lLNTUwVDV3ODZlaHpIZ0lBOWY1Q1U0eVBzK1Z4?= =?utf-8?B?T0hraDZMamhvd2dZV0YrOFFIU1E0U0diLys3aTFIL0VBWGVQd3BuVjROelRP?= =?utf-8?B?QjhWbzFpbjFEcEl4UjNYRmhyazZIY3lKZHJLMzlMY0EvQ05iemxQZEMrczZZ?= =?utf-8?B?aUlxZDUrbE1qRitXNG9RcHNib2lIaXp5UzdXRXFlZ1dnU2ptR0gxWnVVdy8w?= =?utf-8?B?K2wwaUY2NHdDQlNwenBqNDJ0Sk0rK0Vua0d3dlhOdU9vL0dqcVEyVTIzR3Er?= =?utf-8?B?NURVRmxTK3p2cE9lL05mQUhNNDllOElVclIrRnkrYjJ6YzJoMzF3aGNYdndk?= =?utf-8?B?TlUvc1U0Z2VOY09VanFDc2V2TU9vNWgzaHZ4Q1UwT0V5Z3haTjFkakYxTkwy?= =?utf-8?B?YUhoaDhndnVZVlF1R2JHWFNaVUd1RXlFMHBBejgzTzJ3NjYwMkl3UFNMa1Bp?= =?utf-8?B?ZGdndHBCNFlVcndob1MwUVFwNnhOYUVXMjROQW1rUzlvU05tWEJNK2lPWE14?= =?utf-8?B?UTNwcEtpekJmeDVEV3pEWlk1bG5OUlVuSVNQNWJSa2czUHhzVG5JNm85b1Iz?= =?utf-8?B?YUVic0dFNklYd1Q2RkEvWkpNZXBSSTJBZG4yZ1dFRzVub0pKZkVCcTYzUUdN?= =?utf-8?B?T2FkOTZQQUlHKzQvRE5Mdm1YU1NpYkVTU0RITU1BTExMalEwbk5DMlBBR2hM?= =?utf-8?B?NVBNQStjd2U2eVZyY2t0dzZaTVhoZ2t6LzVnd3BYM0VSOHMwWXNTSFY5dVp0?= =?utf-8?B?Z2xlQ2dWSFJDNnJGWmFwcXpEdnpZcTFnTjl4SSsxMjlMNEp6REFxMmVIczhO?= =?utf-8?B?VUpkY2RENFl1d3pScU5WTGNvMjZ2VXNhTVNtdURUakVzdFBsVEE0N21LZmhC?= =?utf-8?B?NFp1R0hvSnVnL2V3eWpKeXFETGgvL2NuTUZhd1Y5ZGdYZjV4WktIZ01xUjNj?= =?utf-8?B?TzBaVUlRRXFZNEEvRGpvQy9FTy9pblpsblFRTHFybDZOQUE4VzV6M1FXTlhG?= =?utf-8?B?VG1zQ1p3c1BqRzlVS0lsdXNHMlRMT1U3MU5TQ21DSGVpa1RoREt1MzZhaGpp?= =?utf-8?B?LzYvTXJNVlJvcm92b1d1dW40VHpsOUUzNmRtNDVoTHFONll0NnI2UXgwZmRy?= =?utf-8?B?S1IvdUdtVUVBMkFCNGNTU3lYRGFDTjNKZ2dOWDNnZWJ4ZFpnUDdZQjdiWDNX?= =?utf-8?B?R0NHcU1vNWJ2NHVVb1RGQS9SdVhaMTZpR0pkZVRMVkthQzFhUkJDYmpTcTc0?= =?utf-8?B?M0YyWGNDRlNKejFmVkkvZTZwK0dITnlTbExYMTNjSWZlTzZ3QVVDcDl4VnRr?= =?utf-8?B?NUJnN2tmM0NudWpjTVRoSlRXQ2ZIY0F5dTJaM0NYQkNOblJKYUowNlhLQ0xT?= =?utf-8?B?MUhsQ3VpeWgwKzg1SFBnUWpuSGZlZGhBaWhFdnM3dzlsMDcrVStQMGxwSWZL?= =?utf-8?B?SjBOekdqSHFRNGdiRTRJQkJCWTEwU3dzZnFhbSs3OXdKNkJZNzAxTlJ4WWRt?= =?utf-8?B?c0V1OWVPSEpZZ3NQSXRjSThGclkrSmhySTdxaWsya0EvRkIvOWRiMFAzM0cv?= =?utf-8?B?MWtMYURRSGVOY1NtRHRFRFUwM0I0aTZocEozeDlBejVKa0dxSTZwVFZ3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf7ab336-dc3a-4c18-cdaf-08dd49ecabd5 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2025 16:05:00.3655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVP250MB0980 Subject: Re: [FFmpeg-devel] H.261 patch to detect Iframe in H.261 decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jerome GORIN: > - skip_bits1(&s->gb); /* freeze picture release off */ > + intra_flag = get_bits1(&s->gb); /* Intra 1 = I-frame, 0 = P-frame */ > > + if (intra_flag){ > + s->pict_type = AV_PICTURE_TYPE_I; > + }else{ > + s->pict_type = AV_PICTURE_TYPE_P; > + } > + > format = get_bits1(&s->gb); > > // only 2 formats possible > @@ -498,10 +504,8 @@ static int h261_decode_picture_header(H261DecContext *h) > if (skip_1stop_8data_bits(&s->gb) < 0) > return AVERROR_INVALIDDATA; > > - /* H.261 has no I-frames, but if we pass AV_PICTURE_TYPE_I for the first > - * frame, the codec crashes if it does not contain all I-blocks > - * (e.g. when a packet is lost). */ > - s->pict_type = AV_PICTURE_TYPE_P; > + > + H.261 does not guarantee that a picture with the freeze picture release bit set is an actual keyframe; the macroblocks can nevertheless be inter coded (such a bitstream could cause a segfault with your patch because it tries to access references that aren't there). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".