Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support
Date: Wed, 30 Aug 2023 00:20:16 +0200
Message-ID: <AS8P250MB07449F1B2B253BDA5D7CBA278FE7A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAPYw7P5ptTAypoSeaGsQNbya+QJBgrBcdB9vvSZggL6vdq9AjA@mail.gmail.com>

Paul B Mahol:
> +    st->codecpar->sample_rate = AV_RL32(st->codecpar->extradata + 4);
> +    if (st->codecpar->sample_rate <= 0)
> +        return AVERROR_INVALIDDATA;
> +    av_channel_layout_uninit(&st->codecpar->ch_layout);

Unnecessary: This channel layout belongs to an AVCodecParameters from a
freshly created AVStream; of course the channel layout is equivalent to
an uninited one.

> +    st->codecpar->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC;
> +    st->codecpar->ch_layout.nb_channels = st->codecpar->extradata[3];

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-08-29 22:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  9:52 Paul B Mahol
2023-08-24 18:06 ` Michael Niedermayer
2023-08-24 19:04   ` Paul B Mahol
2023-08-24 19:54 ` James Almer
2023-08-24 20:09   ` Andreas Rheinhardt
2023-08-24 20:33   ` Paul B Mahol
2023-08-24 21:00 ` James Almer
2023-08-24 21:11   ` Paul B Mahol
2023-08-24 21:51     ` James Almer
2023-08-24 22:06       ` Paul B Mahol
2023-08-25 15:57         ` James Almer
2023-08-25 16:28           ` Paul B Mahol
2023-08-25 16:42             ` James Almer
2023-08-25 17:13               ` Paul B Mahol
2023-08-29 21:25 ` Paul B Mahol
2023-08-29 22:20   ` Andreas Rheinhardt [this message]
2023-08-31 17:51     ` Paul B Mahol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB07449F1B2B253BDA5D7CBA278FE7A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git