From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 459F8447B1 for ; Fri, 21 Jun 2024 12:21:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9AF8768D836; Fri, 21 Jun 2024 15:21:30 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2039.outbound.protection.outlook.com [40.92.91.39]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 821C668D67F for ; Fri, 21 Jun 2024 15:21:24 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eNzuK9SHsuQTQ4g17BEYOKM84xW671bfyF3fp5xuoQ04Ravzy1e1FJFDM1wTtyzgEoigFLUFSB9yYjKYRxJboOpytmGsXHe5O0Ls1V102TSnu20rLhsZeBx4tuKeAp84n9RWEB30TjoV7LhGW6tpk9mt/ldk6LeD5+377+Oq0w3p1Wtwx/S+svINqfzNnM7WCdQgr7DS41oBWdeC7jTGdgt+ZqxkUwyEpnC+anG/YqCO04xk1cAekmwg7DLchKi+4uvCvDjLp/r3DJKCh+T3OOwXrJ6J/My9ZrUlAsrxumrxC5bKpQIcUWBnzT7vo+FxO2QoEHnxt7bAwRfI3QyjpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u655d5ZR7tqlOwjzmj1yWYNiaGfo5Xe/v//XRiLgzcM=; b=Gc2LXAAqyuJVcuK/6avqvgUWpGt0SBmuNxhR6eHLQgzr0fVODl0ACUQMi4lVZOQsnllUmSJdAHF21hzQQ6ljHhJWBSUL6Va02ekaAESFr/aZjZZblL6zfxpPiHclZ+twbne6v6XPq4jVJM29vpNvGJM4/gClcdDoD+WJRMl/N5w7t92OwIjvVUMk3nEJMgCp93/zG2L9WL6s+EtjO3xDCQQYNjs3DUaSaMYGyEOugQKutAFJBF34v4o4S0vm/PuE1/mIzH7t8LbeZkkKDq5EkDAaDpi79sfJl+n6A8gZOsuwVYxGy/FsFCPk9RZGL2EK+XJUJJlSWLM8AFoq/PefmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u655d5ZR7tqlOwjzmj1yWYNiaGfo5Xe/v//XRiLgzcM=; b=A2ba0Sse9lTXr59nAVyLKKfZWIS8oLTaSaabxtsTLn15O5wGOtL4wqNnlcaN4BSD90kguSduR7KgiDI0wMnYiFjoSYy1silNUUqrug21Bn5QGIGu5r1vNLV182RiFws/d5sCk+X85FjDjGoOAoZHrSgfz2n1AG2KFjLt/uNdw2ymkXmmon4SpMYQAwrwurlQwyD/9eFViC4s2g0adMu4/+SwAiTX/mkuDiJGHjzsJ90Af09w6sU6qStfjMzz025sonSsFCOGoAlmPqome5ukiXw3wSvaqj8wTPiZ2N4C63SrJyYb6A6xj2wcfrGjnsGKQ8yvNoq9RhYcclqqbpxLsw== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PRAP250MB0420.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:279::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.19; Fri, 21 Jun 2024 12:21:23 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7677.029; Fri, 21 Jun 2024 12:21:23 +0000 Message-ID: Date: Fri, 21 Jun 2024 14:21:20 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [//Kgc5c+Y/90LjFnQSC0a+12mXQbzRqDkaWlxZMDdFk=] X-ClientProxiedBy: ZR0P278CA0088.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::21) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <5951fa94-90de-46f9-a7a7-22516fc2cff6@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PRAP250MB0420:EE_ X-MS-Office365-Filtering-Correlation-Id: dff2a26e-a1b8-4220-9545-08dc91eca9da X-Microsoft-Antispam: BCL:0;ARA:14566002|461199025|440099025|3412199022; X-Microsoft-Antispam-Message-Info: K3O7bQaIL1gyroaPQF1zwbzZXxsQ/VhzrnjwOYUPq/CwqusPrDmtxNR3maR8CdYJXPjeqRPTIy1OytVKFumMFevmuqThWaKhUlje3LRjIDC7tldSAHJvCtMuxrVCYmmuPjlBsUgrjwaIzFIeXs+IBxdMzzB3gYD6yf4ATnW5Nv4w96vZO2BbuaRRMkEjhag+MPTsig5rfISeJyIaM9Vb/0CFM7e0P8d362Eda/ZbxhA26KLfO2V4mgm+salkDPpNVHj08W7LVufSWjmvS+Va790lWEDh4TOUIl42849K+K22XPeTkvxplItbpdNOlkINFEzT1FT/5gTAi4vY42raedfpHhYp4Xcb7+l7kRSJ4ILO73HR/+QpbxOnrGBz/yxqoK/kct0Wd5rQK5vwpzdfLoB6rPHj0Z4lV63+IiulWKRi69xv8Eszj81LHCCM4ainajQSJesAGmM7LCFVrt9jZH4kn+VgOeVXULVhCeOMbJU8Puo5E7vjbGVATqhnaZnwoCHQUh+J5/JZFGOvhANVcQNLfn+08DcL+o/Us75Yh/kM8LLh870vfVHyUffGjvnJ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dk84MS95OHFaeE9KNjVld0V6STBINkNVeGNPSytWeVIwQzR6RkZBNXpHclZD?= =?utf-8?B?VkRRQTI4OTVUVWRIVDU5aTV3a2RlaHplUDc1WHlld0JwWUluQlRsUXdDdElp?= =?utf-8?B?dlhBQjVaMnpMRGNadEhrS1lTK3VDbVdRT2djT3poR05wbm5hVVByYjNHSTVQ?= =?utf-8?B?TzBWZXcvaVAyb2pDbDhLZVhvN1pZRmVjSkhUZkUvOS85V3pNSFhEcElLR2xa?= =?utf-8?B?QzJwQ3BENVVhanVRYlNtQjVFK080ZTJ0cHhSWC9oNFZtaGxpbHJ1M0pkRktP?= =?utf-8?B?OWVNZmhWNXJMQW1KcjlQZXMrMzkwZUdjREpsTzNNSFhMT21wOUlNK3BOUXJT?= =?utf-8?B?Wk90dkIySmRJaldma1JzekRVTUp3eVZYM0ZKSWFHSHFtWkRhUGxMbEVmSkxp?= =?utf-8?B?QlVFYXRrTXZtTkd5QmNGQ2JsTmVrd01PbkxXeTdSTzc1bWVHT0pkR2NLWXF4?= =?utf-8?B?QzJMVWhKNkZrQnRHWm9ZbmpCNHpqQWRibzNoUjNkMFlwZ3lZdlgxVVF6b1pJ?= =?utf-8?B?YjFhbzFzak5QM0tWQlRDczFJVFdHL1ZOUC9pNS85ZEIwMmFEQ1ovak9vdFdX?= =?utf-8?B?cGprdGE3TGt2V2lVU0VIVFc0eWg3cTliaStmTkhZRWFxMHBYWG1tSDJBaGF0?= =?utf-8?B?QU44eU1uRVVhaGc5NjkwQnNNaTZKZ3dXNVRLRzdsdE50TSt1NG8zODV2eEpO?= =?utf-8?B?MFBVd1BiQkYrb1pVMGlDKzBPVEk5a3k4NXRheWE2S3lJRm0vQUdkR0NxNjM3?= =?utf-8?B?SHNGZmVCbUhYSGFaTkJEb1M1WGhXNUc1OEd0MUt4RXcxRlZKZm5TTDJTQVB4?= =?utf-8?B?NHk1a205dU1rc1dwZ1BESkV6SmhhcnJZZW8wS1dHcS9jZnhJNFo4dzMzdDJZ?= =?utf-8?B?REZMZ1RIWWNzR1dhNEVkWlNLWm81WjNDK1BEZWdXUHIrYWUyQUdnUDNJdGdF?= =?utf-8?B?ZnUxcXpqMlYvWnJaSWwyQVRFKzJDbmVrTERMY0MvK0kvUUNYOG1hMWpMUm4x?= =?utf-8?B?eEZoOHJSMkFSVUwyVEt4REU4eElaTlRkTVRkOWl2VTk2eXBnTE5XcngyTklR?= =?utf-8?B?Z1FHZ1c1bGFBaHJ6NVIzOW9oUHNTVnY0b1JvZFR1WkFqdDErT3R0LzNTQTN6?= =?utf-8?B?N1l2eHN4d2ZXRkM5TTNMYU9FbnBBcHI0Y2NFaWNpdVVOV3gxbVlMYW1pOHpJ?= =?utf-8?B?eVFhMU9VVlZKcU13aHlCdGxZenZwL1VjMkVXcVBRam5MRWZScXdhNTVLQ1pS?= =?utf-8?B?Y0RYTXBTZlpqUU12QittNzNvenZ1TUJtMHZDTElmRmtiSlVodkxnUmpOMEdG?= =?utf-8?B?T2R6TWVDQURJYzlIeHBNbXFpTjFlZk0zRFFmb0JGa2hhUG55alVMWkhpNjNj?= =?utf-8?B?VkNBWktOUnNsRmthNm5xWlZkbmlreHRTaGZ3MkhnSkIvK3pWRE41QXQ4U3hV?= =?utf-8?B?U0laOHMyMDc3bkpDTTdjOEQ0M0hGdkRJRkFsODZFTzd6WFFVZGRVRHdZaE5Z?= =?utf-8?B?RVBoVmdMOHhYN09rTFk2cmZ3elZMRE5iMi9WenlhQndRdDh2NVJwZ1BvUVFD?= =?utf-8?B?OGgxVUJJOEdHZytPLzhNaVFwaHZuYTJCU3RwN2hrMGgzSld2STJVdmc1Ymo3?= =?utf-8?B?RitTV2s4bmNkWEEwU21iY1FrMTI4ekhHRjlkeHFCOVdGV3pIOHJ0TCs3RWh3?= =?utf-8?B?SzhIZXJGbllRUDBTRG1FVHFnUXo5WUNLL0JrWlNHbStPNEcwS1N4YUZRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dff2a26e-a1b8-4220-9545-08dc91eca9da X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 12:21:22.9953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0420 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/iirfilter: Move ff_iir_filter() to lavc/tests/iirfilter.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > It is only used by the test. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/iirfilter.c | 14 -------------- > libavcodec/iirfilter.h | 15 --------------- > libavcodec/tests/iirfilter.c | 17 ++++++++++++++++- > 3 files changed, 16 insertions(+), 30 deletions(-) > > diff --git a/libavcodec/iirfilter.c b/libavcodec/iirfilter.c > index 727a370444..cefe35ab6e 100644 > --- a/libavcodec/iirfilter.c > +++ b/libavcodec/iirfilter.c > @@ -277,20 +277,6 @@ av_cold struct FFIIRFilterState *ff_iir_filter_init_state(int order) > } \ > } > > -void ff_iir_filter(const struct FFIIRFilterCoeffs *c, > - struct FFIIRFilterState *s, int size, > - const int16_t *src, ptrdiff_t sstep, > - int16_t *dst, ptrdiff_t dstep) > -{ > - if (c->order == 2) { > - FILTER_O2(int16_t, S16) > - } else if (c->order == 4) { > - FILTER_BW_O4(int16_t, S16) > - } else { > - FILTER_DIRECT_FORM_II(int16_t, S16) > - } > -} > - > /** > * Perform IIR filtering on floating-point input samples. > * > diff --git a/libavcodec/iirfilter.h b/libavcodec/iirfilter.h > index d6b8fe2782..8ab8ae68c6 100644 > --- a/libavcodec/iirfilter.h > +++ b/libavcodec/iirfilter.h > @@ -28,7 +28,6 @@ > #define AVCODEC_IIRFILTER_H > > #include > -#include > > struct FFIIRFilterCoeffs; > struct FFIIRFilterState; > @@ -114,18 +113,4 @@ void ff_iir_filter_free_coeffsp(struct FFIIRFilterCoeffs **coeffs); > */ > void ff_iir_filter_free_statep(struct FFIIRFilterState **state); > > -/** > - * Perform IIR filtering on signed 16-bit input samples. > - * > - * @param coeffs pointer to filter coefficients > - * @param state pointer to filter state > - * @param size input length > - * @param src source samples > - * @param sstep source stride > - * @param dst filtered samples (destination may be the same as input) > - * @param dstep destination stride > - */ > -void ff_iir_filter(const struct FFIIRFilterCoeffs *coeffs, struct FFIIRFilterState *state, > - int size, const int16_t *src, ptrdiff_t sstep, int16_t *dst, ptrdiff_t dstep); > - > #endif /* AVCODEC_IIRFILTER_H */ > diff --git a/libavcodec/tests/iirfilter.c b/libavcodec/tests/iirfilter.c > index 60cc6fc43d..e03e842b85 100644 > --- a/libavcodec/tests/iirfilter.c > +++ b/libavcodec/tests/iirfilter.c > @@ -23,10 +23,25 @@ > #include "libavutil/libm.h" > > #include "libavcodec/iirfilter.h" > +#include "libavcodec/iirfilter.c" > > #define FILT_ORDER 4 > #define SIZE 1024 > > +static void iir_filter_int16(const struct FFIIRFilterCoeffs *c, > + struct FFIIRFilterState *s, int size, > + const int16_t *src, ptrdiff_t sstep, > + int16_t *dst, ptrdiff_t dstep) > +{ > + if (c->order == 2) { > + FILTER_O2(int16_t, S16) > + } else if (c->order == 4) { > + FILTER_BW_O4(int16_t, S16) > + } else { > + FILTER_DIRECT_FORM_II(int16_t, S16) > + } > +} > + > int main(void) > { > struct FFIIRFilterCoeffs *fcoeffs = NULL; > @@ -43,7 +58,7 @@ int main(void) > for (i = 0; i < SIZE; i++) > x[i] = lrint(0.75 * INT16_MAX * sin(0.5 * M_PI * i * i / SIZE)); > > - ff_iir_filter(fcoeffs, fstate, SIZE, x, 1, y, 1); > + iir_filter_int16(fcoeffs, fstate, SIZE, x, 1, y, 1); > > for (i = 0; i < SIZE; i++) > printf("%6d %6d\n", x[i], y[i]); Will apply tonight unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".