From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CB52F40D86 for ; Fri, 21 Oct 2022 19:00:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F075068BEC0; Fri, 21 Oct 2022 22:00:22 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064059.outbound.protection.outlook.com [40.92.64.59]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D8F4F68BEBC for ; Fri, 21 Oct 2022 22:00:16 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xux3FkDZ9NSFaTxABZXregd4l+VEOdHlv8pqaBczE2yqiqmXrOF6KgS3GMDf/1exxrtXf6aIIo8u5FuoZkq25yy/TZCwl0sTSyXAhr4x0icCzFC4bECzFgtGYZxfzXkNvLZZSu1sqFWzIBk+FxW0EDXifTpSLZyOKNAHnEg3jmCesrdXsE1uPYnXqq8e8bo9v1OE+ivnAupBF+dazlQXU0OWzd+1IVxhka1hgNktU758jno06TsaC86/oT3/20LqKRjeUqinYtJ9C3iCqmrhh0RsKs5hm8ZNe/ov29yc5kpPyAZ+WHvRA3kQ3GertLh5jBinXVw7WVf2LGNH/UMHdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ziFgbYaOEwjAhX+MURScrJmxITEcHXGvpGg0oBgUyhU=; b=Z+tq1M821g3bK+JWWrHZHI1mtu/6r67JFeevcw3GrTNQj+/uYFCbLihIvkwHvbHLRo641SIi/BjFnkLIU2cizi4WOx2HOGxe1uio3ZG3FGWL2cPZxIlkY76EBATU9D7MMmeVPtiII95cJb0IifRkWiWWAS6AjYrtlgfzoF+2yJICX6zu68QJdvklkDdoM9B+EKi/desvwIat5ErJYWM1hZ1YG7NpWP7SsDwRbjEdwb1EZG8iyFRGxJhyACoXAH7ZAh/qFiCPP4dqPJ93yk/RjnYjzFiioVu1POXiURRdNBnOi2XvBBuJfzgWsXlL9AU4jQMjYq/KUinIPW5FdfC1AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziFgbYaOEwjAhX+MURScrJmxITEcHXGvpGg0oBgUyhU=; b=blptlTFa2WUe1JHwqSMzPHLVkxEsHRbrLAzgGGNfP4+7TbUaKPnE4A5arh7DDeIreWfgZxVLtDkPGYBfEW7HHyAJf8tprWWydHZgWEspystqmKhI24bPMD0+rCOhRuunZ5pAO+/m+uq34H+3ewtYsdk5Zu8VZhV1DbDC/Y9Hyae3ja51JieQeTBfLLlHPDcjQNRgdKFzJzSsWv3b7AkAVxIh+TatU1M3qgB4i88JPDHameTkwQs/ZWzUpIVHj7gDQtMVae0N3nMU+HPsdAGuT4mhUWYcXs/NmIfTzGlE4/TmhAZ1ihk4UXlbVmtmfs1qgJi9oDmDdGvHAmWgdGcbdA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PRAP250MB0491.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:291::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Fri, 21 Oct 2022 19:00:15 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe%7]) with mapi id 15.20.5709.015; Fri, 21 Oct 2022 19:00:15 +0000 Message-ID: Date: Fri, 21 Oct 2022 21:00:25 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221021184608.GA4048598@pb2> From: Andreas Rheinhardt In-Reply-To: <20221021184608.GA4048598@pb2> X-TMN: [tSj7HPEuLwDDbFHxnmVFQkp6vBgUfYCvqrZIWsiVZTA=] X-ClientProxiedBy: FR3P281CA0168.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::20) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PRAP250MB0491:EE_ X-MS-Office365-Filtering-Correlation-Id: afd30929-f3c8-405b-5ce0-08dab3967d03 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NY3RTPLBzyN4R/bZ71JjWxSFwsmmnNQ8ewrUaXkxuiSsM7YfrEduwnctGDbZggbo+6/ZICXv4S/2M44fBkSMf4pSDMucVhJIqvySey5cFUyKFF0R+zNHjKr6FAhvN5VNBVZjNtI4cgd6HnRKHDeg6WOiIcYlc8Xmb6iUutyyMpJQ3wmjGbgVElP/VI+qWa7PS62o8sPNLoDz6g+PKpLnCejTWxhlcMU7jFJ+A/jljjGmzd9+Tsyzn7+4MG8bJlAjR+LfPzufE0snHkv6LBz9sHxqtWa0QGS3LxOc9U3ymQ8+xXbBu9aJyp7bsRqHXhkZUeQqAQYO09LzOnnkl3047xq0WSruIVO9F0oqEfKgQptfsgFVv6t7PNSdtHZirTx+x/X2JO6LRwMswLP59vqGQglskYHnGxvuCCDN1BCXxIBQa4bysR3PxxlK4b/fXhFxzMgtfYhRRIIIzb0ZV2/9gVXJxSakv/d89MUOE2EpH545y4/jpI7fDArgzNtywv7TzwjytseUHv0nVewwFo6EZaQc5A9OtpwcqvQO08Qizkmp5aKkhHmcJUWNd4E3Gh57rHwWOZ4m8xE7KEf4Fam01V3aJXhX32UGOT4u5BBvOIVMTK1ctCFqFjiGH3aE63Yy/XWMua3nt4HMF7I6Y+4FIshC2zIo9LX+M11k5GbY/Pc0bsZO8b2qu5dgiM75dGzb X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3ZQVTdSMlI1OVQwdVMrMzJnS2RXelI4TU9WQitYTk5ZZWN3S09tUW95MHhU?= =?utf-8?B?K3FpcDdmYlRQc29zN1FuSUlyczhqb2tpcnhXWU1lSk5DYTlRTHh1MmdzYUov?= =?utf-8?B?NjYxQU5zTE9zd0RScjVGWTVOMTRPbTh5T3hTUm5EOVhBclJsWHV2aTJiU3FI?= =?utf-8?B?RHc0L0tnbUNLZ3R1NjRmRjdqQWlmdTlhMDY2UmpqU0I3eHJ4NDBEUlcycUZy?= =?utf-8?B?dExQdzRQUGgxYnRWTi96VlM4TTJoVEYxK05RbUVTcHRDc1pCbGNkTFpBNW43?= =?utf-8?B?WVJtOEhkMCtRVGZqUjR1aGNVaDhYdUIwQk4yRFlDNldXWU8wbzZ4bENWbXhi?= =?utf-8?B?alMyNy9xbm4zV3VwL1gwRnlXSklubk5LNTZZek11bmpGRVhzbEtOUVhXbkEr?= =?utf-8?B?QkRaaU55Mzl4M1VpMm9VV2hvdlNFV0xkbDJkQ3dGbHVRQUkxZGlvWFhOQXAw?= =?utf-8?B?Z3ZwVTBuVk5jM090QWM4V3BBdkhRbkFnVjUzdDRRYTFSc0VEZm16d2NNQlY3?= =?utf-8?B?cHN0ZDRRT1ArMU5rbXZra09sWGtCT2xsYmhzeTZPU0VXRktwcjlNZGNkaWpi?= =?utf-8?B?KytZalNJN0VURlcxbWYvaFZtKytjWk0vTENCSGE5eXA1TzNNK2Jmc2FLMThG?= =?utf-8?B?ZXc3QWM2WVJOdUUwK3FyNGxrVnZSMzlDdjkyQXd4S2w2MnIreXAwb3dCUUly?= =?utf-8?B?UlVkS3JyQUJESHJBQjlDTXBVbDgwU0xua0I5UVVWTzgzcUZyWEsxSURrYUlC?= =?utf-8?B?VFc2UmVIZHNMMEp4dU5Rc0tzemo0OUg5U2o0d1dDS0tvMHc0d0kreFM3YUZh?= =?utf-8?B?T2tXYWR0d2crVWtUQXBWN1pxa0JwdUJiVzBnR0xMNUVOVTNqbUtHRFZMNzhE?= =?utf-8?B?bGxmMFhOZis1Uko3VjhVMEU5UGQ1dFVUeHJPbzJMdzhkTFBaZkNLNnBYUEFz?= =?utf-8?B?QUp0QWtXd2NtRFM5dXoraTErQllmSXFvdndsTVZnTlhEVW5iYUpKajlXM3NK?= =?utf-8?B?SFI0UzA2dmxXdExsK09TdDByYU9MaUVQK2NvL2JhWGdUSlh0ZDZlZDhVV2U1?= =?utf-8?B?UzhnM2NMZFloeGlCeEZmaUNjSU5WNlRIanBqUTlDYmtjV3R5L3ZzTXJlcUZG?= =?utf-8?B?RzIvOXAwWGN4Q3F2b00zMk9ML1dKdkRaNzc2THRLQTh5bE1kUUdLM0NQYXZQ?= =?utf-8?B?bVVDa3hhQUdvRWl2b1hNQVVGZ1FEclVaU1I3cFpCUU0yMFZZUFJWMFEvTHFX?= =?utf-8?B?T2ljbEMwdE8yNkM2U0ZUVDkrYmZFdjVUaXVqTk9kWDFVUVlKV1I2aVIvZWVC?= =?utf-8?B?c24zaTRtQ24ydU9GN3Nza1VER0ZFVHZGaGVqazl3UU1maG53QWFydUFkTmpl?= =?utf-8?B?QXY1bXBER21FeGNyY1Q5Unh3NmpJRGU2QktQajFKQnFlWnh1Rzl1Z3BYNDF1?= =?utf-8?B?alRhQmlYOXdqSENhKzhUSk1IWm9qZndmS3dQR21Wd3BWc2Y1OHg3ZGFyNHR2?= =?utf-8?B?R2dqdmMzdEpjRU9rdkFyWFFsSThGYTczN1pXTGJMbWFGK1FNQkhiNUpVcXNl?= =?utf-8?B?a012WHloU1NpM1hzcjFodExnN1RRV0tMZHV5bUk3ekp3c0RxTXVCdExtMnZJ?= =?utf-8?B?Sm9PM2ZWN3JDZnAxOTNmTVNwT2ZWek9MUm4vazFVTDNWT05LUjFldmRZTmo3?= =?utf-8?B?eXpFRU10M0ZXMHlwKy9xN2c5RHg1WERkTWhhVVVKY0NOSG1ZWEQxQnIyN1p1?= =?utf-8?Q?Gi/UuuSZu3FCJFBNA75fO0jIIPBV0QeYH1GHFGP?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afd30929-f3c8-405b-5ce0-08dab3967d03 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 19:00:15.1747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0491 Subject: Re: [FFmpeg-devel] [PATCH 24/24] avcodec/mpegvideo: Don't use ScanTable where unnecessary X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Thu, Oct 20, 2022 at 07:24:36PM +0200, Andreas Rheinhardt wrote: >> For the intra_[hv]_scantables, only ScanTable.permutated >> is used, so one only needs to keep that. > [...] >> diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c >> index 8e6e35b927..bf499a2206 100644 >> --- a/libavcodec/mpeg4videoenc.c >> +++ b/libavcodec/mpeg4videoenc.c >> @@ -175,7 +175,7 @@ static inline int decide_ac_pred(MpegEncContext *s, int16_t block[6][64], >> ac_val1[i + 8] = level; >> } >> } >> - st[n] = s->intra_h_scantable.permutated; >> + st[n] = s->intra_h_scantable; >> } else { >> const int xy = s->mb_x - 1 + s->mb_y * s->mb_stride; >> /* left prediction */ >> @@ -197,7 +197,7 @@ static inline int decide_ac_pred(MpegEncContext *s, int16_t block[6][64], >> ac_val1[i + 8] = block[n][s->idsp.idct_permutation[i]]; >> } >> } >> - st[n] = s->intra_v_scantable.permutated; >> + st[n] = s->intra_v_scantable; > > Iam thinking that replacing > s->intra_v_scantable.permutated > by > intra_v_scantable > is semantically feeling inferrior to calling it > permutated_intra_v_scantable > or something like that > > The same probably applies to te other patches too > iam not happy about the long name but having consistent > naming between scantables (as in the spec) and scantables permutated > for idct optimizations could improve readability of the code > Ok, will send a v2 with this changed. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".