Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avutil/attributes_internal: Add visibility pragma
Date: Sun, 9 Oct 2022 18:03:51 +0200
Message-ID: <AS8P250MB07449D513FF191E8DE3DF6878F219@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <GV1P250MB0737C0A0DCBC4CD7C2DFE8608F5A9@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt:
> GCC 4.0 not only added a visibility attribute, but also
> a pragma to set it for a whole region of code.*
> This commit exposes this via macros.
> 
> *: See https://gcc.gnu.org/gcc-4.0/changes.html
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavutil/attributes_internal.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libavutil/attributes_internal.h b/libavutil/attributes_internal.h
> index 9d3d10b63e..3df1ee6af3 100644
> --- a/libavutil/attributes_internal.h
> +++ b/libavutil/attributes_internal.h
> @@ -23,8 +23,12 @@
>  
>  #if (AV_GCC_VERSION_AT_LEAST(4,0) || defined(__clang__)) && (defined(__ELF__) || defined(__MACH__))
>  #    define attribute_visibility_hidden __attribute__((visibility("hidden")))
> +#    define FF_VISIBILITY_PUSH_HIDDEN   _Pragma("GCC visibility push(hidden)")
> +#    define FF_VISIBILITY_POP_HIDDEN    _Pragma("GCC visibility pop")
>  #else
>  #    define attribute_visibility_hidden
> +#    define FF_VISIBILITY_PUSH_HIDDEN
> +#    define FF_VISIBILITY_POP_HIDDEN
>  #endif
>  
>  #endif /* AVUTIL_ATTRIBUTES_INTERNAL_H */

Will apply this patch and the opus patch dependening upon it tomorrow
unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-10-09 16:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-03 22:32 [FFmpeg-devel] [PATCH 1/9] " Andreas Rheinhardt
2022-10-03 22:44 ` [FFmpeg-devel] [PATCH 2/9] avcodec/opustab: Avoid indirection to access ff_celt_window Andreas Rheinhardt
2022-10-04 12:14   ` Michael Niedermayer
2022-10-04 12:18     ` Andreas Rheinhardt
2022-10-03 22:44 ` [FFmpeg-devel] [PATCH 3/9] avcodec/opus: Move OpusStreamContext to its only user Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 4/9] avcodec/opus: Move stuff shared by decoder and parser to a new file Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 5/9] avcodec/opus_celt: Break cyclic inlusion of opus_celt.h<->opus_pvq.h Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 6/9] avcodec/opus_celt, opus_pvq: Move CeltPVQ typedef to opus_pvq.h Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 7/9] avcodec/opus: Move remaining celt declarations to opus_celt.h Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 8/9] avcodec/opus: Move defines to better places Andreas Rheinhardt
2022-10-03 22:45 ` [FFmpeg-devel] [PATCH 9/9] avcodec/opus: Move Silk declarations to a new header, opus_silk.h Andreas Rheinhardt
2022-10-04 11:09 ` [FFmpeg-devel] [PATCH 10/10] avcodec/opus, opus_celt: Fix header descriptions Andreas Rheinhardt
2022-10-04 21:40   ` Lynne
2022-10-04 22:39     ` Andreas Rheinhardt
2022-10-04 18:30 ` [FFmpeg-devel] [PATCH v2] avutil/attributes_internal: Add visibility pragma Andreas Rheinhardt
2022-10-09 16:03   ` Andreas Rheinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB07449D513FF191E8DE3DF6878F219@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git