From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F087D474A7 for ; Fri, 8 Sep 2023 09:07:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 230D768C805; Fri, 8 Sep 2023 12:07:47 +0300 (EEST) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2055.outbound.protection.outlook.com [40.92.48.55]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 221CC68C6D4 for ; Fri, 8 Sep 2023 12:07:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ULRvxVMmiyT4SgiqSv4UqYTcoyrj+dBOaC64P3mo9oVL4W1OPGEFElHW+GFqyyZaOeExWq4AIhbB/kNj0S2k0ucgNOODKy7JwjYiV4uXcI7Rbu2AHXhnL6HOuBOzsbgFyoHkl5ly3ViCm3y8e0+aK5Y9SacTJVoBilX3Nspwpg+h7cuV9OdqCuNRu4rMrDs6cf5ChwcePTYtEE/P0C47o9zGP4rL2vtzPHJNfQkZaRjgOZdDT97Tq6IHgY/OM+cPb/dWl8dxS01A2iIms4TkHX5LsZSdKPzLb5TxPazu7WwYw9IXjwHzCQNF/t/ic17HpIitj2FB7w56YM1XZaNvoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vDniXGAshL2JIih1bh31zU9QIoeO528AjL7YFHGanBg=; b=mY6K3etRaPUiRtEGEauyIchbnk+cLgd2cZ5UrUP+i7Ik67o9yF0TQMBCmaGtEFBb8vAheD8tS5etA7PI9qnLUoUOfM0uso9IMz9hSKHFUfTIaDIdNKI+ljo0p3jyHRSuYk46wT9tAN1EaMfh97X4HDUmZT45jAJKei7D9uoB7gvXsMDuVjyzjDuRVcQH4xUA3dTxS3+SRD2Umdg0Re7eX6aOiaJXC/OiJnfhANYBTJs31qY8jhsWsXThiB1WwONRJhkiObcFx5QleGLMe4qByKyRL2CkL28oq2ItpHfb5PLwTjT+EitIss/lswgfJ5XjhKKJABw26kOlSDg/aLgW/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vDniXGAshL2JIih1bh31zU9QIoeO528AjL7YFHGanBg=; b=MufJahSHbdu1h71kMCkpyebO6yF649YEzfhSKUKgJqEZ+T57HQJAkIiQpypPa+UZxQ4+eat0l5htjsTobt40Iot11oL4rf/k50CJlMNeNWwssJTB/ueGMYAKGg/DJ+y7kujjXHs5L3ut0JnRqClhjV3yJgOpnPs3ehli+gNSQroxtD7gkQxO+MrlnFR7ooEtiEsW1pTodiwLwhJrEZzI/JE77Ft/fXlJpqz3rMsfklaAIM13RyMLidPIVe2fYf9ekhaaoIQI7DtabOYTzZYEkNmY7wNQLN0ejiP+av2JF+8VJJosbQUes/+slcv2kVTEeSIQz/WwFFGcPVfIrt54nQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0239.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:278::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Fri, 8 Sep 2023 09:07:38 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6768.029; Fri, 8 Sep 2023 09:07:37 +0000 Message-ID: Date: Fri, 8 Sep 2023 11:08:56 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230908081508.510-1-christophe.gisquet@gmail.com> <20230908081508.510-6-christophe.gisquet@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20230908081508.510-6-christophe.gisquet@gmail.com> X-TMN: [RuDEwPkKsQoLQBdopr0Al7sg2abjQN+9] X-ClientProxiedBy: FR3P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::6) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <2ac0475d-6c04-7e6b-cf52-65e967ed35c2@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0239:EE_ X-MS-Office365-Filtering-Correlation-Id: 88f20aa8-85aa-4667-8b8f-08dbb04b0be2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JF+x9jXC8IY44ZEP+hnWOAuYTXFUn4v+Seu3kowdeEFpSrnFThQeX09KQhqIWFHhcdQUayvonsu7RiumB03M6Qyf+CccczUfyY2/yDe5qMn7D6jTD9UMubRzljiw3bS4BLevLWx49KS50Qth1Q+7/3mj8+VUC3+0YjdSKoZdK0Szp/bUgBTxGJcqqu4Y7R+y0uohKn8ow3QP6sE/E0h95uNOLVxJUBY8DwA80F7lrrPSAiXzAgJe/wsizHNTL1/4aYPGblj/ad6euYxJ+TGQhf79RDHJExMXEdcPtERDCHpPLsYiwnEBMx3wnan+SNZ7JH+J03q92y+sTYv5px+yPZ83cgDDVdGDaLl8Te5jVZnQK7Trzp9DpHWAMATiBWZk1gVLrr8L8HT7NZxVeLk1in/gH+xtSLUUG0ZFjQ3c7UXA0nUrXI3ShD7soXFUp6zlFMZXKelR6AT7W3NY5zn/AjlQ45wylsn5wT0aBdw75K6yeLK+uBigV7TnLi1e4Dax3MWmWyvZUrF2pbEpKB1vzwjOi+MNiwse7JyXaNhc1AQk6bIdpJlNaj6MXqATlc9y X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDh1MlJCaGpWZFlScTRVMW9QMjljZ3BBRjQvd00rN1hxWEFwM2c5bXlTUGFu?= =?utf-8?B?b3pFeTRrZC8zSUxnMkhWZG9rOFZqbkFJenU4YXhyamZDdFVGWEZleDdxdTJ3?= =?utf-8?B?VFhNR3YySzJHbUNic1psT0xjNnNpdFduNkVtcC9hME9QM0xBSlkvbW1QdVFI?= =?utf-8?B?RkZ4aXUzNFN4M09CeW9CcEYwSlM0RHpiWkVjMzFFNFNLVWNlcVAwL3VhZGY1?= =?utf-8?B?MjJ3SnB3OHRUa3lPdE4vTTB6UHhaY2VJK0RMYUhaUnJhSElNVHVyek1qZWMv?= =?utf-8?B?b3BtWms3cEZTMksrK2VqNkhQVnhHWlVRS2JabmIxYS9UemVtd281VHc5bVJG?= =?utf-8?B?U0NVbzJEMTZYNGRRZ01tUzBGd2Vvc2k4WmJQQU5hTDgwT3l6WE1rNFZpMkJJ?= =?utf-8?B?R0N1UDFnTmZMVEtLNnBBTUI1SDFMZWZSa2E4bU9SeU52YjZReGd0TWRPTzNy?= =?utf-8?B?NWxSQWlMNEhoZ0ZpWitERWJ4S0gxNTBHaEI3YmJjcGY5djdoN1c0Yll0Sm9E?= =?utf-8?B?dWJQOExzSm93cUo0U3cyaFVFTE9ZU3pHU05tYUQ4TjlXU3hQNDFyVE5IMWRB?= =?utf-8?B?ZGZySXVQcmpOalZwZ3N1a1dhMG81YnJlS3pVNVUrUHU0RStZZW5XbFlPbURY?= =?utf-8?B?TTBqTWJOSWcwdHJVMWo0RzNBcWRyNGZuSHVTZHJudURKUnRVSVlibllIcmdz?= =?utf-8?B?ZG1jQk41d2hnVDA2RDZNRVJWaUpCZWVQTjl0YUtreURCWjhnaVpZdFgycThi?= =?utf-8?B?YlZpY3ZUdEpNV3c5NXIwdzhIc0tSU1ltbUJFczJZMXBaSmt4ZXNZNlk3UHM1?= =?utf-8?B?TW5RMmJ2M0UrWS8xRCtMcE8zbjlVYkxONlJxUEo4REpueUpqZ3N0ck9XVTdI?= =?utf-8?B?ODRvZmMrRFhGOHhWYzM4MXFGQVJCbkRiTEkzbXhoK095a24vZnB2L1hGRDJw?= =?utf-8?B?ZVI0YjFuZm1qVjA0ZUdhQ0NvYy96SHkxdllHTmYxbSttNWFUZHhIMlYrMThi?= =?utf-8?B?MWJxa21vcnFGVTNObEhNNUZPMWpUdlRYYUZBVXV1SW9RTi9RV0NydWdOaVNl?= =?utf-8?B?U3Z1cDJOK3lGR1pmQjJCWmwrSE56ZEhEVGdhcjF5K0RrNE00MUhqTTNkN1JT?= =?utf-8?B?SXFwRnRRYUw4V0FxOE9RbSsyMTVxcFEvc3ZJZVU0RGw0RlgyaXhIc29lTkg4?= =?utf-8?B?dHlScTV4Q3d5MlNGeThlSVJuQkliODJpOFVPUDJ2MzhCbVF4ZDVnQUVza00r?= =?utf-8?B?VnVZK0hxUjNmc28xQ1BNVWVCNDl4TmxwcytWclBrZ3VSL0pBU3NVUE5qc0JY?= =?utf-8?B?Z2NvOUxDVjV2U0RqUGFHbTdBVkNwVm91K2VyMDBwbVJHWWR5ZldkZDVZQy8x?= =?utf-8?B?V0xLRGVXcm9zaGNXUSs0Z21kS1V6QTZtbjZGN3dTMDJtUHMzTXBrdk1wNjRQ?= =?utf-8?B?S1VzV1VKeUp5T1ZiNUZGMGc5SXd1amRPemlUOWxKZ3RpbDk1UHR6R0hyOTFJ?= =?utf-8?B?VUhzRDgxcklseHhpVWtBT0Q1V2kzRG55ODlZWHVMWkNUcXBBY2FIVzBCNVhq?= =?utf-8?B?NlNNblJ4S3lhYnk1VzQ1Wmw4Mk0rbTVYUlRGcDAzcmFrdnFud2hMdDhEM2hH?= =?utf-8?B?MW1QWS82cE50YVh0K0ttZDhYN2ZLNWNkVVh4ZE9qbHJJK2tadEliWmVLQmhn?= =?utf-8?Q?sjhzqUc7tU1/uWfZOH5q?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88f20aa8-85aa-4667-8b8f-08dbb04b0be2 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2023 09:07:37.5626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0239 Subject: Re: [FFmpeg-devel] [PATCH 6/7] proresdec2: remove a useless DC codebook entry X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Christophe Gisquet: > --- > libavcodec/proresdec2.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c > index 02e1d82d00..b20021c622 100644 > --- a/libavcodec/proresdec2.c > +++ b/libavcodec/proresdec2.c > @@ -534,9 +534,9 @@ static int decode_picture_header(AVCodecContext *avctx, const uint8_t *buf, cons > > #define FIRST_DC_CB 0xB8 > > -static const char dc_codebook[7][4] = { > +static const char dc_codebook[6][4] = { You would not need this change if you omitted the length. > { 0, 0, 1, -1 }, { 0, 1, 2, -2 }, { 0, 1, 2, -2 }, > - { 1, 2, 2, 0 }, { 1, 2, 2, 0 }, { 0, 3, 4, -8 }, { 0, 3, 4, -8 } > + { 1, 2, 2, 0 }, { 1, 2, 2, 0 }, { 0, 3, 4, -8 } > }; > > static av_always_inline int decode_dc_coeffs(GetBitContext *gb, int16_t *out, > @@ -553,7 +553,7 @@ static av_always_inline int decode_dc_coeffs(GetBitContext *gb, int16_t *out, > code = 5; > sign = 0; > for (i = 1; i < blocks_per_slice; i++, out += 64) { > - unsigned int dccb = FFMIN(code, 6U); > + unsigned int dccb = FFMIN(code, 5U); You wouldn't need this change if you used FF_ARRAY_ELEMS(dc_codebook) - 1 here. Btw: Why is this codebook entry useless? Can code never be 6? > DECODE_CODEWORD2(code, dc_codebook[dccb][0], dc_codebook[dccb][1], > dc_codebook[dccb][2], dc_codebook[dccb][3]); > if(code) sign ^= -(code & 1); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".