From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 021C245301 for ; Mon, 19 Feb 2024 10:54:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 518AA68D3E4; Mon, 19 Feb 2024 12:54:21 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2052.outbound.protection.outlook.com [40.92.75.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 54C2268D1B0 for ; Mon, 19 Feb 2024 12:54:14 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1Lf3mRuBZpiW/fbRqtlovgDHYPPjhXhFGChKJr3z5bRfRF7dBgXkoSurhK2FYcUrXgwAi5iMwpdon2JCasxCr8hqXghMPbL5dpLP4+p42VGK6muW5bX9HKEwG9Q+nnCvEz/9aajzfmszOENU/CuduCE/ZeXe7H8H7+vJYehMHHImhipUHrWeNdXvluCHiM8Mtw+kEwjfRrOd8vVELIVjfHo/hHnEnfnjqv7WxzSio74/SbiODtGjNI35rkgTR6bkO7coudsSp/4xDPJKi0VuCplpdLc2+X8GMNbiXWXyyBpNhNbDr2ilC/LO9JIqXWXfBiwUrKs5AfUqFqI2h3ZnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=89RCr7B5hCW8xGJ/39PYBd3PDSRlkpFqLkWRuA6aqYI=; b=P98vgk4cWt9fWwnjx2TwUImwfdXRa8wg6AnY/HYVfeZxg0w7+V7gKeM/LCMe/AmZUalv4JzVcTJBpvuR6y9o3xGKGYj0Q7I1WsDKrsBTB1dKJzbbmnw4su5+zu5fvj1oExbjeZKlJfbnqrC3T0ZVyiQ6ltPH1w2vEm+rV2Ukn0qkUzHADIwtK7K0vqvQ58eaXpiVxehyrvofXf+jQKwV/685uhEAIVYFh4s0cpnn9TsH7vboqzl6ByhNruOtClMRvhvgVX+wYuYfKO9U/oQRZRxjpWXnuYVSukvvZR32ykQsHxF0tW6xHewPhECzr1xnk813tZKMKUEsJcDmPt6ebg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89RCr7B5hCW8xGJ/39PYBd3PDSRlkpFqLkWRuA6aqYI=; b=kPQ23U95mnQAlBOePDOA9QUH4YVI5fTqkQC7TFUm1f9covK9woTZF4reAISTHX6zUjoThnqNGuFhriTERRbdWEiup1FUvvvOLApZ4DU+oo/XrEmMDgfgTnDl/4I86lfPAqTWbDNokh5nrXvNsak5vzmFG1P8l45x2vJFbgFDW3HgbrOizmb6AVgH17VQn1b2V7UMMdC+7OtUEJ+9pX3rYCzq3yofo67TpdCWevxQ4bm0hmBXFkz7BRwFaJrlmsUwXHafk7vMYMV2vLTPkhqyjxqveiwX8PHKwLB/x6jUZt8yUsQ+3/+Ym75tPmJg4WF6zwog/sxak1qM4BUg2o5p8A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0279.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:32a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.38; Mon, 19 Feb 2024 10:54:12 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7292.033; Mon, 19 Feb 2024 10:54:12 +0000 Message-ID: Date: Mon, 19 Feb 2024 11:56:07 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [Y//rIX894EU5FUdbLhQPu2KijakHmFtd33aeKQUKPyU=] X-ClientProxiedBy: ZR2P278CA0023.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::18) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0279:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c88dad0-0770-4276-656a-08dc31391b5d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W6bSKyUMJlDB0NDkp2S4rEpZ2Z+Iqfhq+GlaEdU7UKoiRr4K7Wz3ypBDPyxZm1Drzq+nyH13Ec3bIOFDYVr4iLpjTneRSX4YmxHyk1LI/hT5LVAj7qHAU+NcggpP4hWYI96QWVd4fu5WE4Go4UacWFeHUOYE0N5ShdYjidtCR7hhKiUPLZQP1F4dpMuH9U43DNCoKs8P1tPf9MoB3rVYictiE3+YzqR5ibBv1mCHLcjhllrYpHq2od4LWxGIwW7j0WQ8c6E0Jp9TDayNFbfPefouKeYduzM0Sf5JmwQiB9yY/lGS6sroZ/QZ7mxhBzotvPyl+dbz3cv1p0wCLWrWFlT0ch8z6RXwYafsLgknLEyC9Qr9nxO1Vb5hsFNkhLV4BmgLnex93fdMkJngkxVX+dsAqTJ0q8yqQ8KNHkZUfUP0JBRt9YXc4DaLgzNFyIkmZJSeTS0ymY2jlstt9pn5kidtHPmMX2osD0ElY50RPd6TlMgrJ1t3dtT+tTQaeRD5QukjVnWF8AB3FqJ1f8gHOs13+DJlf1sHBptLp1H3tO+ZU5UoGaYXxhApt0c25M9R X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmxCVXhTRjFjd05aSk9qNzlRUlJYZm9sQ29vTE5JT2t4bXZ3TWtSdjBueUNC?= =?utf-8?B?Qy91dDFKaklPUW9VVXdxNHdRMDBMSXRpR21XeTRQR2dxalJqQVIzNDB1VjZu?= =?utf-8?B?NEc2SzFHL01hWE9pc0RES1FOQWtxTGZSYTdmVmpyL21Ea204VjdGL3ZnY0Rh?= =?utf-8?B?a3FMbnJtUVVjemVPTGVSVEg2bzdUamVBMmxzN2RNYTNESnNhZmozS01lNytI?= =?utf-8?B?MWRxUkVsbmR6cWlGWnp4bzd1SE5zZWVTbFdsZVQ1UTBMRWw1bFFGWGpDV2Vj?= =?utf-8?B?cm93YVRuYVQ2enlvbytQdUhxdWRPTnVDTlZwaGRjKy9peG9jb0RtdzNiSlc4?= =?utf-8?B?VzFScGVvOUk3a0RHcWw4WVdPMnVRbFZDeUV5ZkZOeW1GT3lOY1h0UGw0SW1j?= =?utf-8?B?d0RiYW9CbnZMMGxQTHVhaHh6T3ZEWmN6TG1UZ2J3NTFSMHlBOHZ3RitjdnlM?= =?utf-8?B?WlB4NTA5OUJyaUhhcVA4aEJTZ0R2Ti9oL2M3eG5nSUdtSGZBRnlBS2wwZmFm?= =?utf-8?B?MGh3T0dCUEl2UXRDZ1hGZlBLMHJZTERvZ0Q1cWVEYzZna01WWHlmTkZJckxH?= =?utf-8?B?bDNMTzRYU3BHOVhtYVk4b3JOU3NRTks3UyszV2VSYVpTbGZTT3FVS3lsaSsv?= =?utf-8?B?cHdPLzhXQmFCUThpNDhLSUZQTU5YOEs3Ym9jd3JrQWtOeDdCT2hacHFDTFdD?= =?utf-8?B?WVJOVDhhLzhFTHhCUHVrK25LcWM3NWxNejNaVW8wRVlrOXBWVXBvaERZZzRr?= =?utf-8?B?d3dFU2dKVC9tQm8yZ2tncTVnRGVwUjM0WWxkUmkvSkJuaXdlNVUwRTRnY3Av?= =?utf-8?B?ampKc2EyQmRvRXN2Qzg2RzlLb2dvUG1VWFBpVFVIVy9raWttdjJTSFh3Rjc3?= =?utf-8?B?eXE5eTZoR2gza3lUS05MVGx6Y3RYam45VEF2NmczU2J0ejF5ZGQ3RjVrWXVh?= =?utf-8?B?bkIzdlc5ZWpGamtEQXZPY3YrMStmUUF6Zkd0ay9UQzNlK1BJS1M5Um9QRFhV?= =?utf-8?B?TUxUcEZ4elVLeXZkSjAvNVBaZ2RNRUFKbVZwOExUSlNyVGd4ekZ4UGdWSTJF?= =?utf-8?B?MTk0Mm9YL2E1VUhWSlJKMTl1YXJiekZVaFZoSVpxMEJneDlnT0s4eFlPWnQx?= =?utf-8?B?bVdSM0lCVUVvd3ZmN2JvbWdIa2t2UTNQTmFQeEJSamVZbXBnQkJQWGtQWlRE?= =?utf-8?B?Z29TaDJWS0RreEk2dzlmTmxVMzVWSWVIVzZyMXlLMldFNzRVaVc5RWlHOHQ4?= =?utf-8?B?Sk9hSnpkbzBHV2Yvc2R1MURZNmNxOHlQY2RHVGdtK2VVc294NnpUNjlsMnhx?= =?utf-8?B?YUNDVVhXVGhlL0luQ3haMjExcEVqWFFRUmx3bGowSllVV1VabWJpQ1VCblZ2?= =?utf-8?B?Mmp5blArVkRMM3VYdWdJREZBTEJZVEpHb2dSYmpRYU1SOW5SbG16NG1IcDk1?= =?utf-8?B?cHZHa0djU3k4NDFXbm4yM2FBRXE5eUhkQmcwS1Z6cjU0WjRYcFpsT0k1Mjc4?= =?utf-8?B?SG5zUnBlM0dnSitFYmdpYnRQcnVZM3Q4U1ozQXhldERkSEFxWko4MkVyVDRk?= =?utf-8?B?MXFlZWN1VXdjN3RabCtRZzI4Z0oxbWpQeU56V0FYUjRwWTZ2SmlrdWhSTUYy?= =?utf-8?B?b2lGNWc2eXpFRXdTd0ZRS0pYcFlTQTFld3lJVzlZWTFOZUs0UC9peWRKODN0?= =?utf-8?B?WVdoRU5WUUdEazNhTkpvZ29KU1FXcUl1bkxIMEwveTRXQVZOdk5HYkFRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c88dad0-0770-4276-656a-08dc31391b5d X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 10:54:12.3781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0279 Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/bsf/hevc_mp4toannexb: Don't realloc when creating new extradata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > On 2/17/2024 11:44 PM, Andreas Rheinhardt wrote: >> AVCodecParameters.extradata is supposed to be allocated with >> av_malloc(); av_realloc() and its wrappers do not guarantee >> the proper alignment. Therefore parse the extradata twice: >> Once to check its validity and to determine the eventual size >> and a second time to actually write the new extradata. > > Why would av_malloc alignment be needed for extradata? > I see the doxy says "Must be allocated with av_malloc()" but I'm fairly > sure that was meant to be "Must be allocated with av_malloc() family of > functions", like its AVCodecContext counterpart. The idea is that > library users don't use normal malloc as extradata will be freed with > av_free(), and not because it will be accessed by SIMD code. > I thought that potential accesses by SIMD code was the point? After all, the value of AV_INPUT_BUFFER_PADDING_SIZE (which is used for both packet data and extradata) is chosen so big to accommodate reading via SIMD. You incremented the constant for this very purpose in 6e80079a28. (Granted, I don't think we have code where extradata is being parsed by SIMD.) Apart from that, given its differing alignment, I am not sure that av_realloc() is really part of the av_malloc() family of functions. We should probably replace "av_malloc() family" by "compatible with av_free()" wherever we want to allow av_realloc(), too. Anyway, there is another advantage of this patch: >> >> (Of course, not reallocating the buffer is beneficial in itself.) >> >> Signed-off-by: Andreas Rheinhardt _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".