From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D96F648938 for ; Thu, 21 Dec 2023 19:12:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C481468D0D4; Thu, 21 Dec 2023 21:12:54 +0200 (EET) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2099.outbound.protection.outlook.com [40.92.58.99]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2625368CCB4 for ; Thu, 21 Dec 2023 21:12:49 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXn2PmV1x36+Jj0Gt+AvyY5acLem0jPVMn3HTexWQDZy7lpzntQ9tVEQUQ2W8Mfcj3341JOSL1kpc52/5SMwMWAZgjQLUtvgnhPrcXUUL9vDTZFuMc4Xuh2QflMwmNrcs9zKs0HCT7WpiDl1pIbm2s+nJ+P1jYdzpKsWyJj7ML3DQgdIbKY+TDW1/EEXXHJR5VIjVLdd0NIKJ8a6mP0/fx0kQBVkRe1vOgAObQqA/N20gffOcR1LgZRGglgWiTlmG05hKJj7akOe7L+SW66d2fgZ6lnfW19HLJZCmcnwBGJeP1pwtGXeOvzMwwb5DfJlHuNt8LxUTjhPVKuWa2d4VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=No54UWnrkib0C2GSVQS/JsvPB7aoONwWCPS+E7ROrjg=; b=JtlU3Koa/0UFkGbZ9iAhT0JqwTdKUeXmk3L1zshK9++F/wXX6uW3KxPVTz5ZEpFVFb4KTcoBjCNcgxcZZrQV2kDkDLfUJ000YY0rXwZmfVb/jbQecqyLq99gV/GXUCPcBX/lS7+LX2YGFj+KdyKfL/GYwoP2KapoinBSgKv0KsByCzEqK+P7MDw4XXOkQE8DiVl3Gn0mdzKAfS7M8K0pdTmzHqASSX0AzGSJv9hRAVL0Xd2pgLRwhXhwQmymgM8hEU7AMvNV5hWGOAHC4TN5of+fCRoWHVRTlm/WlvS2lUSH2vChGk8PrqkRKGUgWKlwMD6I/iQngIuwhGfy8wiwfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=No54UWnrkib0C2GSVQS/JsvPB7aoONwWCPS+E7ROrjg=; b=X9bN+qjvDipyljBCsTw+SHc6FhyuxrRYS8YphmFSZ+U5y3vXV6Z+F4e7bDZnnBckYRKOrof0O+GIcbbh2oocg7pPT8vIQG16w99eFMRbe9iW/RvUWApJ2rjXGF/TKPh9cV+yRfObj782K0BHtLPZyp2Nt02HwfkW7aX3UFDzQXJPydXSFYZH+UYCl4hmv+ML2kY/2HirjNR7fu/e2rQg0i+itsgOfjBr9tWKt8uG8cE0tDIuXwznjUyHd7f9ArZJ6wnSWs8CONadImpBBtm8NflWvOQU6x4xZo026SmcbjgSxLArEXI8bkbq+Ett7MfiaPPVOglQwITZzeBHR76GBQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0316.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Thu, 21 Dec 2023 19:12:47 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde%3]) with mapi id 15.20.7113.016; Thu, 21 Dec 2023 19:12:47 +0000 Message-ID: Date: Thu, 21 Dec 2023 20:14:19 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231220084356.796186-1-fei.w.wang@intel.com> <0ec4a5a324fcb829eea33916dfc4b44e7a91b79b.camel@intel.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <0ec4a5a324fcb829eea33916dfc4b44e7a91b79b.camel@intel.com> X-TMN: [dd74oNo7RiNhytk552cAU7Ew3uH1HugsfuMv+NnjTyM=] X-ClientProxiedBy: ZR0P278CA0077.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::10) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <84570028-1176-4c7b-afad-db7aa5e62b43@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0316:EE_ X-MS-Office365-Filtering-Correlation-Id: 41fd3138-e1c2-4449-68f5-08dc0258d0fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FyIbgJ+qZYFPK8OtltfASYha0dW0stLrpXxC5U42re461pGk2vaosEF2DDt72/O4fJxeHH+N0HMX1I9kBgU4Rk3UeNHKKxKgkcNv3qcqC4GXxRQHlSSyaJ0PFFcnuYGVtVQ/KBp1udhWhB1T9/6y5QskD9IWCgk/N+XvTemCEES75tx3iebD/sfP77OdWpj9UqYCGO1ksb/1OaYsjwWlLeDhP0J9PMwDINMlDrU68yHvS7Oy0zitCI19XL2YBjFbohjJqm/NYrXgYR7G919Zde+y0hXQF2E1pN9QVL2clD4AI4EoArZH8Ddk5ynmhrs9G2q7ciJclzLzC+qfyAY+zbDHkICQejkhqvTHnHwOpelnTfIGg4M5/RG9uYo6uSLXxNFVXvJm/ZiNxQGazkkiyBamqO7Edl5xZba2A2BwDhVyVb6JaCUHdrwA4yPG5Z1TNOnGsqlHzwPN2li3TlEngKmI7WEf7Md4ecXZDEeT9QplCj9qp/+wqGOLC3Tg774D6KmzUp6KlTUNY1EuwhagajB3d0EZhgVKcffIx55OOO9uLbIDdg22dfWAUTQ2RGillvrzTWRiR5NnPtZBI9EeqeQKrqUPuseZubJ174UYSag= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cm8zY2lZOUhQOHZpV1BQUENTK3pRUFhJL0lxOVMxYUR4c0MyQzFwbXR1dWhr?= =?utf-8?B?MlRTV25scEt1aGsxTDEvSU1IalRWTEFMWFIxMW1TeXQ0YmRJY294b3ZRbDhW?= =?utf-8?B?NmgzVUxhYjZKcXVrYjVBVjVnZk1YRld0d1hkS0oxaFRwb1ZkYVZUMWljb0Iv?= =?utf-8?B?S0JDU1lPYTE5YzdEZDd6SEl0Y1lFZDBNeW1uUGJGeGFVcEZDYzh1OGlkbmJ0?= =?utf-8?B?dUU5T09zZHBJSjU2SndZWnpRT0owb3BYMldyWi9Uc3dvNmR1TGN5YW5DWUw5?= =?utf-8?B?UFRaU09wZjBFaWRYQWlVQzdKZzRNQUJtdlhGYXlrakxSampCTHRtdzBkWHhp?= =?utf-8?B?RlRERGFPalhzTnRUQ0tXaVR6aEdWcllRNXpmVUwyalNhOGVaU3FEZHZ2WTRB?= =?utf-8?B?ejRZd3F0V3NhUjNRZ0tBclBlWnc5Q3dqdmJSSS9KUGZ1UkVMMUt3YnlROFpH?= =?utf-8?B?Yk9JUk1DbGVjV3FuTEtGVTNFeHhlV1lvRkJ2V0ZEUjVMMjJJaXYrK1IybzUw?= =?utf-8?B?UkozNzBnNUdETGxaZ1FuRUZTZHh2M3JvdGY5MlE5ZGhVMnJrcGg4ZE1mQmRO?= =?utf-8?B?Z241cHdlUGZhYUlQNm9JOHZpSTdpWlViaHhMMVlsY0lkUG10bklqZWYxQVNU?= =?utf-8?B?WlcvUURWZ0JvQkNRdTVTZlRPcmI1V2VsNzVFaSt3eEJ2TzRCT3hDelNTSDIy?= =?utf-8?B?anBONlU5bUdLLzRRSS9tYTcycXR5NjFhSW1Ka3FmNHAyQjFnL1NQMUhiWEp2?= =?utf-8?B?MmVNcnI3SFQrTkRWU0RWcWw3SVRUSEhkeUZjU1M2c2xNWjNaNHNhTFJIT2RE?= =?utf-8?B?dmhHZzBIck1qMTJBbnUwZnJmY21SREJPQnREam5ZL1BqL2ZNWUhyM0ZaekJi?= =?utf-8?B?VWk3dDdJZVY1WHVKdUZBT2l0K1c0WE1qMEFWSGFBZ0JWQU5rYlFjOVljR2dO?= =?utf-8?B?WEQ3RDQ5djN4bVk3TXpUaGU0RU1DTU96S29GOUk2Q1UrcHdwTjhiRGYwOXdP?= =?utf-8?B?K1NXazF1KzUrYUFlY2F3bVNHZDhjS0sweUM4elV2NHMzYkFGUUlaZHJycnlF?= =?utf-8?B?dnZ3YlhEQjFwSlhmL1NHaktYdEZOQ2FSeGhGN2JjemVqcm5OZ2dWTEFEdENK?= =?utf-8?B?TC9tckRjZXU1WnlWOGhMRk1xV2RKOUpDTlNBb3FTVm1oQzhoTk1NNC8xSjJO?= =?utf-8?B?L0FaTlREaVdhalFUdXJWTVZtcUQvaHlnMi9WcVBKMDFnUll1ZXVMdGU4UXJt?= =?utf-8?B?UTVWK2prTEdVTGF2ZVlEVGtnNDZsdnE5S3pWd3VKU0xSTTNkUDFQOXNCQmV6?= =?utf-8?B?VkFJZlN3RzRWU1V4TnFTbFhONjRycGZrQ0VvWFYwNTZ4OUhqZ3NuRC9PS2ll?= =?utf-8?B?eVdaN2hESUtMMW9FNU1DVGp0b3BRMVF6UDkzcnFoNTdJMUV1dUd6Y29UZGRt?= =?utf-8?B?bWdxUEZGQ0lEbFYrdWpOYjJsKzA5VDB6bXhnb3NVSldCV1pNOHNjd0tnTjd2?= =?utf-8?B?MS9kajhHVTNJS0lXRGM5WUJDSkZxRTFMNjlJenh0aWFzSDQwZktBRktaeG5z?= =?utf-8?B?SUNhYi9DejdJT0FzVVp2ZHdmVUt6SlFyVUh1K0FuRFhuUTZXbVJ6RlZ1cTdU?= =?utf-8?B?aStaUGU0MHZ4TjdiT0huMGQzRW0yckV5S2xxdlo5amEzUy81Y2dLTUpHNS9H?= =?utf-8?Q?xFWGQBf1+TZlJxfT9wXK?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41fd3138-e1c2-4449-68f5-08dc0258d0fb X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 19:12:46.9649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0316 Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Wang, Fei W: > On Wed, 2023-12-20 at 17:11 +0100, Andreas Rheinhardt wrote: >> fei.w.wang-at-intel.com@ffmpeg.org: >>> From: Fei Wang >>> >>> Show the unsupported message and return unsupported for clips >>> contain >>> tile list OBU since it hasn't been implemented. Otherwise, decoding >>> maybe successful but result is incorrect. >>> >>> Signed-off-by: Fei Wang >>> --- >>> libavcodec/av1dec.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c >>> index 4dcde234c6..629e37c3f8 100644 >>> --- a/libavcodec/av1dec.c >>> +++ b/libavcodec/av1dec.c >>> @@ -805,6 +805,7 @@ static const CodedBitstreamUnitType >>> decompose_unit_types[] = { >>> AV1_OBU_SEQUENCE_HEADER, >>> AV1_OBU_TEMPORAL_DELIMITER, >>> AV1_OBU_TILE_GROUP, >>> + AV1_OBU_TILE_LIST, >> >> What do you need this for? Decomposing it would only change whether >> CodedBitstreamUnit.content is available, but you are only reading >> CodedBitstreamUnit.type. > > To show the unsupported error and let user know that there are tile > list OBUs in bitstream that decoder can't handle them. Otherwise, like > my commit mentioned, tile list obu bitsteam may be decoded 'successful' > according to log. > As I said: You do not need CodedBitstreamUnit.content for the error message. >> >>> }; >>> >>> static av_cold int av1_decode_init(AVCodecContext *avctx) >>> @@ -1327,6 +1328,10 @@ static int >>> av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame) >>> } >>> break; >>> case AV1_OBU_TILE_LIST: >>> + av_log(avctx, AV_LOG_ERROR, "Large scale tile decoding >>> is unsupported.\n"); >>> + ret = AVERROR_PATCHWELCOME; >>> + goto end; >>> + break; >>> case AV1_OBU_TEMPORAL_DELIMITER: >>> case AV1_OBU_PADDING: >>> break; >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".