From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3FB6948797 for ; Sun, 17 Mar 2024 16:55:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 169A668D155; Sun, 17 Mar 2024 18:55:39 +0200 (EET) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02olkn2058.outbound.protection.outlook.com [40.92.50.58]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 69DD468CD43 for ; Sun, 17 Mar 2024 18:55:32 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SmHAbiqYV2h9MXJnrdMkAkvOr14mNzLZ5o9U38KqNFSe2a0RTrc+ufhfUEYokZMYkmlmionGGHiGmjFn6xY2V26GQuXAz7xuO77y8wCD+1fdKkz6Pc225sp0Jyx8TfjJHl+9bfgpNv1kEX/ZP9M8/Mzb3IFW3BeeWVXu2o9NIUR8iyBzdQP5iE22+nBkLTJBc09Ia0Xd6Sd0JoGnlITb2KkqYSP0NWi1unbRdfELSddQ3WOwLJXyt8D4W4Gzhn+DNUgriyTcton76G0zvsdZjPoZTzSXSAr16sHLu5Kibt9oFlLJkp4S+kvGpCxDvBBWfUufH4o/vvrT1SXN/aacPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gklcZehwdhWsBPgbvufpC4BIFk5bi+UUGW/G0qUmctY=; b=nUp8oC+8t4pCJK+rZMsRoMJ2eCIS2sY2DP7YqLzLj0X46SmeKnKRz/4Et9eCuIoMJ5td4XZtRpwZAQcEzNWROqPdIpMUe8AB+LCDdlgQmDkhWOTRwONxOMkC8JmeyyJgKj2BrPJARUubjnBg0vHfCOFumIIVtmLg7fvMolRpdtxoiGIvbWCBHop+3C39Yt5O9QnGMJpmo4B6WjP+aLJ+Hx8eKeRMiLziZLfgt27/J9/SugsEWd5nKFgFhHkKCreROn2UiYu8wh5EsN4flPrrtOWGqgBzPuR2u6o1OVwPNJCVWuGvjDz3ltOs16/njmg/INEwZRdtz9EhB14u9FYWdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gklcZehwdhWsBPgbvufpC4BIFk5bi+UUGW/G0qUmctY=; b=c1o2cOU3oGRz9D3RHN6K52S6+PuAB9McahKAf4URf0mzHy3K6K3kBplXOp/1yhrr5NfPSGrEAyY7HaPXE/LOvo68zrGrcZlUlsDEvEUljh4s3271ZubaCD85hTuKra5AOeO2/VbaKM3Y1KFeJ3KiVD/fdAO2bH2RSQoxSyFreCM5Mh10DpWAcB53rjMUKk53TAsro9iC6AIYTB+ltQbVzsPwvgWf/GM68qcpykL0nQDdPYd494y8w3VsqdIih2Zt/Uq/2L8XzEEck0L7FF0oeGw9J63p0ghZ2igw7FdpQlO8b1/akc4dfv/HHOXnD+Hp60OGH7MYrHln4nkKZvxX+A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS1P250MB0605.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4af::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.25; Sun, 17 Mar 2024 16:55:30 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb%7]) with mapi id 15.20.7362.035; Sun, 17 Mar 2024 16:55:31 +0000 Message-ID: Date: Sun, 17 Mar 2024 17:55:28 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240313122425.92457-1-ffmpeg@haasn.xyz> <20240313122425.92457-2-ffmpeg@haasn.xyz> <20240315111854.GB21517@haasn.xyz> From: Andreas Rheinhardt In-Reply-To: <20240315111854.GB21517@haasn.xyz> X-TMN: [dd5hwkVoUnna4jMcUxeOY/mq5qZ3A4MSu66Ft1WawoA=] X-ClientProxiedBy: ZR0P278CA0059.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::10) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <1aeaca96-de7a-4f8d-bebf-9fc02ffeacea@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS1P250MB0605:EE_ X-MS-Office365-Filtering-Correlation-Id: 979ba254-dc39-4e9c-ead8-08dc46a30e0a X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnqOm5fONWoLHaAhhnlxrZ9+4ccEl3ABksNQ627XGZlynNoxI47fUlz0yuYFjaMvkOZXN/7R5VDsRn0ctta9r0WKc6GBR3NUci1dTb+xoVdC/BTA2MK2LXYCzChz6B8TBUQs9X09n7DIgFqklazP9LYk00w8kd8qOHv8OF0VzCwYbZf5hTWcG98LM1pbDRn875AhZ8Z/bDwzhEHnroMIU4FNgZ5/QrxTP11Bueb7zpqxqLV5oqWfpOkakXZgoGhAQGmkPBNtiWilotCST+Wi/VM/AZ+0LfLyIhMYQ/MW4i4g8vhJVTg7G1GCWj+3dQZuwD1PIqZa+6vif7c90kV3f6L4Gey19lquY/LGa4udGMqAgbAsymW/pSvvlPLIHrIizWherQnQpVW5P4YqGqUmmwJKShJ4ZWlo14qD35zbekvIKNjLw7Uxw4vJ/rZxaQvZvvJkUZl6Z+0070RRu4FhLqBrA4X/8HX7j0j4b6uIijfmR4Rp4zwgoU0hXRDK8qSbZXsKleatHviznjvzeVnLbSO98cpZX1UFuQ/pbpz6FckpJ3J1x4C/4BgHDe9674tMHO5kxf5gqSzGsOGrdNb8+Fr0vXTrUzXFpqXm1+lSdcmi7bHndVZkcrGJOajuA8P5wnuxDADGxQRblL69yoGy5yxHtp4HzKVi0AtRMrK8delFkdrRsfDJ9pY4niAXKzh0NUy4bGeLBLEIb4nEAf9WN/M3AZjK1z51GmX3jmc7FynlDmVRQQmLf/5BaKHpwI6rM2o= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8QSr+QGpykv7Bv2mcj21W9r4UNEHW2mnaRGfLfvPXLrBHMmjs/3Em3Tw1KhHd7j4arb5VfAZtstjlu6JwOAbhW+jK6L0zY3UyCahWXSRAlumWSGGqJ8rEMQaSUNdnN7OP21XTH17hyN+jUdKzGAVpRzozOFXCNu4qy3yklWNXZ4HgXrkwczdswxsGeETQb4SVqZjOz93KsSQ2lmqjurgJW7BXq60Q1mVM2RlOGD/r6ZXeja2Q3fjp0jz1nshgpc86buX7Z1IkIA/3R8JzfsZeDJwkLfTA7do4YpFvx3HML5tT4S2TXHqBI7ZLkhsu+itPx98O4mOXFZ/Jqhj93nX051uZHoGEObVrKl4rPfFmRyVaz6fyCEIgV6g/bC8ZY0Mu0Dwq0cA241WC4nYj70gamyN2h5JMyhNywNRHnYGR34wjogFgA108AAINIZQr/6RJ+i9ea1MDT9l0M8vu8z32CobOsIvVCEx/curmQsc7JTI/QebUeN4Etu4iVxIobiiLbMMObgYvK9sBQeaqM06e47bpRJNvWV9O8TPJ9ltNmpysfEIgwcrDy4fB5PZxjhp X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHR0NWpnYTExaWZjS3dHOG96bDZ6ZXgyWkk0T1QzQjFVS3JzNC9PcEVvYU1E?= =?utf-8?B?N1VJb2JPOUJWd0dVZWpBNVpFWmNmdU9ndjF0MVE4UWZaQWNQSWYrSHdYRVRO?= =?utf-8?B?NDlSUlRTaFNyMEMxQ2dUaTNoK1NMcUxPWGZ1enlSU1Y1UWlXMjhVYjAzeEdL?= =?utf-8?B?azhWeExTUnoxaVFqV0dSTWNxaEIwUmt5cVRzbzlodFpQNlFVOXNMa083RDhO?= =?utf-8?B?ZWFPV0RhcjdKNUtyRU9RYmhGaHhTeSt1L25McngwY2lycTRTemJBMXlwRWtL?= =?utf-8?B?cC9IdzE4UlVoaUlsbmpqdml0eHF0dnltZ2RvUHNqY1pUTkVHMFlEY2xKSENE?= =?utf-8?B?MHpxNDM5MzNJV3o2V0Vaa05QamJNQUYyZHJnUHVmbHBDbGliUWFyY3Z4MWtN?= =?utf-8?B?RllYL0F3SDhRMmhJS0lGRXhuQTUwSTFPR3NRUkh5Mi9Rc3dYQXB5cG9BVXNE?= =?utf-8?B?Wjl5K0ZwZWtEd2RaU0VWSjZmSFhrS0c0ZGRaV2hNNXVCQXRheG90ajFJTG9Q?= =?utf-8?B?aXlhU0VIemQ5dHFLNkpVM0w0RVQyTFNLRnc4RTJXUGx6VWsxa005NkxQN3hv?= =?utf-8?B?d1RmSkVucmhVaGh0MkYwSkRxVFpDWjBnOFdwYUNmTUo0NzlEenFNd2dJUWtI?= =?utf-8?B?SFMvZ2pkb0ZETlI1QUtlUFUwWEsvODR3SnAzZGtPcm1uYk0zVkxqTkhQT2I5?= =?utf-8?B?QTYzUWovOTVZRTV2VmNyNzdja0trcU01TitwVTRWd2NmUjMwZEVUMkM1UkVV?= =?utf-8?B?cGZuL1ZFR3hURG9jckJnbmpXa3Z6UlJtb3gwa0lhUWluRlNWZ3ozZ0NpRGdj?= =?utf-8?B?WUZIZksvb1psRU4vZnEwWmZMeDJ5b1VWeVBQVVh6Z1Y4VzdzU3UzekdEMlZE?= =?utf-8?B?L1BzNjRvQ1BOa05KL1gvdmxVbWpNODBTS3hkcVpJbjVWS0QvNnpWbnNpbVNt?= =?utf-8?B?NExkL25kZExGS2xsMlgwSFZ4Q2Z2ZW1Hb05tUm94TTdYb28yTSt0R3RsMFhJ?= =?utf-8?B?K1ZYSjUxMllJSXVIRWNGMUgvZ1NwMTc3eUdwenZ4cTFJS2FBMFBwQ3VGMWEr?= =?utf-8?B?NVNJeHRmaEh1NE9NSGE1K1dGRXk0aDVZQjM1MnUwMUFLNE00dnZPKzR0ZkFs?= =?utf-8?B?NnNjSWJmVU00aWRuZFNQVmVYSitKQVBXQko5TnVIdWc0MWdkNTJ5NnI1R2Y1?= =?utf-8?B?TXRlWWtnNmJJTC9YckQra2VtTnpkcmJ2S3EyaDhTTlNPZ1lONklXVFRRN2lD?= =?utf-8?B?aXdNR0F6cGNiVG54NkRGQjUyOEJBNktTWmNvNGVldVo3ay93L0xicWxqWFNH?= =?utf-8?B?SHEwZnN2eCs4anBHUUhVRDY2Sk9MQnBNZ29ONnl6QUM4T1ZVTjBvSGtVZlF4?= =?utf-8?B?M3h0L2VSTFFGZlZDTldSNDBDNTdndEYwRXhaR0Fod1lURmJvUUE3QW5TNUJz?= =?utf-8?B?TUtMd1c1YkF0WFV3U1JYN1d6OWRrREIwSndSOTJEakRRRHBUTG1YZjVMK25Z?= =?utf-8?B?MUJoTE90NmZGT01RSWpHMndyczl4UXNzZlBSbDIzQTJGNjV2QW9WUUdwTHhJ?= =?utf-8?B?TENVNS91M1RuSjNYUU43b1gzd1VtNTZUaXhyNDNncllJV1VvaGl5UHJORzJS?= =?utf-8?B?cjdEbTk4a2IwY1VSUXYvK1VOUGMxampCem1qcExRQklZQStiUEJiaGw2L3Nq?= =?utf-8?B?a21UWVFzZ1RNVjVCSmNCOUJsYkFURmEwdDZhNUkyV0tBa29OWCtMU2p3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 979ba254-dc39-4e9c-ead8-08dc46a30e0a X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2024 16:55:31.0764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P250MB0605 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_scale2ref: switch to FFFrameSync X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Niklas Haas: >> This should be &tmp. It is probably the reason for Michael's segfault. >> Apart from that: It is easier if you simply used 0..2 for *iter (1== >> returned sws_get_class, 2 returned ff_framesync_child_class_iterate). > > Changed this function to: > > static const AVClass *child_class_iterate(void **iter) > { > void *tmp = NULL; > switch ((uintptr_t)*iter) { > case 0: > *iter = (void*)(uintptr_t)1; > return sws_get_class(); > case 1: > *iter = (void*)(uintptr_t)2; > return ff_framesync_child_class_iterate(&tmp); > } > > return NULL; > } Better make framesync_class un-static and return that directly. Also: It makes no sense for vf_scale's child_class_iterate and child_next to return framesync-objects (even a framesync context whose AVClass* has not been set!); but this is what your patch does. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".