Re: [FFmpeg-devel] [PATCH] bsf: use standard include paths

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Andrew Kelley:
> Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
> 
> This makes code copy-pastable to other parts of the ffmpeg codebase, as
> well as simplifying the build script.

If you want to make the code copy-pastable to other parts, you need to
disallow using the ordinary relative-path header inclusion. And I don't
see a simplification of the Makefile.

> 
> It also reduces ambiguity, since there are many instances of same-named
> header files existing in both libavformat/ and libavcodec/
> subdirectories.

What ambiguity? As said above, said ambiguity emanates from using
inclusions with relative paths (and from using the same header
filenames) and not adding an -I for the parent folder for the files in a
subfolder. (It would be different if we did something nuts like adding
-Ilibavcodec to the compilation of libavformat files).

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".