From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/6] avutil/error: Add HTTP 429 Too Many Requests AVERROR code
Date: Mon, 15 Apr 2024 18:31:23 +0200
Message-ID: <AS8P250MB07449428D1EBC3D348B6E6C88F092@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240415162741.110374-2-derek.buitenhuis@gmail.com>
Derek Buitenhuis:
> This is a common error code from e.g. CDNs or cloud storage, and
> it is useful to be able to handle it differently to a generic
> 4XX code.
>
> Its source is RFC6585.
>
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
> libavutil/error.h | 1 +
> libavutil/version.h | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavutil/error.h b/libavutil/error.h
> index 0d3269aa6d..1efa86c4c1 100644
> --- a/libavutil/error.h
> +++ b/libavutil/error.h
> @@ -79,6 +79,7 @@
> #define AVERROR_HTTP_UNAUTHORIZED FFERRTAG(0xF8,'4','0','1')
> #define AVERROR_HTTP_FORBIDDEN FFERRTAG(0xF8,'4','0','3')
> #define AVERROR_HTTP_NOT_FOUND FFERRTAG(0xF8,'4','0','4')
> +#define AVERROR_HTTP_TOO_MANY_REQUESTS FFERRTAG(0xF8,'4','2','9')
> #define AVERROR_HTTP_OTHER_4XX FFERRTAG(0xF8,'4','X','X')
> #define AVERROR_HTTP_SERVER_ERROR FFERRTAG(0xF8,'5','X','X')
>
> diff --git a/libavutil/version.h b/libavutil/version.h
> index 1f2bddc022..5de2d92146 100644
> --- a/libavutil/version.h
> +++ b/libavutil/version.h
> @@ -80,7 +80,7 @@
>
> #define LIBAVUTIL_VERSION_MAJOR 59
> #define LIBAVUTIL_VERSION_MINOR 15
> -#define LIBAVUTIL_VERSION_MICRO 100
> +#define LIBAVUTIL_VERSION_MICRO 101
>
> #define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
> LIBAVUTIL_VERSION_MINOR, \
Wouldn't you need to add a new entry to error_entries in error.c for this?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-15 16:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 16:27 [FFmpeg-devel] [PATCH 0/6] HTTP rate limiting and retry improvements Derek Buitenhuis
2024-04-15 16:27 ` [FFmpeg-devel] [PATCH 1/6] avutil/error: Add HTTP 429 Too Many Requests AVERROR code Derek Buitenhuis
2024-04-15 16:31 ` Andreas Rheinhardt [this message]
2024-04-15 16:43 ` Derek Buitenhuis
2024-04-15 16:27 ` [FFmpeg-devel] [PATCH 2/6] avformat/http: Use AVERROR_HTTP_TOO_MANY_REQUESTS Derek Buitenhuis
2024-04-15 16:27 ` [FFmpeg-devel] [PATCH 3/6] avformat/http: Don't bail on parsing headers on "bad" HTTP codes Derek Buitenhuis
2024-04-15 16:27 ` [FFmpeg-devel] [PATCH 4/6] avformat/http: Add support for Retry-After header Derek Buitenhuis
2024-04-15 16:35 ` James Almer
2024-04-15 16:49 ` Derek Buitenhuis
2024-04-15 16:27 ` [FFmpeg-devel] [PATCH 5/6] avformat/http: Rename attempts to auth_attempts Derek Buitenhuis
2024-04-15 16:27 ` [FFmpeg-devel] [PATCH 6/6] avformat/http: Add options to set the max number of connection retries Derek Buitenhuis
2024-04-15 16:43 ` [FFmpeg-devel] [PATCH 1/6] avutil/error: Add HTTP 429 Too Many Requests AVERROR code Derek Buitenhuis
2024-04-15 16:44 ` Derek Buitenhuis
2024-04-15 16:49 ` [FFmpeg-devel] [PATCH 4/6 v2] avformat/http: Add support for Retry-After header Derek Buitenhuis
2024-04-15 17:33 ` Stefano Sabatini
2024-04-16 13:59 ` Derek Buitenhuis
2024-04-16 13:55 ` [FFmpeg-devel] [PATCH 7/6] doc/protocols: Re-order HTTP options to match http.c order Derek Buitenhuis
2024-04-16 13:55 ` [FFmpeg-devel] [PATCH 8/6] doc/protocols: Fill in missing HTTP options Derek Buitenhuis
2024-04-16 17:13 ` Stefano Sabatini
2024-04-22 14:26 ` Derek Buitenhuis
2024-04-22 14:58 ` Stefano Sabatini
2024-04-16 17:08 ` [FFmpeg-devel] [PATCH 7/6] doc/protocols: Re-order HTTP options to match http.c order Stefano Sabatini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07449428D1EBC3D348B6E6C88F092@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git