From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/fpel: Remove remnants of MMX
Date: Sat, 2 Mar 2024 02:54:50 +0100
Message-ID: <AS8P250MB074492EC8A3828FB57459AF68F5D2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB0744EA68BE97D60800D4145D8F5F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Andreas Rheinhardt:
> Since 7cad4dba505f9ad0adf013dd5bdf02a57249eecc
> averaging functions only exist for MMXEXT and SSE2.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/x86/fpel.asm | 23 -----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/libavcodec/x86/fpel.asm b/libavcodec/x86/fpel.asm
> index 278d1410fc..b07b789074 100644
> --- a/libavcodec/x86/fpel.asm
> +++ b/libavcodec/x86/fpel.asm
> @@ -25,16 +25,6 @@
>
> SECTION .text
>
> -%macro PAVGB_MMX 4
> - LOAD %3, %1
> - por %3, %2
> - pxor %2, %1
> - pand %2, %4
> - psrlq %2, 1
> - psubb %3, %2
> - SWAP %2, %3
> -%endmacro
> -
> ; void ff_put/avg_pixels(uint8_t *block, const uint8_t *pixels,
> ; ptrdiff_t line_size, int h)
> %macro OP_PIXELS 2
> @@ -49,12 +39,6 @@ SECTION .text
> %endif
> cglobal %1_pixels%2, 4,5,4
> lea r4, [r2*3]
> -%ifidn %1, avg
> -%if notcpuflag(mmxext)
> - pcmpeqd m6, m6
> - paddb m6, m6
> -%endif
> -%endif
> .loop:
> %assign %%i 0
> %rep LEN/mmsize
> @@ -63,17 +47,10 @@ cglobal %1_pixels%2, 4,5,4
> LOAD m2, [r1+r2*2 + %%i]
> LOAD m3, [r1+r4 + %%i]
> %ifidn %1, avg
> -%if notcpuflag(mmxext)
> - PAVGB_MMX [r0 + %%i], m0, m4, m6
> - PAVGB_MMX [r0+r2 + %%i], m1, m5, m6
> - PAVGB_MMX [r0+r2*2 + %%i], m2, m4, m6
> - PAVGB_MMX [r0+r4 + %%i], m3, m5, m6
> -%else
> pavgb m0, [r0 + %%i]
> pavgb m1, [r0+r2 + %%i]
> pavgb m2, [r0+r2*2 + %%i]
> pavgb m3, [r0+r4 + %%i]
> -%endif
> %endif
> SAVE [r0 + %%i], m0
> SAVE [r0+r2 + %%i], m1
Will apply this patch tomorrow unless there are objections.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-02 1:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 1:22 Andreas Rheinhardt
2024-03-02 1:54 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB074492EC8A3828FB57459AF68F5D2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git