From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AA9A54422B for ; Fri, 2 Sep 2022 19:05:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9C2AD68B99B; Fri, 2 Sep 2022 22:04:58 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064082.outbound.protection.outlook.com [40.92.64.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 35B8268B7F8 for ; Fri, 2 Sep 2022 22:04:52 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S9ZNrLGjpnafSgDaUidhPJasM3iZN4J2RFEu8oUI0Bf2Ree0NkrKlFmy9Cinh17Gsnli9xQ5jlJEszYVGkmyljb1xjJISLoXk9yX5lBe0fggRopGRLrKxxmdRyJk19m47Dfcnfgnmi/UonWCJZwRpf0n1CU8JV4Sg9LGXcOeuBVjScjPqVVCIt7A952EZ+cBK3rIi+RI12IMm5CCpFelCAkkoJu3gpy2gjuyEyRySV6Ro+d60nUnVm9pbvu1J0DkesSIs/9asbG6aYQhJGTYsJl++i+KzsoR6wja0oXorNLLSKc8APyokpL8HN1PpXJCJcLRISRDOyLU75uheaGmgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2RJ4fE00+qBofXeRfvGZLSYtL0qMFE1C+ec/O7WF5GU=; b=KO1qGM4/611GpKXBrzuBdpJSHkijgb7IdRWBHPF7Ti5jpxppcO3PdYy2tK0yBGdXGqboExpAY2ZxsJ9hdAKDpvcCxvv/OTh1Q7prjIoxlUGd8lviKPN77NCxlW7pk4FBCiO1hxVrNI7GJnhHNs4yStzfp0CGTFdoai55iXWr1f+4WRBsmFujRlCGlntxZt8RUxfNAInQvbdZEdaYChHQ5mU25o2wi0jmbT5rDkizmoBM3CTKbMGhc41Rl4/2qMM1WfaDuDIayJ3n70Dp2R7EcQtY/nzz6gbJDt6IKzTcfW+zce0PwR8Y7knHetXCZ4ivLVJXmOpJYt0gGp6Ws6Tovw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2RJ4fE00+qBofXeRfvGZLSYtL0qMFE1C+ec/O7WF5GU=; b=Ta9Mo9F+6ddpzcoy6IKkAGyFWlSBXxVAABnb9SzgjKx36dJ7tsbTSJGzZZCumB1GI6uamB0/HupMUSAYwyLoOqoYaVWwy1JHBm5yu6jrT+DRP695Pk27Sz+7KWKvsU7YP9F3Ji4F68sPO1+lvA833RbFgw1YBaVmf5awgsG/IUwOPbFvqiq+rdo/6TD8hc9f8RnNHeLoIQBVGRjhlQFLCDvMLl0QKmd5hP9IYvEP01upuEXhyg7iMbYyBaxMucFbbuSmoD7cmCr5XaANin/RxipcOz1daZqqLd+qiqiFlZBDNvqG7QwKFYqc+7sodlzm/aXclUJWHblC2p4pl1KF9w== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0154.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:375::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Fri, 2 Sep 2022 19:04:50 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47%2]) with mapi id 15.20.5588.010; Fri, 2 Sep 2022 19:04:50 +0000 Message-ID: Date: Fri, 2 Sep 2022 21:04:51 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220902142028.261480-1-mvanb1@gmail.com> <20220902142028.261480-3-mvanb1@gmail.com> From: Andreas Rheinhardt In-Reply-To: X-TMN: [ozlq30LYqSU05dTmSjM5RRYIe4woZYI8] X-ClientProxiedBy: ZRAP278CA0004.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <2160e2dd-9151-900b-eaff-17c0d224467c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6351f395-37a7-42e0-2922-08da8d1602e1 X-MS-TrafficTypeDiagnostic: AS8P250MB0154:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PBwf0swbbj5i9rFZjBp3QSV6uU5h1hxPwtqlGMuk0rDK/DJea22Z+A+ySTW9SXba/pLagKrpD2DDckOcAKlHRqhoihpHc/G8h0DLiNruZN6P2LwevwH/zbv44MvwRxjVs0Q6xOEVkJH/ReJiEkn0koOfOr0uCj9NAQILBcA490oMGJNdWCQ3rlgfrBz4s1v7dLicdafUSOi88qWQk0tz052lV4ronPV/fJu3BEr7MeVIOP6mpzeQN4zAZGlQY8Hqfti9SdC1eyxR87vDeJt5gio1DmWrRDazgzN126nY6gIS7H/iY3hMr1DuOlnSkpuYVWuZdTIG0f0dnWVScyhwo94TSWFUp16KrGzyb1Ixa05d3wmwdco7oqmdDjXIAXcSDKSWKKnysoJdMDp2W4Mh9kKcJCVTA/M9l0bK6FkAtPVpisvjRnGN9j+g6+0ShYyPqcwxsRPOtMlh15wPxzRcHoJtJMbNOUwJKJW9ugB9uM0u527peuIguKDlfPRpSpW6mBnfNiCjLYvCFZGOZlDx12RC7m7cq/lhf4a76N5vGQfx7amSo665fdBjTZhFWghKF3Fm6s3wW1b5dx3gM1dUcQLIBK0SzBGlsRRK7nZqhF9qG/tqJPqNTFcHF6An1ZDixL/tTwTqcmSCPV11XPZK9RD/9feiIuC9kwhUneS46PbeUKj5/g0FvyLJNEzwiSBy X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFZnd0VtaUdFSXFDQ3BOdFVmSnRDOWpNVGYycGhzdFNSRTlMZUJBbENUZGw2?= =?utf-8?B?UEZXKzlVS2F2dzJvN242Q2UrNktFUVM4clRHZFhwY3JaZ0xBQlZzMnIwUVN2?= =?utf-8?B?V25hd3E0djRMK1hReFJhNVUrcUluSHdhaEYrVFR5bkRjVkk4N1g1Y291UkFq?= =?utf-8?B?VlBVQzZqMHRNcm9aYjlJUEJRMS9wVFNHN2daaDltZEI5RSthcm5aN1laMWlE?= =?utf-8?B?ZUNuSXB1UG9ob2NhbllwdGFQdFlWU3U3OThLeGw0L1NRd0dWSDRQZzE4S1Vs?= =?utf-8?B?VUxJenpQU2RINEJxQjRHYXRKeG1kdS9WenlKQ0JIS1ozUWlCWWpwYVBpd1R2?= =?utf-8?B?eGhkTkdCQ0hQNkphclZuc1NzZjl6MHRTeGxPK3l4ZzlKUGQ4YjdPT1JSOG5H?= =?utf-8?B?RXhJbHdLUGtDcW1JaDV5aHE1TXB5YUpkKzZFSXdyZGMraUtmeUlHZHdMVk1q?= =?utf-8?B?U3ZCS3FNUTVpNUdNcWMzNHY3Tmx5ZjJMSGYwN2pIdnN0TzNGZVI4Z2tHQjlt?= =?utf-8?B?Qjl4Zzg1K0hRb2xEbW03ZU5kVFhwUmFyVVo1bEgySE1qQlRJaW9ZNFZTcEVH?= =?utf-8?B?N2oxdFIvZWRaT2Fyd1orK3pqd2UwNUJkVnF3cDdrYy9qWk5iT0h2SWptKzVq?= =?utf-8?B?cXZSY1FlL1ZSSmVtUGs4ekZHd2ljNithM0VLQ1IzYWJqZGJJRFZ2TUkxWi9l?= =?utf-8?B?eTNBVjRDV1hwSTg5UEl3SjJtNHU0VmY4OEN0dUlYM2NmcXBXRFRzWGF1R094?= =?utf-8?B?YVJSbFBWR3QxNjE0R0pUTVRYRFI2QVc1OHNiakxTbGJzTjZBZFhhMXFPaXpH?= =?utf-8?B?Y2d2SStVeEQ4UE5mN1JhYVl5aVNvN0R2WlRWODdUVGNreWJTZ2pTQWlpSStt?= =?utf-8?B?aWFwTXc2YThQTVlWaWpXQWV5eUZRRmlFb2FINFZ2alhSRk1qOUxxOUE4Ykg5?= =?utf-8?B?Y1kyMUk1V0hGUUtCMUxFOWMxZEl3WVczN2l0b3dCRmI1akJSOTBlWEVlWWJK?= =?utf-8?B?bzQrcnZzUXpTSWJ0Y0RCeE5sQzNzV1RvQmNOaVA5NjlkaGVLSzIxQ3FpOW42?= =?utf-8?B?VlZwRVpWU1VZTlIwU3JNeWlSaWZZdkI0ckJJbWlGSnRIUlJFb2w0UFQwL1hZ?= =?utf-8?B?czRaY29mNUNGNTVNbmVwT1E3NDh0V1JmM2lhUVk5cnJXSW93Q2RVMWpzUW1x?= =?utf-8?B?RmpRTVRaK2lsWWhrL3JuQ0x1MktLV3lFUk0zclgxajAvMjJ4QURnSjJLTThK?= =?utf-8?B?alRCam1UQ2xqYkNCMFIwRWJpRm02dUlvR3NtVDBieWdKazBtNTdEQ0l2Y2k0?= =?utf-8?B?QWxLbFdiQjVaR3g4VFN6TXpmMGd3SnQ1Rzlpbkhtd3JVQXNtOC9JVWZJWHg4?= =?utf-8?B?MDZtdWpIeTFMZGU4M1cycE1VcnU5aXltTk5HT2s1QkNMV3dGYjlURHBVdW9m?= =?utf-8?B?Z2ZNRC84Ti9xa2ZTQ0piYW1wVjFzc2JCUkR3Ym1KaTFsWHBmS3BocUhjSXJY?= =?utf-8?B?eDBuVkZISkdra0czNzJSUzlRY0Y3WFVLQU9SbWZBZGJIYlBtRThuL002QXRU?= =?utf-8?B?Z3pxNHBnSnc0Tkl4QlR4NlEvOW5jQ0J6K3hlOEt4dWxvZTdYMzdWZDNsRGdv?= =?utf-8?B?ZTF6djNzNGR5OUZ1NGVmbkJOblVvL1pwV3VKUDlUWWlIVW80TDFqdlhSVWls?= =?utf-8?B?N0pUM09HMWhhQ1llUjlEN0gxZkd6OWJTSlI1SW5Pd3ltODdZSnBZQ2doUk4v?= =?utf-8?Q?36/uqJpmyPq2PhEHYUxpx7pmY7EaBUpo2pAQpMN?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6351f395-37a7-42e0-2922-08da8d1602e1 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 19:04:50.6422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0154 Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Martijn van Beurden: > First of all, thanks for reviewing. > > Op vr 2 sep. 2022 om 17:11 schreef Andreas Rheinhardt < > andreas.rheinhardt@outlook.com>: > >>> +static inline void put_sbits64(PutBitContext *pb, int n, int64_t value) >>> +{ >>> + av_assert2(n >= 0 && n <= 64); >>> + >>> + put_bits64(pb, n, (uint64_t)(value) & (~(UINT64_MAX << n))); >> >> Shifting by 64 bits here is UB, so better modify the assert to disallow >> it. And rename the function to put_sbits63(). >> >> > I could also add specific handling for the 64-bit case. Perhaps something > like > > put_bits64(pb, n, (uint64_t)(value) & (~((n < 64)?(UINT64_MAX << n):0))); > > or should I leave that to whoever needs that functionality? > Leave it to whoever needs this. > >>> -static inline void set_sr_golomb_flac(PutBitContext *pb, int i, int k, >>> - int limit, int esc_len) >>> +static inline void set_sr_golomb_flac(PutBitContext *pb, int i, int k) >> >> This seems to be only used by flacenc.c, so IMO it would be better to >> move it there. >> >> > Yes, I was wondering what to do with this, similarly with the functions in > get_bits, mathops and put_bits. I suppose the additions to get_bits, > mathops and put_bits might be useful to others in the future. The golomb > code is probably not useful for other codecs indeed. Is that reasoning > valid? Yes. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".