From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 652B948AFF for ; Wed, 1 May 2024 20:26:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0B56668D726; Wed, 1 May 2024 23:26:23 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2103.outbound.protection.outlook.com [40.92.90.103]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3E04C68D6A5 for ; Wed, 1 May 2024 23:26:17 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/nlG61S/QQqEGlAkoezoR7H8es5GDiGerbYdDR5H8mj/CFHx5VwtDsiqyfut5zo5ZeSMc+ZikuaQbtvyGP1pe68hqjEMNSUx7d6ok90MsK3KkAVB8agmzPW64zXtQLtqnB/S6ZwQZcnWf5YfHAvXHSo3p2eEcF2XoeDv30cKxBI74qrcZS3f4+qZoRTijjAO0m2tIw3PPkxjylIWp1HwkgUtjxMGzFmGnNIBtMciYJCChSa8hNR2iLD7als9mM4quYh67ZkpeW0ZtOfRDgT9at5F2qkwiF3VvvOx+65lSKEQgECSsf5gXKBebI6c0OgCSVSoS1LJVNqTWAN1oCpUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q2eVT/Kp3Qt7QgMYH4XtmPDCOpn2hMssUJeolgjDRWo=; b=g/F1dGR1QCJxaKgDJsZc8GRPMncvywZfTmejFrBnbrnKf+bXXt9QIOCqMZgsDZsWwbNbGLiQlMnFo6ii9CozwDvJKqhYOQKP5pkaGJ2PJELXF8XdnxUuTjH6+f7cQ/d/0q7nmQdM8sHzPpFyvFIiAi8YxR7dEl5cfD/glz1X72belW7houfHoS6ZYmdCiJzjwiVYDR4s0HydAn4MUZI7ierjH0v2lj/nyeh+x9GCwuHEpoSTnJiazMXasSjClBSNpzw+0nSCJgUMGT+vxmpWfUlU0qrTVYRFK8syDM+E7o3RO5j0Jwd3pnS7oD95lweCf3vxMoG9N7wBplx37JuLcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q2eVT/Kp3Qt7QgMYH4XtmPDCOpn2hMssUJeolgjDRWo=; b=PI5eIJyt3mIXr588r/4BWG5RZ87peYq1r0k9TEYE/UQT1I3RpIid79xtlFWHtSgPzCXbXtymVk93SwY/u++UTlPzEpaAXTaLXLz9OCJJ5/6ba0m+jcsu08LSncpyAQOAP3nYlPHY3ahrfvKXCRAUK4ZOxBkwYae3N1mDFn4QXNc2XF+BP45ZG3+FsI0C7xcLyztBc1qrl3LyHxjrw5zMkSwZU9SzeDc/atBk3466oWUHCaTSXN95kEzctwkXhGay9ZwuNwS8hrP87fTMZquk+DPalG1RsfwSwix+7CsXHVbzp3xTvILJaa9lfsVVKpG42G6lnkjrh8o/l1oiPghedQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0118.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:371::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Wed, 1 May 2024 20:26:14 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::1f29:8206:b8c3:45bb%3]) with mapi id 15.20.7519.031; Wed, 1 May 2024 20:26:14 +0000 Message-ID: Date: Wed, 1 May 2024 22:26:12 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240501190156.36095-1-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240501190156.36095-1-jamrial@gmail.com> X-TMN: [wJ14JuqBvH1h6YqHO6KJPulKk8ct8NwFP4EpIQutRZM=] X-ClientProxiedBy: ZR0P278CA0093.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0118:EE_ X-MS-Office365-Filtering-Correlation-Id: 59c3cee2-6b96-4c8c-925d-08dc6a1cf29d X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: cGnbIC/oRrad1NwaWblg4ZOQTn4y0BGJOxs2kUCl6L52IbGswI9rpKo1BMmxapQtoV5XUraxZx3HfejZAQzvKhjpgzMcXXtl5KJpk0yAzBXpv7sH/cyWaK5gDMq+c6FWHiP9qIMOZovHFY0cxvy3QDz/35Nmmu6rFvozO+Nxmhx2wTtwWQG+91pwO18C+iP6IeDuwo/3T6yrdll49eM5jSc9OGdXcVA4kb6a3R/4A6R8fGI5Eb6zpj4vqXYq3gcH9mPxMlLYA5gFw+GFW3ajTawFiPfCbyu4+yO+plPH+4y9W+mTRp3p5k2m9CKlJpnpjHKFewfs8wfkiXM+ZZ241DThjoAV7AZNu207dr/D53pJ7qlsL4AAbkFmQ2RQR6inlhRoQ5wt7rXBj/YLiWQjlUHCmRZ8u+iRDbfPznms73RWPejTu1MPx7ZX6brg0dDCuwJG+x8ljIBzyG848lrWe7Hq7HmpBvoMQ1+1RIBMR+KyqricI6BiYQhIEQaN6dEACyWT8ZgnUXIMiLMtlAYfAFtIWS2o/k5ESeunthnjT5M9ChCyHyhUFdXsRk3yoznV X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnZaM3FOV2VHdjZxbit4bEdhNFdwaWxyRUhJUWw2S2pNZXhabGJOV2UzV2tI?= =?utf-8?B?VHI2K08ybTg0bDBzZmxEcmZuWStWUFdDZGlDNTNLcnRReUZudEZOZ1RLNGNB?= =?utf-8?B?Y2tKZjRqelA0N1AxcXRzakd6TmU4UitkZ05KdDNiMTV3U3hmdWxKUUFSWlo2?= =?utf-8?B?T0RQUUlKdy9YRVlpRmxHYmNQVDFqc1kxSWRTZ3kvN1ZZNFJnSXJmdUc4K3Vs?= =?utf-8?B?MmRoZytwcExsb0tjeGNrTklNazJ4RTE0dituR21seW12VjR0MHhIUUpMcTBn?= =?utf-8?B?T3RROWJ4ME5GeEdTYjBReUpyOGphUG91aElTNnV4alZ4dFVEZnhMTGt5UUsz?= =?utf-8?B?WlVNRVc2cVlGcVA5TnJWem5KQlNMSWpEL1BycUFQSEZRSzdFemwwQUVIUVcv?= =?utf-8?B?MW55UGpGdTdYZHBiN3k1ZFpWVFFNOXZ2QURjR3BzMEtMdFFHOExXdFpNbXN6?= =?utf-8?B?Q0RMdHNVV2ZMUzZ5M2c1MGd3aCthWmNTOVFTTWdSaklZc2hqS0h4SmZLaHJl?= =?utf-8?B?K3JvVEZGa05jYjFrMlhoNHhRM01Kc1JmdGVVYjVBbGcrdFJtblNKVWNWZkxq?= =?utf-8?B?Smg1YmNsdjdhbklHbWI1V3Awb2MzMU5VUnZXRFR0bVV5c28rYmEvSU50MWxS?= =?utf-8?B?NTI1UDl1UUxMc3c2b054OXFwYVdBY2hJYVJhU3Z1T0NzYlFMMS8zdUVHYk5C?= =?utf-8?B?Q2tSV1E1UDUvZkthNVZtQVFIY1RwMnI4Z0t5NDJsZkpHcGl4ZjZOaXJ3Sis1?= =?utf-8?B?a2JWU1liY2t1b1lkU21qV21jUlNsdUJyMzR3c3Q0V2M3MWhmMnIyblhuRDlH?= =?utf-8?B?N0JJS0I3QytpUldTSkZPTEtpUWVaRTUrb3RFb2JzQkROYS91Tlp0b1B4U0or?= =?utf-8?B?Y2srdnU0Y1JzQTdBeWd4VVM0RWNrNS9kVFFkbWI5amYzNmdtVXJ5SHhmcjI4?= =?utf-8?B?OUNSWnREUGo5UjRoMElZaGRRWGNoQ3Fyc2M1cHdTcWwzYWJXTS80N1lDdy9l?= =?utf-8?B?SzRadmM3TUNxbWoxZnpUNzRodkRTb25IVGozWXRNeVlvWXZKSkNMSkQwNjNi?= =?utf-8?B?UksvV2ZPUUxFcThVOFphQXJ6ZGtNT0pMTXUxWFF1eHkyT0hzMzU4UEVkNU5p?= =?utf-8?B?SnYyS0VvaU9yMldraFdyOEZTajdQWVFhUGdaODZCbzNhNURnLy9mK1FoalN5?= =?utf-8?B?VjVmM0RzclAreHBJOTNQaXRSVjJaSG41Q3lFZFlqSm93c3k5NEhoY3dYMGZ1?= =?utf-8?B?c2dqN0c4WlNXRllITWpleHZnYlBRMU5ndHJaNDM3NjhmSC9oVUVwMmNwdmdx?= =?utf-8?B?bDNiTHd2NUFUd0N5Z2xNVHNjQTRlN08wNmVCa1VOVXBxaWM1emdWQWZ1WkY5?= =?utf-8?B?LzZ3M29uNDRHSU5yRkxQNGcwOWVVdVVZcFNwU1IxczgydVVzSitYbHNFS0Zp?= =?utf-8?B?cmZJTFk0L2VpY25GUEhvMjRaQjdvY1ZJT0FBbDBma2VJREpwaHQvZjZQSUoz?= =?utf-8?B?R1N4Z3pBVVF0dE5vUGZqUWZUV2xhVXhrSFlkYVNaUTNablhtNjJyeXZLUTBU?= =?utf-8?B?U29NRnZjTmx0QVdxWmlIaXlOczJYSnFnbTFsTnJWYXhiT2RwSlkrcGVUR2hq?= =?utf-8?B?SFhDSzlXbEhZd3ZlMjhuVUZEblA2NTlhcHliMWRsdjA3Q2JBWkNtQUIxVXhj?= =?utf-8?B?L2tBUkUrV3l1d21SckQyalFkNEROeVllNmJpVHR0YUtrQnRlZjhONmRBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59c3cee2-6b96-4c8c-925d-08dc6a1cf29d X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 20:26:14.3885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0118 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec: prevent ch_layout from being uninitialized in ff_codec_close() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > It's a user-set parameter shared with AVCodecParameters, so it should only > be freed by avcodec_free_context(). > > Signed-off-by: James Almer > --- > libavcodec/avcodec.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c > index 888dd76228..fc8a40e4db 100644 > --- a/libavcodec/avcodec.c > +++ b/libavcodec/avcodec.c > @@ -414,6 +414,7 @@ void avsubtitle_free(AVSubtitle *sub) > > av_cold void ff_codec_close(AVCodecContext *avctx) > { > + AVChannelLayout ch_layout; > int i; > > if (!avctx) > @@ -468,7 +469,13 @@ av_cold void ff_codec_close(AVCodecContext *avctx) > > if (avctx->priv_data && avctx->codec && avctx->codec->priv_class) > av_opt_free(avctx->priv_data); > + > + // Work around av_opt_free() unsetting ch_layout > + ch_layout = avctx->ch_layout; > + memset(&avctx->ch_layout, 0, sizeof(avctx->ch_layout)); > av_opt_free(avctx); > + avctx->ch_layout = ch_layout; > + > av_freep(&avctx->priv_data); > if (av_codec_is_encoder(avctx->codec)) { > av_freep(&avctx->extradata); This and the other patches will cause memleaks for users that use allocated channel layouts and avcodec_close()+av_free() (this is deprecated, not forbidden). Furthermore, where does the rule "user-set parameters shared with AVCodecParameters should only be freed by avcodec_free_context()" come from? It is news to me. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".