From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5803744242 for ; Fri, 2 Sep 2022 21:56:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A028468B823; Sat, 3 Sep 2022 00:56:24 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075072.outbound.protection.outlook.com [40.92.75.72]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA2EE68B20B for ; Sat, 3 Sep 2022 00:56:17 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RzLzE+fQVOAFSyAYM3YmRKiNrcxq0qG8yw6EFrlyGa6GacEq9UEj4Uy/Rg2QAAsQsoURoZQkMLbP8AYUs6rJyRVJhbaP2zN2aTx/h2BQLgr9mY3WE/wqZu17Zb6WoCkgx9wpn89Mr2atE133TWrxWSqymIQgZ3Hc6lonKtRr2K+h+ekym7z+gQoJpipgVyo+KbyMhcNIEpkNEhxQBKbRZcLVRTc9U7Yp0NmOsFx99VqpP3YZq1B5DGW27XjUi8Wz+aTR7YK6H9+bEQ7iTX33B9XFP4vfARmS5z+MbWwRU3wObm9qdQIZuEhCDrYdTHKwKXFAPjhvblVhg09JySecbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nWPv0Q1v0qz7QIK89ssAVqsdLOEY9770K+r5BnpY4h8=; b=FcKyvKMCCA1cjcdgktRc8rk4zwTZLKPN+YuCNBbDMvcjmYmxcVNYlyVy5ZGEunMCVN5JaP0wWpjn6y27YwC+1YmxURVmOi6fFWB44C4NRxT3LeZr0dOL7b6JiV/J3pleBhhtZkVCQc087oiD3+ggHb2xBKb4Ui0VJ1ejaJ81v+JNEYxLmm+e3kKg2lk/+Xg/GfyhcrU29xOhz48B2PRVcJ7KP+JY39YpkGGT5eI1UiwxpgVRs1MXiGYOfQJokjTVtU1vBUblyR8/oT3/CDQc/WniMtQYlbmcdsLH1R5vsxDSfDyDMwJgd5pTp38Z3QLDrfbgZkewjbUh5cPQlWTGYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nWPv0Q1v0qz7QIK89ssAVqsdLOEY9770K+r5BnpY4h8=; b=ABO5N8gyBd/zGbTJ0/cpqAjSQdd1+lI6igx+umcuFJMRIVDFpvHnWQc/vDSaOQNyfEIK2MR2xpH5vj98s0S/ek+tYbobigHg1jeO6EwJSVSxcu7ZMsZ3cB2eP7qGmSQFY1OQKOIxA3mKSaS23PX4b7qb0kCV/52iQxAinQ2T4FpPJlXieOWQ7YJyb3G3gM00tZmZ3LNYd+mVitV1K+CT++1go0USbuA6rQEROEOaFoXXX6kPwF5b5740j7x8Pq9SdCktZs40PgJkWGxoLqGDAR9AWNaCEFkDyKyY+c8h+9mIvtQJ+pDMtFaKKWSCnzvlO4Ym0QmANdRthxt8Lguv3Q== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0370.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.15; Fri, 2 Sep 2022 21:56:16 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47%2]) with mapi id 15.20.5588.010; Fri, 2 Sep 2022 21:56:16 +0000 Message-ID: Date: Fri, 2 Sep 2022 23:56:15 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [2Z9tLMoEA1oaZoRcu/Wp4HQ8AOJ2jCq5L5xXrsaxUGA=] X-ClientProxiedBy: ZR0P278CA0058.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::9) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <74383d07-6b51-1e15-848b-6501751f8f36@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92464bdc-1309-4c81-5d03-08da8d2df4e8 X-MS-TrafficTypeDiagnostic: PR3P250MB0370:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: psM2cyPwm7azW5NyF8YMOzbOu3Bzb5X5zWG+8W3dbNOetvRHo0r07G5RtjLysscniiDyr4lTf9PigI+1J6L6qFf2pj7dHa7zGUBHwmp7oh2W4LZGmSfuycn2p3VuKmRqE2XBmfD1+Et0AhDO5Fre0dvOEBHb0ZhALpyiR05VG81E1bsQkukQhJ8KJmSb1vLon62kfBo8m+O3k6EHJYFNnupXyWwvohFgljw8Fx/oQb0mI37PDBqkVOrRITJ0k9euPfmzaAkgEJhzYwhMv8GtbMGTwhD8zPxHOhQyeW91kuEfiMwqYSh+1lDztgSWWlQoE5vvqssDU0YWYmrBdsOl6q9b7id43y83nfUPjL/V2WoYjmn/yyGBcMAZGVgDlk5JTOsogvefHHviO2DUZUZjsLBTHCIdgePkUDXlrem2EKIPFS6a33fBUnB6jTlsxJ7n6r5FX4BFhGvUkQMrMbYl2ppg89IRu/W1kFQI5qGKcmkjAOpsWqHXxaDA94J2s0MJgBDF2DJWw1PyjK5ljieLhYPgaK15nMlqFp1jz9VvirYtwwMz/rES1iPR0X3ohCwLaE9FsE2KZ9rE92/IiwzRtmGlyHEqJ9kstUrYnLs2KXvie8BOGprO+4PwxL/fFqEzN22AW7P0H205mAY949t866tk3A3JuN2NwyhxG8AQeVUfltuVKSk3XyRWWVHLlTpl X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDBPYkFRcDBDamxVOWdOTmtVVnp5eitrUWQrYXh6V1J3UEJnZy92NEt6clpW?= =?utf-8?B?VGJqSmFCang2bWtjRUJuSldrdDlQMDI2bCtiQ0hjZU9LRFMrdzdoWWpSa0c2?= =?utf-8?B?UnpkUWVsRTRKMnVVckNBL0hwYTZtemdxWXN6Y1ZjRGh0aWliQmMrVmljdXVl?= =?utf-8?B?alJ6aVE1akRvQnYwVjUrZzVvQW9YbHcxMXVRc3lad1J6WnNEeWswaUNXTTVC?= =?utf-8?B?UUQvYmw1R2tOazUyYXNVbUUybmtqUGNLa0Qya3dmRFRmUERxKzhSWkNlRXJU?= =?utf-8?B?YVg1WUtkT1ZJSTNHSm5YTFRTZEhSN3h2U1JLZFNYV0JDa1hPaG8yYktyeEZr?= =?utf-8?B?N25SeGJXckVjcElpdGFMcHg0KzNwaXhlZHoyNTFaUzdiMk02ekk0N0xyakpY?= =?utf-8?B?eU5zRmlVd0FSTzlxTXAvdmh2MmJUVVQyYWZEbE5Wd01Odlh2ZXhoMHN5eEZF?= =?utf-8?B?KzhtTmllQ0NRQi94TW1iKzdMUkk3V0RMQkRYSUZLUGJWQnVpdjgzK0xlQTJ4?= =?utf-8?B?d1FRbklFaWFNRFppeEM5ajV6dGw5WU5sZmh0bUJqeXlpWVFobnd5d1NVNlF6?= =?utf-8?B?SGJiMDdNdjRMdUxFNDllRFZzejdRVmFLektIYmM4b0ZsWG9tSDMvTnd5Ymlv?= =?utf-8?B?MmdCUE9ETHNZQWxua0ExZzUyZGdLdE1ra2RhQXlLREFTMFZKanl4YzZFV214?= =?utf-8?B?R2daSnZnTnhJWTg0UGZhT3M3a3NrRzJaTFZHU3ptYXYxNTl1R0ErVDhSeWtY?= =?utf-8?B?dHFIbkhjNHlZbkZ2OUxoZzUrcDgxdXA3d21xVStPRXQvZTRYbWJCeExHRmF0?= =?utf-8?B?b3I1bktvTkZBNGY0SkVHVjcwVS9IdU5SaW85YzgvcEVyMFFIazBGczVGM0xw?= =?utf-8?B?ZGVJaWhueEE2eWdrZ0RqT291djJlQnhwS3BUTkcwVk13Z29IUjRWMXRtY0xY?= =?utf-8?B?WjNxUWNLckRNQWFYZVI5a0tuUmtYaUt6eUw5Mm1Bd1FGWmhiVUtSRnIyUUJT?= =?utf-8?B?RXk4ckwwZjhENm5Oc0kyeWM2NGdiZjg0SGJQcHZoaVlyZExWYlNPZW1kbEN4?= =?utf-8?B?dkV2ZGM3cXhwcjNZUHRWS1pBZUdNektnRkxtMVVYSW9aWjBlaEppT0Jtb3dO?= =?utf-8?B?RE1XOUkxQmE4ejNRR0R6U2FIVk13ank1eTFHUFowU3QzdDVYemdOeGE0VU1L?= =?utf-8?B?YlU2TFdGMVJKSnh4bWhBUGd0V2orZUlCL3loN0VJQmJnZnR2cG4yM0VHREJz?= =?utf-8?B?V2d0OURDaWR4dWpvZENldnpOUDJLaUF6U1JidTk0Wm9jY1RyQllyTFZLSmNq?= =?utf-8?B?N0Y1OTVhbnVHWGcwRXEvdEl4UWVxN01WakJSNFpSTFI2SUZuZFFmNFdhcElO?= =?utf-8?B?dlJzVTcweVFBcjV3NkZOaVlQYkt4Wmg4aVFWbzVwQldCQzNIN1pJK3JaUWhH?= =?utf-8?B?YWl0RnVhR0pWWW9NczhqNWVDOGNFbXFlSEtqc2hXRy9UbE9sMFQ1TVNtS2ZK?= =?utf-8?B?M3ZjcEN4dEViUlRSaDZmc3VGN2VFa0xhZ21DZ2F2NHRzc29nb1E4Wks4NGhZ?= =?utf-8?B?V3R6aEd5aE8yQ3VxRFYzSkRVWUVMVzNDbkRSc3RTcUV0ZUM0M2JWWTQ1dS83?= =?utf-8?B?S1U5eXZud0VxR0JBK2wrL3BGQWZ2OHdjb2w1T0NJOWNoTkZGM2tROGRNL1I1?= =?utf-8?B?T2I0YUtXRFROWXI1SUYxL0VGcWVpM3dZNG5FWWFYeXVmcDFZaHp4b0g0RXpI?= =?utf-8?Q?kpOcC4uAF8Vy1BhprkMdX5UiEc87JY6W43IOOKC?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92464bdc-1309-4c81-5d03-08da8d2df4e8 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 21:56:16.0762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0370 Subject: Re: [FFmpeg-devel] [PATCH]lavf/hevc: Fix type specifiers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Carl Eugen Hoyos: > Fixes several warnings: > warning: format specifies type 'unsigned char' but the argument has type 'unsigned int' > --- > libavformat/hevc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/hevc.c b/libavformat/hevc.c > index 1841dd5785..ca5187a92e 100644 > --- a/libavformat/hevc.c > +++ b/libavformat/hevc.c > @@ -848,15 +848,15 @@ static int hvcc_write(AVIOContext *pb, HEVCDecoderConfigurationRecord *hvcc) > if (array->numNalus == 0) > continue; > > - av_log(NULL, AV_LOG_TRACE, "array_completeness[%"PRIu8"]: %"PRIu8"\n", > + av_log(NULL, AV_LOG_TRACE, "array_completeness[%u]: %"PRIu8"\n", > j, array->array_completeness); > - av_log(NULL, AV_LOG_TRACE, "NAL_unit_type[%"PRIu8"]: %"PRIu8"\n", > + av_log(NULL, AV_LOG_TRACE, "NAL_unit_type[%u]: %"PRIu8"\n", > j, array->NAL_unit_type); > - av_log(NULL, AV_LOG_TRACE, "numNalus[%"PRIu8"]: %"PRIu16"\n", > + av_log(NULL, AV_LOG_TRACE, "numNalus[%u]: %"PRIu16"\n", > j, array->numNalus); > for (unsigned k = 0; k < array->numNalus; k++) > av_log(NULL, AV_LOG_TRACE, > - "nalUnitLength[%"PRIu8"][%"PRIu16"]: %"PRIu16"\n", > + "nalUnitLength[%u][%u]: %"PRIu16"\n", > j, k, array->nalUnitLength[k]); > j++; > } > -- I didn't catch this, as I didn't get a warning at all. The reason for this is that it is actually not problematic: "The ellipsis notation in a function prototype declarator causes argument type conversion to stop after the last declared parameter. The default argument promotions are performed on trailing arguments." The default argument promotions include promoting integral types of conversion rank < int to int. So av_log() has to read an int/unsigned even when one uses a %"PRIu8". And so my inttypes.h contains this: # define PRIu8 "u" # define PRIu16 "u" # define PRIu32 "u" No wonder neither GCC nor Clang warned about this. Anyway, patch LGTM. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".