From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id DDC374D3D7
	for <ffmpegdev@gitmailbox.com>; Fri, 21 Feb 2025 11:11:21 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6C0AF68C777;
	Fri, 21 Feb 2025 13:11:17 +0200 (EET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05olkn2086.outbound.protection.outlook.com [40.92.90.86])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 262A368C3B1
 for <ffmpeg-devel@ffmpeg.org>; Fri, 21 Feb 2025 13:11:10 +0200 (EET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=DHVspvHgrKGWrifg41KesrutsGsomZr5zVu7IPXYOGQO/HBovVU/elUrNCS8xjPwuHp+0kOAEVjLmwnu7MERkAIsYH6EOoVsr5qYpfiXi5EktJsfF03vO+J+hFT29LFiI2E+BjVFvPIKBV2pQ2nd2Q8biSAiN6PeeVuouobHVXfoAynmgMaept+Qa/enjvfJfrfe8j1m0MOJEWGUCmuz+r8nkr3ojU70XIa5BrYKoJlhDXOmIcnBKtDI/YIA0cF8cnW8nKEfnfmJkEPdWthcAKXyL6CQ8adiVO0XV6JtrxqUiE8SxSwxlCf+9XbMCEeCxZ6h2ydJyTZ3tXGM238JhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=igwjRuXTcpA3dEujyUko9DJ2d3CIJocsINEDM7aUxhs=;
 b=ZCPfeChO2YiY4yxzVLM4PuxC5FcQ85ANjq54lsPNPnwych5Lew8N08Io9ye7caHsVB53T8twDLGtyF00NlMXdrE9qlI2C/UG/qNfosZZqRb1qp6Q9N+5WI2RxALfZtY5CQuVXu3Urp9BBKJmxD0EMziJHoNoe0TuHxY5vHFR7PENUsOLS2+uaCe0ENtzs58oJI6hESAnsIWtpQEnCvx49ZeS4C+tLOYfumG0/8cEW7qKPa2ZcDSIeYVogAA3Va+zYBhfIQOLanqbJ1bki1TYQQ2NBQ0+YZCQsUea5ZfrRS/HYKzqXwz1gs23NPIrJgmtbVu4vMb/QLd3IoMCJuQjJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=igwjRuXTcpA3dEujyUko9DJ2d3CIJocsINEDM7aUxhs=;
 b=qEyIVMDGvHHW0TaUHqMM8hag80Qkoc8ktBOVmu+PEJMq0aprOcxSHo4G9+fARjQqclR7wP1cMN7Hj0RAblNvmdi4xBk8fRRxtKDfLv1yS1ZewHb3zAHhWrpCi3/6wYfEUA0X7OOY6d5S2V+cfVRjIw4SbKVP3tSojxLZM+Qft2kVBJ9HvU6lKEzFF40HCZMUaMIUPD4nzRt34e9Kc0IJKB8QvPZCAjX8kOS4JCEZsLNS7VVCzQ8SJ7PMnwSyOE/zJyWKNLmFQ89GQxpZZvIOaNpB1BlszZZQ6tHGvCqluuUq13+0LMgzxFwil8UficZwuG7G2zLYCImrQIaz71fg+Q==
Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14)
 by DB4P250MB1005.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:3f3::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.15; Fri, 21 Feb
 2025 11:11:08 +0000
Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
 ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
 ([fe80::384d:40d4:ecb7:1c9%5]) with mapi id 15.20.8466.013; Fri, 21 Feb 2025
 11:11:08 +0000
Message-ID: <AS8P250MB074491855918A8AF99E031B98FC72@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Date: Fri, 21 Feb 2025 12:11:06 +0100
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <pull.52.ffstaging.FFmpeg.1739959172.ffmpegagent@gmail.com>
 <0750b971f9ae0fc38917e0a3b3ccb7ad2e8cd221.1739959172.git.ffmpegagent@gmail.com>
 <AS8P250MB074405D4ADECB60BA5A180608FC72@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
 <DM8P223MB036568FA5ACB52B54870A440BAC72@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
Content-Language: en-US
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
In-Reply-To: <DM8P223MB036568FA5ACB52B54870A440BAC72@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
X-ClientProxiedBy: ZR0P278CA0134.CHEP278.PROD.OUTLOOK.COM
 (2603:10a6:910:40::13) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:541::14)
X-Microsoft-Original-Message-ID: <6068c442-58f1-48ce-bbe7-7f3cb0ab180f@outlook.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DB4P250MB1005:EE_
X-MS-Office365-Filtering-Correlation-Id: 58c5af6b-87fc-4930-9d68-08dd5268710b
X-Microsoft-Antispam: BCL:0;
 ARA:14566002|8060799006|15080799006|5072599009|7092599003|461199028|6090799003|19110799003|440099028|3412199025|12091999003;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?R0FpeVJXakZRbnAwYzE2cEtyMFdkclNsMGlwd2hXQVo1cERxMEdpMmFCK1A1?=
 =?utf-8?B?dElCZDNKckIxYUl4WFExbEJnYm9yR1h5cEN0ZG5vclM3NVRpSWdjaG52SDFH?=
 =?utf-8?B?TEkyTDhJTFRpSTVaMzhQQ3hRZlNHWWxmRlZQeVY2Mkh3QjdKMkpUVWQ0SGZN?=
 =?utf-8?B?SWxLaFA0b3lxLy93bndyR0VmVWFETCtYbHdWdG9mQlE4MUhZM1dpcGNsbTE4?=
 =?utf-8?B?NkdFbkd1N2hRSWt2bFE2YTl2QnlBMGdWVmhMM0lYT0dSdnNNL3hpRk15Ukdj?=
 =?utf-8?B?bDFrMEhNRVhYZDFwbGpteUlva1BrNkpRbktnWThVbjNMQ3oxdFZSS3NlVzB4?=
 =?utf-8?B?cnI5VmpuWFhnTjFYQVJTTUVtdUQ3VE01VTcrM0hIbjRLczFFRHZLN1FDeW4r?=
 =?utf-8?B?QWJTTjRQM3lJY3JhYXJNOTdQSEJnR1NrZDg4aEtYVmZkaWZrNTR1MmFWaXk2?=
 =?utf-8?B?S1BEM2VMeEdJM1g0K3M1ZldLSjMzdm1JZEpWV0tWUzJtMkFyUTIwWnhGTm1J?=
 =?utf-8?B?T29QRUU0VnRFRUpiV1ZzY3RGTUpLNlVYNlpKd0dGQ2dWbFNoYWRYK0VDc1c0?=
 =?utf-8?B?a0Y2VW1wSG5DTnlUQjlicEtKUUE1Qm5RSjNUZ1RlUFZ4WHZXeTgrVEt4TSti?=
 =?utf-8?B?VmFtWjh2SmFtU1lvcTBFR0w3UmNOWG9tZjZZeWhjS0dkMTRvVGhGamtkY1pt?=
 =?utf-8?B?R2kybDloV05zRFBmNkcvRC96bGhuTFVxQnBaaFM2Sll2ZUFnV2d4NTlabGxp?=
 =?utf-8?B?MzAzWjBwRXRNbnZDRkhPYTZ6NzdSMW43ekR1VHB2Y2NnTnhMZS9qRE5Cazl1?=
 =?utf-8?B?eC9kQXQ4TWlmRG4xcGhZVW0vZWNmZjg2N1R5N05kWVZsb0Q1dCszQUdMdnUy?=
 =?utf-8?B?T29qZWVRYWQ5Q1QzRzFpbEN5Q1N1VU5qYlduMnBJTlJxNklKZ3UzV0p6b3Mr?=
 =?utf-8?B?WHlYVWZweUJXUitiaW14bFEvcklWRFA0blJUaHlOdG92bnNTNGFMNG9idlRL?=
 =?utf-8?B?U1lrNVE4TDJ3VWJpTUttUlZ1UUdTWks1dERrOGROVkJmTk4yamVrZUh3K3VI?=
 =?utf-8?B?SWVYa24zMXJ6cVdWK0NzaldSRll2RjEyY0I1OGdJYTUwVHFHVUV0UE5YSDJ2?=
 =?utf-8?B?M1g1dmU0dm93S01rSFhFQjNwTm5lN2l5djVxS0htVG8vT0Jwa1laZWVHQU5T?=
 =?utf-8?B?TE54eTVJQlpka01IZG5ldDdVR1YrcE1mV3FvVWF0WDRmWmovaTIycG10Yitk?=
 =?utf-8?B?RzdPVjlxK0NUZUFmM0ZhRUlSODNldWhvTGU0dGJOZEFoNVkxQ1lUd25ReS9T?=
 =?utf-8?B?SFN5aG5xMS9JbndodWdYOTVtUzR6c1ozUVprOHVrWWdOMXcyTVJzQjlwMEJB?=
 =?utf-8?B?VVpyeEdmajNqTkR4dHM4QkVuRXRtTmg5N3prcEZQTkFqczZMc2FTd1BSZ1dS?=
 =?utf-8?B?VDMwcHdzUnFCd0VVNENOZXBKSmRCdjI1R2tDaFdzeUNDMHl0VnlPcVpsNlZI?=
 =?utf-8?B?aVRGejd3a0cwRHRsR1ZrSWVZSWpSSHhtaCtRaFNyVGpoZExGWGtNUk1XTEVa?=
 =?utf-8?B?RTFXZz09?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlBTNnBPdm1yY3BPbVdpdjRMcWlhWHdwZXVhbE5QaGFreG00dlNGa0c0dll3?=
 =?utf-8?B?Ym0yWWczbWNrUVZUTEwvanNrNjl4RForWHpQVkR4MVZtMmNUYjFCQmppN0sr?=
 =?utf-8?B?eDB6WXpvbDgzZmQycy81QTIya2NIYWFBQUNhRUV2bGFLSzc2aTFZL3ZyM2Uw?=
 =?utf-8?B?bFovU1hPVFJ1N0dzWlVmNDlYWWV2M24rdzQwUTlOalhSNFRtQi9oVjdTYzdL?=
 =?utf-8?B?bytGNnpnYWw5YjlPV0djNzE5ekF6WHVMUG8xMkhSWWNLUm1OR21CSmdTejky?=
 =?utf-8?B?RHFYenFGQlRUdU83SkVDSC8zdHczQnFvdTVmbk5tZnNWdU1wSCtpKzFKODBD?=
 =?utf-8?B?WjNncUlwaEgwMDBrY2FSWUZHMStuVDRGU01TMks4bHdHTjRIT2xNWG81T0Vy?=
 =?utf-8?B?eDN6OVRpcEQ4dndjNjYvNWRxRUlwdUI4MnAweDBka0ZmNUxOazNvM1UyY3ZB?=
 =?utf-8?B?bFdyUEhqM3ZWejlXOTJGTmZHNGdVL0xITWV6cEZjdUVJQjB5NG0wMkhiQWZk?=
 =?utf-8?B?allVMUN5VUtkL21FWFMrcytmZkVNYkxtcDBMVXFEQmQreHZPVVFpNGhlTjR1?=
 =?utf-8?B?bHVPaDZsTDZzdzhMTFN6NkVqSFdTbnlTTDlrN1hPYmtTQXRXVmcvMkxlRW1C?=
 =?utf-8?B?YXh2T2prSVEwQkd3eXR4MTFSZjVDVmpETWl3TW1rVnVGMkIvL2tzT0NlRE5a?=
 =?utf-8?B?LyswMllJV2NSbFVWMUpmcFhLd29Ld1RKc21ITURIOVJvbDMwNmM0YjhWcGp5?=
 =?utf-8?B?SlBlUTBtaHptbmt2VFlNMS9VYWtSeWtuL21FTHZpU25TOHJtZEN6N1MvQ3JT?=
 =?utf-8?B?clVPM2ZYT1J3VHphMUNVSUJpVGd3UTdzOFkzY1pCYllmTG1KVENiSzAwdU9i?=
 =?utf-8?B?RGVVakRWbVN3MGNyY3ljSkZpaWZRWE9ya2Vka3hIUlhoOVlUZ1IwU05sVWdW?=
 =?utf-8?B?ODJYMzA0SUR5cndRbzZxeTJ2V0JyWEQ1SUpvb1plak1CZE1CWklKQnlWN2Rz?=
 =?utf-8?B?c253TzBvTFRPY1AvWDZWUFBPWXNXMm85RDVpREJTUWQ1aGtEV3VCNmt3TzlK?=
 =?utf-8?B?NWVnZlVLUGJ6MXNpY1dqQTJ2VG9wV1dNSnNTeVo4K1duOGpGQlhuR3hKNVJq?=
 =?utf-8?B?VjRGbHlQUW9MclZZNC91WC8ybVVCeVNSeSsydXFEcGNaUnQ2eVcxVm8rNTNp?=
 =?utf-8?B?dk1yZ05FTm1iV0xDN1J1VUVTdkw4d3JFUUlwbDhJUGdEeWtTcFA5dXdjSEJ6?=
 =?utf-8?B?SnpLdFdTMzhqQU5DOGFOd1lrV3krTFlWQmRPWkVrNzB0d1VzQ25iYWE0YUZZ?=
 =?utf-8?B?WlVYMnQ4WjQ5MnN5Z05XTVJKdWFEdXNLWHlNdWNOSEx1MlFFbk1xSzNsZ3Iv?=
 =?utf-8?B?WURLTGJqZDVoUWlmd3VrNk1TcHh1Zi9FZklzeXh2SHhlWDluMzBtZFZmZVJK?=
 =?utf-8?B?blc4WUROUUN6ZTlhOThpR2tOWWRMZWk1UXBkMUVQdXN6YkJLTDRpSHNPUXV0?=
 =?utf-8?B?WU1WcXFpSWJLRFpXOXVNWUFWVFFiQlptVStvSmhkNTdSQkwybG9oWFBYUU5G?=
 =?utf-8?B?R2NPQ3o4VHRCa2kwYU52TVliaVZmZnJYT1BlL2MwOVN5VzZxQXNaWmtsaUF3?=
 =?utf-8?B?ZW50TjlQdjBqV2Z1eDNoQVBUZnN0R0lOeFBuMlovaXZHTnAwV2puWEg0cFRJ?=
 =?utf-8?B?VlBmcHlNUFYxRkVaNnRhNmkxTWUxK0orSEx0ZllZSU02djk0QTBrNDNRPT0=?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58c5af6b-87fc-4930-9d68-08dd5268710b
X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 11:11:08.4954 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4P250MB1005
Subject: Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_graphprint: Add
 options for filtergraph printing
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/AS8P250MB074491855918A8AF99E031B98FC72@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Soft Works:
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>> Andreas Rheinhardt
>> Sent: Freitag, 21. Februar 2025 10:23
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg_graphprint: Add
>> options for filtergraph printing
>>
>> softworkz:
>>> From: softworkz <softworkz@hotmail.com>
>>>
>>> The key benefits are:
>>>
>>> - Different to other graph printing methods, this is outputting:
>>>   - all graphs with runtime state
>>>     (including auto-inserted filters)
>>>   - each graph with its inputs and outputs
>>>   - all filters with their in- and output pads
>>>   - all connections between all input- and output pads
>>>   - for each connection:
>>>     - the runtime-negotiated format and media type
>>>     - the hw context
>>>     - if video hw context, both: hw pixfmt + sw pixfmt
>>> - Output can either be printed to stdout or written to specified file
>>> - Output is machine-readable
>>> - Use the same output implementation as ffprobe, supporting multiple
>>>   formats
>>>
>>> Note: This commit includes only the default and JSON writers.
>>>
>>> Signed-off-by: softworkz <softworkz@hotmail.com>
>>> ---
>>>  fftools/Makefile            |    1 +
>>>  fftools/ffmpeg.h            |    3 +
>>>  fftools/ffmpeg_graphprint.c | 1152
>> +++++++++++++++++++++++++++++++++++
>>>  fftools/ffmpeg_graphprint.h |  224 +++++++
>>>  fftools/ffmpeg_opt.c        |   12 +
>>>  5 files changed, 1392 insertions(+)
>>>  create mode 100644 fftools/ffmpeg_graphprint.c
>>>  create mode 100644 fftools/ffmpeg_graphprint.h
>>>
>>> diff --git a/fftools/Makefile b/fftools/Makefile
>>> index 4499799818..189feb4e2a 100644
>>> --- a/fftools/Makefile
>>> +++ b/fftools/Makefile
>>> @@ -19,6 +19,7 @@ OBJS-ffmpeg +=                  \
>>>      fftools/ffmpeg_mux_init.o   \
>>>      fftools/ffmpeg_opt.o        \
>>>      fftools/ffmpeg_sched.o      \
>>> +    fftools/ffmpeg_graphprint.o \
>>>      fftools/sync_queue.o        \
>>>      fftools/thread_queue.o      \
>>>
>>> diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
>>> index 6cc0da05a0..432954b4cc 100644
>>> --- a/fftools/ffmpeg.h
>>> +++ b/fftools/ffmpeg.h
>>> @@ -714,6 +714,9 @@ extern float max_error_rate;
>>>  extern char *filter_nbthreads;
>>>  extern int filter_complex_nbthreads;
>>>  extern int vstats_version;
>>> +extern int print_graphs;
>>> +extern char* print_graphs_file;
>>> +extern char* print_graphs_format;
>>>  extern int auto_conversion_filters;
>>>
>>>  extern const AVIOInterruptCB int_cb;
>>> diff --git a/fftools/ffmpeg_graphprint.c b/fftools/ffmpeg_graphprint.c
>>> new file mode 100644
>>> index 0000000000..77f143b8c2
>>> --- /dev/null
>>> +++ b/fftools/ffmpeg_graphprint.c
>>> @@ -0,0 +1,1152 @@
>>> +/*
>>> + * Copyright (c) 2018 - softworkz
>>> + *
>>> + * This file is part of FFmpeg.
>>> + *
>>> + * FFmpeg is free software; you can redistribute it and/or
>>> + * modify it under the terms of the GNU Lesser General Public
>>> + * License as published by the Free Software Foundation; either
>>> + * version 2.1 of the License, or (at your option) any later version.
>>> + *
>>> + * FFmpeg is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> GNU
>>> + * Lesser General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU Lesser General Public
>>> + * License along with FFmpeg; if not, write to the Free Software
>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
>> USA
>>> + */
>>> +
>>> +/**
>>> + * @file
>>> + * output writers for filtergraph details
>>> + */
>>> +
>>> +#include "config.h"
>>> +
>>> +#include <string.h>
>>> +
>>> +#include "ffmpeg_graphprint.h"
>>> +#include "ffmpeg_filter.h"
>>> +
>>> +#include "libavutil/avassert.h"
>>> +#include "libavutil/avstring.h"
>>> +#include "libavutil/opt.h"
>>> +#include "libavutil/pixdesc.h"
>>> +#include "libavutil/dict.h"
>>> +#include "libavutil/intreadwrite.h"
>>> +#include "libavutil/common.h"
>>> +#include "libavfilter/avfilter.h"
>>> +#include "libavfilter/filters.h"
>>
>> That's an internal header which must not be used by fftools.
> 
> Thanks Andreas,
> 
> I know, but isn't fftools itself "internal"?

fftools is just an ordinary user of the libraries; it is not special in
any way. filters.h is internal to libavfilter and must not be used
anywhere else.

> 
> What's the alternative? I could move AVFilterPad to avfilter.h.
> It's prefixed with 'AV', so isn't it meant to be public anyway?
> 
> And then there's the hw_frames_ctx does it make sense to 
> move it to AVFilterLink? Or rather add a function to access it?
> 
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".