From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files
Date: Mon, 12 Sep 2022 17:04:10 +0200
Message-ID: <AS8P250MB07448E77CAE61189C20C68A88F449@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAB0OVGogCiprgdAt2rzt3e=hzacVuXcHvtQjf=hL1irc90rxLw@mail.gmail.com>
Should fix ticket #9909, fixing a regression since
bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
Thanks to Carl Eugen Hoyos for analyzing the issue.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
This would be my solution. What do you think of it?
libavcodec/x86/Makefile | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
index 4e448623af..41ca864849 100644
--- a/libavcodec/x86/Makefile
+++ b/libavcodec/x86/Makefile
@@ -140,8 +140,11 @@ X86ASM-OBJS-$(CONFIG_QPELDSP) += x86/qpeldsp.o \
X86ASM-OBJS-$(CONFIG_RV34DSP) += x86/rv34dsp.o
X86ASM-OBJS-$(CONFIG_VC1DSP) += x86/vc1dsp_loopfilter.o \
x86/vc1dsp_mc.o
-X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct10.o \
- x86/simple_idct.o
+ifdef ARCH_X86_64
+X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct10.o
+else
+X86ASM-OBJS-$(CONFIG_IDCTDSP) += x86/simple_idct.o
+endif
X86ASM-OBJS-$(CONFIG_VIDEODSP) += x86/videodsp.o
X86ASM-OBJS-$(CONFIG_VP3DSP) += x86/vp3dsp.o
X86ASM-OBJS-$(CONFIG_VP8DSP) += x86/vp8dsp.o \
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-12 15:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 14:17 [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe Carl Eugen Hoyos
2022-09-11 14:19 ` Carl Eugen Hoyos
2022-09-11 14:26 ` James Almer
2022-09-11 14:21 ` Carl Eugen Hoyos
2022-09-11 15:29 ` Andreas Rheinhardt
2022-09-11 17:15 ` Carl Eugen Hoyos
2022-09-12 15:04 ` Andreas Rheinhardt [this message]
2022-09-15 22:03 ` [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files Carl Eugen Hoyos
2022-09-15 22:12 ` Andreas Rheinhardt
2022-12-13 15:02 ` Andreas Rheinhardt
2022-12-13 18:54 ` Carl Eugen Hoyos
2022-12-13 19:03 ` Andreas Rheinhardt
2022-12-13 19:11 ` Carl Eugen Hoyos
2022-12-13 20:13 ` Ronald S. Bultje
2022-10-20 7:04 ` [FFmpeg-devel] [PATCH]lavc/x86/simple_idct: Fix linking shared libavcodec with MS link.exe Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07448E77CAE61189C20C68A88F449@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git