From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 329A94B129 for ; Wed, 29 May 2024 16:24:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3DA9B68D3A1; Wed, 29 May 2024 19:23:59 +0300 (EEST) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02olkn2013.outbound.protection.outlook.com [40.92.50.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EE50B68A7ED for ; Wed, 29 May 2024 19:23:52 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fb5BlIMnd7av5AZwMAftGo36+Ld2uQlkYxgyfzs6dDaXDGjBIbJ466iEInGyHO5+nIhP04rTbbyYQ/sBP1aqDL734hbKVMpL81T87/146qdFIQRPQ0QD2+WRZj2EV1he6xExiiX8OqXAzWlBKj9cQ/mhLdI9epgvKzGMK01L1e2frWkQmtv+ZfUb+lvjOIMjfrsTtugDck0OwpUqUoPdWCsvLHDCasYmj1tlCnDsGp8TFWeACdt+utqo3aOJ8m7oXGFF5emuFjG+Fs/9ZfwoGkoCrcARSVhGcs3K3VjF47xCHhaLcGSFUydJ34a3qEWB+2RGOiRGVsw4jpkLhJkAhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXnI0Tk8w1LF0X0BXF8z4ZgO5rmdIdDOmNULhm+vaPs=; b=iD8z8gyWna6mbG6+391vUE/qHd78UvtrWGWsouwxo4+g8RL2jDjlKcbtjvZ4d66fOhu80GIDzu47thQbbMplWQ6mpgOBO6N1YFNbjNiofZSJHTug2vXuWeLUHE4HPMMr3KfTRoi1Sf/sjFJtOtFmGcrrBqRps0mXpzOln0O45y1MB1DuTHz3D7H6/kZIJ/6ROPx74oGsWFO5yVE5OdA5dfQBrbFR0fv3M5C0ybg0fh3ccL/uILCKrAXm3tGWz6ihO+orYn1I6v4OQzyexmTBig+EUgsTCKFUllFmRwZ8Vl/M7qkPa8vNm1TCwbiJnPG7SL4b5H4LNPJ0gdgNjG3s8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXnI0Tk8w1LF0X0BXF8z4ZgO5rmdIdDOmNULhm+vaPs=; b=O1zfgTcOVxVYj8PkPVcbQj9VXdy63r/8qvraX3j7k4PBHrDnnqKGhucNlrRG5jbE4u0K2tmi0DLIcziuBbzUYy+vQWt7l9y53hyYSGEKlT3PVRERbwL6Y+Q17mD33BOIdQK3OYgUQ9KB9lUYomz75206gC/u+2QbSDx3XTvdSAi+14HqxWw89cWhWaV+k1EwlQj0B/pEX5k5SWWJ3AfiZrHV3rTMZnZXWscolsH6b2Lp8ofqafR0td7ABcRPubUS1AHgJYRDMl3/Uk2sX1T/kg4kNyq0IF+bhDniBZP8nHF27RYI3gSVOrCNY11UxFHCWqG42UiG+gxpkqvbQWjJEA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS8P250MB0298.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:37d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.27; Wed, 29 May 2024 16:23:50 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7611.025; Wed, 29 May 2024 16:23:50 +0000 Message-ID: Date: Wed, 29 May 2024 18:23:48 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [ouwWx/C82klbIh4vNipfKMkiIGbovwHeD4zQ5uS6rJs=] X-ClientProxiedBy: ZR0P278CA0119.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::16) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <1c0b5cf2-b2df-410a-82c9-e97a98d36b9d@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS8P250MB0298:EE_ X-MS-Office365-Filtering-Correlation-Id: 25e22759-7c7f-41b7-bac8-08dc7ffbb971 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: 0xp/7jbPoDlqq8DRKKaPptgvr2qnw37xu6lOQXQZrm/ferVzLxzWwzFJAJe+Ob4gom/F8DJdNc5QWGWp5kwgWVgIxqT8XK2NEot24e1HKsFi8Fqql77RQZIIekuuElaVBIJIS0td7EDpmsuAMyZbIGv2+zaKNdVXDrDmPd86EnYaq5hf2rivEh9/30eCCt4+K/QCShnliNdxr6JdSggmhVgS++X/DW4JO2lgHgdhiTgmAku7A4KDUtCn/5oB9yR8MoZPJN7dZug9uumB77zJe+RAiEL7N72EGVWJjEe+aO3ovfUrBDdKXvXQZHh8kIoMyzaaNIGwzUj0mbqLMXkw8wkau+YwF+A++onHvIGmWmdPCxGol+owoLSAEzfaLfJNeHW6DPXMM6v9Ikzv2Lokp4s3qkgStx/psuy2lZkS3GEhQdnSJ8cL/vfbRtouFE9Z1wikFW0q9w5X3ZHp7l1RNxKuWIanxx7NQ46DylW5f4FbzpbB1YPk3eBWN7C6Y9O8HQp8IGaNoLG7HK7rmkM9MHxrTY9QgfS1DsXNsfxlksCgm7riRB8NDcw8JppVU/fR X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVZHWUREaTIrdVpzaWViM3A1N3haVGExdllhUklFNmZuWGxQK29pMWlXVGIr?= =?utf-8?B?K09QVzg5TUZsK2ppZTA3S1FZanN3UjNsKzVvc3JCQ1FMbVZFYU5QTjh5ejB2?= =?utf-8?B?MFgrYzl0YS9sczJUN1VBazl2VkJ0R1FmaHQrZjAwTkNXc3FlK1d3Z1BnbWsw?= =?utf-8?B?eWNIbWNCd0hxdllBYjRhbDZPSHBPdjVLaFk0K2t6b3hHZy8wcGFxcGZLNVM3?= =?utf-8?B?RnpEY3VweHFnVlRDUFpMSjBZOXJwcWxneWMxSUlqa1FRT1B2TjdWMGNtQks3?= =?utf-8?B?ZHM5bW9wYnZnNG1JTk9EUW1PenBjTHViWWY0NERBN0dzZHJuY2N2YVJ0TW1u?= =?utf-8?B?ek1qNzlFQ2NBeE1wRlh3UElvMWtvN0JWOGhrWFdCQlRrYUhoNG1pejRUQUE2?= =?utf-8?B?ZnAyNjE5VGFwUC9acE00UHMrTWpROWx3cWtPK0t0N3ZwTnZFbW04V3NwSjJ4?= =?utf-8?B?Rk5SaEpYVHp0U1NPWjJudExXODFsaWtCK0Ztait4eEw3ZVpTci95elJJSUZ5?= =?utf-8?B?blFRWjdkVDRicmsydWhtd3NIblB2MlBqRnFBTkJna1JsVW1ESXVUcnNLZ3ZL?= =?utf-8?B?RGVkOVU3VksyK0Nta0Y1REQ3VzlyREE4Ukw2a0JjRVRWckplaGMxazdiQVIy?= =?utf-8?B?aVQ0cCtPZzFqRzFXN1A5VnBIWU9FcTY1ekpaYnBVNURiSzlNUW1sZEdUQ0Er?= =?utf-8?B?VC9vNU1xNEtUSkRFRlZVd29xNXFFWEpUUkhaczdjMFMwckJXK1hDcXZPREQ3?= =?utf-8?B?cTh4OVJCWTJxdFZrR0dKT0QxV0R1cjFpRGliSmJrMmRVNTVqNEtwTnI5WStO?= =?utf-8?B?VnZlRVYyNGEvN3o4aS82OFFlZ1Y3R2NmdzJzS2JvdFNtU2NUTWppc0VZRm91?= =?utf-8?B?NUJIWVFlOHAxdWZBb0hZbFh3L0ZpNGVhOVl6eFkyR0lGcUdKN3JWYnNsdGtz?= =?utf-8?B?clUyVWVVRHJIWlpLNGZyemFwWEVCRFZFY0ZQSmM5bWp1Nzc5c3YxdEt6UXN6?= =?utf-8?B?ZHZFMnV1RmhPNEJNVi9RWE5wcTJJeDdNYlBFaFcyVGdmNlRCR0cwcWJvTFlM?= =?utf-8?B?N1hyZFp1UGJpbm10MjI1MTFkQU9PakRJaWRCY1lBK1pjN050ZWlQUDEwd0w0?= =?utf-8?B?VVNYV2ExT3lRUU1LN1NqS1dZZEFZSVpua1FnS2JJZ0lUampiazVWaUQ5WGVG?= =?utf-8?B?QVpXUXNXRjJzaTFwQm1Oc01BVEk2NlZZbVFmOUc5SVdOeDc4b2xnNnFnbkcr?= =?utf-8?B?VlVvSTNBdmFQQ1pwYVEzd3ZETWU0U2grc0cySkthMkZlemF3cFZUMzlZV0Y5?= =?utf-8?B?UDluenN6N1YwOTJXazhKdlFOYVlETDE4L0hjYXozbndQN0VnTUVQc3lBSU9U?= =?utf-8?B?NXZEblR3alA0Mm44Z0JTZGJuSjJrVVQyNTNXZ2szUWJKTHpYRjZoOHI0WXRI?= =?utf-8?B?UHZYSnJxakQwSjU5V1lDSER5YUFuak53T2lzalZ0b1J5b2dVY1paVTIyR3FJ?= =?utf-8?B?V1AxUlNSM2ZSMG9zanhuT1dwZStqTXAzVjdWbHFBUXRSQitEbWRUZ1g4Qmgy?= =?utf-8?B?M3djSFdBd3U4UjdDZExYZy9ibkN5QjhCbmFHcmFscTBiS2gyemdNREh3RDhy?= =?utf-8?B?OVRDN1N5eE9FdjhzOVNYck9NNjRCTHlkanJ6UkNFS1lkbzdBZGN4TlVhRmJ6?= =?utf-8?B?bGpiYmtoSmQzcHNKUmpGbUR0VzlhZU14TTVqRTRhQS9XSXp0K0lBQlJBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25e22759-7c7f-41b7-bac8-08dc7ffbb971 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 16:23:50.6180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P250MB0298 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/x86/vvc/vvc_alf: fix integer overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: toqsxw@outlook.com: > From: Wu Jianhua > > Some tests fails with certain seeds > > tests/checkasm/checkasm 2325607578 --test=vvc_alf > checkasm: using random seed 2325607578 > AVX2: > vvc_alf_filter_luma_120x20_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x24_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x28_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x32_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x36_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x40_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x44_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x48_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x52_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x56_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x60_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x64_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x68_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x72_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x76_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x80_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x84_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x88_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x92_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x96_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x100_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x104_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x108_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x112_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x116_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x120_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x124_12_avx2 (vvc_alf.c:104) > vvc_alf_filter_luma_120x128_12_avx2 (vvc_alf.c:104) > - vvc_alf.alf_filter [FAILED] > - vvc_alf.alf_classify [OK] > checkasm: 28 of 9216 tests have failed > > Reported-by: James Almer > Signed-off-by: Wu Jianhua > --- > libavcodec/x86/vvc/vvc_alf.asm | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/libavcodec/x86/vvc/vvc_alf.asm b/libavcodec/x86/vvc/vvc_alf.asm > index 71e821c27b..91f158bac9 100644 > --- a/libavcodec/x86/vvc/vvc_alf.asm > +++ b/libavcodec/x86/vvc/vvc_alf.asm > @@ -278,7 +278,9 @@ SECTION .text > psrad m0, SHIFT + 3 > psrad m1, SHIFT + 3 > %%shift_end: > +%if ps == 1 > packssdw m0, m0, m1 > +%endif > %endmacro > > ; FILTER_VB(line) > @@ -356,7 +358,18 @@ SECTION .text > > FILTER_VB xq > > + ; sum += curr > +%if ps == 1 > paddw m0, m2 > +%else > + vpunpcklqdq m11, m2, m2 > + vpunpckhqdq m12, m2, m2 > + vpunpcklwd m11, m11, m14 > + vpunpcklwd m12, m12, m14 > + paddd m0, m11 > + paddd m1, m12 > + packssdw m0, m0, m1 > +%endif > > ; clip to pixel > CLIPW m0, m14, m15 Can this happen with real inputs (like when called from the decoder)? If not, then the test needs to be made more realistic. Anyway, what is the performance impact of this? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".