Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/7] avcodec/mpegvideo: Don't overallocate buffer
Date: Fri, 28 Oct 2022 15:53:12 +0200
Message-ID: <AS8P250MB07448AB1DB2E52C0B9725F338F329@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB07446223CCC8816F450B12AF8F309@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt:
> Only encoders need two sets of int16_t [12][64]
> (one to save the current best state and one for the current
> working state); decoders need only one. This saves 1.5KiB
> per slice context for a decoder.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/mpegvideo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
> index 697438fa6f..0cd7c86ff6 100644
> --- a/libavcodec/mpegvideo.c
> +++ b/libavcodec/mpegvideo.c
> @@ -382,7 +382,7 @@ static int init_duplicate_context(MpegEncContext *s)
>                  return AVERROR(ENOMEM);
>          }
>      }
> -    if (!FF_ALLOCZ_TYPED_ARRAY(s->blocks,  2))
> +    if (!FF_ALLOCZ_TYPED_ARRAY(s->blocks,  1 + s->encoding))
>          return AVERROR(ENOMEM);
>      s->block = s->blocks[0];
>  

Will apply the rest of this patchset tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-10-28 13:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  2:21 [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Don't initialize H264Chroma ctx unnecessarily Andreas Rheinhardt
2022-10-24  2:22 ` [FFmpeg-devel] [PATCH 2/2] configure: Remove unnecessary mpeg[12]video_enc->h263dsp dependencies Andreas Rheinhardt
2022-10-26  2:01 ` [FFmpeg-devel] [PATCH 3/7] avcodec/mpegvideo: Don't overallocate buffer Andreas Rheinhardt
2022-10-28 13:53   ` Andreas Rheinhardt [this message]
2022-10-26  2:01 ` [FFmpeg-devel] [PATCH 4/7] avcodec/mpegvideo: Allocate map and score_map buffers jointly Andreas Rheinhardt
2022-10-26  2:01 ` [FFmpeg-devel] [PATCH 5/7] avcodec/msmpeg4dec: Move setting decode_mb for WMV2 to wmv2dec.c Andreas Rheinhardt
2022-10-26  2:01 ` [FFmpeg-devel] [PATCH 6/7] avcodec/mpegvideo: Remove always-false check Andreas Rheinhardt
2022-10-26  2:01 ` [FFmpeg-devel] [PATCH 7/7] avcodec/mpegvideo: Remove incorrect comment Andreas Rheinhardt
2022-10-26 23:33 ` [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Don't initialize H264Chroma ctx unnecessarily Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB07448AB1DB2E52C0B9725F338F329@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git