From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D6B7744F7A for ; Thu, 12 Jan 2023 04:10:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3451B68BD5D; Thu, 12 Jan 2023 06:10:42 +0200 (EET) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02olkn2061.outbound.protection.outlook.com [40.92.48.61]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E8D4968B5F2 for ; Thu, 12 Jan 2023 06:10:35 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gl1MMzR0TGG5QnAUn5np86YFqyR1LKfbJLwiZwId7tD9cWU3GdkaFfd74IFn1du7XZsdYCFdcwZbudg+TvKFv7vugt+4hx/J15fmnqfO45c5DvdzKE20qUlqPYnn4xxbt80RNaLli3fsBV7tZWAu0/vh1G6rMIEUaNU9iAut4+vNBINcqjQpfaFRDunZkJ53lkKuqfS/E2bwgQhMZU6TFdNh4OEDrqP2IxCALehdj9qpQN78c4/oLTFRg3djNbymCH1GmzwAw7MSO1DfTcsVVVY/nXN9bhMKW6KS7xgCCOj0PwHWN6xosSAsEm+z/+I4oPkiMji6NLkCM4sovQpgFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XJ2gCbV5sSw+3Fmvqb6Vk70PlAnk2q48RTJbvkIDggE=; b=hMeIDux/wYvRfBmytEpIDQSuJJQtCnvVHVOgH3mi3uutKN1cBVK9dNjgGIniHW0UaPnxfd+JmvVGXrL1htEdoWQcbshQ3c9eFA3b8sulE+HaSWjvODeFml9EewYDNflAJszYhX895YfBHr2kNLYkAvORs+BFufh9v3ochKX0yMD3jxb2wSP+AsSILDFEYSAM1BfqmFzmDBzz4B9F1OOuGf0jANcGR9BGlAFq6D6ks6ExqX2UWSNdHObsyIetV1GW35Kf2I0ylD7w+QSRvloOgJEEArXKEEk4PQJuNFoolSCibPc+wVei86myaBGce4mkSvRKHsBceIRNIbXCyvoiVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XJ2gCbV5sSw+3Fmvqb6Vk70PlAnk2q48RTJbvkIDggE=; b=rAY8t9RVg6JxGcdDo10PTrlqCHhW+X47mYcMwdtjmfjUWB/19dbh4MWmVlJ1q1DmDl8ACsS3ZlubGDjX6j5xW1QTBiQaF0fzVOhVc2U6suHqPsQ9vI79Uft5+J2nD2CSTEvb7mwfbTCCp+3DlMPyNuv7IHP4dETxnkaZEVIItcmcYDE1d3U4fFjb22eiQrB6C14lz+S7bI6dqiRdcjjwMeRDqw17h1eFRzmD3/yQ07ojjsHAw+utxxjIigGP7fxNts2OPBG/3T3uRB+7iCtYKlhWipgR1OOgggv2wwzz1F2PTr+vk58qpIojeh+bp+QRCQnwu+5AiC3TNEsHwA8m/w== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU0P250MB0484.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:34c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Thu, 12 Jan 2023 04:10:34 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2%4]) with mapi id 15.20.6002.012; Thu, 12 Jan 2023 04:10:34 +0000 Message-ID: Date: Thu, 12 Jan 2023 05:11:03 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230109071210.1829699-1-haihao.xiang@intel.com> <20230109071210.1829699-4-haihao.xiang@intel.com> From: Andreas Rheinhardt In-Reply-To: <20230109071210.1829699-4-haihao.xiang@intel.com> X-TMN: [t5X6YfhSA20L11SNFPSPJthWIo/GmOrj] X-ClientProxiedBy: FR2P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::17) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <2a8820f1-f2ec-abea-8c97-bd78ff9801a1@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU0P250MB0484:EE_ X-MS-Office365-Filtering-Correlation-Id: eb6aea82-dc09-455c-f0f0-08daf452f3ec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tGbAvVhQbb6etLnMnVH9Gt3XLuqqs/ZzLCmFeW0q00Dpy3T8fvoga/5SaaMhE1uggF1nOQv3xtgXO6EhZW+IqGKnmDAxOfkIz94BMR8Bd0GHGMlsStQ89Erxmi1mKOziRSgkI4uuFs2x330NMzoamN98M8pnHJFqYS2HZ59phL+X9OMwvo/mrgwIWmTPI8Ux1Dko8yn94LvibTM68oXL4ArKPjsY+Et+qxrTyveM27s+/lBRnnRpb65w82Oi6Kpzd6EDQW+wR98JJtS22IuFAHtjwM0bnZL4BasdyXnfmQx04a7Bt3ttvY7KtReswT3rb3mk/HHE4tYemnSIwWn9BU3dNbK+X9FprbbcyCC66Z0e0+Tyr6mqjknIxaLiOxBm40VTvqfgUZHecJuZPd7glfQYib1RqgPFLMSfhxoKV4uYQ8m0bEZ3OAuJbOFTcpbVkj1e931gCrNxdOhgQaTArO1Y9Qc3Px7UYoUMJbFSewwMsbvNM46zo2nkvKhMxnl/CbzATG+k2XKd4in2o9CZBbmqhutRNg9i5LmOl282ep6zuPKCD0eN0eGhOQEeA0yZzJKuEiRM2QDy1mCcjWENar7r2JFS2vtnrkABDiRYemDOyO2b92R35iUPXJcannb6FwX/rDqwqXJpvSI27oQ7zuVjN4rN7yInI6Xlh37yVk4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2NVNjJISXN4M2pZRzlJYmxmYnBmd0hrb2NhaVNyeWNnOEwwNDFNL0ZuMFZ3?= =?utf-8?B?ek14Uy83d2FzVE91Zmhia1NmbDlWbkkrbUVuTU9qay92a2hRMTU0WnBEa0Er?= =?utf-8?B?NHVXMHhyK3RmUGY2R1JsLzFXdGhjQ2s3VWQ4cGdseFNJUHluS0dabHlBVCtz?= =?utf-8?B?WFh1NUI0MUhaanRwQVJUVUVTMmxtQ2dxVjg2anNrUXVDS3ZTSFZ2SWd3WnFJ?= =?utf-8?B?bWNZTHR4dGxUVVppbXVkM0tTbmlZM2JjS2I3MVpUekpQZmZsbWJ5cHluNDJJ?= =?utf-8?B?NC9FN2orMDFNUGhnZlEvTzh5VC9hMVVuYjZOelplUW5ZSjJ1TTM3WUxFSnNV?= =?utf-8?B?UUptNG8xTERzWkI4UXRmblNpYVg4U0tBdHF0dUZwejNCd1JQTlVqQncrc0Jm?= =?utf-8?B?Zmo4OU5KWmsvc0NROE0xWngwaFNaRkRrRnI3NEgwZktiREpQdkZHRzhLeUpt?= =?utf-8?B?ZS8wY0VyWjVxVG9CT2hlNXg5RUFOWmEvWDJxdlJXcnJJUWdwMUMxemFSUVl2?= =?utf-8?B?bUlhZGlTUEYvS3ZuU0pINUhFT3JjOUJsQWZSd2NuVTNrajlrTDBSSVgyS282?= =?utf-8?B?YSs5OEpUS1B0eXNSdTk1NlVyNG5HeDFCYzRzSGFFVit2ZVAvelVBQjZ3VlNN?= =?utf-8?B?Y1dtNmJXOVQ2TjBkMmd6aWtoZWhlR1g1dCtNODkxMStwSFo0SEtzTUdsMTRG?= =?utf-8?B?RUp5YnpoV1ZHc0hnSlVjdmZhOCtOZ3h0TjJQRDdyM05KcTJxZkVZNitJR1dx?= =?utf-8?B?SjlXMy9wRVJrbzVEdUVGVGE2Qko1ZU85bzNNdWVuVVE0QkVMZUdDQUdCL28w?= =?utf-8?B?R3BuTzlEbmp4OFpqbDlLcktGYm5OZEdoWjFDeTUyUVlXQ2xSL0RBbEE0UDgx?= =?utf-8?B?YjkxeG5CeHB2U1J1UmxnTWExdkJxKzNYQlBjYlVXSlBQQzNhb2NWd2g2T05a?= =?utf-8?B?aHFnenJSc2J5YjhBWU4rYjAwdmw1TVc4S0djVmxkWlZ4bzdMQStqUXUzbVFu?= =?utf-8?B?bGpuSDFVRHJkNlN3V1RoT1B2OG5mUWs4UEhRNXRVakN4WFJqOHdNQ1QxWFRF?= =?utf-8?B?R0ZBZlovSkY3UFBoSzFyblk3c3VXcW54WFB2UncyZkFaVW1Tbi9LaUFWZVVa?= =?utf-8?B?dTRJOGdzWW1weDdUYjNzdjVJUStIMWpqTVF6blJZMTZoVS9xSHpjUWxQSG5q?= =?utf-8?B?YzQydkFzYTM1OWpQYlFSS2M5UUFLZEt3MjVvQlI0U3hIRjZBRUUvVXZoZWpY?= =?utf-8?B?d0NCc09mNDVqVnk4ZkwveVZwQ1V1TGpoVm55T0J5THl0c0RybmFSRW5BdzRC?= =?utf-8?B?VS94UWJHVWFDeUFTS0RFanZETkZhblNMUkFKS2h6eGtKODRqL3U2M2p1Vm44?= =?utf-8?B?bzdtMlJ2M0lPTGhuazdKOTZObXhSNlRVZzVsS0REOXptRHJLMWViVmg4K09p?= =?utf-8?B?MXVEOFlHc1ZOdlQzemF2MzNKbVE3MDdmM2Fya1JHMHA0clZKTmdmK0pXUXFp?= =?utf-8?B?MkRod3NYUFlpUnZKUzZqTktlVHpHNTFJK0U4ZDRGSFc5My80Qlk3RG1DandW?= =?utf-8?B?b0xySk8wWldmQjlqenFNQ3pzajFsWUs4Q2tmUUtwYlNuTGpyOHBoM1BiMndz?= =?utf-8?B?WmpkTlRYM0NhWkYwaHNSUzl1YXpDa3NJbW5sZTZJZnBIS1ViTWZRSVJ5ZElh?= =?utf-8?B?MDBHTEIwRjBBOTI1Wnc1alk3M2Z0c01iZXA4T2xuQU5CdEZQMkZXazVsdEgy?= =?utf-8?Q?6yP3a2UnFE+LRsj25I=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb6aea82-dc09-455c-f0f0-08daf452f3ec X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 04:10:34.5264 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P250MB0484 Subject: Re: [FFmpeg-devel] [PATCH 4/8] lavfi/vf_vpp_qsv: add vpp_preinit callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Xiang, Haihao: > From: Haihao Xiang > > Set the expected default value for options in this callback, hence we > have the right values even if these options are not included in the > option arrray. > > This is in preparation for reusing the code for other QSV filters. > > Signed-off-by: Haihao Xiang > --- > libavfilter/vf_vpp_qsv.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/libavfilter/vf_vpp_qsv.c b/libavfilter/vf_vpp_qsv.c > index cf11cd7fdc..2a7b06fa33 100644 > --- a/libavfilter/vf_vpp_qsv.c > +++ b/libavfilter/vf_vpp_qsv.c > @@ -259,6 +259,19 @@ release: > return ret; > } > > +static av_cold int vpp_preinit(AVFilterContext *ctx) > +{ > + VPPContext *vpp = ctx->priv; > + /* For AV_OPT_TYPE_STRING options, NULL is handled in other way so > + * we needn't set default value here > + */ > + vpp->saturation = 1.0; > + vpp->contrast = 1.0; > + vpp->transpose = -1; > + > + return 0; > +} > + > static av_cold int vpp_init(AVFilterContext *ctx) > { > VPPContext *vpp = ctx->priv; > @@ -683,6 +696,7 @@ const AVFilter ff_vf_vpp_qsv = { > .name = "vpp_qsv", > .description = NULL_IF_CONFIG_SMALL("Quick Sync Video VPP."), > .priv_size = sizeof(VPPContext), > + .preinit = vpp_preinit, > .init = vpp_init, > .uninit = vpp_uninit, > FILTER_INPUTS(vpp_inputs), I do not get the point of this at all: None of these options are of type AV_OPT_TYPE_STRING. You are merely setting the default values that av_opt_set_defaults() would set lateron anyway. I also fail to see how this would facilitate reusing this code for other QSV filters. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".