From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 33AD34521F for ; Fri, 13 Jan 2023 07:08:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7202068B37A; Fri, 13 Jan 2023 09:08:46 +0200 (EET) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02olkn2046.outbound.protection.outlook.com [40.92.50.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07E40680C4A for ; Fri, 13 Jan 2023 09:08:39 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C57Ay1gsJafr388GVqvwrdYHVjDdQk5eGVmPev5D2abJ/b3V+eKteKFAhE0hkDS+kjUx3BsFTkn9ehrLreRh1rxcoz3+vDjZceJlbkVDTE9xmf5cdqoVL+7Z3JDFoybtZujNnDhYaDpW//rn9jG8I/ovLMUzFRixlqZcTo2m0W8MfIHLB3Iz+lRZ8NauaZE/VXz8wr/g2I5Tbh7QlMjk1m4UAqDYD1UP1jESfXktu2NQDcVrUjZx1ZA245ZWlZ396orNUPJFx1en63J6kfHobYhYup+9Ab8HDMvU1wYaJzpXuFBuq35kaziEtcZw505ziQVYuIFQm5NeHH131NW5dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mrChjFV5On1FBX6Dg34M4tG4M1mbHUzCoEwMMueLAtU=; b=fLAbzLM2I+opzE9xVNl1wbc7XBjY63yIeqAw/G9PFWZUIwi621569wj+NcJSI4HA38OjxoWdhKhH31GaNttbq8bXdaP2jrPSOhVIYHsJ30jpgBQSvbozPzmiOgQufJJaECpCopnoQZ7Gr23bZnePMAINK61epOk3GSVZfNHNkgABYrheb4NN7FUB5dYBib6kUdgxHd94FNbcAGDmmgRcVxX8HaqyovaeXRexp9p4J4L/VqLwUV/QeujCsxOG1Rv5vEcrCi2YvlLMqYlxPf0Gd0WF7JF1cFBrOtM9Wa0MBwFWW7OrPB4FQNKAYp6mwZMsM6077P5qxGzPIa3Z2Vy/hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mrChjFV5On1FBX6Dg34M4tG4M1mbHUzCoEwMMueLAtU=; b=qVRqWRI/7KVHW3gKsTxobBKWjNdMtR474pSzYqMiFwejBl8peLlTt1lJp2qJM7pQSKKAWdYTNMP5vjmIbrY4XcYhfe60ci2UdR4M8wkut+VWTtJJpXa/dkJaZaCrzz4W+5pDK4869SO7yZVfcOEHCKs8k4eYxiiSfWbQSnDcH2ZEYQSOKO3BqqiIQi1CY98r8VJpGm6g67gz8LKGww+J6hEMamzAHn3LTss+K8hm978iyFWaOodhVYJtr/YXEUudjZvkr+W6XtikdDImQ1ETz7LRh3LQ1kNJEBsbx4T/Tl6FQCsz2aI9tbYDXtwz9dwU2e3qsdA7G9ijVbaryeq7tQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS4P250MB0488.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4b7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 07:08:37 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::c37:cabe:316a:60b2%4]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 07:08:37 +0000 Message-ID: Date: Fri, 13 Jan 2023 08:09:05 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230112222326.22018-1-jamrial@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20230112222326.22018-1-jamrial@gmail.com> X-TMN: [5nWutVJ37ejA6jt7NpEgeNcIqqICg3TX] X-ClientProxiedBy: ZR0P278CA0168.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::23) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <3b5c31b6-dcaa-bfad-1621-021bcbad3e79@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS4P250MB0488:EE_ X-MS-Office365-Filtering-Correlation-Id: 96ce5653-8527-4c7c-d1cf-08daf534fde2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fkkfIxp/a3BA8iTlE4hX0+qv8GheSvBKRduTffDz1/Ckgb6qIRGvCZsgr1pm9mQbsROjEM2QOTp2DlSzcChB21T0NVj7A+CxVTk4a9UkRPnkO2g4vI+G0Thp8Qdam4AKmYda3wFnWiT9XxWg1fLju5yskkkvlfWJTZ5oJMURb7rOcPcTn0GEv07zda3F+L5xch2HhI9hWvqJU8Yoa/15kG0HXHQTzdCEMWAHg2efY3GDOp9kEuLhtfNzT/SjHJc9h5ICikZEw8ZQmOoIR7zAOHQgUtmOhIZRNx1E7aXL7QRoj/0Ybpl7mQRapsrEmIoZ0tqniNJbuFM2btFklZBUM4Qt2AJNW3uaideebBBx2cF2TKKhbyiBV62i+ZiXIvqErCuSDIv1UlxXP6lT84auVIB9n2ReA8tjr2rM0qlGIl+x+QYiRuf13kZptndj56QRJajaMhQstz4N2GQz17O5XuywLnPAl6/iuEZZs5v7YQAncDEIWP/BOMMC8R4bdl0t5kQZsm6q2MCzy2HNV9JKc2nTYYdzVq1GL70xx5FZH9rbW4r7y2ZEIP1NJYY5SbN2RTlMgagzeQ+2apjGFkVa7l0g91FZFmXrv9ouGzk1gpzPVCXaKcEDSyFxVMSeH8aek6Wsuh4hAoYKVvuuCeLWZg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjNUZVBJcFlJbTRSVk5HSjN1YS9ldEliZHV4WStWaTluYzhHOTNncjdndEJH?= =?utf-8?B?eUtGNzd4UmFxWjRxQWpPdnVXaThhdHNUelh3cTgvMk9EN1NPejhkbkpia0Vx?= =?utf-8?B?UjhMb2trdC9ZSjZhZWxqbmphM1NQemJHUHM5c2VEOHVaMngwQjNhWVQvOXhP?= =?utf-8?B?S2ZDa3JPWDVuTXJhRWFWcVpqZFpvbC9CclZMaXkxR2FvSTA5RXpFclM2ekdt?= =?utf-8?B?SFF6eVlPcXVGdXpiTjhEU21mVWdPcHBxQTdvL1FpbmtpNldvUlg3dzZsNC82?= =?utf-8?B?cWFxZkVMVU5BK2JnLy9EOU93R2RtbVFDTFUwMWFJN3BuVWd4eDRqZklWbkI1?= =?utf-8?B?ODQ1eEdKOC85M0JWQmdSZnBTaE5uQ1N4OE1GQlVSYndmTlZWZEpnRWdkY2Zs?= =?utf-8?B?czV2c1VzMmlTUis5VXFhN2xtUEpEZHhUekZRM2VJQXFWRzlMekdKdjM3eG1j?= =?utf-8?B?V0Q2UjRIR29TdjdVWHJaSXU5UHEzaThpakhSL2QyV0x6TGJCeE1DMURGMmFX?= =?utf-8?B?VVRQd0NoL3lERW52UDYwR0hrMW5EZXF5N0Rrd3hPTWRkZU1kbUFwdzZCWUZl?= =?utf-8?B?MnZhb1BNU3V2c1dLUkhrNTlobjJIRHVTSFVkWkRhSGVPMnZCNEZaMjlEOXJ6?= =?utf-8?B?eXU1LzhLbTNRbDIzZDR6bzBrSlg1MHBQMmZwWThFbFd5Yzd5ZVBqdGlwWFdz?= =?utf-8?B?ZlpFV2NpR0laV2lka25xSDVIUTNzMmFYSFd1ZlZJSGF3bms5cGlLcWkxWTBF?= =?utf-8?B?WTUwdkNzREhva2tqMUUxUlZoeVlISFJtR3JXOFAvdmFmd2t0QXhOSnY1b2RB?= =?utf-8?B?aCsvOHlOcVIwS2NKYjgzOVlXTEFkMWRLUytWM09uZlhPcnNRR1VNaUpTVWdJ?= =?utf-8?B?WlZPbTlnVUlKbG9tSDQxeTRNUXU3VWpWUDFVZ3REcDRpcW1ibVRFQmI5MG92?= =?utf-8?B?U3R4YVFQUG8yRDJ5Ny9Oa3RlU3g4TUNxSm9tOTV0MzRldjlHelhQbGZDbnNr?= =?utf-8?B?Q1dCV2k4U1ZHV0dkQkNjNklnRnFmV0c3aXhZYUwrL0Jxd0xzR2M3NTE4NUh0?= =?utf-8?B?Rjl3bjROQkNERjRDVEM3a0pWM2swakNxYjRUelNJd01jS1JUek5YcjBkaU8z?= =?utf-8?B?N0QxS1Z6NnU1VUxGQUJlUGhDdkZxYy9FWnMyMVNTNzEwRmMyVjV0UmpIQ1Vy?= =?utf-8?B?QXlqaEZmQW95aGpjNVMvMTZpMStyTE5oYnNKbmFiSmk4MDBpNW9WczdDdzdo?= =?utf-8?B?eDI1eUdRT2d3VjRKZDZYRWpaWUQraUpYZUp6bUVpUC9tSDdHNk9DSmE3SG0y?= =?utf-8?B?N1FjeFBIeXRmcWVydEdGWmNlUE1XL2owdEI5OGxDWGZONW1DcGY3QlJFbkdL?= =?utf-8?B?dGdma3BZNlFFNE52OVRKdjJMWFlPbmpyR2JhRHBuS2VFQURJYzRJd0JldDMy?= =?utf-8?B?QUdJOTQ3N01PTkV1WWRjZU16bTBiSjc2MFdvNlVrNmZpejhIa2VHVFhlYWxK?= =?utf-8?B?ZXRZVTJYekxPOU51ZktOVU5HSUNtM1RLSFdYdzNrT3NMUWQ5Vm9ZL3hLSFJF?= =?utf-8?B?aFlVU3ZSVGJoc2FLTlBNSEh0S0xCRjdaUWFDVFo0NmwzaTYyZW1hQ09oT0x3?= =?utf-8?B?QVNFWVZLazBQSWRxS2x0QW90MC9wMVhzUStLck1yTVE5S2FId2tDM0tKbVBF?= =?utf-8?B?bXMwak1OS2lHV0krb0piY0xVM2ZzeFQ5MmxzOUt3bHYzRzhsOHBrQVIwbUVw?= =?utf-8?Q?DaV/xrMsmegkXMSNk8=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96ce5653-8527-4c7c-d1cf-08daf534fde2 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 07:08:37.5763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P250MB0488 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ac3dec: don't export Matrix Encoding side data when no such info is coded X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > No point inserting the side data to all frames just to say there's no > coded matrix encoding. > > Signed-off-by: James Almer > --- > libavcodec/ac3dec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c > index 0b120e6140..7a84f3c85d 100644 > --- a/libavcodec/ac3dec.c > +++ b/libavcodec/ac3dec.c > @@ -1819,7 +1819,8 @@ skip: > break; > } > } > - if ((ret = ff_side_data_update_matrix_encoding(frame, matrix_encoding)) < 0) > + if (matrix_encoding != AV_MATRIX_ENCODING_NONE && > + (ret = ff_side_data_update_matrix_encoding(frame, matrix_encoding)) < 0) > return ret; > > /* AVDownmixInfo */ If the preceding frame had a nontrivial matrix encoding, will users think that the matrix encoding from the last frame still persists? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".