From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: Paul B Mahol <onemda@gmail.com>
Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter
Date: Thu, 29 Jun 2023 21:57:48 +0200
Message-ID: <AS8P250MB07448856AB10D1480FDC916D8F25A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAPYw7P7Ap6__px=6GQcShyvrSk86GH2LhUHHe-0ToZ=DXBtKPg@mail.gmail.com>
Paul B Mahol:
> On Thu, Jun 29, 2023 at 9:35 PM Andreas Rheinhardt <
> andreas.rheinhardt@outlook.com> wrote:
>
>> Paul B Mahol:
>>> On Thu, Jun 29, 2023 at 8:18 PM Andreas Rheinhardt <
>>> andreas.rheinhardt@outlook.com> wrote:
>>>
>>>> The discrepancy between the definition and the declaration
>>>> in allfilters.c is actually UB.
>>>>
>>>
>>> I get no such message with ubsan.
>>>
>>
>> UBSan is a runtime UB-detector, not a compile-time UB detector.
>> The earlier code is UB because of 6.2.7 (2) of C11: "All declarations
>> that refer to the same object or function shall have compatible type;
>> otherwise, the behavior is undefined." A type and its const-qualified
>> type are not compatible.
>>
>
> This is so minor, that it is fully irrelevant.
>
The actual advantage of these patches is that the objects can be put
into read-only memory (.data.rel.ro in elf).
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-29 19:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 18:17 [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h266: Remove double ; Andreas Rheinhardt
2023-06-29 18:18 ` James Almer
2023-06-29 18:20 ` Andreas Rheinhardt
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 2/4] avcodec/vvc_parser: Constify parser Andreas Rheinhardt
2023-06-29 18:19 ` James Almer
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_ccrepack: Constify filter Andreas Rheinhardt
2023-06-29 18:19 ` James Almer
2023-06-29 19:18 ` Paul B Mahol
2023-06-29 19:36 ` Andreas Rheinhardt
2023-06-29 19:42 ` Paul B Mahol
2023-06-29 19:51 ` James Almer
2023-06-29 19:57 ` Andreas Rheinhardt [this message]
2023-07-01 12:01 ` Rémi Denis-Courmont
2023-06-29 18:19 ` [FFmpeg-devel] [PATCH 4/4] avformat/ac4dec: Constify demuxer Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07448856AB10D1480FDC916D8F25A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=onemda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git