[FFmpeg-devel] [PATCH] avfilter/vf_v360: Add assert to suppress Coverity false positives

[FFmpeg-devel] [PATCH] avfilter/vf_v360: Add assert to suppress Coverity false positives

[Andreas Rheinhardt]

Should fix many Coverity false positives, namely #1457947-#1457994
as well as #1461195-#146210.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_v360.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c
index 5ea6e0d865..299dbe9ff5 100644
--- a/libavfilter/vf_v360.c
+++ b/libavfilter/vf_v360.c
@@ -286,6 +286,8 @@ static int remap##ws##_##bits##bit_slice(AVFilterContext *ctx, void *arg, int jo
     const AVFrame *in = td->in;                                                                            \
     AVFrame *out = td->out;                                                                                \
                                                                                                            \
+    av_assert1(s->nb_planes <= AV_VIDEO_MAX_PLANES);                                                       \
+                                                                                                           \
     for (int stereo = 0; stereo < 1 + s->out_stereo > STEREO_2D; stereo++) {                               \
         for (int plane = 0; plane < s->nb_planes; plane++) {                                               \
             const unsigned map = s->map[plane];                                                            \
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/vf_v360: Add assert to suppress Coverity false positives

[Andreas Rheinhardt]

Andreas Rheinhardt:
> Should fix many Coverity false positives, namely #1457947-#1457994
> as well as #1461195-#146210.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavfilter/vf_v360.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c
> index 5ea6e0d865..299dbe9ff5 100644
> --- a/libavfilter/vf_v360.c
> +++ b/libavfilter/vf_v360.c
> @@ -286,6 +286,8 @@ static int remap##ws##_##bits##bit_slice(AVFilterContext *ctx, void *arg, int jo
>      const AVFrame *in = td->in;                                                                            \
>      AVFrame *out = td->out;                                                                                \
>                                                                                                             \
> +    av_assert1(s->nb_planes <= AV_VIDEO_MAX_PLANES);                                                       \
> +                                                                                                           \
>      for (int stereo = 0; stereo < 1 + s->out_stereo > STEREO_2D; stereo++) {                               \
>          for (int plane = 0; plane < s->nb_planes; plane++) {                                               \
>              const unsigned map = s->map[plane];                                                            \

Will apply this patch tomorrow unless there are objections.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".