From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 50BE147EF0 for ; Thu, 29 Feb 2024 12:48:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 181F268D157; Thu, 29 Feb 2024 14:48:19 +0200 (EET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04olkn2042.outbound.protection.outlook.com [40.92.74.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3089C68CFE3 for ; Thu, 29 Feb 2024 14:48:12 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9xRNF6ns/zAR4ZRVOn9LN28N7hLHLnwOMINQ0YDr81W/YX9ty2Y8RJN+hsicIaBHQaOHw5P6ITGAdqb8aMt6Tt+ulGRsGjVZuDt3owOrXgNQurU8C1YKEWy7SpqRQ16ifPPMqUd3sPLaII56IWKq2BRR6fADctpT3OjrZil4L1f88TUvxm3WiaMpvrHJiQ5rIbjPAJsjg+0xceGZqlHdVF4d5eJiR9fv5D/3VSOdaJASfd97OfNfbX1FUZaC7DHXmT5j5aBsf5vgeNaEP5xiTUy37dMVN5wO+KultQBOA9uprfBco4Pv/yxtiee2AT9F1DchUMoCJeXFZI28V/D9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eMkB2g0qS4g7trtynt/vWLPQcqV4XzfMxKQyW4mgSfg=; b=UITAVxLDmdptlJXf0Je0Dy4XJKccOXc22dAVDh0is7C4MT6LIQhlAPdNE7Y1gL5+WdOUU1Pm2dX+W1z+csxGeXD+7Ffs+jzcnHUIAdZDgVZzbmGegXuFXnvRDxSdsWVA97frVpHmF7SFnAtjUi0SS4iy8RWARar6IqHKf5jPMVuv13H7BhBka2WrA0m7Q2nGI9UGyPe6EG+9ON7Vykm2rVzDkxxFC96rbxUCWKrABqCZqkym3gIG5s6be1dgpL93W125S3REEvZHKWX6+y/cLA5GKEHZL5INRA6kRutR0Spzzst+ebDWA235N/lo7/MOEd0iTuvwOwy+LTRn35rG/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eMkB2g0qS4g7trtynt/vWLPQcqV4XzfMxKQyW4mgSfg=; b=RJvdjzUDsxWIYVoVgcj51JsT9N3ocEna2uyG0i5YtLQV4KhPuuJQP/brksFWSHLqdxv3AaCl90dPFLlaHxRVepzK2XdxE8KX4hap3N8l8ZQyXF+5HhDLwo0hImufzIwhhy4WR6fSBR50receMif7Qx7ZSNZ9CclVxg1epM6qpBzNZkEEUklb1u7w4FkrKgGK15pyHXW6+CF0JsZsBkxfhoaVXTC5IXkAO1zk50psTZTNSSsgyxWtCZUEcmAgyFL0iF5kj5iDRU5KdmaPpTSJCxZjtMw2xDGyJhT2welHLPVbfYI6tg+bGfpH9pRISWDHVdPYmwfgijZBDRxJe1T7JQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PRAP250MB0513.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:290::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Thu, 29 Feb 2024 12:48:10 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7316.023; Thu, 29 Feb 2024 12:48:10 +0000 Message-ID: Date: Thu, 29 Feb 2024 13:50:09 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240229123340.49055-2-ffmpeg@haasn.xyz> <20240229134338.GB51236@haasn.xyz> From: Andreas Rheinhardt In-Reply-To: <20240229134338.GB51236@haasn.xyz> X-TMN: [kEJJw3dMFYVK1fRhOvD+960wcGQjwRMEH+U7Rcp7+QU=] X-ClientProxiedBy: ZR0P278CA0185.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::18) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <15007d4c-43df-480c-b691-adc0a97ef708@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PRAP250MB0513:EE_ X-MS-Office365-Filtering-Correlation-Id: 53d99bce-49e9-4b49-5585-08dc3924af66 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bT/YK/Ls3cbbOncT/S7UhWLc32yL1OgQos229qLfYft237j4SE9JgeTMUFM7CwUf1pcpntF5cBDfpX7XP6GFtZ+N1FUkrueXsWaKPpGhoAAdwd/k2pao2v0gMIE74UkXr20/tEYEngSxJ2VjKbVGETlyz+QEk1MQF3mnTuamar5Ddey9YnelZMJKYH5uve9mjqwIIgjm1siEMorXMHS6Iu/VgFY1R5jdO2MiqaA9tglx66Kdh98SE707Ja24Yl1I+Gw8zRUadZPEgLX4JwedjUEs8iqFeQHROkz9jpAY5NQm0iYKKfLWyBlisIxwDMc0+hN7emxLoSqX0pvS7D9pEI9ATCBj+Cx5r7/KIYkV2Mdddsvxhcc+K5a1U2S+UJwZygJwpsSEFhQLi0pR4d+KNgSjon0VvKPSTLamKVlOOwG8FYpxE+i4lafe3qmvDGo4lFDq5yYLQOxrcVyPy1ZjB43MDUhOV3KkFMPf8bu/+2y22CRhk/ab5rTbF6fBMYjTlPlJ/2bNm5xPvXAQSlrQDTn4xDg7sxt1bgRy8yLoNY+nWuBUNF8YN7uAh/0xZRj0 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWRKTWdPelhpMlVRYzFDeTh6VXFHeTJpdmcyU2RxR0l5elY3MWNHeHFXTEdY?= =?utf-8?B?U0NzejdaSjNaQk9Jb3Y0NmNJc2RUTUlNRGdzVmZQOGFRV3dvelRYMGNPNE1z?= =?utf-8?B?WkgzSGNhR3RaZ2FhaTlzYnZoS0tvS3NZSHhuSjhhVFBhQVZFalZEaENrWXNp?= =?utf-8?B?VUZ2TGNRS2x1Y1AwLzBKaVZkVzdjaW82YUZqVkQ4Nk5PaE1HRjB4dURDMmZh?= =?utf-8?B?MUE0YmZlMkZPQmFzZ24vVzdhd0lBTWlMSC9mLy9Md0Y5Ty9TTTJGOWhkWDRC?= =?utf-8?B?OC8ybVIrTGRLdzJwbFU4OUt6WGhtQ1VSeWxGNloxTlRFV2x3ak9YUmVlWFRS?= =?utf-8?B?elMxK25RM0MrN2pIRGZ2clV1M0FqZG1YQlNiZlhjL2IwNDk2UkpTQ04xbE1x?= =?utf-8?B?dWFjWmlTSVpPMmRBcTYwejhsN0NhZmRLVmxta2toSWVpamo5Rkt4aE11NlZY?= =?utf-8?B?bGsrM082d3pwVUY2QnFWOWFweXJmU0VmckRIVG9nbXhUMU9WWFRvNmZmemN2?= =?utf-8?B?RERuckZ4TytRRFRHdmhDYTJHV1dxRCt0L2d4T0h3NXJ1OGF1c1B1YnpMbjlz?= =?utf-8?B?aVhqdHI4aC9wVWlVU092eEVhVmdWTURNZ2JPYjM2Sm1nVE80NnhZR0QzeXlR?= =?utf-8?B?YVhxVEZpNTBqNEluNFh5a2U2dVFNNFV0bUxjVTFCMEo2YWFJRGFMU3AvNVdH?= =?utf-8?B?bE5VVnhaMGV3WFFyRVpLb0NtMG1mOXBBa2NaQTZQd29RNDQ4VEc4U2RTS3k0?= =?utf-8?B?QVQ4VjVTYWZPRG9SNDZMYkZKclF5SGE4RFVOQnRVaHRqemN2OEZWbVorL3lm?= =?utf-8?B?U1M4enVNUGhaTTk1ZGhRMkFNWFYyWFVwcVVSSWRlOEkzZ0xRWHF0SStSdmoy?= =?utf-8?B?bFI4TktsbTlVOHE0bjdKRUZmeFJPdTVmek5EMFdMNUJQUlRYU1hlSnFOYVdQ?= =?utf-8?B?bmkrQkw3bFVodWc2OUVDVkhZbzd4ZFIzenZ2MnV1RGwzd0FFS1M3UVdlOWNs?= =?utf-8?B?cWVWVkE1dFZPZThJc1FaN3hLSjBNMk5lQW5iZWE5aEVmOGdtVVhWakJxZE5v?= =?utf-8?B?ckdvWFZrZC90WVNtOSs0eFE1QnFIc1RiSWgwVnNubU4zZW5FekdqTGV5U2pT?= =?utf-8?B?MFJRUWpyWERqRjVVVGE2NndRTXc4WmZLY3lSV1RpYytQaE9JSEx3NVdNUGVl?= =?utf-8?B?ak1jYmkxY3NobjU5YysyTi8rY1BNQ3ByUHVFRnJYVTNFTm40L3hlaDhPOEhD?= =?utf-8?B?TjFIOHhrM3VMaXJESGREaHJSMnBKa294MVp5cnF5Sy9ybVVKZmMrUXI1L2pt?= =?utf-8?B?WG5TSnkyYkdLYkRzYWRKR1RUUllzVnpuTFNKbDd1czdubHlxdU10ckNuaEtw?= =?utf-8?B?SHpzUVNEK3oyTi9lVHRnU2pxSm5yamsvbFl0MTREYWhvVkYyWFhkNzNjVkd3?= =?utf-8?B?elI3QnhvOUgzWWFJMkkyalBMWk5EczNOTUhQNlJHaENwRWlZWG8xUXJzb2d2?= =?utf-8?B?TVNLeis5UFl1SmNKdm41RTIwRFBXM0dCOG5aS2R6MWJxYm5QRXRBdStWQ0dt?= =?utf-8?B?US9nZ0dvaUtOaE05SVJjWUp3d2gvSWNuT05tS1kyNURaN01ZblBXdjBpckRl?= =?utf-8?B?M0ZGWTR2eklyT05HMnNlRUNHU0tWVHRWNW1teTljVnp2U3AvSnZlMDJGY0lE?= =?utf-8?B?SlVFclZ4RzRvSy9PR3N0ekEwS2IwS2l2NHhvdFR6NzZMVnZFUFlLSERBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53d99bce-49e9-4b49-5585-08dc3924af66 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 12:48:10.6177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAP250MB0513 Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM film grain synthesis X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Niklas Haas: > On Thu, 29 Feb 2024 13:33:36 +0100 Niklas Haas wrote: >> +// Symbols that do not depend on bit depth >> +#ifndef GRAIN_WIDTH >> +# define GRAIN_WIDTH 82 >> +# define GRAIN_HEIGHT 73 >> +# define SUB_GRAIN_WIDTH 44 >> +# define SUB_GRAIN_HEIGHT 38 >> +# define FG_BLOCK_SIZE 32 >> +#endif > > Decided to move these out of this template as well. > > At what point would it be cleaner to introduce an > just for these shared helpers / definitions > live inside? We will never have a public header (corresponding to <> instead of "") for internal helpers. Whether this should be put in a header of its own depends upon how many different files use it. If the answer is "one" (as it seems to be now), then there is no need for a header. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".