From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM film grain synthesis
Date: Thu, 29 Feb 2024 13:50:09 +0100
Message-ID: <AS8P250MB07448628B8D863F9BCE53E5F8F5F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240229134338.GB51236@haasn.xyz>
Niklas Haas:
> On Thu, 29 Feb 2024 13:33:36 +0100 Niklas Haas <ffmpeg@haasn.xyz> wrote:
>> +// Symbols that do not depend on bit depth
>> +#ifndef GRAIN_WIDTH
>> +# define GRAIN_WIDTH 82
>> +# define GRAIN_HEIGHT 73
>> +# define SUB_GRAIN_WIDTH 44
>> +# define SUB_GRAIN_HEIGHT 38
>> +# define FG_BLOCK_SIZE 32
>> +#endif
>
> Decided to move these out of this template as well.
>
> At what point would it be cleaner to introduce an
> <aom_film_grain_internal.h> just for these shared helpers / definitions
> live inside?
We will never have a public header (corresponding to <> instead of "")
for internal helpers.
Whether this should be put in a header of its own depends upon how many
different files use it. If the answer is "one" (as it seems to be now),
then there is no need for a header.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-29 12:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 12:33 Niklas Haas
2024-02-29 12:33 ` [FFmpeg-devel] [PATCH v2 2/4] avcodec/aom_film_grain: implement AFGS1 Niklas Haas
2024-02-29 12:33 ` [FFmpeg-devel] [PATCH v2 3/4] avcodec/h2645_sei: decode AFGS1 T.35 SEI Niklas Haas
2024-02-29 12:33 ` [FFmpeg-devel] [PATCH v2 4/4] avcodec/hevcdec: apply AOM film grain synthesis Niklas Haas
2024-02-29 12:43 ` [FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add " Niklas Haas
2024-02-29 12:50 ` Andreas Rheinhardt [this message]
2024-03-08 13:21 Niklas Haas
2024-03-08 13:31 ` James Almer
2024-03-08 13:44 ` Niklas Haas
2024-03-11 22:32 ` Mark Thompson
2024-03-12 21:40 ` Niklas Haas
2024-03-15 10:17 ` Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07448628B8D863F9BCE53E5F8F5F2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git