From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] configure: Remove av_restrict
Date: Fri, 15 Mar 2024 12:45:26 +0100
Message-ID: <AS8P250MB0744852A9813495C9D05338E8F282@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <403d1cd2-37a-773d-1c1e-dbb03b7d36a@martin.st>
Martin Storsjö:
> On Sun, 10 Mar 2024, Andreas Rheinhardt wrote:
>
>> All versions of MSVC that support C11 (namely >= v19.27)
>> also support the restrict keyword, therefore av_restrict
>> is no longer necessary since 75697836b1db3e0f0a3b7061be6be28d00c675a0.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>> Untested except via godbolt.
>> MSVC actually uses it for optimizations: https://godbolt.org/z/3EzPnff9T
>
> This change looks good overall, thanks! Fate runs successfully both with
> an old version of MSVC targeting x86_64 and a new one targeting aarch64.
>
> However, MSVC 19.27 (aka 2019 16.7) can't successfully build ffmpeg at
> the moment - it regressed in ec1b6e0cd404b2f7f4d202802b1c0a40d52fc9b0.
> Now building fails with this error:
>
> src/libavcodec/ccaption_dec.c(186): error C2143: syntax error: missing
> ')' before 'sizeof'
> src/libavcodec/ccaption_dec.c(186): error C2143: syntax error: missing
> '{' before 'sizeof'
> src/libavcodec/ccaption_dec.c(186): error C2059: syntax error: 'sizeof'
>
> This issue is not present with the following version, MSVC 2019 16.8
> (aka 19.28) though.
>
Testing with Godbolt shows that MSVC 19.27 does not support
_Static_assert. But it supports static_assert (its synonym defined in
assert.h). So this is easy to fix.
>> Btw: The block about __declspec(restrict) was always unneeded
>> for FFmpeg due to 17fad33f81c7e9787fcdc17934fc1eee6c6aa4bf.
>> It came from Libav commit 17fad33f81c7e9787fcdc17934fc1eee6c6aa4bf.
>
> This looks like a copypaste typo, I presume the latter should have been
> 0cff125200ab53fa3ae70d85b4f614f269fe3426. (The code it changed
> originated in dfa559bcbd41397b3408c59d016631c7c65e320f in libav.)
>
Correct.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-15 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 16:24 Andreas Rheinhardt
2024-03-15 9:33 ` Martin Storsjö
2024-03-15 11:45 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB0744852A9813495C9D05338E8F282@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git