From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 891D947582 for ; Tue, 12 Sep 2023 07:43:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F30068C968; Tue, 12 Sep 2023 10:43:32 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2022.outbound.protection.outlook.com [40.92.90.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2088768C8B3 for ; Tue, 12 Sep 2023 10:43:26 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VzOd6Hejb81kMZrwgNwKkOBwZvLIh1Z4OFQYkDQPtS/GPxfP+sYrADJ8tVbygP+EMPLTVr/vCZyv0b89M1OUCyudT/liF9xXJGL1YrVrWIAdSpp3GoxPpBL1D2QdikJs0rDPivXgQ57kVhLeZmnbVdV31JsYovghrbWIhdNyy9+crtP/Nl2zkmp3NfpDRBGrGfayOQ1lQdb6jxr7rwjQldOKFneqwv9m/MSWnWgDjpMr5StbebrK+lyXsvOrpJTYB199uw1W15bo7rV7MndmmVvMnKK0UAlWz7zQYhBCb553Om7HFLEdASLauWRsBU+qR8VGYI75Te/CzLRQZUc4xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VnhTkyb1zKNFKBv9W4pODQMqUfPygKbL+TT50fbBjQY=; b=Vh7iMEx7mHkn6QtIwU8JwsOENFb4mJspWSKx3E3PrEph4UwNTUaiEB9mYjlvLMdC+WYF5NKiLAZwiwijoKOvNfmqlMV9YxccBfhN4uU5jVtor4prY81pK44S++tlK8kE79CZu1q3d5sfJOTLFoAiSq5iG7qzaaGkFVlJA+2OrRB+x9yPOfINDW0N9eLX8ozSYiCebWJqRRrevUKycdQ8tqk6iB1cMbxh9EcnMHS9e06uQIKEpiaPvf0UVC/rQ5mOw2gt2EFetgeMSpqkzm/wkIz8YCaIzmI93NUMQSau+H1xLQAfopGXhqHSCc63VtEcg6jJ6IKBbsib3iQ6Xx3Gxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VnhTkyb1zKNFKBv9W4pODQMqUfPygKbL+TT50fbBjQY=; b=WhiBvSjFaiQ3zx6Ywi6nDmAiHSJvcyc2Fa9P+juCenFO3dGo9S91i49INzSprxrKddY4Cdo9PnKm5uxq94T/vn2tRok+Auh+I0Yau/u51d5EU7J1FWRznhn/EtBKn5d+ujiBGE4co9uxiGb0NyxwHkGfMeDyCl2OPJ1J/tIw84BDJ7BJvoO3aGbXALDftnxTTSXiB/GdwpnEDBmNW0MyCvXHxJkxniCLaRXL9ftxN3h4pJPFJmkuUEkKOLAf+/mmDjuKxfR9S3YZgrfxEwrvMyB+S4JzlZ6nAnuvu7Midte+B7nTMOCm574r91yJG+aFabaWLBEDGPEWpusRoJSQ3Q== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0366.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.35; Tue, 12 Sep 2023 07:09:38 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6768.029; Tue, 12 Sep 2023 07:09:38 +0000 Message-ID: Date: Tue, 12 Sep 2023 09:10:57 +0200 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [44KArJQ+q68pazi8+E+fE8AdPf6EQTna] X-ClientProxiedBy: FR3P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::10) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0366:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ba55ea2-75ec-48c4-22d5-08dbb35f3a00 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yz7jU+nnUuwzaTDZUC9Pj/8R/WS94cXd2hU+39RI71Crhex3iAllGubq6ICdvFZ8+MHlGUv0rdQ7Fgdm7RGOZ841+ZCxSn93I8QAQPt8gSV5M0BNXG3XfsmbEgxqWePX6hCht0XGMntruC3wK4wa4tG0QLxXKTqFLq7gvYgtUUVREODfxsVwjy18SjfawD1+wrs1unq3+88nZV2RseazgESsFHmISRohQfVpbNIAardfEXbun/W46WxNoeFshmPZZP4XBYkmdLHq7on1IRyvijZCM0vXxJTeaGu9oNVYsfVx0oQFe/HW37Bq7jD+b71a+5enn2qRHViMMP9IuFui3boA8vTlrnZE+5aYv+luuQdWShERFLGFr5plnAE/mPeHU+4vD9NeZO/4S1bs1WFoTu1lxFP9sIXZefhANClUHIilqyvSq7diPJh7x+uJIn5VHIMPracYND4krEFNU84oxz1kLVLg8QVQEozj9wFWbsVcuKAYmeIOUON2x8a+RkE/a3Ow6K5LiD8kjFg2a5VoI/c5F0OJEpv8qQogYYrpxtpcEDGncO43nl3ocU19Mmp1 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUhGV21EVDBJSkVteVBKekRzTlk2ZnZnU21MQkRBdVplRUFxK3czWjdYV2pL?= =?utf-8?B?NVhOMjZPYlE4OVk3MGYyWUJDa2oxUnVBUUN2WmQvNzZXOGgzeTVsMVZxaTlJ?= =?utf-8?B?N3VwcHpwTHc3Ykd0UmxlUjloWCtqZTRJaXlVNVdwU05GTTF0ZDFOOUlhb3pB?= =?utf-8?B?eUVzZEoxOFJTNC9ianpDaXJCN2NpL05TdHhlaVJHUG43Y2NrdzJRV1l5VHk1?= =?utf-8?B?TkFyQUczelhJUW80M3JjdmtuSHI5MmN6VGFrL3BBYjFMR1gwaWtnMkw0bnc0?= =?utf-8?B?WE1WQmxNQi81SUhmcmFwc3J6WFJkaWc3ekJoMGp3UE1zY3RZTzBJeE5KRUJO?= =?utf-8?B?N2dUOEVGWlJ2T0ZLTVBFaS9GVUpEOU5mYVZkcGExTWUvSENhK3VpMFBWMmha?= =?utf-8?B?QnV0UVlHME9PZ01zZis4cFZnNFE1NHh1a2RiZDhUZEhuQ1BCcTI3ZTJMa2lP?= =?utf-8?B?Z05Sek1vMld3bkJ2T1ZxY2dRWFJ2V1VhaW5HNGNFSlhXTCtnKzNQRm5IMy80?= =?utf-8?B?cXNBQ01YSmEwWWhSeDhzblFYRWViVkIvenBYcXNDbjl5NEFzc00yU2dwakpt?= =?utf-8?B?cEUyR2V2cUhTbjYvSmkremFDZVVhOGdpOW42SytlSU9jK29sdkp3aDdKZlNt?= =?utf-8?B?UWY2SDRjbHpXbTUyYmlOK2J0Z2orQWtZd3hRdE9wZkc0cDR2cFZTWjFUUzBZ?= =?utf-8?B?SUVBTUhicUZYc3A5WVBHTXF3VlpOd2lyR2tGL05UVFlDdTNIeUxTeU1NQUZK?= =?utf-8?B?bVhWUi9odEkwZDJHamZpL2N0d3k3RDl5OGN0UHVVRkNJa3ZxaUVUZGZjK2hJ?= =?utf-8?B?Vk9qMDZZNHdoRTZEd0c2Z0d6TEN1UWpzT0x1bHhNb3BVVGpmSFNHUnUvSzdZ?= =?utf-8?B?ZVVadTN3ZEl0M0xlcHRQNTVsaGgrT2ZzTEQ1aFExb3ByWitycG1HcitMUjBq?= =?utf-8?B?VmRQellUZXM2enFWRHI0R0JpMkVaSG5KSTc1ZWdVRTNIMlM4SUV2dDF2b1lp?= =?utf-8?B?VURkKzFEYXhzSkRlNUFCNUxxQW5leHpBOENNbTFuQUhPeXVYTi9rcjFFZUFx?= =?utf-8?B?Q2lXSStVRnF3T0RWcFpQbm1wL2RTUkhKZEhJR2IvU2M5WmxvNThjRHNZMGxZ?= =?utf-8?B?WnR3L0syS2xxTGFDRW9hWS8xRmVyZE9WK3c5ZTFraFBzRUlVYnFUczh3SERp?= =?utf-8?B?S2pMOEdhbVJjZHA1TmZyN0tZMkVWMEpReFlYVEJQcFo3Zk5MNWVlVnkxcnZ5?= =?utf-8?B?cTlBM2JUWVYzL282OVQ4WTZTY3psR2U0a0U4MGx5dTF5bTArM0RvRGFONmwr?= =?utf-8?B?cnhGU1lwTUMyR2lUUUZVYkUzbnB5RjZDNWl2NENpcDFMWnlIUUdRbExqU21h?= =?utf-8?B?TG10YkVyaC94S3UyU2s1QkpHbW04KzhaVjQ5cE1McEp5Qk9YMC9kK0NaRnRo?= =?utf-8?B?VEQxdTNLTnRaWkdZZTBqdlN5cU4vK1pWa0VnUWgxL3FkVm12empMbkp4R1FD?= =?utf-8?B?TWgwV0lwQ0lIanBFOFBjdEJxVTE3OVZodVNsTnRQN3Z1Ni9ZZEs1U2hKSHpY?= =?utf-8?B?UjFpUklCcG5tWXFpV0UwcjJzWkhHQ1p0cjMyeFdJUlRkRDN0bWRWczVXdlZW?= =?utf-8?B?N3JCcExRSG1hK1JhbElLeUk5NFh6dTA3ejFTMDJhYlRuMmlIWmdxS1g5KzVZ?= =?utf-8?Q?BQi7DX3PgxB5Q06jWB4o?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba55ea2-75ec-48c4-22d5-08dbb35f3a00 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 07:09:38.2199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0366 Subject: Re: [FFmpeg-devel] [RFC PATCH 1/3] aacdec: always skip the first 2048 samples if there's no side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Lynne: > For some reason, this was never set, which meant all **raw** AAC in ADTS > streams, except faac, had extra samples at the start. > > Despite this being a standard MDCT-based codec with a frame size of 1024, > hence a delay of 1024 samples at the start, all major encoders, excluding > faac and FFmpeg, use 2048 samples of padding. > > The FFmpeg encoder will be modified to also output 2048 samples of padding > at the start, to make it in line with other encoders. Does this also have actual advantages besides "being in line with other encoders"? > > Yes, this leaves FATE pretty sad. Will fix it with the real version of the patch. > Didn't we once guess the number of skip samples like this, only for this guesswork to be removed intentionally? (This is not a rhetorical question; I thought it to be true, but I see that there is still code for faac in decode_fill(); maybe I misremember.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".