From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1AD554E1F4 for ; Mon, 10 Mar 2025 02:13:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A186368E5CD; Mon, 10 Mar 2025 04:13:36 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2091.outbound.protection.outlook.com [40.92.89.91]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1619568E476 for ; Mon, 10 Mar 2025 04:13:30 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kSMcSr39xOb4VEJqoz2Pj8AHW9mrAOvyQUt2rqGyYWw90jMLLbTrje8i2++BgJB8E9cFt90O7WdO9FOoZ0ZSz2KzUowUfqIh+WFBVECycepOukQE2K3WpSzVExrhC6ZBBA4j56phPQ4J9JpRjHe5iYQMkO11JXIoPlMNo38JvbTMbVxWVvoYtVcPlkAIwPZcHWBuDHMjpBh4a+FPJsCBIUmy5Wae45xQG6tc3DHqi1reEVwzoNXamRmAtl4J+VCr7YU5DfSzWqACW/VPXQIneAlUo5eQZvgd/v2AhMONjTxfvip7E51pPfJe+Rq1evgj0fm3bt62kSlttUEN1PIbBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AUNTHc2HyUoZAvPoIK3lpbKymOz0QS60XQt88ZpMy6k=; b=FMaxYBxjn4CCAo+BcRzxlUSK/QiXfbL7hqCwFoVWDTJVvSBFpodlrlJ2Z3YR+RrRiAME0+L2g95OijnIumtsBmtxK0Ea+w25/IjF5WaowClGuSbKj4w1XGuUXYW2SEegw4xt0GLHw3c88i0LxBTI8vrf5L77iA2k41AuoPBJcgYhlV3IuP8y3TUBGo0VfXl4nbVTPSIAcmaeQRC7XjJgxu3TTBuRNMZAwLANhEt5PE2pFmbpfv8/WHfoNnVNV8AIlLDPz8M8I5sOmWpI6DTSTSBu/yfc2iFaaKX0jw6w3Wz6+il/uirett+90uv/Zs3Pjq3xjKxowLofnWc+XTbADw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AUNTHc2HyUoZAvPoIK3lpbKymOz0QS60XQt88ZpMy6k=; b=XgROAsuKdf5HtBzeGs0q8TVeDu3kPqnx7/ogFNy7PzRSXH809PvuUeStVXr1F4eSUqY2Mnd+d3bGkeNiYBVKUf0yO4MKEXn82emhb6q2b8kLiI/bMvfcWHOBINhBkqhbQLCYEZIb4pBk8rXKDpPyQc5L/1s1Tcm5o3ZXWuGUwiARRvkN68NO9OgAo7P8Z9Sx/u0kNt22Aed9Re7ea49ht3JwwTD7eDa9vhbfVpkaqP/7yyOan1i5yyfJWYk35ag5tEzkIZ1wBWLEdr4K+S6PuLFrrkOygpkyP+DNxeEA3Zd48m+aSpw9lELnzhYC8JxK8jstOLr8OMgtOTCLsVX6sg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAVP250MB1027.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:2f6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.18; Mon, 10 Mar 2025 02:13:27 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%5]) with mapi id 15.20.8534.017; Mon, 10 Mar 2025 02:13:27 +0000 Message-ID: Date: Mon, 10 Mar 2025 03:13:26 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: ZR2P278CA0067.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <6edcc2d8-bcaf-4413-a08b-730ccdcb6c83@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAVP250MB1027:EE_ X-MS-Office365-Filtering-Correlation-Id: b487166c-aa67-4dc6-55d1-08dd5f79250f X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|15080799006|5072599009|19110799003|8060799006|7092599003|6090799003|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U0tHcVUrOElubTFSVVZpamNIZ0NKU1FhSE1FU3VGK2VvRGVBZGpFL0Z5MDR1?= =?utf-8?B?dHdSWUNhTkI3UWc5NUlLV1JqM3FxTHMvRG9NVFVLb3ZsTU9qU3dvZGd0UXR6?= =?utf-8?B?VTAxUkdDVm00MldhWjk2VUQ1MW8xbXpIa0tNZ3hVbEFHa3lQSmFiTVlDaGFw?= =?utf-8?B?NUhUdXlNUjB5bER2NUZySzJpelZvZHRLN0YrMml1NklEakRRS3AybzF4K1Z3?= =?utf-8?B?L0RHSlZYem9tYTZTbC9tUmJaV2tIYldDdTl6TWxqTVJKcWxpRSsyVHlVVlla?= =?utf-8?B?U1NvQmtLV0V4ZlV6elNnTjZMcTMzd2s3WHNsZDkydFpRRkplV1EraWRNU3Ev?= =?utf-8?B?aU9wS0lFWGtSSFloUC9aa2RGckVnQWN2SG02d1pIT3p5VFVCbnVGbWprU2dY?= =?utf-8?B?dzArL2lvejJ6U2JOYnNGZEZmRW5GRVZaR0VnZ3hLWkpvWDdjTEk3cmVIV2Jo?= =?utf-8?B?MjkrMXJUMHFVcFErekFYQXg3bDdWYVIrd0d3N1pBL1VFcmF1Uk12Qi8wRnpS?= =?utf-8?B?US91cm1jMHRzYWxGZEJkZ2Z5b1IyUUFCaExDMEs5SklJaENDbUFNQ1kxNnZM?= =?utf-8?B?Vk82dFlHVWVuQlY5bCs5dy9lWi9pUWxrN1VvZmRxK0dMaUJIWENDbEpQVFFt?= =?utf-8?B?aEZ2dDJqYjdEYythUENKNUw1V29KZEUwYk45dW5yRUMxWXVNakJUUG0zQ3Zu?= =?utf-8?B?aEwxQU90cnluOVR2R1ozN1BDaU4vLzVjUXp0U3hVWTNMZHRJc1h2UVNzK29m?= =?utf-8?B?Y0VoSkJSZE1yZVpHb2RxSGtlN0tVVk1rVlIrd1MzR1ltMnY3MWRaRFVhVTlG?= =?utf-8?B?WVNsZXdpL2xtbnY3ejBLSGxIendqVVRLamFLSmQ1VWVJTzhFSXg5cVg0UExn?= =?utf-8?B?bXhZMjJkTVFZRlRvTGNNUTdrUi9obUo1U0dDUEwyNHorcHlkbm4zODcxVVFs?= =?utf-8?B?R2F5TmkrTHFMNXJjdEJWdmxEWVBteTd1SEhiTzYzRzBJODNsMGE1ZS9CQ21R?= =?utf-8?B?cE0wYTRBZ2dtR0FQQ2doMUlpNWVLNE41ZWtBWTNCNFE3U1NUZHcxZUM0SUJ3?= =?utf-8?B?NXRsUS9JK25vb1gxTE81Rk1zQkJLQk5NOXp3Tms1YTNhckdSRDJBNGdESmha?= =?utf-8?B?b3NpSFhPcmhXay9MSzZDNlhyeklMbjBlc0ttQWhGalNMYVNFeWpzNFAzRnd6?= =?utf-8?B?Q2xodThneEIwOEJWVjVyREVJQTBpcENPRW94dGZraHRVVEdZcmRBVXZrUG1v?= =?utf-8?B?OFovenJTbVZQcGMrMmxKZEhXRTlwd1FsQ1ZGOCtHRGhmUGg0Q0oyMzd4LzJx?= =?utf-8?B?eEVyN1VFb0VOT1hiUzR1d003N3JKQ281bzI0UnkwRGljNHJqZHVlTGRROG5w?= =?utf-8?B?VkhYMjlzc0Q5TmI4QlhlM2xjM0V3eVgrcER0UWJ5bG1PU1pTR3RwYWx1cndj?= =?utf-8?B?UXBkNjVHaGdsc0RkUDNFQ3BGa3o5UUROY0tkMTBpYmtxTkJ0bGZqeUtIL09V?= =?utf-8?Q?htSJmk=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTFlb3dmaWQvQnUrV2hUVlJqUmdIMExsWk5POXEzWkk5WjA4WHA1VjZ3YlFv?= =?utf-8?B?a29FVFlIcDhyRkk3TDlGS0FrSUNrOUNKOXpRakpLQ1dremd5WUQvSDlzckpi?= =?utf-8?B?YytCUTJwKzI2bHF1Nm5KcVhxUGljRXRkU3NLMHRSSmpOSWdweUlRRU4xUzJZ?= =?utf-8?B?WjlHUEdFOWRCeWZMd0ZBMEl4VnBTZ1RnQlNxc2RWWGRQT0U4di92Y254L0t1?= =?utf-8?B?QzdycWZuemZBOElyQVN2Mm5YQUdSQkxIa0pENmZKSG4venlLRmxUdTNNQ3Zi?= =?utf-8?B?K2RMclhZK1Y1aTdEVnArL1ZaM2RueEUvRmZmQk1OWjlRdUJzMDZweG1QbGxh?= =?utf-8?B?MHVnMnlDVUIwNS9tckl5Q3l3YStVQkF2OEhoN0NzYnlldE1TN3YzR1ZtOHNv?= =?utf-8?B?Yzlwd3VrcXpPcndrcXRGazd5NVE0SXhQVVRHT2c5TnhWQ2lONDl0UWtyVDBQ?= =?utf-8?B?UUZ2U2p6aVFnQlduWit3YzdsL0JHaXNkUzhCYk5ibU1abHZkNS9vZXd2WVBm?= =?utf-8?B?dXd6U3dJVFpaMUhTbzRxZXV2TWlnakVnbFB4dWV1eGVtWFpUV2txTGZzTzVr?= =?utf-8?B?d0s3WEZGZkFGcnZUaVN2TU1zMXlBQU82bS9VSWV2NVdrS25kazJ6cENFQklU?= =?utf-8?B?SWgrRFNDb25wTWRpN1AwSjd3ZTY5MlNUY09nSHY4YytnZGc2bEtwb3N6UW5J?= =?utf-8?B?ZG91d3F5dmhQeG9PakNnVnJNMGxZVUFnTitYQjl2OWpEY3EvczlHZGVja1lv?= =?utf-8?B?UjNDa2JDWFVLK1NueHd5OTRXUVhES1N3Z2luQmZVVUhYbXozUzU2YXZWWEx6?= =?utf-8?B?bEtDYWFQNzZFQjVadGIwREV1bjM5TTZUdVNvM3VwT2VZQ0FTNjJQUzhaTDJ0?= =?utf-8?B?YW9wTmFVR0pvalFyNWlpcFM5R0t6TmZUbU5La0xUUDFlcTlpcEhxS1RTdHh5?= =?utf-8?B?aVdJN1lyaVB0N21xeWJYZkpiU0VxR1ErdGdSOXNLZTgwUHovNzJvekUxa01W?= =?utf-8?B?MHVqRHBUYldlY1dXS2MvaVRHNGJ2SWM0aTV6U2c0YTErQUVHdHRncTVvYWJX?= =?utf-8?B?ZUpBRXVuM2ZYUjdCYldVbzI0cWVycEc3c0pDN0FNd0Q2TGE4OERtU0wxWjdT?= =?utf-8?B?SE83MmxuWktWVENlTGIwbmR2TmN2MDBxcGhHa2xxOE5iaG5zTXQxZnRLZVBS?= =?utf-8?B?S0FpbWQxYkhaTUtjVmtnT01SUjFUYlZoMm9Zb1BscVFTMndxNVhjUXpJTXQ4?= =?utf-8?B?OGdrRldZQ3lNME9mSHMrT3EwSnB0OHZZbWNWMk1ENWlUMFk1ZmhsK0grT3Yr?= =?utf-8?B?LzNsdGNqUHRidTNxQXFBNzdCaEJoczgxbVA1OU5aTGFZLzBIUUVraS8xVEx2?= =?utf-8?B?WDM0V1VyTnYybEVUVW5Bd05jTDd3VnprMEtKY3BvYzRUYWk4UWZPQjE2Tjg0?= =?utf-8?B?UDdtc1FpNWw0ZGVYZjRaL2krLzdmRFhqZnl1Q0J0ZnB4M01uS0Nzb2JLa3Fu?= =?utf-8?B?L2YyMk5meStnSnFyYWsvR1VJbThYT0I4RytpRkJUbi8yOVM5YU03VE1ic0dy?= =?utf-8?B?WE5kYlI5VXZCUUlkQlI0QVVNZzdhYmZpc1VrbEtIUm9NV0ZBb3RNdXB4Z3JU?= =?utf-8?B?c0pKaTJUeUJORGxUcEhVZmZzUVIzOVBHSHJDVndvd25qL09KTmN3Rk01cHZq?= =?utf-8?B?eStmYStQUjgvUjFhREZhOXpYbS9ybzg4eVVUUUdPTE9KYXpsK0hrNTdBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b487166c-aa67-4dc6-55d1-08dd5f79250f X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2025 02:13:27.6781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVP250MB1027 Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/libx264: Set FFCodec.pix_fmts field and fix deprecation warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zhao Zhili: > > >> On Feb 6, 2025, at 01:42, Andreas Rheinhardt wrote: >> >> Zhao Zhili: >>> From: Zhao Zhili >>> >>> We can fix deprecation warning by not set p.pix_fmts, and copy >>> FFCodec.pix_fmts to FFCodec.p.pix_fmts in av_codec_init_static(). >>> However, that method requires non-const FFCodec. So I decided to >>> set pix_fmts and p.pix_fmts both, and disable deprecation warning >>> explicitly. >>> --- >>> libavcodec/libx264.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c >>> index 409f45fc7d..9b8b32ef4e 100644 >>> --- a/libavcodec/libx264.c >>> +++ b/libavcodec/libx264.c >>> @@ -1633,7 +1633,10 @@ const FFCodec ff_libx264_encoder = { >>> .flush = X264_flush, >>> .close = X264_close, >>> .defaults = x264_defaults, >>> + .pix_fmts = pix_fmts_all, >>> +FF_DISABLE_DEPRECATION_WARNINGS >>> .p.pix_fmts = pix_fmts_all, >>> +FF_ENABLE_DEPRECATION_WARNINGS >>> .color_ranges = AVCOL_RANGE_MPEG | AVCOL_RANGE_JPEG, >>> .caps_internal = FF_CODEC_CAP_INIT_CLEANUP | FF_CODEC_CAP_AUTO_THREADS >>> #if X264_BUILD < 158 >>> @@ -1659,7 +1662,10 @@ const FFCodec ff_libx264rgb_encoder = { >>> .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | >>> AV_CODEC_CAP_OTHER_THREADS | >>> AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, >>> + .pix_fmts = pix_fmts_8bit_rgb, >>> +FF_DISABLE_DEPRECATION_WARNINGS >>> .p.pix_fmts = pix_fmts_8bit_rgb, >>> +FF_ENABLE_DEPRECATION_WARNINGS >>> .p.priv_class = &rgbclass, >>> .p.wrapper_name = "libx264", >>> .priv_data_size = sizeof(X264Context), >>> @@ -1691,7 +1697,10 @@ const FFCodec ff_libx262_encoder = { >>> .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | >>> AV_CODEC_CAP_OTHER_THREADS | >>> AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, >>> + .pix_fmts = pix_fmts_8bit, >>> +FF_DISABLE_DEPRECATION_WARNINGS >>> .p.pix_fmts = pix_fmts_8bit, >>> +FF_ENABLE_DEPRECATION_WARNINGS >>> .color_ranges = AVCOL_RANGE_MPEG, >>> .p.priv_class = &X262_class, >>> .p.wrapper_name = "libx264", >> >> Only Clang emits these deprecation warnings; and IIRC GCC does not >> support disabling deprecation warnings inside a definition like this >> (compilation failure). The deprecation warnings can instead be fixed >> like in fdff1b9cbfd8cf5a9810c29efa4baf13a4786742. > > OK. I decided just set -Wno-deprecated-declarations in my build environment > and not continue addressing the depression warning. > FYI: 0971fcf0a0821388c5258f46f73bdfbdeadd1b52 silences these warnings from Clang. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".