From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] gdigrab: Allow capturing a window by its handle
Date: Mon, 11 Dec 2023 01:34:08 +0100
Message-ID: <AS8P250MB07447B266C9628F17357F1AC8F8FA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <719e708c-25a8-422d-8392-6a837b138fe3@nihil.gay>
Lena via ffmpeg-devel:
> x11grab can capture windows by their ID, but gdigrab can only capture
> windows by their names, internally calling FindWindowW to lookup its
> handle.
>
> This patch simply allows the user to specify a window handle directly.
> Signed-off-by: Lena <lena@nihil.gay>
> ---
> libavdevice/gdigrab.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/libavdevice/gdigrab.c b/libavdevice/gdigrab.c
> index c069232472..05d3c0c929 100644
> --- a/libavdevice/gdigrab.c
> +++ b/libavdevice/gdigrab.c
> @@ -273,9 +273,13 @@ gdigrab_read_header(AVFormatContext *s1)
> }
> } else if (!strcmp(filename, "desktop")) {
> hwnd = NULL;
> + } else if (!strncmp(filename, "hwnd=", 5)) {
> + name = filename + 5;
> + + hwnd = strtol(name, NULL, 0);
This won't even compile due to the extra '+'.
> } else {
> av_log(s1, AV_LOG_ERROR,
> - "Please use \"desktop\" or \"title=<windowname>\" to
> specify your target.\n");
> + "Please use \"desktop\", \"title=<windowname>\" or
> \"hwnd=<hwnd>\" to specify your target.\n");
> ret = AVERROR(EIO);
> goto error;
> }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-11 0:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 22:10 Lena via ffmpeg-devel
2023-12-11 0:34 ` Andreas Rheinhardt [this message]
2023-12-11 1:35 ` Lena via ffmpeg-devel
2023-12-11 1:52 ` Lena via ffmpeg-devel
2023-12-12 0:47 ` Stefano Sabatini
2023-12-12 13:59 ` [FFmpeg-devel] [PATCH v2] " Lena via ffmpeg-devel
2023-12-12 14:07 ` Nicolas George
2023-12-12 15:31 ` Rémi Denis-Courmont
2023-12-13 10:03 ` Nicolas George
2023-12-14 10:32 ` [FFmpeg-devel] [PATCH v3] " Lena via ffmpeg-devel
2023-12-16 15:31 ` Stefano Sabatini
2023-12-17 17:29 ` [FFmpeg-devel] [PATCH v4] " Lena via ffmpeg-devel
2023-12-17 18:17 ` Stefano Sabatini
2023-12-14 10:52 ` [FFmpeg-devel] [PATCH v2] " Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07447B266C9628F17357F1AC8F8FA@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git