Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska(dec|enc): Rename macro to avoid clash with winbase.h
Date: Fri, 1 Sep 2023 00:31:44 +0200
Message-ID: <AS8P250MB074476FB231FE935E0AD90B38FE5A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB0744DDF2BCB0C9698EA3F7C78FE5A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Andreas Rheinhardt:
> winbase.h defines IGNORE and is included via bzlib.h when compiling
> for Windows. So rename this macro to NOTHING.
> Also rename the muxer macro for consistency.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavformat/matroskadec.c | 4 ++--
>  libavformat/matroskaenc.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index 21f52ccab2..fda77b0b89 100644
> --- a/libavformat/matroskadec.c
> +++ b/libavformat/matroskadec.c
> @@ -2171,8 +2171,8 @@ static int mkv_stereo3d_conv(AVStream *st, MatroskaVideoStereoModeType stereo_mo
>      } stereo_mode_conv [] = {
>  #define STEREO_MODE_CONV(STEREOMODETYPE, STEREO3DTYPE, FLAGS, WDIV, HDIV, WEBM) \
>      [(STEREOMODETYPE)] = { .type = (STEREO3DTYPE), .flags = (FLAGS) },
> -#define IGNORE(STEREOMODETYPE, WDIV, HDIV, WEBM)
> -        STEREOMODE_STEREO3D_MAPPING(STEREO_MODE_CONV, IGNORE)
> +#define NOTHING(STEREOMODETYPE, WDIV, HDIV, WEBM)
> +        STEREOMODE_STEREO3D_MAPPING(STEREO_MODE_CONV, NOTHING)
>      };
>      AVStereo3D *stereo;
>      int ret;
> diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> index d26c0fa059..bf2ca7106b 100644
> --- a/libavformat/matroskaenc.c
> +++ b/libavformat/matroskaenc.c
> @@ -1633,9 +1633,9 @@ static int mkv_write_stereo_mode(AVFormatContext *s, EbmlWriter *writer,
>           * values to be in the range 0..254. */
>  #define STEREOMODE(STEREOMODETYPE, STEREO3DTYPE, FLAGS, WDIV, HDIV, WEBM) \
>      [(STEREO3DTYPE)][!!((FLAGS) & AV_STEREO3D_FLAG_INVERT)] = (STEREOMODETYPE) + 1,
> -#define IGNORE(STEREOMODETYPE, WDIV, HDIV, WEBM)
> +#define NOTHING(STEREOMODETYPE, WDIV, HDIV, WEBM)
>          static const unsigned char conversion_table[][2] = {
> -            STEREOMODE_STEREO3D_MAPPING(STEREOMODE, IGNORE)
> +            STEREOMODE_STEREO3D_MAPPING(STEREOMODE, NOTHING)
>          };
>          int fmt;
>  

Will apply.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-08-31 22:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 17:58 Andreas Rheinhardt
2023-08-31 22:31 ` Andreas Rheinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB074476FB231FE935E0AD90B38FE5A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git