From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0222B48E2A for ; Mon, 29 Jan 2024 07:58:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BDCF168D1E4; Mon, 29 Jan 2024 09:58:06 +0200 (EET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2054.outbound.protection.outlook.com [40.92.66.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0715A68D14A for ; Mon, 29 Jan 2024 09:57:59 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UXkFWUPjMMiU4YhWDsjGyqP5tjpJhqcv+j8ftAM7DJsBcbbCAa/6wZ7Q0/Gu++f7GmTIh7+i0HN4lU1f54rtWcNHCiXYXIgfBuI4HSBW7N/orKUS9F3JO87RXCMslHWQLJvR62WmHdVJ98pGFY6nzPC078EjyHtLZP2D4R/LIZTy1HwUssul+jq+tFd87uWwRsKiP1aj5lik7FQZUDmK9tbOlVZAX1EDj0Gn3vv+qxKZl6yDpi/ZjtvMsS17K8d9QV6iPy/vnMxeeiCYj7h/U3hN1lQx51Gxaie56FFYAzN0uEFg40b3UgbhHS7ToiwMwjaBrhIZYUO2d6xKXBkMVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w3tz18R6zy7JRAllAnEJeiFUKLaWLdpzHzxw3cJqb/g=; b=Y4isuHfJlQ+06pf9IzE7RNidhII3QsOGJfdCM0NKNbtRHsUqfU1F0BvnhucQmkLosqmBjjh1AbuNALUyOB75l9U4EYG3Sws467N957U0HKA/rxa9OIb78+Nr8ms86uxijIRweQOylntePNPMy0R92Ouyizn3O3nxv51OExI2ymqvUvcYI3b48pv2rr7APWece1Hfvnd/P4aJuLXX3B4ak778sneRgrHllVOGlInvitdbgSfF4YJEze5Nx09sLzzJG0KQNqe7zt5yw+BuSK/JY4gmC81GhPlwmiMuIiU7Y4s4rCx8M2tSRCNFNPGKPX9qMwJvsXZmMLsdPPxfDPP4pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w3tz18R6zy7JRAllAnEJeiFUKLaWLdpzHzxw3cJqb/g=; b=DisXI1mV7XgMTloa11YMV7yD/s4s2W0UYAtKpKS884ybQ4DIHJJNGyEJwg3WnPHFWUlbnRaLOPBZLzNof5o684+LGSMFu6pvjqLxz8SHw0OdnZvJk56Jg3F6kx10by/pAVJViuWX8WsWe4L4cStod/yg3NpjjVQcWYfTftxkydD/kjnt/5xV+5c+jEzpKR89QyNfa9yy8FFhtabngdoQF76JvpmRCJOqp8u8o3LYDxtm2sXWyTqGYGUaKGE//NvDeckbdwrPSrPBudT2Hth1Oqkks4UWEpI/Gz1fmupjB1BM1OF+nCpL+i2xUSCrqpvwSF3Gt4Zsi23IfGm7FT7jvQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0194.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:179::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.32; Mon, 29 Jan 2024 07:57:58 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7202.031; Mon, 29 Jan 2024 07:57:58 +0000 Message-ID: Date: Mon, 29 Jan 2024 08:59:38 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240128224141.GT6420@pb2> <35759608-96f9-4247-84aa-18bef03b864c@gmail.com> <20240129023127.GV6420@pb2> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240129023127.GV6420@pb2> X-TMN: [UaRPwLrC2WYegl5S1BoRfT6ZS8vVT4+X] X-ClientProxiedBy: ZR2P278CA0029.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::12) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0194:EE_ X-MS-Office365-Filtering-Correlation-Id: e11628db-15c7-4ae4-3482-08dc20a00224 X-MS-Exchange-SLBlob-MailProps: 9IecXKUgicDPE2UyWmSi8/WwRKLe2HqauR/0kst9DqlvBaqarhwvrN/mYqeCetLbulDE712HLgtfZ2za3vbA6cSy1jLeW0wYZyxXurD9xQPssvUtnNPBWgTOg+LpXodSopIi5YoINVMcrV5zSyvbtlrtt1IsPqlWgA+Ao38hC1YjWto9FMhF8aQ7k8/i9nWwV5XNM+JiIOGb/00iYWY4PkcCgj1gVp3Ldg+nxRj8KJl25UALjW2NjZhOfzvZKd+eEFE9hvIh9bNby/XzmgwLlKW6XN4EBSXVyXY9sUXWYI4bLUp2oPV/iVG1WLH9b4va1AiGRrgknZNyFmp2IcJSVvFbEIz/rwT2xyxz4As+UmrNsQPd7rGoam+MAR0Ma4/Pk8Z9gu42NXBqsk9Iy3XJy17cTerb7C1bWgmflKpdInMK896pPNpB3r4LrYqNG/k2A+n79QQtysy+eCnkaULQsGw77nBhnXShLM/8M4sly7gDhcZuvuByZiLv76mLq/e2WkWxflDPP8pLPvOpSfwfEm1eB95jmVCWP1uMVTKoOJe/RNoGRICSK9/EP/hUgCXl5AM5avj3e0iPQwG4rG23j8k1Ba2FZr5sGp2NenTRBQtpHZ7w6P+VMQRpx+ZUiN9BkHhFRsPiqyDvfmdpbEivjddFPW32vbUgH1gakz3O5dVj27m/mkd7kcKnAw11EQ0D3rS7dQkXnqgGkcgZ8536A2ssjWCC1++CAseHpfn3gdW5+2nlxWJmKA== X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /ZP/0HG9m7vD4Fgdi7ePBGmLWogryske1sTWl4cwFxipx7ZVSjJ8oTKZFoKEGnSyR9mc0nBWAjk6JnlwsXWRZJ2pVcRp0uF1X/xSdHiMhapdtPAzzC0sd9DIyFO8ztCH4r7E6T0g9CdVIxsBB6A/FiS9G2HEOsONggQJqGJVioafqaOqFEn6lX3/G882rpO9KiZsbAM+Osq8Lf//LYk1raSBrfK1YGfN/c9+T96rps4VGzv45KLJuYCDQSzAT/LkzHO9PCwqIhqZwCUSAc8DQ7pLqz7w3F9y6fX3OdXj6UQAuX2S4M2I4GvJ41IKBHE73C8RiUdHLECIrmjkQ4EO/sd05227xlry7AnPDJUIIhn4FoyTTj2Y7kLsb5Wz+cDsCFiqfJ9Zcn1OXPbUFl5v7l4KMz1JhPRfSv6xsyF9GXJrtlUaJlrDQt58q8PCb1DoC+Hcq+FOoEYezW1XUcVBuZuD7QQ4gUUHSca1WNJoPx8C33NKNQ4/okMTQ0YxXGYxcONLjOxfO/61lah4ZvHKHVrfk4mLStMLjqrFKvtC6FmrGgzCDOaXvS3ivVWRKm1s X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGNaTk5peGRGbU53Nlo1bndZMm13VUoxNXNpT24vVlkzQ09wd3FmQVVGNlhU?= =?utf-8?B?Q1BqRmlJUEU5MWN3aWpPYjRYUGxyOUxZSG1iQUdCYVcvd2psUkNXNDBWVENQ?= =?utf-8?B?SWY2UzliRUl4Vzk2MGxzWWo5UnkzV3lta3BSSFJNZ1I0R3p1Q1djS1QrYVdt?= =?utf-8?B?OW9RTEhjUERMNUxTaVdxcVU2cnVNQnF1Zkx5b1pCMkFjU01wRHpUWlpxMDIy?= =?utf-8?B?cVErZTFUQ1NzU3hWaW92dTkray9DNS94NUJKcEtnT3RWN1BiSllDcXMrSFdo?= =?utf-8?B?eEJQUGdndHpmMlBFT1Vwd1RXalB3c205bDdRYU5nSklibGpGcE8yQ1pMUTRt?= =?utf-8?B?c0hlNm5oQ1ZqT3k4VXZQNWYyaHBYbmFzMG9OOFQyL0VoOHJRWmtVQ2huaUhx?= =?utf-8?B?Qkwvc0hKTHJzcC8rUWYxMzhCWE1GSHZsL1BjdVE5WURLcWNtSk9RaGpzWjF1?= =?utf-8?B?VHM0eDFReEMrcHlNbFB3d2o4aFp5dUU4TUZ5ZXRNZlZqR2RiS0tacU5PNGE2?= =?utf-8?B?MmhqTjVsSGxsR0I3d3d5ZGtPOWlYN0lBRmdwSWw4ZHdEcUdzU1FXT1FzL2RG?= =?utf-8?B?NmlkZXFXbmlvMDFnSTN4QUllbnZscy9mM3plWU4wdEwxRElPd21EdnQ2VFJ0?= =?utf-8?B?YzMydDVDRjVSOUVkeGRtdUYzN2crMlZxYzRPaGlvMzA5ZG9kUFpHcXhJVlVu?= =?utf-8?B?WUNMcGVsazM4QUI0S2tUMFNhcFVmMHVIY1hEUnJESmhsaDlRc1lXdzZEemw1?= =?utf-8?B?NDYyc1prVzFrYzdCeGRieDRGdEYyUEhqL01LQ3FTbXpQeW5Jb05rVTh4L0tD?= =?utf-8?B?ZHlzWVFjTzF3WHdhSnBLN21kQUVIK3NuK25GY1IyNWtMdEJGa1pkQWFZelRO?= =?utf-8?B?U1NnZ3FZdkVRa0xJU1pUcFkzLzV3bk4xN3ZXdFVQZUhlVFdBeS8zTWlFcU9P?= =?utf-8?B?NndLRmJwbHBBMTg3YTZ2UVBSdzdvTzV0cElFY3prdkFlQ3oxS0R0bkFFOE1L?= =?utf-8?B?RFhJZFJCK0diSkpMRXdJY0FGa0FnVWtXNWF4cGRKVHZiUm81WUFKN25vL1p0?= =?utf-8?B?V1ZmSWl5ZWpNcTJjVGR6UHlITndrY1ZZRlVpK0JOS29ubkxtWmUwOTlHL1Br?= =?utf-8?B?ZWU5QmZ2ZFlZMWRxb0JMc2VoSFhqenlFaFFra1BydVRDSWoxa2VvRU5kV1lK?= =?utf-8?B?aWFaOVVYSWtiSnN4UzZrbW9pZzZmbnhYOG5UWDBFLzFIdmttRTVOSWFwUEFs?= =?utf-8?B?UWpZMXhENjI1MXZzbllQNTZQWjNHYndFRUFKTy8yZG5yTFp1ZlB2UGJUV2pH?= =?utf-8?B?bW1aMllMV3VUR0JNbkwxUmFoV0hDb1k1bngzRUprU1ZlL043V0phVTFYYnA2?= =?utf-8?B?TWxFY1dDaHkvWFg0WVM5ZC9vVkkxK0k3T3NtM0xJeldWeU05Z0FBYlF5SWNt?= =?utf-8?B?MDQ4RmRYb2RySG9sYnovYm1CSTZNVHVjSVJITTlpMm9MSGc3dXFXOE00OU1D?= =?utf-8?B?UzVrelBINlBTb1JFdGRsVHp6RGViTG5nbXpaRFVlSmZqQzdOTTVQaHgzMDJi?= =?utf-8?B?d293MW1vZXhDS0UwMGdEZDBUU2Y1dXU1amc3R3BnajRHOU5Hdm9QZHR1YnY3?= =?utf-8?B?TzQ1RTRLbnJlYXlnRnF6QldOdkpueGx6R2s4RC85cGpGTVdoZG9EekdCUHVy?= =?utf-8?Q?kEkrj9ZxQzE0pkmRgSKb?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e11628db-15c7-4ae4-3482-08dc20a00224 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2024 07:57:58.4048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0194 Subject: Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec: Rename ff_kbd_window_init() as it will be needed from outside libavcodec" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Sun, Jan 28, 2024 at 08:52:20PM -0300, James Almer wrote: >> On 1/28/2024 7:41 PM, Michael Niedermayer wrote: >>> On Sun, Jan 28, 2024 at 02:49:26PM +0100, Andreas Rheinhardt wrote: >>>> This reverts commits fd5aa93a37b3fa21195c6d7b22ef655124020e09 >>>> and cf00f60bab1f79213c274a6cd4357b32bd5c0101 >>>> ("avcodec/kbdwin: Support arbitrary sized windows"). >>>> >>>> The change in question has only been made for libavradio. >>>> in anticipation of merging it into the main tree. This has >>>> not happened, so this commit reverts the changes to kbdwin >>>> that are not used for anything else. In particular, these >>>> functions are no longer exported (as avpriv functions); >>>> notice that the fixed-point function has been exported >>>> despite having never been used outside of lavc. >>>> >>>> Signed-off-by: Andreas Rheinhardt >>>> --- >>>> libavcodec/aacdec_template.c | 8 ++++---- >>>> libavcodec/aactab.c | 4 ++-- >>>> libavcodec/ac3dec.c | 2 +- >>>> libavcodec/ac3enc_fixed.c | 2 +- >>>> libavcodec/ac3enc_float.c | 2 +- >>>> libavcodec/dolby_e.c | 4 ++-- >>>> libavcodec/kbdwin.c | 23 ++++++++--------------- >>>> libavcodec/kbdwin.h | 10 ++++------ >>>> 8 files changed, 23 insertions(+), 32 deletions(-) >>> >>> I still intend to work on SDR either within what people agreed to >>> (that is a separate library) or in form of a fork. >>> >>> For both it is easier if the functions it needs are accessible >>> >>> thx >> >> Renaming an ff_ symbol into avpriv_ can happen at any time. Renaming an >> avpriv_ symbol to ff_ can only happen during a bump. So this patch is IMO >> ok. >> There's no warranty that whatever happens with SDR will happen before the >> next bump, so better remove as many exposed symbols as possible. > > You are missing something here. > > With the symbols, i can fork libavdevice and add SDR support. > Without the symbols, i cannot just do that. At least not cleanly > Because i need to replace libavcodec too and i need to extend its ABI > then. > This makes this more messy. > I would rather have you just copy the needed code into your fork of libavradio/libavdevice than add avpriv symbols (one of which was always unnecessary) for this. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".