From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0BA0749022 for ; Sat, 2 Mar 2024 15:46:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E201368D2EA; Sat, 2 Mar 2024 17:46:07 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2076.outbound.protection.outlook.com [40.92.91.76]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB85C68D0BD for ; Sat, 2 Mar 2024 17:46:00 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Heq/niqNVNogY4WOdVZvgriFueLOeZc6Du+vGu4WOjH8i1QKtihPBKqeOf6Q3CdnaI4SHOy9j5nLUBe57/Q6EtTxDe3duJD+HfpjK2MBryknDlNk7AY5X6ShG1qmwnB0X/Q5uhv6P25nNkiyyv9WwAHJRvyt2mu21tyo0QQq00iifJ5UlrttLeNbkE/aqwWZHKlX801vQorxsQy9mgJkOpKfOTjbyH5fDuQWTFkJs7eRaxV2rhsCSdMfuKIiknn6ykWe2RBc0F4wuZDiRRyDsaL+Dvl6GPQ/jO4uvOYiG0g2j+80rmHzmQgbJJSk7GrrB5/UpwjzrclHKT/tdg2IFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i5tJwJKhPtVdV+Uqm6DLQ1a5uBF5Mgx2TR6kEWBDBpg=; b=OWs2W0cMUQ6OwTECo2K7GFtHogW5/lC2botghfNFNtAoOKBXnWojQG59iEBYb+7BVK/PcuWhU6qR6eeUgjuA/A9cc35/nyQzHW1GUrOi1ST4AYWy1ONaF3ffWvEcA4KTuFCQmDa0Ky5vCHN1jom87gp3skOKHehbBWe7sfKutP2e/x4ps0H/iVIwqvQJkO0doGv6UupAfmrBt6AzkjRc+JqitEsQCxD7gjqUEGE+AB1g4CP3IdZJebKxC+uKAw6H4XuC0nCJTRDqJN02VbAp68djsP5CPaP+muhEKB6fvMph2icCsHG2b2PovlvFl5gJueYDdB87Q+wE3xLMzHYGIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i5tJwJKhPtVdV+Uqm6DLQ1a5uBF5Mgx2TR6kEWBDBpg=; b=KEiTTr+CvG+wKQgke8RvHdpZDVBBQicn4JFdMazLH7evKHPSqjVED9LM9HuLREV0gkeWrHuN5oPY/2UerTM865qwqYzJ8TerSjD91rBJWYImJ56nVbG2LJt1miv+GOuMjw8LEajbtejkyTvsIyz5D4tgU9IRCfdgCDjdign/NndfV+oAF25fuTdQ9IeASttAku0A9084jy4EVp3DW3LST1D9+KtrcVC/nM4iU5SKWtPc528fuUWpGd27m1zntLkoAKrefl8Fhfah9HC8NnIjGyYprNsJ+IhY20mvnvCLsmrk9W8q+KO9k2UE7oFOuP6GZQpxpTWgKRV/QeB6UBX97Q== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0293.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:328::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.34; Sat, 2 Mar 2024 15:45:59 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7316.023; Sat, 2 Mar 2024 15:45:59 +0000 Message-ID: Date: Sat, 2 Mar 2024 16:47:57 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [ahYIVkLNVln6L8kuRNZqkJ54lHwUT5cGnxomBRco2oo=] X-ClientProxiedBy: ZR2P278CA0034.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::15) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <1ba22a8b-78f2-4fef-b11f-7c9af85a25ea@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0293:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b6c42ec-2bbb-458c-4817-08dc3acfdb71 X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnp1Zl+T4aq3XJ6trwEamTGXNwE3yykfvpKsgBEnh75/m+xj4CxuyuDOQiotOMMffcvXZpgPlGJg8bvxXUuBl7s9MfwZOJ6Syc51H1RuqmvP9okCxoO7EjKiEODxXPz2x76OTontsaWjYH7a6qrQqKRXEBIscG5nT9XgC8M9hIf0rX8rzDDNJR3SVsgtWccDiu6S6ohSsZp0L20D9/T1D5xu0v4Nta+Mls3p+k99pwnbPWnM4Wy3ulVZM6wpwSdDMR26ZwuPJjtRwqaJeLvrEYJsRVyX0vb3heyFD1JLl1a6xF3WkILW+YMBHFnGuvmPawecdJJK3WGngnwQ4mGDMq0jB6BaIy0bChd18u5ViqNpV7XncZJsjk/UOIri8DD3SGbc0xgzQgqHNVuT55KLah3tdQslf+1WGbukmJsu+gPUgvUTSiw9z4kObOtqcuKHWIWkZzNDexC5H/7D+1GlG3UGU4fKDgUzWX/bdAp1bqMauJA3UVnDYeX6Hycua1RyZQA/5b3imN6DUinPKHIXBxMaRspeALdg+kohm1n3jiZIHGpn7X0Gip9KFx13klEn4+Xv7e29vfm2SThdGLXH4cXEMruP5GD4kME6ZeRGASLaMdnBVEp2T3hrIbIFKet9/7Rc3uz7aYTf/wf2ChuTbCYkumaq4uIQJSbpQZcqg8n2inu67kBZGfgz/dQaXRYfXtEGetF/jbS9cT/hc/mkJprwYpZQ6/k5HCk2ZTY62BKHgyGq34kQyW6xKoPC8yQeTSs= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xu3jwS6yXbjSiMaD5tpeuFT6rRlB1g4lla4ATFJF0Mbdib8//Dv/bQfXE2qHMgQxYH9vI2UP/oyqykI81XMpsX4NDuIIhxGzKEL7PUfbOQTg+SK/nFdzJtiONtdIAlLQJ2zh/pUSGM/VJhdtHpSfv4rHYlIma2PGJ0JmXMCEWwlqz2WSp78FeJ+OSwlE5aZV/1GjOaDSl8kTlwKAsGneBN2ZJCBb2peQUQftBro/ez36bDONX6zixBrYS2cAqKCBIYbEjBYtA8cqer+WG6bKeTvYFgr5XLCDxESMIV2vQ707+FLjd3LzfqfBxcLJ3Xlx0GDH7XoI24ssAhdT0D3FmMkHZPgreGOnJVTR6Q4wZC2/HU7DTZgfWf6CCDEXxFIMxcUQklCkOwWgY34HLdbZXOB7RFLI+j23JeUVH7rPxf3LcTgIB1dCuzpNfhy6ab5j+ukHx9z08Vj7rTWoejmtr/V2HydALFUg3HwThVMe0BZTSGvNxbfsnZ4DMHUL/DqoCzqPqiI95lmnWCytT19zzI0hqMs3ysGGRt/yhSejyZvpdo7+UqTmm9eOT2Qkkkke X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q044cTVYd0htbFZLTDR6NDlhVE92QTdYS2hGcmpGbGxmdWdLeHJNYkg5WUNq?= =?utf-8?B?Nk0xaTFzYlpWQ3AzZDZLdVV0QWx6QXhzQ3lxKzJ4d1FjeVp3RFl0WFFoV3Iy?= =?utf-8?B?cXF1MzZkN2N3NlJXbTlFdFlIYUN4SnYrM3ZZbXJ6c0Q3YUp6cVpHdnFzQ1k4?= =?utf-8?B?OWFhSkdXeUZBY3FwUk5RMDY1a002Y08vYmZiVlRUVmxUcWE3RzRjN3pJaSti?= =?utf-8?B?QVNTRGVWa293cVZGMzVuUFN6K2VHeVg5czgyY2NZMEJNV3hna3ROcFFnNE5F?= =?utf-8?B?bkNQQUNwd3lNU0gvay9Hb09IWEI4RmQ0ZDdJZkRnNnNuZmF6STdMckp2RFl5?= =?utf-8?B?SGl3MVZCWVU5L0dzci9qNkpsSUtNS3RxdDJTcVEwWUxZYVBGNnFwMGV3ZVly?= =?utf-8?B?MStHV1Y5NFhOZ3I5bUc3SURKVzFLa3BBb0hyU2daTGJEVzVESmJiUVM1Sm1p?= =?utf-8?B?d1lJQXRHR29oSnZtdTkybzIyL3g2ZndobzFrQW5hMnRZN0lsU2JDRWpWeTdF?= =?utf-8?B?ZnVaUHdGYjB5aTJoajNOc1lqdE9SZnNNOXpFcC9udTl1NmFhMDFoOU1MbDRE?= =?utf-8?B?ZEFuakFkZmlOaWp1RVR1VFNQQzNkS1NsQUdwaFBBTkxHQ25OZmV2VGpLdUEy?= =?utf-8?B?eWpIZWN3Y0svcjkvS2tIUjJ4U0FlZURoVXN0MXA0eTE1Wmx0WE15SlBvbFdv?= =?utf-8?B?eGhhRkxvRkswM0RSa0x2d00vT2xWMEVmeHh0TmF4ZXdFQXBWMGxYZGpnd0p5?= =?utf-8?B?ZHB0cE5YWTF3bUJVMnZVUVJNelRXclhlOVR6d2F4SGNuWGlIbi8rSXJma0kr?= =?utf-8?B?L0N4eFRxTm1NV2k3Y05yM2Q5WDZpL1RYMno1N2lydWcvTDBOc2phTnU1dEZw?= =?utf-8?B?QTh1cmtUbi9UQlhiM1VuVmJoM3RKdDNSS0sxY3hQRk0rdCs3SEZwNkpFN1JG?= =?utf-8?B?OUJBUHBUazBsTXVLOWNXZk9lVTc3a0RrRVFkV2JwcmpaQ0dzaXYvemw5N3pX?= =?utf-8?B?aHFQMEwxcFNmdXhPV1JVOGE3UExrdEt0OWhiSXltNTBNZXdjek0ybDdYT1V3?= =?utf-8?B?MEc4Q1o4M3pvbUpOSnVMVkxubWZ2TmhMUjZ4Y0gwaHNRTDVGWVJ2QmdvWmVM?= =?utf-8?B?K3orQVpzbkVuVGR1QnBQdWhhSCt1U1JTbUNUVEhTd3U3T2FRajJYRUQwUnBP?= =?utf-8?B?a2NWalBFeGxhSzBTNFVXSytHQkV6eFhuc2J4U0U0cGc1MFFEeUVOdk1kUFNM?= =?utf-8?B?YmJaMVFscTVteFFyTHg2Y2VpSnltWGliMnBRbVdvZzEzV0tBZk5GOXZIZHVE?= =?utf-8?B?d1BMYWcyTWR2S0VHMTdnZE9YVFFtempGMkhNOTVOYUxXRkNTcTlVTHF5Z2xN?= =?utf-8?B?WUlIb0IxRUUzTzVyZzlseDlNNlp6S25LQ3JSTGs5T3ZSTExDZDhla29BZFU2?= =?utf-8?B?SitvRVJxelBYUjFPUlhxb0IzbzRIaVlNS1o0cTh3d0IwRkIyNUNVY0FjWnQ5?= =?utf-8?B?U0pTYnYrREo5bDhiUGJ4OWxSZk5TV1RDN1B1cXRYV2RnTlFMRkVjUmVpOHBi?= =?utf-8?B?czBSY1BUYjRGRzYveVVEa3JyNmZOVlVwRHR4Skx0bnllbDVpVmJGeHZIckQy?= =?utf-8?B?VjJ6WUVBVFBnSzFQNHJUcUNhVXFvTmpSQWswQ0lkd29PYkhZdHN4c0NWMGFT?= =?utf-8?B?TDB5bTZaN2lHMDR3ZVl5YXUrYnhFc1BONlRqK2R6UjY2RE1WQkZMaEdRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b6c42ec-2bbb-458c-4817-08dc3acfdb71 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2024 15:45:59.5458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0293 Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/dvdvideodec: Only free allocated buffers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > How has this slipped through? Answer: AVIOContext starts with an AVClass* that is unset when using ffio_init_context(). Therefore the av_freep() leads to freeing of a NULL pointer which does not segfault. > Btw: This patchset is based upon code inspection, not on reading > actual files. > > libavformat/dvdvideodec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c > index ef2d4e6df4..f2f23affb2 100644 > --- a/libavformat/dvdvideodec.c > +++ b/libavformat/dvdvideodec.c > @@ -1202,7 +1202,6 @@ static void dvdvideo_subdemux_close(AVFormatContext *s) > DVDVideoDemuxContext *c = s->priv_data; > > av_freep(&c->mpeg_pb.pub.buffer); > - av_freep(&c->mpeg_pb); > avformat_close_input(&c->mpeg_ctx); > } > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".