From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 430DF49634 for ; Wed, 14 Feb 2024 18:51:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 249DD68D1F8; Wed, 14 Feb 2024 20:51:36 +0200 (EET) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (unknown [40.92.59.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02E4268C6F3 for ; Wed, 14 Feb 2024 20:51:29 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXpPivHyUlKLGF7ZmVgNwF6xHuIit5ShSuJ5U2oiunukhCr1lbOJiI+/NJjaivJmpzhBODhcstaLSR0WZ3S4Mj1M/k9PdWcjd1cE3hc0/gaTFt3o9PDBHz/5Hbw6r8oQhlBq3rsSaTD8pt2z375a7Yn5XCopk93KKnfSg6EBpLA5geEkcvxtO4G9BwTg4IirgW+JzYR+DlZEark6VoCwgjeb49frO383uKELqphu0inX6MboG7q4ev2geBtMbZFf/z0qeFelCW4g8NSGSvK66cd4IcFaMgjP4q4l0xBIHXFYVp+W1oMLlSR51NakP1dm3NIWrryWw2A+axaeV4rYbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1QcPOZIhe6c5P0YUKtX5gwS52s09RhgBG44vjFEqExU=; b=X5eJgrNSiogT/PGfBIvpB1OJEmxHZH4Q5NIBQwQpvV4TMrpyCPlQSdNGenIakkvajvX5BQ78xbxx2Wlb1Gf34Dflvv57+HOdbVpji8QLsCjtjZws9DPJx3Bk0mkFhwECugM1GNKG/T//a66vNcmbBBd3I765xVm1ws/ejOMCUA5nEZbvbL6X2utHVyPcx1emkX+5ZZuNsFOuq9SlHnfy4DLDrVxlLvOa6VUl0HIv7ZcEPYPH1Z0ULyeiHQLNWC24YiGQo7XPDYuTUtoU49h+TRW7hMsyDGBSnUjpwmQRKGbpCoIWTTMp8mOn4GpZToUcZZ6uZ3FoZg5xfToN46wMtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1QcPOZIhe6c5P0YUKtX5gwS52s09RhgBG44vjFEqExU=; b=Jp4TLUgGcoJ60p7M0u6swjXv/dbNcOsuMhg7sTDXfHbvc6ChMdXPdGHdF2we/1l4Ah6ENmVHi2ji8muQkTmsW1aPUjSWE5mUdyPrEBFBJTQ/nXqlQ4hpYfL1PLslBjbtA3Mx39jNUU47tf6LEQHt7FRmNm/K0fT50EAFYfCn0weR6uka01t12L/XAfkXIXwREqf/hMRgFwMRzdBIJK8zW9ZQo8Fp4p8UXOI6J28UfJRrnjrHstvzBeCxViJVRKKbs5oGc04/PtDhhXEyXIfKIbX5xNGTO55tRiQNrbyf0CQ2XCi4gnBRo0K+r7c/89rpJhziswat/VYLPejLSviRCQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0253.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:279::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26; Wed, 14 Feb 2024 18:51:28 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::65aa:deb0:a18e:d48d%5]) with mapi id 15.20.7270.036; Wed, 14 Feb 2024 18:51:28 +0000 Message-ID: Date: Wed, 14 Feb 2024 19:53:22 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240213212456.167386-1-leo.izen@gmail.com> <20240213212456.167386-4-leo.izen@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20240213212456.167386-4-leo.izen@gmail.com> X-TMN: [hzlsJTXqvqoK4z44LiU+FG5J6upBTOfY3erR8GZuo+s=] X-ClientProxiedBy: ZR2P278CA0040.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <5be965ce-1c8f-47aa-954a-d6889e15993f@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0253:EE_ X-MS-Office365-Filtering-Correlation-Id: 3198ff61-3a4a-49b0-a853-08dc2d8df376 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lXYRNcj+QJOTsh6x0IyD6YgprTgso685KEYk/9gaFuRrzUSZ4tdbr0x54slNwJ55IsksRcVXV5qJiuuRIcmZ2C5BBSGd/X/2RbuqSBA20Hgc2NWFZXuaKYf5cntzf4wwLZ6kJey/aDFR2s5RwTkSR2baok/AKm9x1AKTgCQ0FSs6U5URGCm0CxAiDVx5oPGmAc7sBCK/fh+NA7zCf8olYi2VUUc7S7Y+07llABudm6CWbjgkCWe/tjbVz0LEkO5CpNUgSL/I9/GSCtMpCs6CpagQc9+ZQI2JRXIfv0VySA9i4QM8/h7RCOUomfj5GfSMU9R4NMCd5wn6nw4u3+Gx0R5cbKLPFsy+/JjxMriYZQAj2l2A89uMJVIoUggXJonOA2BZ4iWbyLCVj9BkrsmyWtasUWerDuYpxKYZF8pOQECE3Fsy/3vU0eOp3eNK29qKNvLMfz1zKN22y/TGqQij1PgOKrMDuRRVfI3ApZAVUuF1W3n3TH6ezzs2z2dqDCCFh29hQiNZsLAeb+8afjafWb6R648TvzXBFEQ3xgq9BmQuFdRNxwpX0KIxl5w+peVn X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1U5YWJMd2sxTVZoaS95dUdyQnRxOXkzUWhrdXg2dm5CZ3czQVM5N1ljN3Nu?= =?utf-8?B?NjFNOXJ5STJKNEkveldSYkVrTm1rSkRMZzgvVXhzdFhxeVZmRy9QMUVVZDM4?= =?utf-8?B?bDl4ZGI0cndsR293WVo4OVdGckFHM25hNHJ5c2JQaE9LNmkwR0lGZTZydm9u?= =?utf-8?B?K2FQajJIcHBNL21HWVd0N1VmRzNFSTJ0NGVWdTgyMjBLaGJxZFJyOWlKTlNv?= =?utf-8?B?alJvQWtuZTFtcG1IdmlrZHgvbXFNeHRIdW1MQjJvaEIyNDd0WXdHMjBMQ2tj?= =?utf-8?B?L3Q4MEFESmZhUnFpOHI5ZjNxY1hjNXJRTlM4UWVHVkV3b0Yvc3hBUkRvSGlp?= =?utf-8?B?S3hJSitPR1lJM0ZQTDgzNTNSb1U0THhHVmp3K0M0UWFYa05xMkxmNkFMcDRu?= =?utf-8?B?MWl5UUdLSzczZ3dUZlBBR05CdEdUdy95akdQZUIvVDg0cE8rUmhhd2xvNkFQ?= =?utf-8?B?L0xvM096RUQzTWN1em9JWStPaFcrU1V3WG4wbHJLanVtWTZ4c0tBWTZRc0kv?= =?utf-8?B?WjN5RUtTVUNSUm1tdFRjdWd1UVBUTUxqekM2NWdaVk8ra3MvY0VkTFllcTNS?= =?utf-8?B?K3d3MXRYb2Jxd3paZDVpTW54NWUrNitiVUtNQm5aSm1MblNVUS9WSkoyY2xW?= =?utf-8?B?YmpHS0NvOG5jVjBsd2hibS9ETDJzbzFKQS9SbjUwL1RTN1h0bjluWjUwU0tQ?= =?utf-8?B?UitEMWNESTlSb3hRcjVXK0doU3o3UVZvNEpaNUM5enduZTB0R0tlZXBZZ0Js?= =?utf-8?B?bDZYSHFob2RtaUYxaEFPRVROaTBQOUxmQzNPRXNxZjM2eitqR1JoQjgzTkdi?= =?utf-8?B?S0dKdWtuaWJWMzRhNVhxTy9HMDRkL0pXZXlZamhCSUsyVVlyemlJeVpjZXBV?= =?utf-8?B?VW5mU1hZQTdQQjU1K05JV1ExcSs5dFRYams2MDZERFJ2cWtQcnl6bUtrUllI?= =?utf-8?B?cnJpZy9xZUgvWlRqcVIrYVMxM3VVNUtIYWkrUmEyQkRLV2RCcnErcVRhc01I?= =?utf-8?B?UjkwYUg2THZkekEreFVwU3NIZmtwNzhvaVBVRHpSNlgveTQremd1dHNxcFRE?= =?utf-8?B?UzhWVXYzaFhJN3lnMmljaHRGM1M4NTh3eDRWZDc2bVdWUVQvOEtmU1NoUHo4?= =?utf-8?B?ckRGTXljdW5HVE5nclJ0MEFnL29lMXpHVHpaSkFJU1BGKzl5Ty9HbmExcmQ4?= =?utf-8?B?djU3d095R3lOc0c4RjdUcXRzREpwWDlnSnZ5UncvTVNtMTFtZldkWXZjWXVs?= =?utf-8?B?RkRpaEdOeHJQWlN2c0t5K3J2bnd1WEdFcE5JT2dUb1pPMjRzM3hEWUxPRG9v?= =?utf-8?B?Z3U0Mi9TcmVvWTlVeStnS2FnU1Z3dU9ybEFIbjZkME00YUlKNE5SUGFpUHl1?= =?utf-8?B?TFpYc2pPOEl1RjY2YjU2cmZ3cXB2SXJZb3VhK0xrRTNkbmNuNzU1M21jVlFt?= =?utf-8?B?SWJSR1pqQXNudmMweWdjSTJHdVpaMk8wN2E0Y2VwQ3lJT29CV0ozeVJXK1B3?= =?utf-8?B?ZWR3MTEzdGw2QVNpV0h2amlOYVlFT0ZEenV6WUw3d2tmTGJTMlVOSUp5OWE2?= =?utf-8?B?N3B6YU9RU3B3YnIwcTdPc2JHQWRKTjNDV202eXZLLzdnblRvRm1Qay9hZmQ1?= =?utf-8?B?NG5tTGRTbzErNU9XWGtWSGo0NmNoUDJ5SkdsODlwQWlFOVVOdWFIalFrdUY3?= =?utf-8?B?L0tEZVdzR1FUMmhNRG82aWlkNG1GRGw3TTVGMDhXV1EzN3JZOG9ZQUN3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3198ff61-3a4a-49b0-a853-08dc2d8df376 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 18:51:28.0238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0253 Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/pngenc: write eXIf chunks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Leo Izen: > Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk > to PNG files, if present. > > Signed-off-by: Leo Izen > --- > libavcodec/pngenc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c > index 50689cb50c..a302c879da 100644 > --- a/libavcodec/pngenc.c > +++ b/libavcodec/pngenc.c > @@ -413,6 +413,10 @@ static int encode_headers(AVCodecContext *avctx, const AVFrame *pict) > } > } > > + side_data = av_frame_get_side_data(pict, AV_FRAME_DATA_EXIF); > + if (side_data) > + png_write_chunk(&s->bytestream, MKTAG('e', 'X', 'I', 'f'), side_data->data, FFMIN(side_data->size, INT_MAX)); > + > side_data = av_frame_get_side_data(pict, AV_FRAME_DATA_ICC_PROFILE); > if ((ret = png_write_iccp(s, side_data))) > return ret; If I see this correctly, then these patches can lead to a situation where an input packet has rotation metadata in exif which gets exported twice -- as displaymatrix and as exif metadata side data. If the user changes the displaymatrix (e.g. applies the transformation to the image data and removes the displaymatrix side data before reencoding), the exif data (that the user would probably not be aware of) would still be there and get propagated into the output, corrupting it. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".