From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 00A7942AAC for ; Wed, 9 Nov 2022 16:37:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0ADD368B9F9; Wed, 9 Nov 2022 18:37:30 +0200 (EET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2077.outbound.protection.outlook.com [40.92.49.77]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 08E3368B52B for ; Wed, 9 Nov 2022 18:37:24 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OysF+fL3bv7cA80KTaZNDpGZQDunN0PxZ9QQTk/j8HpWNgG4YS6NhGWH1zFXfJ4DPNXkxHFM9y4PcLR7xt4TZikLgeIeJFqtdp9ba80Q0gy8UwEu+rO4E5jthBvUCaeSv7E8pZWsSfCxRa1zEcQAi/jzvKu0tbMzyX2L2J8WEhqynWxRzLShwJ4M/cv6m+oGU78jrA5P+4Q8S0UTz4s9GmQ5LrSQoJz93s868KP7UgX+OGtMLreRQyp2gBjOmQbCY5zYjz5BINdp3jTkDcFLijk/p1eosJYcyoqPcBAq/o5RTs+AEHR2/6Y21m+7GcP/MzOKACJZRrKYULcV+5qf8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QS7067VEtpbntbQOYPViFDoQ0dN7QqDQn9iHQvD7jL0=; b=hf/8hkj7oEuAuT23AF6W/Hb7buM1iXOAuUSYvN8nBX5qOlw+fFHlN2zSwCwDpNgaLB47g8Hn9HRKpAhcQauNXqwdtWIVBr8lclovyvx/kVYZwHUKMTQ0M3T5aNW0gAQmQ3Yxubp+oHy6nPWIfcnZoHmnoa0O674R2iQdmG7hpGA3zV9Y3s1ak82HWVm9k6vL+uek3Jggj4vEUxJItPuptcZiwRGzI+nT/y8gZtpbb8+6uvbIXJ+VIar7tijWcT43zoYI8Z5pjRJDD++Ng5fn+GfKJfuTNTNAybGnzwxuW7COAcaudpZ0uROCOtwFKCMGCpDEoADmpD6UwwnIuAis+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QS7067VEtpbntbQOYPViFDoQ0dN7QqDQn9iHQvD7jL0=; b=q1kumLlM7dhVOgwfxmTW7cRRH9LSxlGphu3Mb0gwUDEsBQy1LbZKhrGy3aVsi0QJgmvUAvyA13DCXrTzdyNx8lZpnp0XHYgrA4Jtn6TbV1VTHi9eghx7vNmWpWaYApBJTJoOcnSGo05ebV1gJx/2edydXYBxdVPoabulzZzDgTupmkjG/ihxwFU9LNXr5zUn6jrvUjP0GDErcGEXgge0+ndKTh9dDf5y/LEc/vbBa7p+5/rVBK3AHiXFagtz8Merneey7RQBuhEOYAbxdL7PAUcfyRxfkG4St1WCzsFzp5OCDXGbpsK2Q7UGB8Hz+6vggkFNqUbiUAXosBENKKZS6A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0141.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:239::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Wed, 9 Nov 2022 16:37:22 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::9587:72b8:e3ec:c4fe]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::9587:72b8:e3ec:c4fe%6]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 16:37:22 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 9 Nov 2022 17:37:28 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [x9s11k3eF1VGwOOXLDk5czZ1l0mH8GEfkZT3PQ6GOmI=] X-ClientProxiedBy: AM6P194CA0050.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::27) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20221109163730.344988-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0141:EE_ X-MS-Office365-Filtering-Correlation-Id: d8099b4c-ad67-47f4-5335-08dac270ace4 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmqNWn9S1x2PUOFdlA6Fd+ZoGyeHM1t/M0+dHhBnYqLZYalfPrKrhRihVbKmBSsFr6M8Hw8XGd6YadZkHbBLVCc3gktSUDr942DLCRmOci0gwScLIPdby9LbKQEKFPBj7HCOk/Q48rqYfkBeaiXBeXgKp4rjjIkoqg0RBKxDSCFnzs7K4dz62FWXo022hgnq+Gom6EsHj8CermCviRpSoCvEFXh0cIjPgHIVRG6LxGRcyod7aEGoGl0k9MeimU0m2wAI/D8oz3GdbtMyV3KXCyMY0ED1kqBMKrxaIlED5XTg3YC7Jh4XWkic+0suGusZCSoUfrVVtekZKmAqAuYhlWdTR3QVeJaaT0XgUeunMsSft73oNOR5Tfzx6XYG/BFvyGWwTS0piL1XAkjuic6xcr7TSYf+DqyzT9/pyWRjZOu+4xaOLhQdgxvIOd4qY1uuBiK09aFjVCKx5ZctlQK5x0FRcxOT8i7uosbORR8vfOkpKDSIJK47Rxg+nx8M2hB7DbvXOrYUGhezSKzSIspFqqaCA1HRVy5JVQpyObFk+GgXSC/fospkHn+a9+wDLSpUtX6kE0fkUIf0S+ydBdvGvHEpcLVSUYvx4So7qCkLo6lzWchjWAK4SnEYt1yqlwVfDTkvtHHoiWO1Omvgk2zKP2+KV5SpCibzLGY4WiaDzPSlEAmhjTM2ZUtBmu8XzYBsZkpkBkCQjjlnBU+t7rASqv946KGVa3IcHVSmslpeXhE3gImTxxpx/q7PcS7Lo6K7DiY= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: imMjpJa6lvm7IbbS/FgMzIOqTmhkDvCHg30HLWY4U7D7S/cHCfWO4vBaL0DkuwKwKeiC16FXQ9Vw0QGDsygPX/em2zMra9BT1b7dSOVQpJN6Sw1zyo8Wl90WztlN7nP33RQGvxLJwdaEjDhFmR8UHQB70mlKoEL8g1KRMPt5xfCb/gz4LeJ4n34LePdZB1gNXbNjxrXL/+ooo6PrUoSkXSSrlAZBe8he/8aAS7Y74pCefRpCjvA05LFadlH1qPfM6bXdo41n6rw8AM2qdjo0qkj8oIgDcwIqBLgiCNgXQEoncRhk/ScsLKsRl1aqhfeN/8A120JQ4iai2puXnHCvJ1ZaQCOYI/MV1b5XBh/sSGzlqXIBkfSKaBmJfRaWo4rJTvpzC8oeLUufT3KW3cYh5UR26F2Xs0QROmNBFJtI0vFmMjqjPwLRyb2RTbthMdO9s2vFEBO+dINlFOaHMQukSaz7LTujKDH4wLJ0BNicyibcF6cVHA2BZRfljmxV7kVtPXuK4vq1sAoAK2n8PIo9PGJkixV7jBq5gtulCJPcbukOyvlxsTt9LeUtIBSa/4DaVfA+VjkuNDf4ZBVqa9km+QJk5DckI5zxxYFbtnR+xpVoT0NntfXzhwv/hDEfcaHmOTO13HGs6RkQFLI+HcUbC3WRJGtoQ/N0Ps1Chrt/LCfjt8hzrebVUe+1DVsRhUlr X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vrTFaF4yFgkh2aR5YxRNro+EXbi3fEOiWEhhLPpMYCMeQUF2STmZwJAoGWCl?= =?us-ascii?Q?m37MOZtFEB0oFD+vR4EZDR3s9T99Ng1ItXujwyejjZEkarYhQLK/r7bNCtbL?= =?us-ascii?Q?FyerwG/qCg343TKBHbP/q2X1+uLYo/ody1KtHXjBgG6omDNcTPdLMLtpSSfY?= =?us-ascii?Q?lsbayWrxcvkqF99/ROhLbVUpKkEH+0U1pc0eXBZ9L+hGwfNLyf2f2h/6tKla?= =?us-ascii?Q?dJf7NkEfu2VqjuNYtzBWm3l9kIX72F6e0vtL476BfMWrumU+Yct5oKXwiuK+?= =?us-ascii?Q?s7jJ1hMUatC8oq2FX5Vqwgr2oRGNALaxqdpxrtlR+gJFkV1MKiD5uUQyWyis?= =?us-ascii?Q?TAg5xK0gjOjTMo6WI+yOhBe12ndqCuMr4Nw7o1z7LWcFvtj3geRawHgdXqWV?= =?us-ascii?Q?8lmA/K/yn+zeWpFtTBsn89uKBZR8q7WsOPfdT3OL9qVLqDnbEBedqC784AdJ?= =?us-ascii?Q?R8yneXItFsYR1KSOQBN1drIU3mIocZUwrsL9iySmlOJdJ4pFzUkjwsN5cLzs?= =?us-ascii?Q?XzkUVWl4Vf7YK6Dce3o9oc3BC0cJVwk57G/z4JCplCSwWOE/SYXsuYULGOBx?= =?us-ascii?Q?4JEpKDZDqyiMdv/DDGu+BOEBWRJFFKlm2Dt8088SZhPeVvmwjAGlQ+ln1WIT?= =?us-ascii?Q?RPb3av69iLbDnF9VgeL9DaqWLtJcjvBKSuvlejd14cVP/CCJsilUmouOclSd?= =?us-ascii?Q?YTiW2sGR5AHlHVOQ6XKZMNi7vbEkNqCGHv8oma1KWIEdkf0/TO7VETczHq+D?= =?us-ascii?Q?C/WszR/5zKtJ5kG2MTscx9Kio/QHmmw7TS/K7BKV0RoEFadP/5qtTkaNoLqc?= =?us-ascii?Q?W4bHvwnJI2tqhO9V1W188TFhHBUbKTepdV/ZBc4b/VUHMErFosqkJLtJvfZ+?= =?us-ascii?Q?8RpakIWPF62bsh82pyvXqBofEOB8Q1OZ+y/YZhDRIMXImkyqVJY7SLM8HTeB?= =?us-ascii?Q?bTpkCjjBQlaGrZjixvb+8z1TvlNXK0sdQvAzxTkMy6V/cuDdo/HEAXQ/Eboe?= =?us-ascii?Q?sEzovIturnrY+B7sWtLqnHCMiKd3QQCJhJzuAiwVBDyVq4mjEA2v1rAGJGXU?= =?us-ascii?Q?gC07c7jg+IDoZQuQwvaMv91r6qfyiPhJ8Atf11bF3kV4EhNfMqNajhHhtdLZ?= =?us-ascii?Q?yMSZA/4ULWtXlF6mYCw9KP7iLzx7JjpD0SPDIqH90furz9zP6zG7lRzV4UaC?= =?us-ascii?Q?6C2wKSh/5PJcnwP5+S0V/j0uOXb7lAmHuVGokjkEW+YsZTnirKXzS9dgMDTD?= =?us-ascii?Q?R/SIM9GrZuUQJ4M2bKm00R13GgoUXXqLzbXcdFu6sbI0CPDKDFlHt4SdBMtS?= =?us-ascii?Q?7xoFRuCZdIZNyLCB32wJoqgG?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8099b4c-ad67-47f4-5335-08dac270ace4 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 16:37:22.1147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0141 Subject: [FFmpeg-devel] [PATCH 2/4] avfilter/vf_fftfilt: Check return value of av_tx_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Should fix Coverity issue #1516765. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_fftfilt.c | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_fftfilt.c b/libavfilter/vf_fftfilt.c index 067ce7eb30..231e74fd72 100644 --- a/libavfilter/vf_fftfilt.c +++ b/libavfilter/vf_fftfilt.c @@ -306,7 +306,7 @@ static int config_props(AVFilterLink *inlink) { FFTFILTContext *s = inlink->dst->priv; const AVPixFmtDescriptor *desc; - int i, plane; + int err, i, plane; desc = av_pix_fmt_desc_get(inlink->format); s->depth = desc->comp[0].depth; @@ -335,12 +335,14 @@ static int config_props(AVFilterLink *inlink) for (int j = 0; j < s->nb_threads; j++) { float scale = 1.f, iscale = 1.f; - av_tx_init(&s->hrdft[j][i], &s->htx_fn, AV_TX_FLOAT_RDFT, 0, 1 << s->rdft_hbits[i], &scale, 0); - if (!s->hrdft[j][i]) - return AVERROR(ENOMEM); - av_tx_init(&s->ihrdft[j][i], &s->ihtx_fn, AV_TX_FLOAT_RDFT, 1, 1 << s->rdft_hbits[i], &iscale, 0); - if (!s->ihrdft[j][i]) - return AVERROR(ENOMEM); + err = av_tx_init(&s->hrdft[j][i], &s->htx_fn, AV_TX_FLOAT_RDFT, + 0, 1 << s->rdft_hbits[i], &scale, 0); + if (err < 0) + return err; + err = av_tx_init(&s->ihrdft[j][i], &s->ihtx_fn, AV_TX_FLOAT_RDFT, + 1, 1 << s->rdft_hbits[i], &iscale, 0); + if (err < 0) + return err; } /* RDFT - Array initialization for Vertical pass*/ @@ -356,12 +358,14 @@ static int config_props(AVFilterLink *inlink) for (int j = 0; j < s->nb_threads; j++) { float scale = 1.f, iscale = 1.f; - av_tx_init(&s->vrdft[j][i], &s->vtx_fn, AV_TX_FLOAT_RDFT, 0, 1 << s->rdft_vbits[i], &scale, 0); - if (!s->vrdft[j][i]) - return AVERROR(ENOMEM); - av_tx_init(&s->ivrdft[j][i], &s->ivtx_fn, AV_TX_FLOAT_RDFT, 1, 1 << s->rdft_vbits[i], &iscale, 0); - if (!s->ivrdft[j][i]) - return AVERROR(ENOMEM); + err = av_tx_init(&s->vrdft[j][i], &s->vtx_fn, AV_TX_FLOAT_RDFT, + 0, 1 << s->rdft_vbits[i], &scale, 0); + if (err < 0) + return err; + err = av_tx_init(&s->ivrdft[j][i], &s->ivtx_fn, AV_TX_FLOAT_RDFT, + 1, 1 << s->rdft_vbits[i], &iscale, 0); + if (err < 0) + return err; } } -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".