From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC10B47609 for ; Sat, 14 Oct 2023 20:04:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D8DDE68C743; Sat, 14 Oct 2023 23:04:10 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04olkn2049.outbound.protection.outlook.com [40.92.75.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8AB8A68C7BF for ; Sat, 14 Oct 2023 23:04:03 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpex7Ba/IyrJnw8TTNlPDhDAz4OUhT1SSbZh252YEvbRGw1yV9cnxNZo0ErNze5f3DyXOdrD59CqKRHaiOWhxnYSeM9z5YIEzDpxpqL8I6U4EbpGDWYQ58JRIcpPs28RbNXyLSs2jhGcilIyfWMiHVvJW6mJ0Yi47xTpsgLguyshQ1UnirYP+Y63RaVzRm+O8jSJ4r69ZPmnOgxXQxHlfmH7gqp+Om1g1i0iUn9jIj6ZqlEbIuxQzu0B10Qkg7e7JNEesmLrasUA12Qyq15EjpmdJUEOLsOjIoxAxo8Q7NhuyMQuWOmbQUbilQhitpzasjnxH6/8lDThM3ZQlOO+0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aUxYiu0ZQC8gBCSRt7Tu1+DDg8OLN9cJkqcLRe1EvKM=; b=Rj0f51w/BiIghDvpuMXqu4idsLAGrR4l43RF2WS6PGu4OrGeKjSoHSI4tfSP4oYvrduHZblwm1izxHmKGBMluEUpacEJ4kYpElqYN08pLZzBJn3yiF42ENuXsAxalFEHATY48qqMsZgdqwRZXeGSs/q2rvnfrjC3eA+373jH6skia3OdFVVpxEsLGspcOAGLK3yp68b52Y9HJ5HHL5qhCcNwCNXBWDwpR58YZmxSAZ91k3SQBLheeVQFcroHWwkOPCjaIxYb6aXLjkE0aonMIvHo/WQ5VkHsvVrll1wl7pvBpnlwk/PfHoKz8xir8p35bAlCWz+7inCsI66pvescuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aUxYiu0ZQC8gBCSRt7Tu1+DDg8OLN9cJkqcLRe1EvKM=; b=tr5/GsGxjrs63+2Jm3FePzUhLKFwHckMuIoVlLFZ21jCSb4Af7KWj5GNLE7n4N2pQGC+AJkWEW3mnYaEA8TTOY0c4r5qU3PUtM1Bpf+v+L0C36+PNE0GhMhu6odidkVWhWFZfnn7Roj7KhpOdjSEYFM5v/0pHf88BsmslK3yh6bEbqs6hduzDJQ67J9pMco6eaNBrKWShXiwY/+HDYKMElqVs8Gg5+Etreue51dYhFZbOsOCQOLYXVNhG5nojDdc5diPA9zXdaR5lgULMqGSBJqv4UtKE5OxJHKe9+ZVL0KyruL9GbPNMnVCxOThgY3ZCZcfVSHAYjgpkkrqPFE5ig== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AM8P250MB0092.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:36f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.47; Sat, 14 Oct 2023 20:04:01 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::3126:4823:194e:6f86]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::3126:4823:194e:6f86%4]) with mapi id 15.20.6863.043; Sat, 14 Oct 2023 20:04:01 +0000 Message-ID: Date: Sat, 14 Oct 2023 22:05:17 +0200 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231007203432.GS3543730@pb2> From: Andreas Rheinhardt In-Reply-To: <20231007203432.GS3543730@pb2> X-TMN: [OYrQVt4QAAECKiqZ1b7HscLBhURxCt58fatC0ScYzMM=] X-ClientProxiedBy: FR4P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b8::19) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AM8P250MB0092:EE_ X-MS-Office365-Filtering-Correlation-Id: abaf7d01-36a9-42a0-c1ed-08dbccf0b578 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m7LgAitTMOI1/NYojjvjseU/Di60C6yTLHSRRWAu20MuaFvy3xkIcdl9+cz1zXBorXZXe4otkiPYTupjbWWYvEqK/bl+6d9QwgyqUX3Syz4l8RPNV/j1ESVMU6Rt1VgBRZU+/I2m/UpvdVXa0pDBRofLeFaMh3G64I1fA8LFcLGxEBBGhjYGmhTFXeI8vo/iMe+VOmreHG1SstI2oQu+NeL6kRLUqci4svOxivaluG7FYxOsIPq+CSf0HOm4deNZ/cjNrS65t7bUjZIU4wiPh4EAGundNZ9lvE/dO/v6a20RITHERqpvLazQiranLznn8ntJkCwI9RYf5K7XlW29j6CxDTJaPJaoEo2oJ8pZTKW7m8mNtXtF/pU8wtAadEWF1r75atpadGRyCA1ucWMehw2mjwhnMMRbRv3fghk5xC6GtutUNR7kfT9lNFIqZazcezf6v18mW0lw4y4UjvI3kDtpRIcq7Rcm/trG2XxCA6zrZ524uY/snDI9Ivz5ThyLnkRF1/Kl+M6oG2RWv06Q18/OeomTHOUdEIUzQw69dX5vhX/YYFCRWJ9hUyFm5XVOqQVXG386IOG7LXTGRTgUh6YgEKdIASh/yRYP5b37px8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDhGRS9XUXFCUEg0QUtzOTBpeE05WEE3U1d2cWNjaVNzYkc1WEJQMHE0MXFk?= =?utf-8?B?SzFVVFk2emFGK0VJM3h2Rm9TNXVrbEJoQm96aDNoQmM3VnJodmFKM1NOV0oy?= =?utf-8?B?YXJCZC9FV0xQL3RhRy9QcmhlQ3pER2hHQnl5TXAxR0k0eWgybWJWYXNBTXJx?= =?utf-8?B?RktnbEZtL2U1RzdxK1hmcXAzVERlczIvTDYyMVVtUlpLdjBCMjZocTkrSU9x?= =?utf-8?B?dFpvaFJvc3pvczd1alRQelV4eVlmK2t1dVd2ejJtMTBEc3RkQy9KTlFlZXpL?= =?utf-8?B?NjkwVjFpRUhsMjgyTzU4cGRNSGdIdGdieStPbEMwNXNsdXl5bnJvS0dqVkVj?= =?utf-8?B?QTlhYlhIZXA5Q3RLUEhxY0pSRGoreXNOVDFPWHFMVFFFWGJKSENEM29vcGo3?= =?utf-8?B?U2hlUkR6V2VwRjZyb2hwRjdSKzhvT01oN3MyNkI4bm14Z3FYaWdNY0d6akJC?= =?utf-8?B?NDRvSGhydG1YbDRWMTQyUk5QaTdqOUdVWjhEVTB0RW1HR3ZiSlNlZjgxbno0?= =?utf-8?B?ZzA1aDIzeUVGbDc5NUx0OWxMZm9pcDBZeUNOcGhlbXQ0eVkwMkxwRUxwUncw?= =?utf-8?B?NTJjaUR6dkE2YWFOTFA1SFFuUHhSSmZVc2RjSmo3MU1NOTVXbGNVSTNDL21x?= =?utf-8?B?TU9ZOHFTRlc3bTJDV1cvZHlFR0k0elFDWHMrdnorOVozZWM5Uk40Uzl4N0xS?= =?utf-8?B?MEZzbVJrSWxPTmUrZk8wWmFVTGh0cEgvWWJhemtUaldQV3RZbFpoNGFJRll2?= =?utf-8?B?NDE4aFFXSU41cWNNTE41Q0NQaXRiN0NDc3J4cTJnT0VLTk5RTzdESTkwUTNL?= =?utf-8?B?dzhoVTdUM2RPWUViK0ZLc2JkTUxtTUNRbHl4NllDUklxYzlmMmJRcHIrZmhO?= =?utf-8?B?TEJuZlNTYXpYMWZSUjlQZ0xlc1QxdEE0RUR6T3dzMk0wdzdMSXh3SGFXekFE?= =?utf-8?B?UmdYTS9oMmRER0VkN1B0SDY1QzZNYzhuTEE0Z3FXRUxXZUVIMzhid0xHVzd5?= =?utf-8?B?VStpQi9FaERwL204QTNIN0s5TFp1NW5BSlp1S2xGZHVqeWFQeU8yTTl3dDg1?= =?utf-8?B?aW9NTlYrbGE3bzdBMVhjWFo5NW9SaVlhK0lSQkZiWHFTVFdkYmlNQ1h0QWtI?= =?utf-8?B?SFp3cmEvRkxnOFR6WGxpclJmSGtseGZrMUJXUVh4OEUzRzhlSThCUWN6clZz?= =?utf-8?B?ZG5YWTFPcmdMTlRtSE9VSFREVVRMUXB1ZGc5QWFsZEFQeHBJR2VGMUF0V3hD?= =?utf-8?B?YVZoSXpWOU5qbXRpSm1rY1BoOUZDRW9wKzlZRWpRNGw1KzQxVFQwbjNLaVIr?= =?utf-8?B?V0ZWWnFlZXJYWEg0VmcrZGtmOE1jMG5mMUxLbWFhVk5vZk40S1psRWQvTkRx?= =?utf-8?B?ZjdWcGgzS29mRnpqUHJYU3F6TVE2KzRyYlhVVnNhN1VFUVMvcDdXRFBLcnpw?= =?utf-8?B?V2l6c0pydkZLYmdlaTBwai9Ea1VEYng1alhRNy9nUFhzZnJFb0FaV3ZQaEM4?= =?utf-8?B?NHJLaU4xckpNNVhwZGcvd0FNaU5iWVVZSzdPQ2U4K1RxVnRpd21CNEZCS3dN?= =?utf-8?B?TWZxdDZwd2dFTmJHM3IzcnNId2dwaGtDbnAxWmYrMUtJWGVVdThkWFNuVFNv?= =?utf-8?B?UHBFL29aZEYwTUlpQkxSallPWG01SitqdlpZSzB3TFg2bW5DaDhEME44VlEv?= =?utf-8?Q?sXAfafHfSzKkoAiZ2sPK?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: abaf7d01-36a9-42a0-c1ed-08dbccf0b578 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2023 20:04:01.4431 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0092 Subject: Re: [FFmpeg-devel] [PATCH 2/7] avcodec/h261dec, vc1dec: Don't set write-only macroblock dimensions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Sat, Oct 07, 2023 at 02:40:26AM +0200, Andreas Rheinhardt wrote: >> They are generally set in ff_mpv_init_context_frame() >> (mostly called by ff_mpv_common_init()); setting them >> somewhere else should be avoided. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/h261dec.c | 6 ------ >> libavcodec/vc1dec.c | 3 --- >> 2 files changed, 9 deletions(-) > > This seems to break several vc1 files like > vlcticket/5887/Cruise\ 2012_07_29_19_02_16.wmv > > I think its there: > https://streams.videolan.org/issues/5887/ > Thanks for testing, much appreciated. The reason for this is line 968, where mb_height is used before ff_mpv_common_init() is called. This actually points to a potential bug: On frame size changes (can happen in ff_vc1_decode_entry_point()), this line would still use the old value of mb_height. But I don't want to deal with this at the moment, so I'll simply drop the vc1dec.c stuff from this patch and apply only h261dec.c. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".