[FFmpeg-devel] [PATCH 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t

[FFmpeg-devel] [PATCH 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t

[remi]

From: Rémi Denis-Courmont <remi@remlab.net>

While this probably never overflows, we are better safe than sorry.

The callback prototype should probably also use ptrdiff_t or size_t but
I  diggress.
---
 libavcodec/vorbisdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c
index 38a5367be3..9728997370 100644
--- a/libavcodec/vorbisdec.c
+++ b/libavcodec/vorbisdec.c
@@ -1581,7 +1581,7 @@ static inline int vorbis_residue_decode(vorbis_context *vc, vorbis_residue *vr,
 
 void ff_vorbis_inverse_coupling(float *mag, float *ang, intptr_t blocksize)
 {
-    int i;
+    ptrdiff_t i;
     for (i = 0;  i < blocksize;  i++) {
         if (mag[i] > 0.0) {
             if (ang[i] > 0.0) {
-- 
2.37.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t

[Andreas Rheinhardt]

remi@remlab.net:
> From: Rémi Denis-Courmont <remi@remlab.net>
> 
> While this probably never overflows, we are better safe than sorry.
> 
> The callback prototype should probably also use ptrdiff_t or size_t but
> I  diggress.
> ---
>  libavcodec/vorbisdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c
> index 38a5367be3..9728997370 100644
> --- a/libavcodec/vorbisdec.c
> +++ b/libavcodec/vorbisdec.c
> @@ -1581,7 +1581,7 @@ static inline int vorbis_residue_decode(vorbis_context *vc, vorbis_residue *vr,
>  
>  void ff_vorbis_inverse_coupling(float *mag, float *ang, intptr_t blocksize)
>  {
> -    int i;
> +    ptrdiff_t i;
>      for (i = 0;  i < blocksize;  i++) {
>          if (mag[i] > 0.0) {
>              if (ang[i] > 0.0) {

We allow the C99 "for (ptrdiff_t i = 0;".

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".