From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> To: ffmpeg-devel@ffmpeg.org Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Subject: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: Don't leave out ... in calls to variadic macros Date: Mon, 19 Feb 2024 14:37:26 +0100 Message-ID: <AS8P250MB074470A0694FD2E9D5ABDEC78F512@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw) It is undefined behaviour (see C11, 6.10.3 (4); see also 14dd0a9057019e97ff9438f6cc1502f6922acb85). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> --- libavcodec/cbs_vp8.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c index eabdef358f..1f7e81cfe6 100644 --- a/libavcodec/cbs_vp8.c +++ b/libavcodec/cbs_vp8.c @@ -223,19 +223,19 @@ static int cbs_vp8_read_unsigned_le(CodedBitstreamContext *ctx, GetBitContext *g #define SUBSCRIPTS(subs, ...) \ (subs > 0 ? ((int[subs + 1]){subs, __VA_ARGS__}) : NULL) -#define f(width, name) xf(width, name, 0) +#define f(width, name) xf(width, name, 0, ) // bool [de|en]coder methods. -#define bc_f(width, name) bc_unsigned_subs(width, DEFAULT_PROB, true, name, 0) -#define bc_s(width, name) bc_signed_subs(width, DEFAULT_PROB, name, 0) +#define bc_f(width, name) bc_unsigned_subs(width, DEFAULT_PROB, true, name, 0, ) +#define bc_s(width, name) bc_signed_subs(width, DEFAULT_PROB, name, 0, ) #define bc_fs(width, name, subs, ...) \ bc_unsigned_subs(width, DEFAULT_PROB, true, name, subs, __VA_ARGS__) #define bc_ss(width, name, subs, ...) \ bc_signed_subs(width, DEFAULT_PROB, name, subs, __VA_ARGS__) // bool [de|en]coder methods for boolean value and disable tracing. -#define bc_b(name) bc_unsigned_subs(1, DEFAULT_PROB, false, name, 0) -#define bc_b_prob(prob, name) bc_unsigned_subs(1, prob, false, name, 0) +#define bc_b(name) bc_unsigned_subs(1, DEFAULT_PROB, false, name, 0, ) +#define bc_b_prob(prob, name) bc_unsigned_subs(1, prob, false, name, 0, ) #define READ #define READWRITE read -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2024-02-19 13:35 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-19 13:37 Andreas Rheinhardt [this message] 2024-02-21 17:04 ` Andreas Rheinhardt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8P250MB074470A0694FD2E9D5ABDEC78F512@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \ --to=andreas.rheinhardt@outlook.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git