From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DECAF4B56A for ; Sat, 8 Jun 2024 13:47:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D56DD68D6A1; Sat, 8 Jun 2024 16:47:23 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01olkn2095.outbound.protection.outlook.com [40.92.64.95]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 346FD68D428 for ; Sat, 8 Jun 2024 16:47:18 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jW+8xS5CRiCKKfhdlczy3toveP4/rUK4JJo4AhtM+Vdvkiussjr8hSDcEDfsYHyEL5dBPfU7p09zXuOG9afvlHQpweU82Y+qaYuneCGNFHq/rpTiUHmcrFHRyP0z4uL3/i11DBcu7efGYcxxbu31gbJE3dcZWLbnw5L/Gs0FEXSA1bZ7JrzOqfH+WsuOFUsEAlAtNwkyilL4zEyx3XiSxVqwqmVNQtRDYugdUawukNchwDZapbTANr85F/z5XkLFpDebbxoQDWM7w10f/xBg40d60RPF+2PObHpDe7CgGGG2AR9y89MrR2MTFirl7kxQ0Px2oeG+buVWBewCN7y27w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hX7hL1hkbgml3Tr36ZQInwS1EWSCWtitd1V2JFzOwSw=; b=niGmhZJJHE4RZ31O3Wu66Gu+FGXSpG5LGPyGR7P1Gm4m7LbBFE3kp8sQV/A1OkGML7q/oAGyw9e9iMvWnWPA0yytItY7dT72+1KI/bz/o12e3yjlLR3hm9Tm7sIk6AGwTAWvF20FK7V8cPzHphkK9mBd/KtRJ7jWQVMqw9x/iD+sDQBfSMeSQUENbjOg8H+Egz6DBnh5WpJUFqclbTfKxWSfJl8VK4925/oUzcIO59qqRevYLPEZjLAv0x3GV2CCgDX0wqf1NWlHosdhNvJjd1ziaM9ylVLMI03vut+x7wUm5En8AyB/9W4zbmTSVXmR/kYmPGeTD/0Vva+zBUnLFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hX7hL1hkbgml3Tr36ZQInwS1EWSCWtitd1V2JFzOwSw=; b=uKzzpQz5Tn/sl1ooQkpO9Wuwr3Go1/BlyfCai4LWcPHusy9xRR734qV/E9aME+cATfnERGXaA/70WzlfNwPWH1CWplAr1v3RvOnHfhJyrpHDkN/haFuv4HuojfmkVhOzLvQUFNxxZJzTIuucv+25aztn36/Eiy3qk/TtO1UGWwXnng8VA6lwNSit54Ax5+ahtrxyQQBDdtVefwCPNTPZYOp9F2oQevv4MVjzoVjwAv2vWp+sUDB5XGNWe+bzm7o8ExRy/P4BuNoVIvR2DhzdCxPDtt3/LoncHhtBStehkaur3YVKipzGpq6PX8deEJo1TL2pDeAXzOU6qTWR83Ao4g== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0080.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:271::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Sat, 8 Jun 2024 13:47:16 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7633.021; Sat, 8 Jun 2024 13:47:16 +0000 Message-ID: Date: Sat, 8 Jun 2024 15:47:13 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <5b83443361479c11a5975c8dd308375a0f101e59.1717837373.git.pross@xvid.org> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-TMN: [YzrdPlcffuyTuScAj/up5w5CfkxaRt95Dv91rbIifiw=] X-ClientProxiedBy: ZR0P278CA0140.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::19) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0080:EE_ X-MS-Office365-Filtering-Correlation-Id: e9ba0b9a-fb63-4b62-a8d7-08dc87c1824e X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|3412199016|440099019|1602099003; X-Microsoft-Antispam-Message-Info: ilrKa8Qd9wXT5Kai4oGLxjZjSmoFHipjRIVd3OK2rlPAuVguAk6oIBc+ugulkTm4pAYvg3hShp/aA6s1LkMOaS3CcEh18CFlJERzrQuq+TCKLtbAn6ZTtkacs1lF061V8iR3YJReB48Q3XZduOuxMndm7jCBnjOrkxCZFW6pWNLav0w+oxrGPX6CgWjqwz8iIWkehujBEwIQ8ArGb9tODfWkHWT7bxXTaS4tfVh6TPIo1bixn9qJhKbnrUi+sbwWK+uVvSOSIfOXb0hg0F3VVcvCkm4Lt1kkJtCZ21/Ns5B00/7sfLLNRt8sDJxZbAMr22Ks5FxvGhwBWbz+2MvDjCNH5FjxL5xWdqd/eZrxUW5YaP12AJ721sG7szEaKpfZkpgvXVJfHUfgpIfV5BoHlEZBFBJbIzhKi2C6Z0tH8Py0TpVaYNFk8ALgD5P6JrCeoBR0y/Xprc/JsGUJRvR0cSPngYnPXTwCATWqKzzQPQcvqOSzgBTPkPjxQ7MlcILWUIZp+YoTkT3AmPvR2QyKEaFs1fjK5qWxnejatJhojAWa92uMtu235VlDPDvpQXG9SJ2w75Bj8ubKHxqtFojA6bm+cnVaZ9gGhgNFdi/rpeg/0U+3RPMaLYErOt80QsDNQkGCJgFJG7mSXMlHzCtaZG01snXjO6hBJR9zfUW+Ue0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVJPTm1YRURCcjlOV0lwZXRyQUU0Zm42YUZiY1E0dTJqZzRGVmszNWhaQ2Fn?= =?utf-8?B?citycTl6UFRnVm1CYWthR0x5dHpyS3A2SHFubXpXSkUzbiticXd1bWZuRWFl?= =?utf-8?B?OXo3bXFVOVFFYkdveHNwTUZDenkvYlRCVUlrNW5sdndsRlgzNWlsUkFiR2ZK?= =?utf-8?B?NGpRUWtMaHlHZjMwekEwcXo4eVRqL0xIdmhGUWhjTzRGQ0FucnF1M0ZheVNn?= =?utf-8?B?dkdVTnVLOWFRMU1EdUdYNkl2VkZ4bHcxeXdOZEJiOWYyeW5BQWkrYk5jWXZ4?= =?utf-8?B?dFlvdVhOZDFnNk5sN2ZoK0MxcFhWcUhnY2E0SVNxQnFFeDkyS2NEOGVjMVF3?= =?utf-8?B?V3Q0YWI2c3VPTW4vd1VBa000dzR0TDJKcHYxYTVjanNjSTU1YzFpak9NSkhn?= =?utf-8?B?cDIra3gvc0ZWS1ZzZHpBblZXYjJlREcwb3l3V01PcWEwY1FsbEZtMVVEb0pK?= =?utf-8?B?elBKU2h5V21zZ25mV0VvemNUVHJTY2xXOU14a0VuUWhheVZlZUVSdlBNelVp?= =?utf-8?B?cnZBZ0hKVGpDMnJaWE12OUE4SjNmY2VuaWRVdENLVGQzcGtUK2Zta3VkNTEz?= =?utf-8?B?U0ZYNjcwQituN1dlVGxVV1YrUStnKzNrNTQvYkVQWWRCSmNRY2ppb3k2aU5U?= =?utf-8?B?empHSnovMUhxZTJVcHYxUTc4NUdrbFk1UHFhQXdaM3dra2tQRGRBc25hbjRk?= =?utf-8?B?ZHBsemFxWHNQaXdzZGRsKzBsTnZDRVVFUkdzNG9ZRG9zTXRMelIvU2dMdlNr?= =?utf-8?B?U2hXU2t4dVltMUs0WU5ZVDE3TzYyeW5SWEdDWEdBVWtzOVJ3UFk1ajBvUitO?= =?utf-8?B?NnIrK2EwRll5K3ZwS1A4cVI4SnJLR3Zzc2xJSGNRVmdnME9qVW40NVZjTVR6?= =?utf-8?B?cU02clVEQWVMT000ampKRDJnbDdjK3ordGJidHUvRHR6b0FBSldJQm1BRkJu?= =?utf-8?B?Zld3bmVyRXZvZ0ZwSHh6VjhDdE9HRzBuMk1ua1UyNFpWME54SnRqYk9nODBv?= =?utf-8?B?TE1EMDFtUFhwVlpKR0NWcUtNVE56STdkVUhiSjFua2ZjeUpWMDJHQ2lORlZJ?= =?utf-8?B?cUNxK21iSlBMNjFLdkNTbE9WTUFoeGZmNjVnUlJ6RkpCdWNBSnpqc0NOOE5Y?= =?utf-8?B?Ry9QQWNoVTNDTVFvOUNJKzJFUzlXaFNqZ29NMEFjMHl3QkFvSDNaeks5Si91?= =?utf-8?B?WDR4SkJlQVpRaTdZOGo5WTRPZ042K3M3TjIrbmJ1eWRBbDVZY05UOHpuNmFT?= =?utf-8?B?STdPLy9TVmNDUUpiTDR1KzZ3YU9rSXhCdThFK3hHd1NTOHk3TnVPZDRZQnJ3?= =?utf-8?B?S3FzSUZ2UDVta3ppNitaU0ROajFpYVluVVBkbjBlMHpacWZzR1BJMmFQd1JK?= =?utf-8?B?Tk9WR3VybXRjOERLcmNVL3RqK0d2ZUVYTmRvOGJRKzNLa3piR3RkNjZ2bkxp?= =?utf-8?B?alphQ29ZWjhMaDcyQVplMWFGVTJpZ0VKNTNBWjhVczdmVWlJdUJiWThwaUU4?= =?utf-8?B?c2E3VWxDMmNUUGNuQTkxY2ZPdEVpQ1hNQ1JzYnlwNjh0eDdvMzZFd2RvWmZm?= =?utf-8?B?SHpEcU9FWGFsZWNEWW12RFdVYi9oMmhxeHkyWjZZTzFRdkJIdWUrakVLeEIv?= =?utf-8?B?enkzcU9NR3lIYnNCcTdqTk5xTVA3aWlsSjRvM3VPK2JYb2J4OS9UNU8yYTln?= =?utf-8?B?WkV3b3Y3cmVSMnpRTWcveWJrK2tQSXc2bDZnRGoxUHcxenlTTCtLandBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9ba0b9a-fb63-4b62-a8d7-08dc87c1824e X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2024 13:47:16.6049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0080 Subject: Re: [FFmpeg-devel] [PATCH 2/4] mm: decode partial palette X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Peter Ross: > --- > palette decoding now conforms to description at https://wiki.multimedia.cx/index.php/IBM_PhotoMotion > > libavcodec/mmvideo.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c > index 3038d9ea92..b5b6ffd25b 100644 > --- a/libavcodec/mmvideo.c > +++ b/libavcodec/mmvideo.c > @@ -79,12 +79,10 @@ static av_cold int mm_decode_init(AVCodecContext *avctx) > static void mm_decode_pal(MmContext *s) > { > int i; > - > - bytestream2_skip(&s->gb, 4); > - for (i = 0; i < 128; i++) { > - s->palette[i] = 0xFFU << 24 | bytestream2_get_be24(&s->gb); > - s->palette[i+128] = s->palette[i]<<2; > - } > + int start = bytestream2_get_le16(&s->gb); > + int count = bytestream2_get_le16(&s->gb); > + for (i = 0; i < count; i++) You can use loop-scope for the iterator here and save a line. > + s->palette[start+i] = 0xFFU << 24 | (bytestream2_get_be24(&s->gb) << 2); > } > > /** _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".