From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AE35D4AD3A for ; Mon, 20 May 2024 20:57:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD84668D232; Mon, 20 May 2024 23:57:09 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2069.outbound.protection.outlook.com [40.92.90.69]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 932E268CEBC for ; Mon, 20 May 2024 23:57:03 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AbqjoDTBY5rZtg7KEL9ZEdIMoFF+UWx9PqgE2H95D8hntcTk/y+1yGNcv5/daegIsoe0qBLubySVTQ9j5CCL4S4jvulJSS5kKw/39c7Lv3lVY7KXiJCSe+54HqXs3UA1lqzQEmQdem5v6B7FrjuLyXHyWVpcG1Uj808Qgl+4Cjxz1Fpv1I3qmNYy8i0GiZALTfpnG8nhQ0A10FW45MevjTVbORhOkiJVckPIZ8rKHHPFNvCB+r5tWmPoIpyDWYbRZO30E8zWw/oX7YlsVHpBgQiqRU2fxbD13xOoT9rgWHJi88mVkM5veqXP+VVizCN+IUac9V+L+XxgIVL0KVKLZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dEcbZn4kVRjgC/SKdr4jUop0lz0TslMYOphqBw6PJ7M=; b=Dtj226e56w/yW2Sazij/TU2kTDFLgMsOO9kt8l0o1n/lGHrt8kheOsxXtSZpeQCPrOTl8ZBryGl4/lzwaJteXJ+j1HitGbL9aJTOomrP8JVj/umVyktOxFO8RmWv+yT9OfWcifMfJIPK30ccDrt6+KzQMUB80DILCnkiKcDMvhw0lCxVinvqhMT2HIgZdvqxOhzw/kp7bZwSrPfXUfNJLWEixOfCkwlbWYDPI2azjoUaMk/GIi+gUBcuKwkTyKpK2BtxYC9SnKCL7ITRGXOB/errAtTmUMhrkAFzXfsaolDL64V9Z2LVK3bL7+DBU3zLkz+1wqueUAcNkBABseB9bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dEcbZn4kVRjgC/SKdr4jUop0lz0TslMYOphqBw6PJ7M=; b=fm8EFSXavHe+vHf+Ag0+2QlXg1bZHhW3RJv3HxBGtiva8uP8EvEIVO5RGp2bF75R8dHwhwTTtJ+tp4q26flv9Q7q9vGMlWpoK9NnHJdybredQOPn1P2FKFNbnGxXDE9xawqCHR3FtynBwbZ++yy2YO/gDD4cChnO8VkzWaT8SXALi0iKi0n1THBXr4NjhPmB+70E2bMgOyv1mCrFSjqxPLqzdknVb3gOOM4ZCRfjtci6MXrwfaN+db3P0uUxXjzlYrksigUPHshPYbhnoH1WebMpwFOomq6UtrTN/T99+c9ySE5BqYc9fQRI3eIS+Khg6uSYUSIFch4kgVYJgEoaWA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0519.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.34; Mon, 20 May 2024 20:41:36 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7544.052; Mon, 20 May 2024 20:41:36 +0000 Message-ID: Date: Mon, 20 May 2024 22:41:34 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240520201420.92545-1-post@frankplowman.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240520201420.92545-1-post@frankplowman.com> X-TMN: [4h6XubfUYExEiaR9Tes4TOuF8RLD5wtt2F5X8EBQIkw=] X-ClientProxiedBy: ZRAP278CA0010.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::20) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <7de4f71e-9cb8-42b7-bd4a-dfa8ec6eede7@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0519:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f4a8931-2141-4980-9647-08dc790d3df6 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: QfLXG36gSe/vgzVZoU6YxVsilb2BX/r7LuBdEp6eQOaO7vCcvGXE8DwdxeIwkEQ+V7auLvVJsxl1G1IM3scNvYDb0LxMhLOvf94S6iabLUGUhbqLFGI7U8DZ200nRgD0/JA7oSKEhWJBPCUqDOi+H4Xgnkn8mI2pngZ3kC9DSihlTTtFyh2Hnw7gri+HJoiWWoiWqfUp6cxYoJlxg/icoOucntj/RT7p5gn4ZYApgXMBxFSgL8AQ4doTcUyv20XlR4m+orTyl/neO1K41bTs/uTebZmST/xmudwvWJ0tpmJx+96YwtyMOmLBUA4YtIHncYlTFRw8qvYCpSB+cZ1FgHJC5B8wciZy5sBgUZjZpt/GwhLNAA3Lur6pakPYAye12avkTT8XLvvhFyQXOjXhRO9fWxEZUpM6U5Qhw8Kpoc5GjGhTB/LoOU+9dyFVXjuFml3O3zFaPdcuC8blCm/GPs0b9Gvb1/0BzV5A5GwiA4UaI1ulIGQLYt65ybPPGnnX9fLXjS6puIOQVNIJyv4aRYcz7J2uy6Y9ok5I2N5jHi+uAjZBnix03wWyZnBWUu7a X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tzh4T25mcEVET3FjYiszOGRzTEVXTjRCUldjOXFOczU4NHhNaGQvL1Y3djgx?= =?utf-8?B?aVdIbmpPTTRvZ3Nna2tVVzRCU0ZWUHpsMGV3bFpDeTV1WXhwMDlHaVJKckZr?= =?utf-8?B?SE8yUDhqM1RZVkxIYWUzaDI0Z3ZjejVOYWQxU3Rwemthd2RSbk40UTE5R2FT?= =?utf-8?B?aXlRR0xWVjdnRGdqTGNMcmxaeVlpWTQ4a00xNGc4dklLNU9QRjNTa2QxWk1V?= =?utf-8?B?OElvQ1p4SjVPTG1tdGlWNnVxSU5FbXEzank1cy92SU1BWmIrNC9uSTQrdVRC?= =?utf-8?B?QzEzdDZQNHNNeEZFRlJIakIwcWRFNFNtV0YzTWJzQjlEdFlsc2RnRWFweW83?= =?utf-8?B?RkdWUThneE5FbVlLVzZ5dEFVZzQ2QjJiTENyR21WVUdNTmFGK1NiUXhIVlFD?= =?utf-8?B?YVBrbDlvcWlmQ0hJaStkaktuMnpFY2xTMU5GS0NuVTRRNzJHMGxWZmZBSTBJ?= =?utf-8?B?OEp6TFFlNzFiNFhNSkg5TC9DTWtDalI5QUp0Wis3YW1CTUJjakdDS3psVXpa?= =?utf-8?B?Q0NhOXBNRFlmUU0yUCtrSTJZNzRDbE1XZzBxVEY0QW4yS0Q4NU56N1dsL1Bi?= =?utf-8?B?SHdqVERNSFo5WENLN2xoNjFzVUNvOVpVM0hWaVNBb2YyckxpbkZRZFJTMGFW?= =?utf-8?B?emkyUm1VUFdmYmh4bmcrMkRTazVTTUVEMHdBL1F6YVh6TWNYa3Q2ZGVFdVR6?= =?utf-8?B?bExkc2huRC9qamwvY2hhMEdsQXF1MlZoaTduc0xRQXYvOU91RjhNU3ZUd0Fz?= =?utf-8?B?ZFJtanpQakVKWFFWZ2swQThkektVRnNBb2RCc0ZwRjBWUXd0cHFnZm5MWEZI?= =?utf-8?B?T1FMcWwwbEgxeDBkZVN6RDd0cHRHeHBPSzBBM2lRSnM4b0srTmhrSnVjaWdY?= =?utf-8?B?UHNkR0pmRjJlWEw0RW9Db24vbUVUS1NrTndFYmoxZ0h0N0lkR3h4emdHMXBT?= =?utf-8?B?TUZZeXFheVlOci9mb3dCU25IK3k1Njl3SGFtK001TmRCd0s0SkNFT1JxeHNJ?= =?utf-8?B?Z2RzNmh5R2JleHJTMHNJSW5lTWJZQ0kwYWNoTWQ4Rm1TbGt0bEM1akQ5czlv?= =?utf-8?B?TjZra3RWR3NsYW1mK0pPb1JEcHU5aXRCb2tDalFTRkV2UEE5S2dVUXRyNWtV?= =?utf-8?B?TUQ0TmRmeUp5V0loM2FZbXkxYjcyUDVJeFpOWDBFNFJ1U2lFSWx1K2JKVXNP?= =?utf-8?B?cWVSeldpd1ZnSDNXWk1YMUdRMnpsZ2RhNU9hYjA0dTFMdFVkd2RaWHN0endY?= =?utf-8?B?b1NRZk5raFdsVkdrYURYaUtLQUExdlFraGhCUDNmK1VTdnBXbkgwTys2bEhI?= =?utf-8?B?ai9uN0FVWlBJYmtIaGIvSU5KeFc0TEx3YnZhQlM0N2xkVkpIc3ExOTc5M05X?= =?utf-8?B?aDR3d1E1bWpwb3FyTlNzcEZwUWlZdm42bE1oeUF5OWtQd2RNVHNZZkxMNFFp?= =?utf-8?B?a0VZci9GNE8zYXZkUG5nSko1SGxPU09tUmw4ZENKcVlObkQzekJBY2Z1MkJr?= =?utf-8?B?dlFYamc1YXJWd3ZNbGM1MlhrTjBBUzRPZ0dFV2M3dzVxRXBwMGdOSVJkMjdY?= =?utf-8?B?N1M0ZVNUQjE2NzJUbDRxdVJMMDU1V2k4UEdSeWNSdmt4UXBPWGNkek56YkFS?= =?utf-8?B?b0NtWEFYL2tSUXQ0eXV1VWVRRVl4eHhXYUV3dVZhWVhmL1hIQ25FNzNZdkU2?= =?utf-8?B?cUF5MTA4bzZQK2g2YXd1RUttbGZRR1ZTV0l3MzIwWC9YT1lCc0xPeTJBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f4a8931-2141-4980-9647-08dc790d3df6 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 20:41:36.3283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0519 Subject: Re: [FFmpeg-devel] [PATCH] lavf/dash: Forward strict flag to component demuxers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Frank Plowman: > Before the patch, opening a DASH file containing streams which require > experimental decoders was problematic. No matter where the -strict -2 > was put on the command line, the option was not passed to the demuxer > for that component. This resulted in an error, prompting the user to > add the -strict -2 flag, which is already present. Decoding appeared to > continue correctly however. > > Patch removes the error message by creating an options object for the > demuxer created for the component, which inherits from the parent > demuxer. > > Signed-off-by: Frank Plowman > --- > PS: Can anyone think of other options which should be propagated to the > component demuxers? > > libavformat/dashdec.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 555e21bf69..40abb5ebba 100644 > --- a/libavformat/dashdec.c > +++ b/libavformat/dashdec.c > @@ -1911,13 +1911,18 @@ static int reopen_demux_for_component(AVFormatContext *s, struct representation > if (ret < 0) > goto fail; > if (pls->n_fragments) { > + AVDictionary *stream_info_opts = NULL; > + > #if FF_API_R_FRAME_RATE > if (pls->framerate.den) { > for (i = 0; i < pls->ctx->nb_streams; i++) > pls->ctx->streams[i]->r_frame_rate = pls->framerate; > } > #endif > - ret = avformat_find_stream_info(pls->ctx, NULL); > + > + av_dict_set_int(&stream_info_opts, "strict", s->strict_std_compliance, 0); > + > + ret = avformat_find_stream_info(pls->ctx, &stream_info_opts); > if (ret < 0) > goto fail; > } The loop over pls->ctx indicates that pls->ctx->nb_streams can be > 1 before avformat_find_stream_info(). But then using a single AVDictionary is wrong, as avformat_find_stream_info() expects an array of pls->ctx->nb_streams AVDictionary*. Furthermore, the mixing between AVFormatContext and AVCodecContext options here does not seem good (e.g. for ordinary demuxers setting strict_std_compliance does not affect the AVCodecContext's values at all). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".