[FFmpeg-devel] [PATCH] doc/muxers: add flac

[FFmpeg-devel] [PATCH] doc/muxers: add flac

[Stefano Sabatini]

---
 doc/muxers.texi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/doc/muxers.texi b/doc/muxers.texi
index de4b9b01f5..64d9221198 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -1612,6 +1612,17 @@ This image format is used to store astronomical data.
 For more information regarding the format, visit
 @url{https://fits.gsfc.nasa.gov}.
 
+@section flac
+Raw FLAC audio muxer.
+
+This muxer accepts exactly one FLAC audio stream. Additionally, it is possible to add a
+single 32x32 PNG image as attached picture.
+
+@table @option
+@item write_header @var{bool}
+write the file header if set to @code{true}, default is @code{true}
+@end table
+
 @section flv
 
 Adobe Flash Video Format muxer.
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flac

[Marth64]

LGTM

On Tue, Mar 12, 2024 at 4:01 PM Stefano Sabatini <stefasab@gmail.com> wrote:

> ---
>  doc/muxers.texi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index de4b9b01f5..64d9221198 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -1612,6 +1612,17 @@ This image format is used to store astronomical
> data.
>  For more information regarding the format, visit
>  @url{https://fits.gsfc.nasa.gov}.
>
> +@section flac
> +Raw FLAC audio muxer.
> +
> +This muxer accepts exactly one FLAC audio stream. Additionally, it is
> possible to add a
> +single 32x32 PNG image as attached picture.
> +
> +@table @option
> +@item write_header @var{bool}
> +write the file header if set to @code{true}, default is @code{true}
> +@end table
> +
>  @section flv
>
>  Adobe Flash Video Format muxer.
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flac

[Andreas Rheinhardt]

Stefano Sabatini:
> ---
>  doc/muxers.texi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index de4b9b01f5..64d9221198 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -1612,6 +1612,17 @@ This image format is used to store astronomical data.
>  For more information regarding the format, visit
>  @url{https://fits.gsfc.nasa.gov}.
>  
> +@section flac
> +Raw FLAC audio muxer.
> +
> +This muxer accepts exactly one FLAC audio stream. Additionally, it is possible to add a
> +single 32x32 PNG image as attached picture.

This is wrong: Way more attached pictures are supported. The restriction
you are referring to only applies to pictures of type "32x32 pixels
'file icon'".

> +
> +@table @option
> +@item write_header @var{bool}
> +write the file header if set to @code{true}, default is @code{true}
> +@end table
> +
>  @section flv
>  
>  Adobe Flash Video Format muxer.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flac

[Stefano Sabatini]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

On date Tuesday 2024-03-12 22:17:36 +0100, Andreas Rheinhardt wrote:
> Stefano Sabatini:
> > ---
> >  doc/muxers.texi | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/doc/muxers.texi b/doc/muxers.texi
> > index de4b9b01f5..64d9221198 100644
> > --- a/doc/muxers.texi
> > +++ b/doc/muxers.texi
> > @@ -1612,6 +1612,17 @@ This image format is used to store astronomical data.
> >  For more information regarding the format, visit
> >  @url{https://fits.gsfc.nasa.gov}.
> >  
> > +@section flac
> > +Raw FLAC audio muxer.
> > +
> > +This muxer accepts exactly one FLAC audio stream. Additionally, it is possible to add a
> > +single 32x32 PNG image as attached picture.
> 

> This is wrong: Way more attached pictures are supported. The restriction
> you are referring to only applies to pictures of type "32x32 pixels
> 'file icon'".

Dropped mention to this limitation and amended, it's probably better
documented in the code than in the doc itself.

[-- Attachment #2: 0001-doc-muxers-add-flac.patch --]
[-- Type: text/x-diff, Size: 1242 bytes --]

From fce90431bba4f729521195d2ea8067a4f11a9a3d Mon Sep 17 00:00:00 2001
From: Stefano Sabatini <stefasab@gmail.com>
Date: Tue, 12 Mar 2024 22:00:09 +0100
Subject: [PATCH] doc/muxers: add flac

---
 doc/muxers.texi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/doc/muxers.texi b/doc/muxers.texi
index 454f2347cf..fe4be49b1c 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -1576,6 +1576,26 @@ This image format is used to store astronomical data.
 For more information regarding the format, visit
 @url{https://fits.gsfc.nasa.gov}.
 
+@section flac
+Raw FLAC audio muxer.
+
+This muxer accepts exactly one FLAC audio stream. Additionally, it is possible to add
+images with disposition @samp{attached_pic}.
+
+@subsection Options
+@table @option
+@item write_header @var{bool}
+write the file header if set to @code{true}, default is @code{true}
+@end table
+
+@subsection Example
+Use @command{ffmpeg} to store the audio stream from an input file,
+together with several pictures used with @samp{attached_pic}
+disposition:
+@example
+ffmpeg -i INPUT -i pic1.png -i pic2.jpg -map 0:a -map 1 -map 2 -disposition:v attached_pic OUTPUT
+@end example
+
 @section flv
 
 Adobe Flash Video Format muxer.
-- 
2.34.1


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/muxers: add flac

[Stefano Sabatini]

On date Monday 2024-03-18 17:58:54 +0100, Stefano Sabatini wrote:
> On date Tuesday 2024-03-12 22:17:36 +0100, Andreas Rheinhardt wrote:
> > Stefano Sabatini:
> > > ---
> > >  doc/muxers.texi | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/doc/muxers.texi b/doc/muxers.texi
> > > index de4b9b01f5..64d9221198 100644
> > > --- a/doc/muxers.texi
> > > +++ b/doc/muxers.texi
> > > @@ -1612,6 +1612,17 @@ This image format is used to store astronomical data.
> > >  For more information regarding the format, visit
> > >  @url{https://fits.gsfc.nasa.gov}.
> > >  
> > > +@section flac
> > > +Raw FLAC audio muxer.
> > > +
> > > +This muxer accepts exactly one FLAC audio stream. Additionally, it is possible to add a
> > > +single 32x32 PNG image as attached picture.
> > 
> 
> > This is wrong: Way more attached pictures are supported. The restriction
> > you are referring to only applies to pictures of type "32x32 pixels
> > 'file icon'".
> 
> Dropped mention to this limitation and amended, it's probably better
> documented in the code than in the doc itself.

> From fce90431bba4f729521195d2ea8067a4f11a9a3d Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab@gmail.com>
> Date: Tue, 12 Mar 2024 22:00:09 +0100
> Subject: [PATCH] doc/muxers: add flac
> 
> ---
>  doc/muxers.texi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)

Applied.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".