From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 457C84C114 for ; Sun, 9 Mar 2025 03:06:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3083D68E6F7; Sun, 9 Mar 2025 05:06:29 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2087.outbound.protection.outlook.com [40.92.91.87]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6992468DAE0 for ; Sun, 9 Mar 2025 05:06:23 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J4Gju10zebihlK0bEGHzcpr5A3afVrzNP4BgBusXd4LywFK68XundcBStFuqAK7RD6t9F1PR55Yafj1jqDLjNo69HJkHx/jZl52a+S7JFKHijCbPbep6SH+T4p+o4rvjqo+Fouy+p32CnmuhDKBrWW0PrsWjNSE5wWWLaMiZsyDUaJnKPmkyLRa3puzoxyYRN7krCyvPkw/3xC8jkeKvrabBzWAqq1P3Z8ILvbpQa0JdDP4JRbZAfRBfESgfR5rLPl0q+sj5om1vtcaT7W8eQSe8z4QHZAHhIf5hTf86Y9+MBx/BhOky0DSk10Whk00Xzmam3R6ABOV7YgpSpuCJBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/7dKkVphY+UQLf8WBHHBJC9wSOTqj/3V0YPs2gaZoSw=; b=ymUD8FD+bJG2Shly3+YtDltIq7r3JU6pp+7KPGPy4TtfmusxbT/2CKbvuA1T5h0aZzAztpJZwWxdadwHCIiqXZjsKTm+RzS6udi4GVCtdrsikEDMjn4mH8c6aZ4gfEE1JwgRLy4jOuLrpjBH2NdQFsub8cPpHgggAn3/5k8NMAppwHPjpUj/DyLCP/NfMW6+GoIaBYPSKOnGt/rbJQMhiFBCUBTTvjKQdVnb+wRZxkXqw0H4bxyT3pRiIuU4g2FUu0YnCVVXUY3rNoB0nZ4aFn4PceYuCb9lBj9DBE/zKduk16D3qfkwPxzacI+kL/kZx4BJnExzd+ElvixCNSy9Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/7dKkVphY+UQLf8WBHHBJC9wSOTqj/3V0YPs2gaZoSw=; b=M68+Ta5uOnGeGeJ5CSdCdpovEu4AwK1D1s8jC3ziBDnAj3Q9WqaJZ2cduvolrHWIPz/WaACfBQYoMynnBA6zEFvkCwAyXbsxixgcptzOXG1wTFvmgEZa1teHBXag+1u0N0Z5q8kGKCyi5vuX76beVzs2159LWtsmcmga2R/Y2eLsOYodiAJO46Dsn11an+OcLdSLWuqUV3AG3CGYfooEGI6NfGbBny/X0ik4Ii+i5S+nmwMw+i+S6tDMcFenplbmDeSAru/exXfGTUjh+dxNK5kWBP70pXOJSqM1sqP6U9B8hhcXPAGhbQ+R/FJ90BKfUBFAjsYWsMWpRuPCUcCB6Q== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS4P250MB0683.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:4be::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.26; Sun, 9 Mar 2025 03:06:22 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%5]) with mapi id 15.20.8534.017; Sun, 9 Mar 2025 03:06:22 +0000 Message-ID: Date: Sun, 9 Mar 2025 04:06:20 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: X-ClientProxiedBy: ZR2P278CA0057.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:53::14) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <5d4a5dc4-2ec8-4ac7-871a-fd6cc01d6fc4@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS4P250MB0683:EE_ X-MS-Office365-Filtering-Correlation-Id: 2400d2ca-74ed-42e2-1666-08dd5eb75e92 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|19110799003|461199028|15080799006|7092599003|6090799003|5072599009|440099028|3412199025; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cDI5Wll2OWNReFpQbWZPdUpwb0JCNncxZWFpN21vRXAvOWppdXVMQ3B2bG5l?= =?utf-8?B?ZHo3ampTR3VGMjJYNmxaL3RueDgzNzRXVUNlekU3K1NYbEIxWi9BVkU5RGtS?= =?utf-8?B?Snl4dS8yNWYyUkdTYkxMK1c4aWdHNCs4WmJvNEVTbXROOXRsNXorUkR0U3pU?= =?utf-8?B?MzRudFJQeElCc3hudjNDRit2VFBJNngwaFBOTlB2b0d3eHE2Q05GaDRYYXAw?= =?utf-8?B?NTI4KzRxbDgvVjNZdG5HbW5pMC9UdTUwR2NoVjRiMDZTT29LYlhpM3VWZ3VW?= =?utf-8?B?NFhiejl4ck9oUUN1MVZUWXhRTkZWby9IdUZSZEZ4NjZFYlEva3R6RDgwNm5T?= =?utf-8?B?S1plcS95ZGtaSGFjclNhUWtpWk02U0ZlM004VXc4a1JBWG9iSWFPYnhIUU1i?= =?utf-8?B?VUZMdk9FeGxsbXJUdTBIdmcwQ1IyQTVpdWRiL1AzRFZqTlo0V0c5c1JsQ0ZO?= =?utf-8?B?Z1E2REZnLzVZUXN4ejIvUmxBUW1Gem13cjEzZHhUN3VjeWMyNlFxMUl1NGRI?= =?utf-8?B?MmVyb3kzVnJXQUhrOWdXTlRINWxiQ1o1L09tM3Q4OUVxVlVKNmhTdUc3MFEv?= =?utf-8?B?ckdFR2xNK1N3OUFWWGdWTm9zckJjeUIwdXJkWnVWWEFTbWxtS2paNWJvWlNo?= =?utf-8?B?WE5wZlFGa1VqOU56QjU1RDU2QnRMUzdwRnFDT0lCbmNobXUzbWNQKzZvUnZl?= =?utf-8?B?bUIvU092ZDY3c2tpT20wZDlOZmZYREJ4Mm9DUk92MmJ6aktHL0hib3RFS2c0?= =?utf-8?B?SURKSE10V2U5WlpQMkxoY2dQVWhGQklCOEMzN2w4VTJXR3lGZnVvM0xaam1H?= =?utf-8?B?NFR4YmpsajlnUzIxZTFTK0tNNnBQUThFU21QMEZKNysxSExLVThiMHVuV1o0?= =?utf-8?B?N0RrOWtMOFpaMDFDMkdWZi9CRnREOEJlQjRIQnp3UlNLMmwvMm1hNEc5UW9G?= =?utf-8?B?RUJ6aUo0anc2eG1QVEtJNi9xTVVwZHdwNHRGMzhXRDJNdFQ0QTZWVXB3NUVT?= =?utf-8?B?citvZ1dVTUdqTUZIVVIyZmZzYk5GT2JxYkY0enlkOHR1Y3Y0aC83dnV4K05P?= =?utf-8?B?T21GVVhOY1AxNWRhSHRBYS9XV1JHd1lHYVRwV1VlU05kUVNMWm1JazVkMktT?= =?utf-8?B?Y3JMNVFRUjQ3RjJiVDFFTVN1UkJQZkJJWHZGMElZMUxFWE1MazJNb3h2bUMy?= =?utf-8?B?YzVhTnJwZldORjV2NFJVSHZ0RWVSQjg2dlhMTWt5aEpMY1ZXS0c1dHIzM3R0?= =?utf-8?B?TlZZRmdtc3lsNUlrY1VnZjFCc21kTGc3ODlGTTMvRUY1VXJQdGtxanZuTEVv?= =?utf-8?B?UmNlbEx6UjhvYVJOdGR4alpoY1hNKzM4dmw3NXYzaFUxUE0zTHJhY2lIUVNZ?= =?utf-8?B?aVRjSHpsYTZPUUdOaW90Z29Lc0dpY2RoK3VXaE9URG0rREQ1Q2pOMnVNZTRM?= =?utf-8?B?MDlLcEdlM3k5SHYwdjNjNElxWnhSR1RndXErU0ZjRFNIdjJBOUFrNkwxQ3Br?= =?utf-8?Q?qCDNrk=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjRtVHhqNFdINVdEUXBXaml0WS9hZ0sraUk1NkpxZ3FuMDZKbjhGTWkrckpo?= =?utf-8?B?cXA3Z0p2Z1ladVZXcDlPR0pKbmJ3Lzg2VXRjSXBIeXBwOVNyMGczMGt4dXBS?= =?utf-8?B?MzlUeWFPNWJ3Sk9XWFEvTVZaQ0ozTzdxeXRobHRrclhUTnM2ZDd1QXhQOWZU?= =?utf-8?B?M2JDRFhPV1NPVGh6T050VUt2TUdlVnVQNUF6VFpGL0tmN2V4N3FidlhRSmo1?= =?utf-8?B?VDVRTVJtVU1WTTZ3Q0VkeGRvblVRWFQ5STdvdGRKaWtJV2Z6UXJKT1A5Y1hM?= =?utf-8?B?WFFOM29ZSndheW9kTUR1UXc5WlJxbm9BVVN5SHBxRzFVMnV4TTBwVWl0OHFO?= =?utf-8?B?cU50dmsyT1pLeStYTlpmVmZuOEJiOFVXbnRLVTVxUDRKbW1US0ZwbTJNMmF0?= =?utf-8?B?UzljTkxRUTdIUDNOV1hmMlA2MVM5cHhNcmN3VlkvVVdteXpBb1l0WTFCZVQw?= =?utf-8?B?NmI0aUNIM0FmV2tPeE1hbUZ4TVVRcjNxVEU4WjNtQUFXQjBZQ1hQZ3lyVmc1?= =?utf-8?B?U3NhbEtjRVY0a3YxT0wvRUU4RSt3bXcvN0pCemZJZGw1S0xZcUs4aUx6Q3Z4?= =?utf-8?B?S2VmT1g5cHhNNU5EelVEakM3NHlnc2c5RXZOZ2NyY3loM2NyUHovYTJnK0ky?= =?utf-8?B?TzZPc2tGZUROT0E0RGhBQmRsOG9ubGpZVWV2YVlaL1YreHlWck5zQjdBQ0JO?= =?utf-8?B?RFFoTEZqMmIrbnZiTmMxeExWUmV0ZDV0Q3o0eVlTV2J1aGpwdHpvbzRuejc0?= =?utf-8?B?bnNobnIrVDQySHZKMG5WZkdseERpSTlXNUZBQ1ZhbVRQbys0RDNyZTRBUmJI?= =?utf-8?B?cFBpK1U2M0lNM1czaDhYQVJKK3BpUFJrS2V6Qlo3elpQUFl0dEI3cnFiT25a?= =?utf-8?B?NFVZb2pIZGJvZjA3dUZlVXRXUmg3dTR1VU1tdlJSRkc3SzlRWnp2SXdoODdE?= =?utf-8?B?MHJQd1A5RWQyWlgrcE1adlV4RFpORFZOQ2NZK2RCYktmSG5tSWN1Z2xnVlQw?= =?utf-8?B?YVZpZ2hPRDlpUDZ6NFg5SFlvQUplM2dSK055di9HcDlROU9iK0g4SHV6NWgy?= =?utf-8?B?UmYvUzFDeHFsK0hnSjN3d3h5czJ5cjA1VkV3cTV3VDc3R05xamVicU1oUmVY?= =?utf-8?B?N2lCd0pqYlJ5YjRFWW5ZWWFhQUcyWUFZdlRKU0F1OFEvVW5JSFEvUTJqVXJQ?= =?utf-8?B?ZUdDSFIxZFNQbDZJU3N4cHdmSlFmNW11Y1JXandmeTI1VHJPekxoUUxORzRn?= =?utf-8?B?a0dXeDRweENMcDZTR2oyL3lNY2ZNVFNadEk2Qno1RHpzVTd6T2YzWU9uamxx?= =?utf-8?B?TTZOSlhSZ0o0WFdSUWl4bnRQUTk0bG56bUFOS1ZEdWhid2Z4OUpNSnNBQnE5?= =?utf-8?B?NFNqOVNrZllDT2lvNkl0S1BSTFQ2OVRJb29iOGxUeURnQ2JnOWsvM2RPSmww?= =?utf-8?B?VzJUdVR6eTh4NjlKcFZjSUtReVF6L25TMnVYcU9pQ0xrUTNacjV3WnJuWWhP?= =?utf-8?B?dUs5YnJRc29nQ1JuMUtxbTJsQlFwZnRGSnJxUkRBUDNNb1hibVBWMGdVZHVZ?= =?utf-8?B?NWt6cEptSDZsZHFKMHNRSjlmcFBzMVR3VGZmcDRHSWIxZnRrV2tuZytOOVlJ?= =?utf-8?B?TmZYYysxMnFJelUyckcvcXR4NHQwckpQRWR4TG5tMzEvUkFrRjNnL2lHTTl4?= =?utf-8?B?R2h4OGZ6aE8xU2ZJNjNVcFdZQk16bFA4Y2hhajNpOTRhVzEwOW5kcTh3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2400d2ca-74ed-42e2-1666-08dd5eb75e92 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2025 03:06:22.0517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P250MB0683 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/decode: Fix avcodec parameters when bsfs are enable by decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zhao Zhili: > From: Zhao Zhili > > BSF can update extradata, e.g., vvc_mp4toannexb. If we don't copy > bsf->par_out back to avcodec context, decoder can get extradata in > mp4 format, while packets are in annexb format. > --- > libavcodec/decode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index c5a577f4f1..95b8c32502 100644 > --- a/libavcodec/decode.c > +++ b/libavcodec/decode.c > @@ -206,6 +206,9 @@ static int decode_bsfs_init(AVCodecContext *avctx) > goto fail; > > ret = av_bsf_init(avci->bsf); > + if (ret < 0) > + goto fail; > + ret = avcodec_parameters_to_context(avctx, avci->bsf->par_out); > if (ret < 0) > goto fail; > FYI: The same change has been done in f631c328e680 (and 662558f985f508 in libav) and later reverted in 87588caf8cff (and cacb62f9cbf3). The reason was that extradata was owned by the user for decoders. This has only been changed very recently in 183c59b4738c last December, but this was an API change (without any entry in APIchanges) and I would not be surprised if your change would break some users. Does not mean I block your patch, though. An alternative approach is that we add a getter for extradata that the decoders that use a bsf known for changing extradata use to access extradata. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".