From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9656647866 for ; Thu, 26 Oct 2023 21:36:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 51C9C68CB7D; Fri, 27 Oct 2023 00:36:48 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04olkn2046.outbound.protection.outlook.com [40.92.73.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C3A3168C95C for ; Fri, 27 Oct 2023 00:36:41 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a4nOQoeKl/m51cqg+5avwd6Sn7hFPoK/oIqg1H+xoL/KT2ZQjQVK+7Yf1pWRYM/I9ugjYhcVEuzRZ2MYG0GY3ljKD71oDmYna00e0MNyuRnKk4lpStIyDCj0QMSTKaWA31wuvEPNHYP6MwA5ACQXEwMsZAnrqnsbgs2uKmrQ8wQy+8p6tSEDQSi4DCTG6QIhJXd79uXMg4om+ozdxz8KCqh6qPCOh4EO4oZ4C94lBT0duNmolCUz0druPbzU0leaeBEYmI6xWLzAV9f2ypZ8bX6GFhVjPHjopz8gpUmf8Y7lMfJgqqsuCgLtqaMxA3061jueQl8hnvMywn/UI6A6vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CiZgyd6VcAAElN5SkhRAtEv8KAzqa/qeDD7ZXEu4t10=; b=OS+TXl/lnyXLY3RJX28JM1DuUsnipyj4Y0xf8DbJSlikm34DDsbhBicOMagE8yn5tmbAs3Gl5ooSDxq8Ip4F809Dhbg8uNz0ZuMbxBfmYNCDgc5LV6KAmXVItFi6mxwfeyJ3jaWhHTE/bZ8sKBMHPzYarkTCfa95DNLDnif4SHQg8RTs4ssTPe2n3xLqBJEx/hHlHMv73K6aTkkG6dSwqnptW0SuPxdvDlMRiRf2E4YhTzAmcbggvdZ7CqKMDygWUHFVXvmVaVTZnUSHBAuIvnS++5M9zju6KW7D8KIlbXGxfWZDWxbtqpasUz6IKNNx136P5hBruaHdgQXEmxKoLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CiZgyd6VcAAElN5SkhRAtEv8KAzqa/qeDD7ZXEu4t10=; b=XslDxvLOmdbNch31ZNnKz328gsClhTFKMu01GQyilzwbVLSOhLG5u8PXZwm8LXj4CJpJjvAhcRCLrE+Y4ed0WaAIoVMybQslvpyLraPuUfVc36EDxbFM+nPlLP9x6nUaXqN+NkFh2exqdzXAvc/H2+9voqwhJ4YJ1/m2udDuaQFr/fmRRFTWFOysFbHqXlHU8/O7AV7lVRa8TUlv6xwN4i6Ch4jLvo839pLHNaAKebxKXpnfQPfuGimKRCIoJivwlxL/bCxBSt/baxOLeNppuibQO7DzqEMGKJQyUZdow4H6cnNWJDLCjLc8euD+h3Cj7hYMjCZnd/a5f5vFkv9NXQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0082.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:171::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Thu, 26 Oct 2023 21:36:39 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f59c:9cff:a42d:bde%3]) with mapi id 15.20.6907.030; Thu, 26 Oct 2023 21:36:38 +0000 Message-ID: Date: Thu, 26 Oct 2023 23:37:57 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231024150443.7438-1-michael@niedermayer.cc> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20231024150443.7438-1-michael@niedermayer.cc> X-TMN: [bRqe0ObJEAuPFtjq9dMiOHayxcSu1YjGBzCD5VUpdzk=] X-ClientProxiedBy: FR2P281CA0159.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0082:EE_ X-MS-Office365-Filtering-Correlation-Id: da58863b-4a46-463f-cf3f-08dbd66ba2f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qfcA1CD2zTT5JZcHAXj44GuT5Vi3LdBuzHuX5wQ0j7ZYlxYFmHvBhOUWIPHXShqqDZFZ6Jcqoe6C57fh4hXWW/gmiz2FOsbLaBn+7FcsDLHwBGGjweTEDjoYP4qNXdFb8uRujUK4ogoBQ8RCtIkzsan4vEPJ0LLLDOgQcCxXSD7QEH8w58ql+Jkc+xlc92d+G/OvX8PvMvW7pQGmsjr95+Wt/gNklS7k5+8PIzn0VDRsfWJx+IjuuvwURqfEItSkG1JxRcjRpd7ZJ7a/iZ/aHMm5CeP6pl88A3u+oCUcyYgM0rbTmWQePtt2gpMy43HNxEG6P2G2tLZ5B+ZaM122thEEUvxF5shVOquqifY9HX4xvkjClfyb3iD8mDPUEPITBLdJyURS5gJ2LCmUNETUXOkKWYbXFy/Oi9Jgd5EdAubllAl8084MYnqeRncKibcEYYe8ScCpZAanWRD9CS3+YB2pBuXUQwuN/E474pNYKJRmTxHLK4Wc5LuziVDGIc0oB5NyRuvWRpooJNN9siJ3ytnzjbHxcCwcdL3rCcoFfXmvANwSq/npz6iqN1R+YkUd X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmpWSTlqdkw4Wmtnc0t1bFdWbnlNWlBMWUVvQ2l1QytVcUVUbHd0Q0dDT3NJ?= =?utf-8?B?YmE1SDJpbUg5L25jT2I3ekFiNnFvMG12bkU2TVRuQllXcGJLYzVscFJ1SEhm?= =?utf-8?B?S3FMNStqUTlSbmNDRWtoeVJ0WmhWS2ZaeXlmOHVVSVZ4RWdWQnJBWTdjcThV?= =?utf-8?B?bytkU3dzazJhUWNqZGtrSFg1OStOMEtlakJGZitITm4zTGVNbUFwdHZMTFBQ?= =?utf-8?B?MGIrK1REQjBqWHRRdE0xQTl2ODZJcVI3MmZYVWxlekhPRFQ0QnE0WCtjN2p4?= =?utf-8?B?Y3V2YTN5ajdnbEd2L0o0SmUyTjNBL0pyaGdQaWFoeUZSa25RcUNPTE03OXIy?= =?utf-8?B?SGtlT3JYWGVaQjBHQXRvSUFYSGdXaUQwb2FxeGw5OFBsQUVYQXp5ajdzWldO?= =?utf-8?B?UkdSSHY4RzBzNnlLR3JDY1ZUZVdVMkpoa1RXSjNtZ01ZZFdZQjFUdDlVMksw?= =?utf-8?B?NlNZdFp1TkJOaXdqTTFyWVZCTFA1b0EvYUtmR3NwWm9zY1VUWWdRZW0waDZx?= =?utf-8?B?bjNROW9zem1vM216aGRPQ2F3WTVOaXdWKzlqSThLeGNPOWZpSlUwTlV0bkFW?= =?utf-8?B?bFVnNW5xR09laTFpUXlCYWpxMEdkbTNTR2NTU01YWHNhOThmZ3ZlS2l1RUMr?= =?utf-8?B?YXFsdEFTTEwzLzlNLzltUWE4bk1NSWpJZWs5K09lUEhxMDUrZHdxUDZnTVh4?= =?utf-8?B?U1BlN3pHNzQxd2Jia3JCYW44OHFnclQ3cG5BNDdpRVV2UUhGbDNQd1pwb3My?= =?utf-8?B?Rk1ETzZENXA5THJqWnpXUlJsZnVYalhYNnIxaEJSVDFSc0lZdTExd2t0TEZj?= =?utf-8?B?U2tuVHR5a3FtNnJzU3piamc2bXRnYUhUMnZRNHdUWGF0S3orSW1EeFNXdkEy?= =?utf-8?B?aEI1ZGM4cHo4ekkrNDgyMHh1dURRU3VmMU5Jck52aUJQRTIzditPV1E4Q09r?= =?utf-8?B?VEM4MlhvejBDeHVDN1JWaysxSUVFTENhNlVMOUFWeE00bW43VmpOWThVUUZQ?= =?utf-8?B?SVFHVmlrL1VBWXI4ZkF4TDRraFRyUUZxNFp4ZXhJd05wcWJnaWNjL2gvVWYw?= =?utf-8?B?NjAyTHdzRUREY0pQc25QOXZjRWdaaVdvbHQ4djJTazZFQWFUQVN3bjRvbEk5?= =?utf-8?B?WWs4RzZLaEdUbW5NTkliNDlEaEdVaXBiSStVeWgwaTM1UzZoTm5PYXlxZzN6?= =?utf-8?B?MHJlTFNRTzBnUy9KYnJNT2ZpMkZjckducGJFMjZZZmt2K04rUlRwWjZkK0RC?= =?utf-8?B?aU0rSXNjUkpoVFhySGFrclI2ZEhIbkphazhTQTNzem0vMnAxYzFCMEFwS1VO?= =?utf-8?B?dkZsREdFeGJ4Y2RlZnJMemNtbGNEZEpLWUE4dE9Jc0hLVU1DOTg0anFXcHdI?= =?utf-8?B?eTFPRjVOaEs1TERIWmxPQVQyNHhsSnVaeFJ5NU8wQmZONHgwdkZ5OWZjdUQw?= =?utf-8?B?Q1M0NUpiTGJPTGgweXMzVDFnSGgzOUdmNjVVelhiNk1xT08yREt4NWhtNkZV?= =?utf-8?B?VUZhd2NtZEVGeFQ3bnhkZG9Ia0VsSmMxZ05NV1JFM1h2RUV4cWhKR3dHQzVM?= =?utf-8?B?em01anZrNE5VR0R4WUxJU0pRcjZ3TENxYTl3cDJEN0hTbnRvMGMyU3BETU92?= =?utf-8?B?TTdvczdDWUhDazdwZ25sK2ZtTnlWcVpDTmxsTXo2VklzUHhjWmxyczdLOTVW?= =?utf-8?Q?vwrggUg3Ymvv6nqO5O7V?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da58863b-4a46-463f-cf3f-08dbd66ba2f6 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 21:36:38.9630 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0082 Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/magicyuv: Use a compile time constant for vlc_bits X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > This will permit further optimizations > > Signed-off-by: Michael Niedermayer > --- > libavcodec/magicyuv.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c > index 4a143cdbbf7..78d7f44cd65 100644 > --- a/libavcodec/magicyuv.c > +++ b/libavcodec/magicyuv.c > @@ -124,13 +124,13 @@ static void magicyuv_median_pred16(uint16_t *dst, const uint16_t *src1, > x = 0; \ > for (; x < width-c && get_bits_left(&gb) > 0;) {\ > ret = get_vlc_multi(&gb, (uint8_t *)dst + x * b, multi, \ > - vlc, vlc_bits, 3); \ > + vlc, VLC_BITS, 3); \ > if (ret <= 0) \ > return AVERROR_INVALIDDATA; \ > x += ret; \ > } \ > for (; x < width && get_bits_left(&gb) > 0; x++) \ > - dst[x] = get_vlc2(&gb, vlc, vlc_bits, 3); \ > + dst[x] = get_vlc2(&gb, vlc, VLC_BITS, 3); \ > dst += stride; \ > } > > @@ -155,7 +155,6 @@ static int magy_decode_slice10(AVCodecContext *avctx, void *tdata, > ptrdiff_t stride = p->linesize[i] / 2; > const VLC_MULTI_ELEM *const multi = s->multi[i].table; > const VLCElem *const vlc = s->vlc[i].table; > - const int vlc_bits = s->vlc[i].bits; > int flags, pred; > int ret = init_get_bits8(&gb, s->buf + s->slices[i][j].start, > s->slices[i][j].size); The VLCs are created via "ff_vlc_init_multi_from_lengths(vlc, multi, FFMIN(he[0].len, VLC_BITS), nb_elems, nb_elems,", so the number of bits of the VLC is not a compile-time constant. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".