From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 69FFD4B535 for ; Fri, 7 Jun 2024 19:35:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE69268D7CE; Fri, 7 Jun 2024 22:34:58 +0300 (EEST) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02olkn2017.outbound.protection.outlook.com [40.92.50.17]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3A03068D6A6 for ; Fri, 7 Jun 2024 22:34:52 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F/9PqN9Jlua/OXxDw1I1zttUK0m9WnVbHtTuxcs0faE29v5vhDa1ImX6aRFi8o7WLDiMRUm9ZD82TH4nQ4RpUFYs/neqRQRGVy/V+02nSDmsGlKhNjHneu5spgvxkiiPTEvq7c2zgbMKClnP4ZynBChiaNrCFzprp/QTJ5nhRqedpfWA4uMeVmo53XXN6JpleGzdN5RDjfPJF3/3Nolh51Ib0RS9SsPdEAhtgTpcBEYF5OV0yGJ6NVXg/eUtdVeE+bw4cofMe9IAZIr3GQvCCgd6UkXEMi0k7hR+SxyGbzoy9hYp0Hmb81MoAi9JR4Lf4fhh94bh/yz1dvN5ZnaKkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+QCVRg+2pyy0nkcJkYWwvt7VUDTybzefOAMRTQrJsvU=; b=C0NYkPqvEbIJjqb1Kc5kgMUzY2P/Pq7/rw8XZnakUPBvGQipd0+eARIXVqs2ZCYTg4NKKsXWL5DuDmt7SNry1JC1yu17kIpuy0sV6OxHZ4FLgVW54GnpcfQ+ox9gn9W3q094RHc3PDqznVdL6GD856OQ9PDi7o0/2O3n6Cx1gCWc2GO4REXtAH/vjn1xh/SwYcCJZ0uBKGI0G+lY9jVNvh1Et4FFINq+o+W6w2ffba2rPFWN/pH2MFCuUOqhWA58qvNVTXw4UGmGBQPUzaEl/aFDBiAFmWofvUu6x4qUINoQ1Vbbx8mHyCESgpALlhfDGCm60npJ/yddjU/jxYypXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+QCVRg+2pyy0nkcJkYWwvt7VUDTybzefOAMRTQrJsvU=; b=VpMNT46VfJXjkU6qzYco4DCkiZF1ci0TiiaW3BLXi+53epug5HvTtMAbvUwpjqn0udKyK7cz1JYLXK4UwyXqUTd689QuwNhOx6VA2HnmprgySgWwRvlZGycQtuKNfUiIuLvw6/MWiyLymgJiq0KPMXFsztQS6cZKkEuWNc4lnyvZx1JXJyOraDe+2cz510JBjOvEqs4nE3o+436a6actfpfYJ5aR3tH9PKmTMshClaeHH6Ig2R8/e29+0Q2ik4cbk1r3vwx/sWcLxRHLrXr8nfXPkZ9vXuygmbXsEzpR1f/MUmDKFHc+ERnQutL+aDVrwfmiH4GQcuq6C2R4oTUYKQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0307.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:17e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Fri, 7 Jun 2024 19:34:50 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7633.021; Fri, 7 Jun 2024 19:34:50 +0000 Message-ID: Date: Fri, 7 Jun 2024 21:34:48 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240607192654.146995-1-ramiro.polla@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20240607192654.146995-1-ramiro.polla@gmail.com> X-TMN: [Y55/hUpQT7RH6mFwpgSj8w8R+VPvLx3Ifd3h7Qk+EPU=] X-ClientProxiedBy: FR3P281CA0020.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::21) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <02f76f2a-485d-4af0-8768-73883100562b@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0307:EE_ X-MS-Office365-Filtering-Correlation-Id: 40fd7d22-4b76-4c8c-8f45-08dc8728e5e0 X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|440099019|3412199016; X-Microsoft-Antispam-Message-Info: kX+80Vwj5Sh5UilLp1aTLdaqHcyMfN3bAihxW9aiAtrc4EFbD9DIxfysRhKHoyoQoRIuWGsw4Uq1ec7zzEQlR42PaEdZepavHMN9af7FbZJkzDMtx6e1uBUApep737DrtmAolGnAgWf9OfUr7bLFSvxJcF+CpmuT+EU1yWe+P74J0Q8ZO5Tq5hLqwGB8Zg5gbzaNARQCJPpG7lXPfSn2bX9vDbNz88CLrSbKqFPS5OlpS21c5oCJHoQBMs1xvDR8/zUqTTD0fIZEnpvWgMW1+KPKXJNBXdZX+XHUIX7axtsAGOuiY7jFfxldA2u9Zl2U87t74Chb6fBX6XH+6i97xxlbcz9ZTfXuqSkDmtwoiyg4aNP92eP2SHyAITo+RDFYctxKISk6Et+AROIBgtaTPSNwrb53IsLWXwFim+RIV4l7hBI1AOmTopwkGwUp/Joz+exbpnfwj7kU3AxiaJ13U/7erJ1ya48cjLGKJhCy2amO7v0B5BYfvA37wmXEhmi1zKWuZAUPGojMGe0pdzbNMlmyhimXTTZgsUJxIAQjfzXKyD01YhFSljfAtShZIJGm X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3pPNldFTG9OTFRLSVAxaXp5Skw2MjNaMjVxR3ZOc0M3YUhhRUl2aXJxY3Ba?= =?utf-8?B?TmNhT3pEb2gxM25nRi84Y043WmtCOEE5VjNuR0NnSFR3cnB5b3JVdmV4ZHF0?= =?utf-8?B?b1ZRamsyN2I2L2FvcEFNelFyaWJjaHJyTmcwRzc5QTdjUmNZRTkzR21UM2J1?= =?utf-8?B?ODlBcjJJNHFQVTN4cGRObDFsZXhhN05ZWnRoMW1MK2oxdU0rVEV4eHF4ejdX?= =?utf-8?B?QjkrTVVGWWtpb2dlWm9FWnFvRUlTbnVXUStoTmJUcmhhaGNORDVYKzhPL0tJ?= =?utf-8?B?cGtFVE82VG1XN0UvQkh0U3RCNThFcVAxb00xcXVPSklhbm1nZndNWUtwZ2RB?= =?utf-8?B?NU41MG1KSTh3Ykt2MU1wTnNBdEhtK0xEVGpvZVV0YW1RL211STh5ZHpDZndQ?= =?utf-8?B?UHdUcmw1YlhxT25CaDNkODVQdSswTDM5SXBmdnA4RFpOL3pOUXlzS2NKeC9j?= =?utf-8?B?dkY5clc4SCtqK1d3L1B6SFdVZk8yTStMZW1YWlhLRDVQQ3IvNDVpKzVIeFlY?= =?utf-8?B?dytDVmpwQnZudmI4NkJqVmtHcC80d3hrT25jY1FObktjbXhXV0FPdjZhVktI?= =?utf-8?B?WWFpMmN5eG4za1RMSStCMU8zY0RiYjNsQ2FZdi90UVBWaWZOZEJEVG9ranho?= =?utf-8?B?Myt3UjNCSjI0Q0hCdktUZTNidWVMR3V3OFh5QWh4ZzhjdTlUQVpLdld6UFAv?= =?utf-8?B?VzBqZXlXa2FEWVNiRDZTMDE1a01FcUNrUWpMKysxdFdqdTNydzQxOVBOMWx0?= =?utf-8?B?NzlHaXMvRFB4elRGNkl6eExEclowZE15QnhKNWtqRXRzVWd6U3pUaDBIV1hI?= =?utf-8?B?NUZxTE04Q2xHOVVoRS8zalpyaHloaEIxM2pwZjFKYkdmb2ZCVmRWSHlPaEZi?= =?utf-8?B?SGhXaVhJOGRCenUvT2pPYk53b0ZhQUNFeUg1S05JYUFHVXpJV1gyR04rR1kx?= =?utf-8?B?TGxMTXhHVFQxa3pFWkRJVUM1VWk2VnJ0STRWUnJJa0ZmaEc2cnJ3RXpSU21m?= =?utf-8?B?eVovQTBESEhOOVdaNlp2N1ZqdDhuTHYva0x2UDNQRjZBMnlLZmE3UzUrSHVl?= =?utf-8?B?L3hFUks2N0dubURNTzJ1TGtUQmxzSmZnWUE2blgxcnZXYk1pQ0ZwSUJib2t1?= =?utf-8?B?VUlJQlczZjRweWMwWHg1RnNJSVJKWHlUQzJnRkhsdDBWRXNKMmRvL3Q0OXlV?= =?utf-8?B?Z1NlWk5jVVNxQ2NzWm9adkxqVUNZczlrVmd6cm90VklrallJZ2Q2ampXRUNO?= =?utf-8?B?Z01EajloQWZCOXdLQlZxdGpTcHQ0c1lOVC9VRnQ3S3pIQkpldmRnTWhQRW9V?= =?utf-8?B?V2orZVk3Y1h0U1NvYVBxTXlvV0xqSTRZcjVvbWcyRlpkcEoveHp1MitoQ3JR?= =?utf-8?B?WmZQdDFjVE94NGVuajZHMWR2SkdCN0NnVDloK2wyRWdrSGh6dUVCclkzRUkv?= =?utf-8?B?d01kTWlhcklWQWNqbVJrbm02UUZBcURLSEZScDhDYTdya2Vkc3RkUFFlcTVQ?= =?utf-8?B?SS96QUsvTHhPa1c5MkZYdEN5MkwyTFJYc0lsemFPNmY5aWpueVo1dllJUHNK?= =?utf-8?B?YjlYNzVKZGpKZ2dqZXJOYzRzWVpKcldLallFeWQ2U04xZlhDTmRCbTJMbTlC?= =?utf-8?B?ZGlJS0IrRTdCaStaS3hpMUVrK2lmakVleE5xUHFtWEF1WURxT3Q1WE91b01O?= =?utf-8?B?K0kyR3VoUTNSR1NmZFhkTzFBQ05vSjNMQ2FaR2hRZFJUYnczNlZVQk1nPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40fd7d22-4b76-4c8c-8f45-08dc8728e5e0 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 19:34:50.6892 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0307 Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/mjpeg: keep last_dc value unclipped X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ramiro Polla: > Do av_clip_int16(val) _after_ copying the value to last_dc. > > Related commits: c28f648b19d and dffae122d0f > Related ticket: 4683 > --- > libavcodec/mjpegdec.c | 3 +-- > tests/ref/fate/jpg-12bpp | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c > index 1481a7f285..7daec649bc 100644 > --- a/libavcodec/mjpegdec.c > +++ b/libavcodec/mjpegdec.c > @@ -843,9 +843,8 @@ static int decode_block(MJpegDecodeContext *s, int16_t *block, int component, > return AVERROR_INVALIDDATA; > } > val = val * (unsigned)quant_matrix[0] + s->last_dc[component]; > - val = av_clip_int16(val); > s->last_dc[component] = val; > - block[0] = val; > + block[0] = av_clip_int16(val); > /* AC coefs */ > i = 0; > {OPEN_READER(re, &s->gb); > diff --git a/tests/ref/fate/jpg-12bpp b/tests/ref/fate/jpg-12bpp > index b3c662d587..9b039a92c6 100644 > --- a/tests/ref/fate/jpg-12bpp > +++ b/tests/ref/fate/jpg-12bpp > @@ -3,4 +3,4 @@ > #codec_id 0: rawvideo > #dimensions 0: 999x749 > #sar 0: 1/1 > -0, 0, 0, 1, 1496502, 0xd91deb4b > +0, 0, 0, 1, 1496502, 0x44efc0af Is the change for the fate-sample supposed to be an improvement or what is the rationale for this? (Is this change mandated by the spec?) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".