From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F12B74D950 for ; Wed, 26 Feb 2025 16:57:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 47AAA68CD75; Wed, 26 Feb 2025 18:57:27 +0200 (EET) Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02olkn2036.outbound.protection.outlook.com [40.92.50.36]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F95268C673 for ; Wed, 26 Feb 2025 18:57:21 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NcIjgKJmMvQlMIADGzQSM2yEal5i+IJz9PgFKjFXYYxyHcsqri6qHsVp+JcHW2WMiSPyf+GqyzCLhUz5TPkKpHrlumu6DxFaO3x8QiQEB1wiIO6QP4UqHoUihtuC4prAqJYztBr/+j/0yUhlpHVcfMM629+3YrOkvFdCxE0MDssGVIYvq4Ouz9YAG90PFjg0XzHCrGTuccpzdJPerHWkwHsCefe60oM97eStu9l+Z6bAVAy+1jk1W1yrkh5MU4mWngd03Oo4QeSxz/ygUrx6+ChWP0NFyajVDuOeuM18LTdqw/r+nIF3yvKk3YIZxj2HpMBDmF0F5QOYX8soT8xcvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3v0n29CfUwO/ymbA/MKvkc9MXbCUSupn70eT/5L8iUg=; b=Sz+jKPdFhXBJlPIWQ3sZnK/CHLnZJPIeAUbz3htegC4e6tW/Rv4CD1PqjAvkrXVjq8B9HdU9a4UBkg2hm43yUKs7uFSLGboItRE4RxkNVcjlAuQDzOlUM+jqQdaew3bEcqXDEvdE6z0ljS7XibgB3+xafLRJZe7r3iK8c8XmHndCRWm43wcYXexc38Q7JUyEP5+LrRO0nEC+PJl3moT1JG8u4/8+mI/do9XHvoSUxfeuhl9m1oDFhDOZ4Gg+xo1DrhMxqPU621pWlHAZFMmpJNfC4bZhnXVRUkZT/EeltAhIZ3f+wKhIIwXMDpVXnS4ltey+aS5JrMUDo4l9goOUJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3v0n29CfUwO/ymbA/MKvkc9MXbCUSupn70eT/5L8iUg=; b=PJulFD+ewg99Ovbmcq5DRx0noVuFoYcR113HvJZysNbl7yF2N6UQU1ZmGmnuPirYrA8nII612CrCDWXaFAkiOrnh+YX1a8KfQuFc6Mn/195kvctvidywerFpFHXNmW68R4e+FrdECyTTtnVRnjNjLHbMjYtsoYpa6FlJnYzlJtR+7qFCor520N9jbxBxp57Mis0Ph2Ebj+1IYyO3m+P23DJ6MTl9bJHeom4z6kYtaoU9CEA3cLneJaV+3NA+Xjvoacx/G6+U0l0AMoVjIip6lx6m8J64+O1JbJC+SKXgoCraowC6Lj0jziUB0RF3ROSNR4MZyPYr/mw356MPSAMeHA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU0P250MB0693.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:341::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.18; Wed, 26 Feb 2025 16:57:19 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%5]) with mapi id 15.20.8489.014; Wed, 26 Feb 2025 16:57:19 +0000 Message-ID: Date: Wed, 26 Feb 2025 17:57:18 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250226164150.5461-1-jamrial@gmail.com> Content-Language: en-US From: Andreas Rheinhardt In-Reply-To: <20250226164150.5461-1-jamrial@gmail.com> X-ClientProxiedBy: FR4P281CA0334.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ea::10) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU0P250MB0693:EE_ X-MS-Office365-Filtering-Correlation-Id: 1de0b4f3-2cbb-4df0-68d4-08dd5686a162 X-Microsoft-Antispam: BCL:0; ARA:14566002|6090799003|7092599003|8060799006|15080799006|19110799003|5072599009|461199028|41001999003|12071999003|21061999003|440099028|3412199025; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bTFDelZLdDJxQW5aVjk4dld6M01XcDNKQ05aVWJjb243OGJEZElFS1gyM0VG?= =?utf-8?B?R2FlZ1dPVlNHTGg3WkZYWmZ6ejF3MXVBaE9wVmhmTXhVNVVMOG5TbERIRmlK?= =?utf-8?B?dGQyN0lWZlBjMUdBNXlJblR2Qk83NUk0Y3BGcWxpQURGMXdYS1FPeDFvdDVM?= =?utf-8?B?d1pIZzFvS0VkYVhkVHpTTTFFbXpXK3hpNi9ndjM4YjM0RnhlMkpVcStBSjVj?= =?utf-8?B?MElJcVlVUVVTQUd3SGorNEQ1T0RhNnJHaU1sQSttM0ZLd2RwcHVUK0V1VWRa?= =?utf-8?B?U2pHNWpYK0RwWXpISnR4NHhLd2lrYVFRRW5rZGx5RTVFS3BQeld6QnNqMW5a?= =?utf-8?B?T3o4aTZ6N0JhSEpkZ3EvNWNLYW5KdEpIcHJJMkF5bWg2Y0ZwQ3FlVTNMUFU4?= =?utf-8?B?ajJNK1JUOXVIZzRvZklTZFpjeWJlaU4rdEk4VEYyVzNCV05FbHJoNVl3dFFU?= =?utf-8?B?TElmUGpFY0xxUW81K1Jkb1E5c1NnWWloTDB4RE5JUnFQVGdLaDN2eUVkSksy?= =?utf-8?B?cmtZNzJ0aFdqYTRvYnBTVkVrem0xY0NxaFcvbkxVaS8wdmRhazZ6YW5semR2?= =?utf-8?B?VDJnUGJFWFhnZHB2d3R1TlJ5ZHZlYmNMWERvWW5TSmlkYlhtSGMzSWxwRlc4?= =?utf-8?B?NFAzNG1iSm8xZm9FR0h3K1ZURkI2NTlaWnA4MGdCTUlDRHJGRVJwT0dlaVA3?= =?utf-8?B?TVR4Y3JrdXJ6YUl6NGZ0b2Y5eTFldWt3OHNSQ2Z3TkdiYW1yVDJnSGtsc0JJ?= =?utf-8?B?Qmc1S043cHRDZjdtbTBoMVlKbVlqdHhRaDZybWtObmd1RHRrTi9IL2lBeFFR?= =?utf-8?B?aXk3YkhUaEw2K29jb3poUEVnSnJsS0VBQlZYOUJxVFgwNUxHbnZGMXRSYnlG?= =?utf-8?B?cGE5QVZGT2RkSG5ydnpuZm9BZkszMzdGR3VPQnFyN2JBa0ZYTk9SbE0xZ0pj?= =?utf-8?B?N3JDNW5BYmFLaGZ0eXFhWVZYZW1vQ2hxTTNuZjZmOG5XZDZmZjUweEdhOHlp?= =?utf-8?B?eCtIZDdhSUdtaFRjOGM1TGRUNk5kNVVnRXRRc2p0c2lSMTVIVnJnbEc1YnNJ?= =?utf-8?B?NHFTRStEMDJ4ZUloNWpPLy8rRXhpWUNJV0dEbTFxOWl2ZWpZUHY5QkFNaXFI?= =?utf-8?B?Zjl2eHhlMmoyVHBreHZQS3dVRE5kMWsweURVRk4rbzNJMGt0UkQ1VzhncXdn?= =?utf-8?B?L09tRHRnNVZGS2x0Q1N0am1zR1Q0SFBLNjU3MWRGL21CbG56MlpRemt6NXNI?= =?utf-8?B?TXpxV1VjYlJnR3k5amVoMDN4NUR5QUVtTVNrZTBueDlaWExiclZZSnh2bU5V?= =?utf-8?B?YTZLc1pIbVp6QmlnQ0lWSWZOT0tTSlg1TnQ2b3JyUnoyZkFxZ2IxcVJmR0l5?= =?utf-8?B?MVd0YXFTQ1R2cVF0a21wUGZqUjNISWdZempGOGpkUjVOUS9WemdxN2RkQVJ5?= =?utf-8?B?a1BxdTNzcGc1dUNDV3JIem1rb3NqVVN0SkZQeDltY3VVME9IbVRURHlQOHJC?= =?utf-8?B?ZCtVdklsODBIMWpNeUsxT0lEQU5FT2pZZ1pEMzJrWnptVjQwVENKVEt3c3pB?= =?utf-8?B?czZyc1Nza1diM0hKM09uWlFVY3o4RTN6b0dPY1QyK29wUGZUdzVwLzMzK1RK?= =?utf-8?B?TGU3R1BEWnBuZG5SbmtFWU9qclQ3MEE9PQ==?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rkg1aHB5aHlwQ0sySGpXYUVKa1F5QXZtek1kSTlEUCtyUnhlYVRJQ002cWFF?= =?utf-8?B?S3d6dHhBa0dkTGdsSHRxQnFEYU1kOTFlSkpCYUh1dG8xZUNXVDlTdEQvN29n?= =?utf-8?B?WHJYMExmMmtubnN0MmdBbGpMdmMwYXY0Yms3R0VTa3BUdThmV0YxMS92VFJL?= =?utf-8?B?OUpQbUoyc2I0YlMzd2hoSTU5SWdjdVZLV1BNUCthckEwbU5SaU02cXMwWlhi?= =?utf-8?B?ODZDNnRpRjQvWktKMEowZGJ2RnVNWXFSNHB0SmJmK2VtSVRRaU5XNkovT2p5?= =?utf-8?B?Z3FmaWxtYmNiWWpVRE1haFRzdHVxSGpHbzMxK05HcFhrMHNUMlNsajN4Zjhm?= =?utf-8?B?TS9aNHBmMi9HekxrN2tjVmFsdEJLb082bU15QkFNYzhGSDBkREpJMTRSdnht?= =?utf-8?B?V1NnSm5XbjVRSDFFdEVBNGpFdGVhd2JFaHp0TnVFd3J1MWVSM2s1SHNOWlBJ?= =?utf-8?B?eEVvbjlYRmhiR3RhcXNJKzd2eENSM0twbVpoNnNiZWE1U0dMQXIveVVHU3hm?= =?utf-8?B?cWJ6QUxzRXlOa3laL3BJRjFsN0VHREkyQU5iV1lRTXlsL1lXeXhZU2ZvbkNy?= =?utf-8?B?bDhQazB6dHNiZnp1QWtObzJheHo1dXFVN1lkREZMTWZaempQQkErMmVWZ3hz?= =?utf-8?B?T2JGT2VYTGY3MUZFaUVPaWI3SjdNR09BdDlXU1pBYTQzOTBraE5iRDhaM21O?= =?utf-8?B?WTN5VGJXcmt1eWxKYUNPVWZGRTBMOW9GaVAreDRBWlVBdVBPQlg0R1Q0VWtm?= =?utf-8?B?MXZvWFRYc2g0SS94dXU5b3lUamtRNWovc0NFamNDNDJ2YlJ6Skh4S2VXNUxY?= =?utf-8?B?cmZPZE9UQlIwdjRJVms0Y1JlT0ZTSzRtNit3anJ6MWFJcmZjMGVpRmFIcnF1?= =?utf-8?B?R3VmaHZzNUVITHAvNFNYMjVEZHczc1ROczJmc3U5LzFmZlpKSUEyNmhsMVRR?= =?utf-8?B?MG9ZWkZ2b2p1Vm1BdVQycjRlMlMxYXczSWltdTg3Ukg5NENpRDQ0cHFkTEZv?= =?utf-8?B?eG1oTnFIYnFuWjB6aVQzS1owdzkzMHg1dTNDOGlPUy93aG91WlVzV0kvMi9J?= =?utf-8?B?MndHYnZkZjJzMmJyQTBDeElJaHBQMXNzb3lrSk94RDJaT2VOSkYxcVg2eVNm?= =?utf-8?B?ZHdTZjQrZkpHMkJKN2lWSXFHOURMMzdlKyt6aFVCalQ1dzljOVE4YjBqUjIy?= =?utf-8?B?ZzU1K0hzL1VRVmkvOHNqNzd0U1AwQ0Y3Y1FTWG1wU1RuUU5PUXM3UFhXOHVZ?= =?utf-8?B?eTFXQysxMUlseG5yZzBwUHZKWkZSSzhUdnFFMnBoV3prSkthdjJZNytrelZE?= =?utf-8?B?dHdZKzNlbWV4TmJaVS92TUNldW1lL3NnNG0wZjR3Zk5GZFdjMGlpdCtJNGpm?= =?utf-8?B?eXNwalBONVh6VHViVTFoYkp4eEd2dENlQzFlZlhsZ3FBYW1jZDlNQTVYRWty?= =?utf-8?B?WURSLzNzUXk3WXdOSUlWSkhoSHR0TWVnU3pFS3dvdlRtb1VxSDNlT1pnS05P?= =?utf-8?B?Y2QwSHplSDFGZWN6c2VEZ01la1FUaXEzNE5Vb0IxRmFlb0lQTkdzS3QwRE9Z?= =?utf-8?B?bmZ0aml3eHlwL3BxSEhVa0lDWmR5M2JaVnZ0NnNGTG1ScW9iV3BZUlZVT3hm?= =?utf-8?B?T2RvTmM4aUE2QW05QjExZUIvaStpL3hRcXhCRUk4VGVOQ3pQSFQ4T3dqZndP?= =?utf-8?B?MUQveU5INjFZcmRxQXAvcjVJQUlMSHVzVExvczMweVNNUXZVejA0cFd3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1de0b4f3-2cbb-4df0-68d4-08dd5686a162 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 16:57:19.2883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P250MB0693 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: inject missing global side data to output frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > ff_decode_frame_props() injects global side data passed by the caller (Usually > coming from the container) but ignores the global side data the decoder > gathered from the bitstream itself. > This commit amends this. > > Signed-off-by: James Almer > --- > libavcodec/decode.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index cac7e620d2..c5a577f4f1 100644 > --- a/libavcodec/decode.c > +++ b/libavcodec/decode.c > @@ -1570,6 +1570,15 @@ int ff_decode_frame_props(AVCodecContext *avctx, AVFrame *frame) > if (ret < 0) > return ret; > > + for (int i = 0; i < avctx->nb_decoded_side_data; i++) { > + const AVFrameSideData *src = avctx->decoded_side_data[i]; > + if (av_frame_get_side_data(frame, src->type)) > + continue; > + ret = av_frame_side_data_clone(&frame->side_data, &frame->nb_side_data, src, 0); > + if (ret < 0) > + return ret; > + } > + > if (!(ffcodec(avctx->codec)->caps_internal & FF_CODEC_CAP_SETS_FRAME_PROPS)) { > const AVPacket *pkt = avctx->internal->last_pkt_props; > Why is this attached to every frame instead of just the first one? If I read this correctly, it will be possible for there to be decoded_side_data propagated to the output, then in-stream side-data of the same type (not overridden) and in the next frame, the decoder adds the decoded_side_data again, presuming that the side data from the earlier frame was meant to be non-persistent. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".