From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 2/7] avcodec/vc2enc: Constify slices->main context pointers
Date: Tue, 28 May 2024 04:49:07 +0200
Message-ID: <AS8P250MB07446142DC24482F3FF26CF88FF12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB07442EF03FD5DC8CB1FA9E1B8FF12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/vc2enc.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/libavcodec/vc2enc.c b/libavcodec/vc2enc.c
index b496f67d3a..4dcf423ef1 100644
--- a/libavcodec/vc2enc.c
+++ b/libavcodec/vc2enc.c
@@ -106,7 +106,7 @@ typedef struct Plane {
typedef struct SliceArgs {
PutBitContext pb;
int cache[DIRAC_MAX_QUANT_INDEX];
- struct VC2EncContext *ctx;
+ const struct VC2EncContext *ctx;
int x;
int y;
int quant_idx;
@@ -116,7 +116,7 @@ typedef struct SliceArgs {
} SliceArgs;
typedef struct TransformArgs {
- struct VC2EncContext *ctx;
+ const struct VC2EncContext *ctx;
Plane *plane;
const void *idata;
ptrdiff_t istride;
@@ -527,8 +527,8 @@ static void encode_picture_start(VC2EncContext *s)
#define QUANT(c, mul, add, shift) (((mul) * (c) + (add)) >> (shift))
/* VC-2 13.5.5.2 - slice_band() */
-static void encode_subband(VC2EncContext *s, PutBitContext *pb, int sx, int sy,
- SubBand *b, int quant)
+static void encode_subband(const VC2EncContext *s, PutBitContext *pb,
+ int sx, int sy, const SubBand *b, int quant)
{
int x, y;
@@ -558,7 +558,7 @@ static int count_hq_slice(SliceArgs *slice, int quant_idx)
int x, y;
uint8_t quants[MAX_DWT_LEVELS][4];
int bits = 0, p, level, orientation;
- VC2EncContext *s = slice->ctx;
+ const VC2EncContext *s = slice->ctx;
if (slice->cache[quant_idx])
return slice->cache[quant_idx];
@@ -576,7 +576,7 @@ static int count_hq_slice(SliceArgs *slice, int quant_idx)
bits += 8;
for (level = 0; level < s->wavelet_depth; level++) {
for (orientation = !!level; orientation < 4; orientation++) {
- SubBand *b = &s->plane[p].band[level][orientation];
+ const SubBand *b = &s->plane[p].band[level][orientation];
const int q_idx = quants[level][orientation];
const uint64_t q_m = ((uint64_t)s->qmagic_lut[q_idx][0]) << 2;
@@ -618,7 +618,7 @@ static int count_hq_slice(SliceArgs *slice, int quant_idx)
static int rate_control(AVCodecContext *avctx, void *arg)
{
SliceArgs *slice_dat = arg;
- VC2EncContext *s = slice_dat->ctx;
+ const VC2EncContext *s = slice_dat->ctx;
const int top = slice_dat->bits_ceil;
const int bottom = slice_dat->bits_floor;
int quant_buf[2] = {-1, -1};
@@ -724,7 +724,7 @@ static int calc_slice_sizes(VC2EncContext *s)
static int encode_hq_slice(AVCodecContext *avctx, void *arg)
{
SliceArgs *slice_dat = arg;
- VC2EncContext *s = slice_dat->ctx;
+ const VC2EncContext *s = slice_dat->ctx;
PutBitContext *pb = &slice_dat->pb;
const int slice_x = slice_dat->x;
const int slice_y = slice_dat->y;
@@ -839,7 +839,7 @@ static int encode_slices(VC2EncContext *s)
static int dwt_plane(AVCodecContext *avctx, void *arg)
{
TransformArgs *transform_dat = arg;
- VC2EncContext *s = transform_dat->ctx;
+ const VC2EncContext *s = transform_dat->ctx;
const void *frame_data = transform_dat->idata;
const ptrdiff_t linesize = transform_dat->istride;
const int field = transform_dat->field;
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-28 2:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 2:47 [FFmpeg-devel] [PATCH 1/7] avcodec/vc2enc: Avoid void* where possible Andreas Rheinhardt
2024-05-28 2:49 ` Andreas Rheinhardt [this message]
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 3/7] avcodec/vc2enc: Remove superfluous error message Andreas Rheinhardt
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 4/7] avcodec/vc2enc: Fix slice length Andreas Rheinhardt
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 5/7] avcodec/vc2enc: Avoid relocations for short strings Andreas Rheinhardt
2024-05-28 3:07 ` James Almer
2024-05-28 6:38 ` Rémi Denis-Courmont
2024-05-28 14:25 ` Lynne via ffmpeg-devel
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 6/7] avcodec/vc2enc: Move transient PutBitContext from ctx to stack Andreas Rheinhardt
2024-05-28 2:49 ` [FFmpeg-devel] [PATCH 7/7] avcodec/vc2enc: Use already available AVPixFmtDescriptor Andreas Rheinhardt
2024-05-30 18:53 ` [FFmpeg-devel] [PATCH 1/7] avcodec/vc2enc: Avoid void* where possible Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P250MB07446142DC24482F3FF26CF88FF12@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git