From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CBF7144443 for ; Fri, 9 Sep 2022 18:15:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 23EB068BB02; Fri, 9 Sep 2022 21:15:27 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075063.outbound.protection.outlook.com [40.92.75.63]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 19E3668B9AE for ; Fri, 9 Sep 2022 21:15:21 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xk5rbqI+9EUK5nI/MVPQ2FBl4HeSNFixlIIntE08bjmdo5CHzRV8M6pM5dC1vFwjyg7FvZOqHoCMp5oLVq9dp/XE1tXu8nOTZqJ+l8oexb5JTP8BfM/LxHNzpH851kEAfl5eK5f1QKT4kFxDWzf1ObGgqRpaWSBUa46IEFUIxPpGXsOUNXKpas4bM3UYf4bcOIovGhaSDpWi+LqOGAGm8oGSW1raywc3bcJL3cDwGllXtssz+OEEQ6N+YnCzOlLKe1xXhiewjR9B5OYS9TdWIoZDc01cp5UYuxDGnLKk9ZZaFW1ZpHqv/Dru3wOGhw7eku26wq7dMivHjvZ9Hj1KQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DhdoKFc/qnF66LHRaWJdBof/13vLNBqqwaOEpQNxTeE=; b=BoGem0/ctZfPw4VSOGZ4mP5pDncsxHXtgM6szEpg46tkFYkpDmZs2fBbLTQaV0A8EEGHj3I0TXew9B9jGqeV5QQzhf9pTWxk8hWt1zN7nb9dTEKDTMTM8pPnz9vbc8UerElTKVG5SozWVORKBUfD1BeYawGtsmfWNURC5he3qMcMqED9KVa5hM8nQSOk27Ck8OUdr3nRIAtGDNMvBe+2srjvxwMldTut37eajMolWBDGWOUzED4gquQSJTyGvmJ8X3tAvCPnpAFgAC5W0LDmtLZB8tQzL9WI9MYIs5ILGI3KBnnwxvtkZQabg21tjyroqbuNULCKeR7AAumybfNVPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhdoKFc/qnF66LHRaWJdBof/13vLNBqqwaOEpQNxTeE=; b=NqS4iY+SqcazSYXD5TZfWUaxFSvCD81ziQbD5jGBaxFjbZWIKen/5xQU5UqvcZSgwMQgtEpUGyzX49C9GcGPh7pSYKpKF4ZVLwwnx1UcHLmYiM83f/1cbXzDepBw0nJBJ64FuKvbBNOn/6cWDegxfPfCio1OnVZgj7/6adIYffV454g5nEuzsADTQJ5NjRF9XDaIiyE2DjbVv5Il0x8egie7BvtX73GhDESvgplfHGYPZKTcn8mpu3VEzGWM/mzXUU9/pOAPdfMK2Xohy6ViJ/HZPz4ZRLZdOKPqdSzT21q49Z+zEXGaMgj+/27n43AUl9yGz+58NedBtu9+SmXUBA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PR3P250MB0023.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:14e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 18:15:19 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::611e:1608:45cb:b58a]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::611e:1608:45cb:b58a%4]) with mapi id 15.20.5612.019; Fri, 9 Sep 2022 18:15:19 +0000 Message-ID: Date: Fri, 9 Sep 2022 20:15:22 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220908173911.GA2088045@pb2> <20220908202528.GB2088045@pb2> <20220909145558.GE2088045@pb2> From: Andreas Rheinhardt In-Reply-To: <20220909145558.GE2088045@pb2> X-TMN: [eyH2eee3bLyAtplOtgjX6JM7RnP8gu5X5An7Ozx031E=] X-ClientProxiedBy: AM6PR05CA0035.eurprd05.prod.outlook.com (2603:10a6:20b:2e::48) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PR3P250MB0023:EE_ X-MS-Office365-Filtering-Correlation-Id: 998663d6-5185-4a37-254a-08da928f40cc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oAPbttCqIHViedxCiJKO1qyTE+XQkwY8wtSi92pZazEX0UtC1PlLHytekhW4q8IdEWtUZPo+6vkUncWv+kYeWoEg5eT/WxVc35DEv0wfwo6il3jR8BXl8UpwER4oKYQZ/oV3CC9mNoJKa4CEULoUwrs8o5LVNdAN+sVOhQAmF8zD3D27oBha/HUTMGUV3ONx4IwL6+pEVrjLxRYg4SXn6rOecAxxHjV//CoCmYvyEm76VWoTlWvXWZaMY7jUSq1fI1snRMHf8dGoFTrw7MFNptR5xJQxWxgo4P6P3oPnDeRZC7t7Gk4Nt3RDACO1wBFvkBf00r0nLY3i1AeYAiICl7612HSzLRriHfL7bI9ONEnmqiXDCtIucnHJuMv9eNB+5dec9F4OH8LlEwl4DcxacTBr880K7RyCmCl3IETRWRDfwWWIevuswEbQSC63tL6TnRpizVPPvUBhFxapAZ1hdD/cu7C5t9wKpnetOGR67ZwjGN9/Ejuv3xtL5+iwnN5+Wnk9t6KS2IQsYQ30QbOboIsxkswJhwh3EFGD/xpEeXiCcdbp9VEoJw9T68exMzN4TnxOcG14Rpq/3mpT4jRE3jNDk7nYicQlRkF8fWN3reCWdFDdffrtu8Ubdb2cSo1T4CSWnaAd8LV8IxU1iKJi4BMBPsyC63q1OmGaWRlTU9rcDDwOcI4ta/gp41RiZMjB X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnhQSFZKUkFBWkpWbW11dmdyMWY0RmF5M245TFZWNHl4TGxXeHhWOHpSYjBq?= =?utf-8?B?OGY5YU4yNUc1Q0F5ZVhlcWZWOGtQa0VIV3FpWDlHZ3BzQ2c2RHNXU1BhRzdm?= =?utf-8?B?bEhzQ0xTTkpXSVo5TFNudGNBclNZYjVLY2NXS29WSTh1SzM0NHVQQTJ4d3pQ?= =?utf-8?B?eks4cEozQnVuY0lmbVBCdGxBSzJVUjhuWlFwbXEwQXJwc3Y4eE1KU3AzQ2dt?= =?utf-8?B?KzEvaFExdlhjWXhoOVpEcW50ZnhZOUh1QTIyYnVic1NGZi9mdlB3aUZqaWNM?= =?utf-8?B?MDlDU1lYNVFyZW9wT3ZVbTZkaXZEcUhTZ1h1c3VvK1hxM3A5a1NqNWZMK3pD?= =?utf-8?B?RkpwZEtzOEZ3SGp2Y2ZuTEtVbGV0dnUzd05ndTVJQWFNM1E5RHdmckNvOHdv?= =?utf-8?B?K1Q5TktVMXJXcFVoWFJ3R2p1eG1lQzB1UFNwZUtUaytrbVBGbnJCUUc0RHpC?= =?utf-8?B?TmZyREUzRkhtWGwrajZpa0s3dHJNWEpzT0l3WHFFV0d6cDNFUVFPeTlzMDRQ?= =?utf-8?B?VFR4UzVTd2JabFV4QU5FZjZaclJPbTk4R2s1WUYxZDdUaGVVQUs2aHBTVWpG?= =?utf-8?B?QSttM0VHdUFNZEdjczFNVklxK2UvVFdNNjRVRjJPM2FWUTZ1VlRodWorbkx1?= =?utf-8?B?dzFoN0YyT3ZwUVNnVHdDTkt2NWtvL1NJZU9mc0xCSGMwVlRlZ3EzMEpRU1Jr?= =?utf-8?B?M2xSdXNQTDVqTEE1T29QOGtBZUIvaVBPVzR5TXpXQ25FZ0o1Y1Y3VEVkdmxz?= =?utf-8?B?MzNjOGpJUUVzanV4WHFmTE9DSytuM0hwYmFqSG55VGVPdGdYS3dUQW84TWNN?= =?utf-8?B?djVrdWFma1VuYk5RR0V1STJLemFzTnZyd2NSdy81NmYrV3lrVGhQMjk5eWZu?= =?utf-8?B?b2xUSmtUOUgyTWM5eUJxbWZpRnB5T3hObzZReHo5UmZySEZoNFdHQjhndTY0?= =?utf-8?B?WFdLYUljT0xCOWZJcFMyQXBvQnE1bmtHS1JtK2xSeXY1MXVMK2RKOVlMVXpm?= =?utf-8?B?bC90Q3NVQlpzMy9adFdiZno2SXlFK0Y3eHc1eTB3VDV0Um5MaVVBVDVDaDd4?= =?utf-8?B?Z2NjWHlRZjdTdVNSV2RxK0w0dlBXT1V0T0IvUmpJUE4rNS9tZkhMUkxFZktS?= =?utf-8?B?VGlrYUtwMXVtSFNDZE5lU015dWlFUE1QWVd1Q2t1b2hReG5FYWtVVWxmV1V2?= =?utf-8?B?R0g3ZVhRVDZsSmpqaVluQ1NVYUs3MjFiYkp4THdOd3ZZazlxbU1nbVNjRmFI?= =?utf-8?B?eG8vUVVxVXNSdVRtZzFNZ1hvNXVSM1QzVkdrSEd1Uk5BU1IwcHhNa1E4OStZ?= =?utf-8?B?SEYwbERYK1BQS3JTb0pEcVJHVjdLVlRtQyttdHRoWTJJYmJUR1JidXh1RUZt?= =?utf-8?B?bHR2bHk2RHJoMkIwZnBNOXd0cTZHSldpSkIvV1Fybzc1UkE1QzlDZkhKdVJY?= =?utf-8?B?RkxHdlU0RVB5c0h4SW9pRkRRTnFkVUlDV1hERGo5akFIaUhnN2l6M0FrNHpV?= =?utf-8?B?NE4wYWxHcmh5dFNyZnZHcytxQU13ZVNmVUdxUE90UEl2UlpuYjBqVTJpV1hO?= =?utf-8?B?ZGdSZWtscDZzMmZXT2s0YVErOEg2R2RRUmhkZHJOWjgyQ1FxeWVNQlRySGVl?= =?utf-8?B?OGYxbmQ1bXhWZ1QxenJGeXN6ang3RU5RZmF4UFRWUElndWoxZzNPTkZBMTR0?= =?utf-8?B?RGRvb0g2NEkxbHYxVmVQZ0NPQ3RGMitJbDlzb2xWaGtOaW5QQmVUMCtwdFhX?= =?utf-8?Q?7JT3uH24CtHDejVHtSRu/PsjV2UoAuRzQvSVdzT?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 998663d6-5185-4a37-254a-08da928f40cc X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2022 18:15:19.3789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P250MB0023 Subject: Re: [FFmpeg-devel] [PATCH 2/2] swscale/input: Avoid calls to av_pix_fmt_desc_get() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Thu, Sep 08, 2022 at 11:44:51PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Thu, Sep 08, 2022 at 09:38:51PM +0200, Andreas Rheinhardt wrote: >>>> Michael Niedermayer: > [...] >>> To me if i look at the evolution >>> of isBE() / code checking BE-ness it become more messy over time >>> >>> I think it would be interresting to think about if we can make >>> av_pix_fmt_desc_get(compile time constant) work at compile time. >>> or if we maybe can return to a simpler implementation >>> >> >> We could put the av_pix_fmt_descriptors array into an internal header >> and use something like >> >> static av_always_inline const AVPixFmtDescriptor >> *ff_pix_fmt_descriptor_get(enum AVPixelFormat fmt) >> { >> if (av_builtin_constant_p(fmt)) >> return &av_pix_fmt_descriptors[fmt]; >> return av_pix_fmt_desc_get(fmt); >> } > > yes thats what i was thinking of too. > Seems like Anton is away for a week or so. I am sure he has an opinion on the above approach. I think we will wait for him or shall I apply the patches as they are given that they do not block any later alternative solution? (There is one thing I already don't like about the alternative solution: It relies on av_builtin_constant_p, which not every compiler supports.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".