Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 13/20] avcodec/snow: Move freeing encoder-only buffers to snowenc.c
Date: Mon, 10 Oct 2022 05:13:03 +0200
Message-ID: <AS8P250MB074460DED2F3BFF8C63F56C38F209@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AS8P250MB0744A449D7ECAC0BC79C9D658F219@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/snow.c    |  8 --------
 libavcodec/snowenc.c | 12 ++++++++++++
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/libavcodec/snow.c b/libavcodec/snow.c
index 4a6c781a95..f55b3310ac 100644
--- a/libavcodec/snow.c
+++ b/libavcodec/snow.c
@@ -606,19 +606,11 @@ av_cold void ff_snow_common_end(SnowContext *s)
     av_freep(&s->temp_idwt_buffer);
     av_freep(&s->run_buffer);
 
-    s->m.me.temp= NULL;
-    av_freep(&s->m.me.scratchpad);
-    av_freep(&s->m.me.map);
-    av_freep(&s->m.me.score_map);
-    av_freep(&s->m.sc.obmc_scratchpad);
-
     av_freep(&s->block);
     av_freep(&s->scratchbuf);
     av_freep(&s->emu_edge_buffer);
 
     for(i=0; i<MAX_REF_FRAMES; i++){
-        av_freep(&s->ref_mvs[i]);
-        av_freep(&s->ref_scores[i]);
         if(s->last_picture[i] && s->last_picture[i]->data[0]) {
             av_assert0(s->last_picture[i]->data[0] != s->current_picture->data[0]);
         }
diff --git a/libavcodec/snowenc.c b/libavcodec/snowenc.c
index 0854f78da7..fec061a8c5 100644
--- a/libavcodec/snowenc.c
+++ b/libavcodec/snowenc.c
@@ -1986,6 +1986,18 @@ static av_cold int encode_end(AVCodecContext *avctx)
     ff_snow_common_end(s);
     ff_rate_control_uninit(&s->m);
     av_frame_free(&s->input_picture);
+
+    for (int i = 0; i < MAX_REF_FRAMES; i++) {
+        av_freep(&s->ref_mvs[i]);
+        av_freep(&s->ref_scores[i]);
+    }
+
+    s->m.me.temp = NULL;
+    av_freep(&s->m.me.scratchpad);
+    av_freep(&s->m.me.map);
+    av_freep(&s->m.me.score_map);
+    av_freep(&s->m.sc.obmc_scratchpad);
+
     av_freep(&avctx->stats_out);
 
     return 0;
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-10-10  3:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 18:08 [FFmpeg-devel] [PATCH 1/8] configure: Remove dependencies of inexistant rtjpeg decoder Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 2/8] configure: Add missing prores_(aw|ks)_encoder->fdctdsp dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 3/8] configure: Add mpegvideoenc->fdctdsp dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 4/8] configure: Remove unnecessary me_cmp dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 5/8] configure: Remove unnecessary binkaudio dependencies Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 6/8] configure: Remove unnecessary qdm2_decoder->mdct dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 7/8] configure: Remove unnecessary wmavoice->mdct dependency Andreas Rheinhardt
2022-10-09 18:10 ` [FFmpeg-devel] [PATCH 8/8] configure: Add (dnxhd|snow)_encoder->videodsp dependency Andreas Rheinhardt
2022-10-10  3:12 ` [FFmpeg-devel] [PATCH 09/20] avcodec/snow: Move initializing MotionEstContext to snowenc.c Andreas Rheinhardt
2022-10-10 16:14   ` Michael Niedermayer
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 10/20] avcodec/snow: Move initializing QpelDSPContext " Andreas Rheinhardt
2023-09-28 14:39   ` Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 11/20] avcodec/snow: Move decoder/encoder-only inline funcs to snow(dec|enc).c Andreas Rheinhardt
2022-10-10 16:16   ` Michael Niedermayer
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 12/20] avcodec/snow: Move initializing HpelDSPContext to snowenc.c Andreas Rheinhardt
2022-10-10  3:13 ` Andreas Rheinhardt [this message]
2022-10-10 16:19   ` [FFmpeg-devel] [PATCH 13/20] avcodec/snow: Move freeing encoder-only buffers " Michael Niedermayer
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 14/20] avcodec/snow: Only allocate mconly_picture for the decoder Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 15/20] avcodec/snowdec: Don't zero encoder-only buffer Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 16/20] avcodec/snow: Move allocating encoder-only buffers to snowenc.c Andreas Rheinhardt
2022-10-10 16:23   ` Michael Niedermayer
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 17/20] avcodec/snow: Remove outdated assert Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 18/20] avcodec/snow: Only allocate x_coeffs for decoder Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 19/20] avcodec/snow: Reindent after previous commit Andreas Rheinhardt
2022-10-10  3:13 ` [FFmpeg-devel] [PATCH 20/20] avcodec/snowdec: Remove debug code Andreas Rheinhardt
2022-10-10 16:26   ` Michael Niedermayer
2022-10-11 14:21 ` [FFmpeg-devel] [PATCH 1/8] configure: Remove dependencies of inexistant rtjpeg decoder Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8P250MB074460DED2F3BFF8C63F56C38F209@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git