From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 869C142C04 for ; Sun, 30 Oct 2022 11:13:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8AB9C68BC30; Sun, 30 Oct 2022 13:13:52 +0200 (EET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074041.outbound.protection.outlook.com [40.92.74.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DF47968BC30 for ; Sun, 30 Oct 2022 13:13:45 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uarnlz3pA8Z1FVe0aY7BB35jsoX7niF4pLKnY/TWgSTa/ury8rgAMU9ko7w+TXYivG4L+k4o10SoLXGA3feFdjmJjZfAYWOseZJRbFRT3t3E2WpH1E+f2Wbj8d1HxGwd+e5f2M84hqr3gB/Bd8v8ZVdIeS78gjDyeEKUSd/cPYwtjkn3v6Uc1ddvSz/xI/h1NaHDAvEZPwAdWmuKfe6K41VOZ9a3QCO5Q0FHyv1N0L+/K9/XcE2Qr8ffZ9ZW+pPrPUbOFtyymwj2QB3WVsl6iH/9KXgJFZJpYwuW0kXykV4UkACOCO55+EbM0mhZbNpIIaoru1494V3KPMgev/d/bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9BheNWPr6gL39bcz5G1Zc1uILTacr7aSIXBcqGUGc5Q=; b=lAkik7JdiVmJFFjEsUCpe1rWfQzCa4aO1DeUqGGeDZst94ICo8tv14K0AQnlwJzmwAhWF7dJsxMhgScHrESvMVeOEfvUr3j9qFk5jIF0Vj4YvxfbupsIQQluwFuZW1xgLx5WgBxXQjfy+FXqC7pz4e3p8G+PqDTYxvTCPZ3mHNgPBNMANL27j/foJYHCv5QV28FamSDxybyNqjxJKeND8cmaywbw1VgnZ1jozOeCLTV8vTaB3/Ql5hUJmkJC9+XXtd43AT38uPe2mu6hZ+OjXdAlhhXBvyMTnXOXiAxy9+cupuvKl5iXGjrEgYYKKfKQFkdj5s6IxES8OY+MqoltQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9BheNWPr6gL39bcz5G1Zc1uILTacr7aSIXBcqGUGc5Q=; b=lEglZ07vrjRylxky+G4gnCQbcVFP+5kAIKaLRdfVyGD6EhmKVrHomFv/hmnXd74JpHr589yQzk5wLRCtfwwGEmbicf87Uc3jhUrtxNlLJVqz7ktmlxz3/dKLePRrR9+oKzmQI9xy+pyyI1hq86ita/wNIdV5ePfl1OeJ0nfgVNt/kjpQzG/rY6tqCi4eqJb9ZIjHHW79rkilHzfFbItXmO7zXe2hx/tf+hgSQDbT5UEPRGvGAeRKC0qLk3qg6UF8AZLl+G6sKq9dFyC8OcoPGltHiO6AZCN6GPM93Mzwdik3UoWc8zCIeUjKwnmUotnHoUwXlQE2qpBqj+yh16M4ow== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS4P250MB0824.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:584::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Sun, 30 Oct 2022 11:13:44 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::2fc7:f931:a7e5:242c]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::2fc7:f931:a7e5:242c%6]) with mapi id 15.20.5769.016; Sun, 30 Oct 2022 11:13:44 +0000 Message-ID: Date: Sun, 30 Oct 2022 12:13:55 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [9TGyPJyEo/i6YcOVPoWAfaVtZJ0PdconcCe2uOiJy/k=] X-ClientProxiedBy: AS9PR06CA0531.eurprd06.prod.outlook.com (2603:10a6:20b:49d::26) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|AS4P250MB0824:EE_ X-MS-Office365-Filtering-Correlation-Id: b766ee2e-e42e-475f-29ff-08daba67cea0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tYl7YLa5cyILQ3GDGRaUW31e2mzApd54kOAozh39nwtXGvaMMSHE2lwVOrsEH3xH0JZtfCgQJzLooM4EVbKDMFzuF2Ke4jbpl7l0hLtyBpdxAq7BPz9f222ThpE7x/NB7mLe8Cr0yv/R+WEMMaAx48mZ7OGKTiqztIIDh7lR7iCJ4oIRqJKZ4xFNPnphSXin3CN4Obk9GCBY4LKSc/Whye3XHYe9lXjl/g0FDhI0tV/Dj/ONNVPBRONLlgYzpKwV3lsZ0Tn4vAjnCaKG8tIJE6cSG+M4SPm/lRTwC2Vy9GmSB9p9MFHH1NPlvIZy63sRi2gogH78DPY+KksEIK+od3GKh0a13DmqO4Qb44JNND5I6J01c5OqAugrzIKEkbBTGw6e9/uu6r+62+5Ctb1PuT8faPvTkS0/V/BmMBFXiuPF6SQF3x6Zb+zwb9NRnEe+veO2OWISkP7crgA2IKQsIwMq7Lerdh+NOkQK2cG14FkwCgNMOseZ0g6bUU/bxV0os9+ScDpSOWXUhPYPuhct2de07TF7ovSlktgKzpynC7eSRsaAbJlfqrGCx7Hp4JgdkSqLYCkJ5i4bZ7kCRxRKKU8GyDR45/6bNDiijoKX1dXXJLFS92p9gnA6m1MoOJcvk0i4VnYsr+DRA4Q8X0xnNGja4rHKSl1sZmQAAp3ZB0d7m6pJncvQGFtzw5iRtR1f X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTlTNTdJYUVFbmlEUW5oaWdRb2hvUlUydlJkS01EbXRaSGVuL2dYYUhEQnlr?= =?utf-8?B?OG53TlBCQ01kM1VBTk1PRVJBaDNkRmNzZ3JmQUJKSC8rNWdVUjdoaGZJSHhy?= =?utf-8?B?UCsvdDRjZ0JVSUd1UWNBYmRqNi9ZTFE4QTlWbDJjWXF2RWZxbWkyWHdjK0lT?= =?utf-8?B?NEl6VzE2OWgvL3NBUnVzYTVndWFEUG9kNWdDUkp6QnFSck4yZnVJei9tSmFT?= =?utf-8?B?TzdSME1lSWVpL0FTeGVPY2J2cHdLN2hyb1hjOEJ4OVRCemc2WjNkVThTMWdR?= =?utf-8?B?d1BPUStuRWlTaWNJcEV3SG5DTE5sN1VJYlVKQkt5emwydUtiSkRuRnA3MFpG?= =?utf-8?B?YlFTTlo3NVNjUnFnQS9SYXBWeXNUeUc1Y2tnSHM3UElRU2ZYRHpiQldQaVlF?= =?utf-8?B?V2ZqVUcxMUhZRldPQ2ZJWlJOazgrcWlCT1pYcklsaXhkRXJ4SGNHRkhFa05C?= =?utf-8?B?N1V4elNFRjVjZExoTWxFWVBmNTRUQ2pHc0RGaGJLQVo1RG5pYzFWYnNBaGI0?= =?utf-8?B?VmNwZGZMK2cxRE9qbzZsZHpyRE81Q2tkcUlUVVJNbS9pSWJ5UWUxODFpV3Zq?= =?utf-8?B?SFN3TUlPbmh4Y1B4SnM0SVFlS1Z2bjU4NlU0V2tYRGd5L2swcjFMWUxIS3Bx?= =?utf-8?B?S2cxTTRhOGF2L2poTk43dHhuSlQrMjZMTlhQL2YwM2dzSkc3dzVFdUJ0WWI3?= =?utf-8?B?U1dFWCs1WitVUjM1K3U0TWhibTNkTDEvRGN0bFN3M29PTDNTMkoxM0hBWVdD?= =?utf-8?B?OVljMC8veDE0ampoNDBjLzdKS0FkTGJPWDNEMFp0b0pBazdtRUY1b2JHS1lv?= =?utf-8?B?VkRwRDM3eHNPeGVDVFRnMStqcHlQdFdpYUNlRitsemF2UUtlTndsNXJlTFlH?= =?utf-8?B?MG5FVVhIUU14OWdJN1MrU2U1dkYxMUh5NGhQemFZdUgyKy9qTEMveWFMR25t?= =?utf-8?B?TVhRcEZsSWlSWVl1K3FsVXBLZnRNSUR5TkhHR0phdkx6V1lWbm45TXZURUYr?= =?utf-8?B?QjZ1dnBOYW9MMlk5b1JLWnpKVzg2alpGZGFxNmNMVTB4ekxDRTJ4dHRsWEJz?= =?utf-8?B?QVlxMm81b3kzTUxNUjJDVkI2dThUalhNZEUxdFlqMU80TjFaZytUdWJFKzNU?= =?utf-8?B?anlqZEY4VGRMZzY4MmtoekJqcGVrU2o2cjVHdGhwT1A2MFRwdGVXaEFBY3Nz?= =?utf-8?B?REhMdzEvV2NBVVJJdmYrNlB4QjUyMHpvbmc2aFJheXZIcEZzY210N3JCTHMv?= =?utf-8?B?QVE0WHhNb1NnM1QraFluQW5NWEtuN0puK1R5bVFhTXA0RVhsbW9iOTF6QjBJ?= =?utf-8?B?YkRzYVY3a3crSmppRTJkankvUEdLdHUzQlZmVW1VU1J5WWN3a1dDRXcyWG4w?= =?utf-8?B?VDJmYmxIOTEyVmU0T2hFcnhCSDh6WVM1aW5heGFJVEV2OHg5OXhKRlFGWWpH?= =?utf-8?B?OHZDVDl3dUFHTmdaSHdhZi9sTUsvUnYrY21PbjV3b3VBckoxSkUvU1ZyUlJJ?= =?utf-8?B?R0FndU9BSlR6THpwQlVrOGpsWlFKOFdQb1B4OVFxTXUzWXhxNWRvSGphbGtL?= =?utf-8?B?MDREZHRPQmJVTklUdWxCRjVqNExVeTM2bHZacURVMnFRZ0RjVWJyQXlOREZY?= =?utf-8?B?WXg3UlQ0M0cwNVB4QStiNzRpVE9GMURVNmR2d1ZMMi9JNVNSSEkwT2ppU0d6?= =?utf-8?B?M1NtcmxSTzRHRmVWWVRxYXdHUjZTTGYzQWxleTN0R3MySzRNeGVjeUZhWVEw?= =?utf-8?Q?q7tJOgXqpCALb+lsx4Kt9TJomYHoVnzb36n7ALE?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b766ee2e-e42e-475f-29ff-08daba67cea0 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2022 11:13:43.9378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P250MB0824 Subject: Re: [FFmpeg-devel] [PATCH 1/6] avcodec/mpegvideodata: Make DC scale tables smaller X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > These tables are only accessed in ff_set_qscale() > which only accesses values 1..31 as well as in > encode_picture() in mpegvideo_enc.c, accessing > the value with index 8. So make these tables smaller. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideodata.c | 32 ++++---------------------------- > libavcodec/mpegvideodata.h | 2 +- > 2 files changed, 5 insertions(+), 29 deletions(-) > > diff --git a/libavcodec/mpegvideodata.c b/libavcodec/mpegvideodata.c > index da0638e052..b98e90cf43 100644 > --- a/libavcodec/mpegvideodata.c > +++ b/libavcodec/mpegvideodata.c > @@ -30,46 +30,22 @@ const uint8_t ff_mpeg2_non_linear_qscale[32] = { > 56, 64, 72, 80, 88, 96, 104, 112, > }; > > -const uint8_t ff_mpeg1_dc_scale_table[128] = { > - 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, > - 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, > - 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, > - 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, > - 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, > - 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, > +const uint8_t ff_mpeg1_dc_scale_table[32] = { > 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, > 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, > }; > > -static const uint8_t mpeg2_dc_scale_table1[128] = { > - 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, > - 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, > - 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, > - 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, > - 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, > - 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, > +static const uint8_t mpeg2_dc_scale_table1[32] = { > 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, > 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, > }; > > -static const uint8_t mpeg2_dc_scale_table2[128] = { > - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, > - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, > - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, > - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, > - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, > - 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, > +static const uint8_t mpeg2_dc_scale_table2[32] = { > 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, > 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, > }; > > -static const uint8_t mpeg2_dc_scale_table3[128] = { > - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > - 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > +static const uint8_t mpeg2_dc_scale_table3[32] = { > 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > }; > diff --git a/libavcodec/mpegvideodata.h b/libavcodec/mpegvideodata.h > index 14f4806d66..cf783ef31c 100644 > --- a/libavcodec/mpegvideodata.h > +++ b/libavcodec/mpegvideodata.h > @@ -25,7 +25,7 @@ > extern const uint8_t ff_alternate_horizontal_scan[64]; > extern const uint8_t ff_alternate_vertical_scan[64]; > > -extern const uint8_t ff_mpeg1_dc_scale_table[128]; > +extern const uint8_t ff_mpeg1_dc_scale_table[32]; > extern const uint8_t * const ff_mpeg2_dc_scale_table[4]; > > extern const uint8_t ff_mpeg2_non_linear_qscale[32]; Will apply this patchset tomorrow unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".