* [FFmpeg-devel] [PATCH] avformat/mpegts: Restrict skipping Metadata AU cells to metadata streams
@ 2024-03-01 21:11 Andreas Rheinhardt
  2024-03-01 21:14 ` Marton Balint
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Rheinhardt @ 2024-03-01 21:11 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Andreas Rheinhardt
Only metadata streams (stream type 0x15) are packed
in Metadata AU cells, so it should only be stripped
from them and not from all KLV streams.
Fixes ticket #10828, a regression since
468615f2045da325e0f73e8e668d49cf456ccb37.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
I really don't know mpegts; the above information is based
around reading ITU-T H.222.0 for about half an hour.
 libavformat/mpegts.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index 836d5dd5a3..7c40e52262 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -1307,7 +1307,8 @@ skip:
                     p += sl_header_bytes;
                     buf_size -= sl_header_bytes;
                 }
-                if (pes->st->codecpar->codec_id == AV_CODEC_ID_SMPTE_KLV && buf_size >= 5) {
+                if (pes->st->codecpar->codec_id == AV_CODEC_ID_SMPTE_KLV &&
+                    pes->stream_type == 0x15 && buf_size >= 5) {
                     /* skip metadata access unit header */
                     pes->pes_header_size += 5;
                     p += 5;
-- 
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply	[flat|nested] 3+ messages in thread- * Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Restrict skipping Metadata AU cells to metadata streams
  2024-03-01 21:11 [FFmpeg-devel] [PATCH] avformat/mpegts: Restrict skipping Metadata AU cells to metadata streams Andreas Rheinhardt
@ 2024-03-01 21:14 ` Marton Balint
  2024-03-01 21:24   ` Andreas Rheinhardt
  0 siblings, 1 reply; 3+ messages in thread
From: Marton Balint @ 2024-03-01 21:14 UTC (permalink / raw)
  To: FFmpeg development discussions and patches
On Fri, 1 Mar 2024, Andreas Rheinhardt wrote:
> Only metadata streams (stream type 0x15) are packed
> in Metadata AU cells, so it should only be stripped
> from them and not from all KLV streams.
>
> Fixes ticket #10828, a regression since
> 468615f2045da325e0f73e8e668d49cf456ccb37.
I sent a patch for this yesterday:
https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/322432.html
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply	[flat|nested] 3+ messages in thread 
- * Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Restrict skipping Metadata AU cells to metadata streams
  2024-03-01 21:14 ` Marton Balint
@ 2024-03-01 21:24   ` Andreas Rheinhardt
  0 siblings, 0 replies; 3+ messages in thread
From: Andreas Rheinhardt @ 2024-03-01 21:24 UTC (permalink / raw)
  To: ffmpeg-devel
Marton Balint:
> 
> 
> On Fri, 1 Mar 2024, Andreas Rheinhardt wrote:
> 
>> Only metadata streams (stream type 0x15) are packed
>> in Metadata AU cells, so it should only be stripped
>> from them and not from all KLV streams.
>>
>> Fixes ticket #10828, a regression since
>> 468615f2045da325e0f73e8e668d49cf456ccb37.
> 
> I sent a patch for this yesterday:
> 
> https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/322432.html
> 
Sorry.
(Your commit message should mention that this is a regression caused by
468615f2045da325e0f73e8e668d49cf456ccb37.)
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply	[flat|nested] 3+ messages in thread 
 
end of thread, other threads:[~2024-03-01 21:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-01 21:11 [FFmpeg-devel] [PATCH] avformat/mpegts: Restrict skipping Metadata AU cells to metadata streams Andreas Rheinhardt
2024-03-01 21:14 ` Marton Balint
2024-03-01 21:24   ` Andreas Rheinhardt
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git